FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is low

Effort is max

Summary

Classes Bugs Errors Missing Classes
24 7 0 0

Files

Class Bugs
org.opendaylight.natapp.impl.NatFlow 1
org.opendaylight.natapp.impl.NatFlowHandler 1
org.opendaylight.natapp.impl.NatPacketHandler 1
org.opendaylight.natapp.impl.NatYangStore 1
org.opendaylight.natapp.impl.NatappProvider 1
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.impl.rev141210.modules.module.configuration.NatappBuilder$NatappImpl 1
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.impl.rev141210.modules.module.configuration.natapp.BrokerBuilder$BrokerImpl 1

org.opendaylight.natapp.impl.NatFlow

Bug Category Details Line Priority
Confusing to have methods org.opendaylight.natapp.impl.NatFlow.setDataBroker(DataBroker) and org.opendaylight.natapp.impl.NatPacketHandler.setdataBroker(DataBroker) BAD_PRACTICE NM_CONFUSING 71 Low

org.opendaylight.natapp.impl.NatFlowHandler

Bug Category Details Line Priority
Repeated conditional test in org.opendaylight.natapp.impl.NatFlowHandler.handleDeletedFlow(AsyncDataChangeEvent) CORRECTNESS RpC_REPEATED_CONDITIONAL_TEST 82 Low

org.opendaylight.natapp.impl.NatPacketHandler

Bug Category Details Line Priority
Write to static field org.opendaylight.natapp.impl.NatPacketHandler.type from instance method org.opendaylight.natapp.impl.NatPacketHandler.natType(NatTypeInput) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 71 High

org.opendaylight.natapp.impl.NatYangStore

Bug Category Details Line Priority
Write to static field org.opendaylight.natapp.impl.NatYangStore.GLOBALPORT from instance method org.opendaylight.natapp.impl.NatYangStore.addPatMap(String, int) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 146 Medium

org.opendaylight.natapp.impl.NatappProvider

Bug Category Details Line Priority
Write to static field org.opendaylight.natapp.impl.NatappProvider.dataBroker from instance method org.opendaylight.natapp.impl.NatappProvider.onSessionInitiated(BindingAwareBroker$ProviderContext) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 27 Medium

org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.impl.rev141210.modules.module.configuration.NatappBuilder$NatappImpl

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.impl.rev141210.modules.module.configuration.NatappBuilder$NatappImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.impl.rev141210.modules.module.configuration.NatappBuilder$NatappImpl.equals(Object) STYLE BC_UNCONFIRMED_CAST 162 Low

org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.impl.rev141210.modules.module.configuration.natapp.BrokerBuilder$BrokerImpl

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.impl.rev141210.modules.module.configuration.natapp.BrokerBuilder$BrokerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.impl.rev141210.modules.module.configuration.natapp.BrokerBuilder$BrokerImpl.equals(Object) STYLE BC_UNCONFIRMED_CAST 211 Low