FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
Classes |
Bugs |
Errors |
Missing Classes |
73 |
15 |
0 |
0 |
org.opendaylight.controller.config.yang.bmp.impl.AbstractBmpDispatcherImplModuleFactory
Bug |
Category |
Details |
Line |
Priority |
Dead store to oldModuleClass in org.opendaylight.controller.config.yang.bmp.impl.AbstractBmpDispatcherImplModuleFactory.handleChangedClass(DependencyResolver, DynamicMBeanWithInstance, BundleContext) |
STYLE |
DLS_DEAD_LOCAL_STORE |
78 |
Medium |
org.opendaylight.controller.config.yang.bmp.impl.BmpDispatcherImplModule$1
Bug |
Category |
Details |
Line |
Priority |
The class org.opendaylight.controller.config.yang.bmp.impl.BmpDispatcherImplModule$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
49 |
Low |
org.opendaylight.controller.config.yang.bmp.impl.MonitoredRouter
Bug |
Category |
Details |
Line |
Priority |
new org.opendaylight.controller.config.yang.bmp.impl.MonitoredRouter() invokes inefficient Boolean constructor; use Boolean.valueOf(...) instead |
PERFORMANCE |
DM_BOOLEAN_CTOR |
14 |
Medium |
Unread field: org.opendaylight.controller.config.yang.bmp.impl.MonitoredRouter.dependencyResolver |
PERFORMANCE |
URF_UNREAD_FIELD |
27 |
Medium |
org.opendaylight.protocol.bmp.impl.BmpDispatcherImpl$BootstrapListener
Bug |
Category |
Details |
Line |
Priority |
Should org.opendaylight.protocol.bmp.impl.BmpDispatcherImpl$BootstrapListener be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
151 |
Medium |
org.opendaylight.protocol.bmp.impl.app.BmpRouterPeerImpl
Bug |
Category |
Details |
Line |
Priority |
Use of non-localized String.toUpperCase() or String.toLowerCase() in org.opendaylight.protocol.bmp.impl.app.BmpRouterPeerImpl.createPeerEntry(PeerUpNotification) |
I18N |
DM_CONVERT_CASE |
260 |
Low |
org.opendaylight.protocol.bmp.impl.session.BmpSessionImpl
Bug |
Category |
Details |
Line |
Priority |
Inconsistent synchronization of org.opendaylight.protocol.bmp.impl.session.BmpSessionImpl.state; locked 50% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
143 |
Medium |
new IllegalStateException(String) not thrown in org.opendaylight.protocol.bmp.impl.session.BmpSessionImpl.handleMessage(Notification) |
CORRECTNESS |
RV_EXCEPTION_NOT_THROWN |
123 |
High |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.BmpDispatcherImplBuilder$BmpDispatcherImplImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.BmpDispatcherImplBuilder$BmpDispatcherImplImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.BmpDispatcherImplBuilder$BmpDispatcherImplImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
141 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.BmpMonitorImplBuilder$BmpMonitorImplImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.BmpMonitorImplBuilder$BmpMonitorImplImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.BmpMonitorImplBuilder$BmpMonitorImplImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
307 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.BmpDispatcherBuilder$BmpDispatcherImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.BmpDispatcherBuilder$BmpDispatcherImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.BmpDispatcherBuilder$BmpDispatcherImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.CodecTreeFactoryBuilder$CodecTreeFactoryImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.CodecTreeFactoryBuilder$CodecTreeFactoryImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.CodecTreeFactoryBuilder$CodecTreeFactoryImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.DomDataProviderBuilder$DomDataProviderImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.DomDataProviderBuilder$DomDataProviderImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.DomDataProviderBuilder$DomDataProviderImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.ExtensionsBuilder$ExtensionsImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.ExtensionsBuilder$ExtensionsImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.ExtensionsBuilder$ExtensionsImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.MonitoredRouterBuilder$MonitoredRouterImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.MonitoredRouterBuilder$MonitoredRouterImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bmp.impl.rev150518.modules.module.configuration.bmp.monitor.impl.MonitoredRouterBuilder$MonitoredRouterImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
270 |
Low |