FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 59 |
13 |
0 |
0 |
org.opendaylight.controller.config.yang.bgp.path.selection.mode.AbstractAdvertiseAllPathsModuleFactory
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to oldModuleClass in org.opendaylight.controller.config.yang.bgp.path.selection.mode.AbstractAdvertiseAllPathsModuleFactory.handleChangedClass(DependencyResolver, DynamicMBeanWithInstance, BundleContext) |
STYLE |
DLS_DEAD_LOCAL_STORE |
78 |
Medium |
org.opendaylight.controller.config.yang.bgp.path.selection.mode.AbstractAdvertiseNPathsModule
| Bug |
Category |
Details |
Line |
Priority |
| new org.opendaylight.controller.config.yang.bgp.path.selection.mode.AbstractAdvertiseNPathsModule(ModuleIdentifier, DependencyResolver) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
19 |
Medium |
| new org.opendaylight.controller.config.yang.bgp.path.selection.mode.AbstractAdvertiseNPathsModule(ModuleIdentifier, DependencyResolver, AbstractAdvertiseNPathsModule, AutoCloseable) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
19 |
Medium |
org.opendaylight.protocol.bgp.mode.impl.BestPathStateImpl$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.protocol.bgp.mode.impl.BestPathStateImpl$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
119 |
Low |
org.opendaylight.protocol.bgp.mode.impl.add.OffsetMap
| Bug |
Category |
Details |
Line |
Priority |
| Static initializer for org.opendaylight.protocol.bgp.mode.impl.add.OffsetMap creates instance before all static final fields assigned |
BAD_PRACTICE |
SI_INSTANCE_BEFORE_FINALS_ASSIGNED |
35 |
Medium |
org.opendaylight.protocol.bgp.mode.impl.add.RouteKey
| Bug |
Category |
Details |
Line |
Priority |
| Boxed value is unboxed and then immediately reboxed in new org.opendaylight.protocol.bgp.mode.impl.add.RouteKey(UnsignedInteger, Long) |
PERFORMANCE |
BX_UNBOXING_IMMEDIATELY_REBOXED |
20 |
Medium |
org.opendaylight.protocol.bgp.mode.impl.add.all.paths.ComplexRouteEntry
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.protocol.bgp.mode.api.BestPath to org.opendaylight.protocol.bgp.mode.impl.add.AddPathBestPath in org.opendaylight.protocol.bgp.mode.impl.add.all.paths.ComplexRouteEntry.createValue(YangInstanceIdentifier$PathArgument, BestPath) |
STYLE |
BC_UNCONFIRMED_CAST |
37 |
Low |
org.opendaylight.protocol.bgp.mode.impl.add.n.paths.ComplexRouteEntry
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.protocol.bgp.mode.api.BestPath to org.opendaylight.protocol.bgp.mode.impl.add.AddPathBestPath in org.opendaylight.protocol.bgp.mode.impl.add.n.paths.ComplexRouteEntry.createValue(YangInstanceIdentifier$PathArgument, BestPath) |
STYLE |
BC_UNCONFIRMED_CAST |
41 |
Low |
org.opendaylight.protocol.bgp.mode.impl.base.OffsetMap
| Bug |
Category |
Details |
Line |
Priority |
| Static initializer for org.opendaylight.protocol.bgp.mode.impl.base.OffsetMap creates instance before all static final fields assigned |
BAD_PRACTICE |
SI_INSTANCE_BEFORE_FINALS_ASSIGNED |
34 |
Medium |
org.opendaylight.protocol.bgp.mode.spi.RouteEntryUtil
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier$PathArgument to org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier$NodeIdentifierWithPredicates in org.opendaylight.protocol.bgp.mode.spi.RouteEntryUtil.createComplexRouteValue(YangInstanceIdentifier$PathArgument, BestPath, MapEntryNode) |
STYLE |
BC_UNCONFIRMED_CAST |
32 |
Low |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier$PathArgument to org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier$NodeIdentifierWithPredicates in org.opendaylight.protocol.bgp.mode.spi.RouteEntryUtil.createSimpleRouteValue(YangInstanceIdentifier$PathArgument, BestPath) |
STYLE |
BC_UNCONFIRMED_CAST |
25 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bgp.path.selection.mode.rev160301.modules.module.configuration.AdvertiseAllPathsBuilder$AdvertiseAllPathsImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bgp.path.selection.mode.rev160301.modules.module.configuration.AdvertiseAllPathsBuilder$AdvertiseAllPathsImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bgp.path.selection.mode.rev160301.modules.module.configuration.AdvertiseAllPathsBuilder$AdvertiseAllPathsImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
141 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bgp.path.selection.mode.rev160301.modules.module.configuration.AdvertiseNPathsBuilder$AdvertiseNPathsImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bgp.path.selection.mode.rev160301.modules.module.configuration.AdvertiseNPathsBuilder$AdvertiseNPathsImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.bgp.path.selection.mode.rev160301.modules.module.configuration.AdvertiseNPathsBuilder$AdvertiseNPathsImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
171 |
Low |
