Checkstyle Results
The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. 
Summary
| Files |
Info |
Warnings |
Errors |
| 18 |
0 |
97 |
0 |
Rules
| Category |
Rule |
Violations |
Severity |
| imports |
CustomImportOrder
- thirdPartyPackageRegExp: ".*"
- sortImportsInGroupAlphabetically: "true"
- customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
|
2 |
Warning |
|
RedundantImport |
2 |
Warning |
| indentation |
Indentation
- throwsIndent: "4"
- arrayInitIndent: "4"
- caseIndent: "4"
- basicOffset: "4"
- braceAdjustment: "0"
- lineWrappingIndentation: "4"
|
4 |
Warning |
| javadoc |
JavadocStyle
- tokens: "ANNOTATION_DEF, ANNOTATION_FIELD_DEF, CLASS_DEF, CTOR_DEF, ENUM_CONSTANT_DEF, ENUM_DEF, INTERFACE_DEF, METHOD_DEF, VARIABLE_DEF"
- checkEmptyJavadoc: "true"
|
1 |
Warning |
| naming |
AbbreviationAsWordInName
- ignoreFinal: "false"
- allowedAbbreviationLength: "4"
|
1 |
Warning |
|
ConstantName |
3 |
Warning |
|
LocalVariableName
- format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
- allowOneCharVarInForLoop: "true"
- tokens: "VARIABLE_DEF"
|
1 |
Warning |
|
ParameterName
- format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
|
2 |
Warning |
| sizes |
LineLength
- max: "120"
- ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
|
76 |
Warning |
| whitespace |
ParenPad |
1 |
Warning |
|
SeparatorWrap
- tokens: "COMMA"
- option: "EOL"
|
1 |
Warning |
|
SeparatorWrap
- tokens: "DOT"
- option: "nl"
|
1 |
Warning |
|
WhitespaceAround
- allowEmptyConstructors: "true"
- allowEmptyMethods: "true"
- allowEmptyLoops: "true"
- allowEmptyTypes: "true"
|
2 |
Warning |
Details
org/opendaylight/protocol/bgp/inet/AbstractIPRIBSupport.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
naming |
AbbreviationAsWordInName |
Abbreviation in name 'AbstractIPRIBSupport' must contain no more than '4' capital letters. |
38 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 138). |
44 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 138). |
45 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 138). |
47 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 130). |
78 |
Warning |
javadoc |
SummaryJavadoc |
First sentence of Javadoc is incomplete (period is missing) or not present. |
96 |
Warning |
javadoc |
JavadocStyle |
First sentence should end with a period. |
96 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 131). |
103 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 124). |
104 |
org/opendaylight/protocol/bgp/inet/IPv4RIBSupport.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 140). |
37 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 154). |
59 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 219). |
65 |
org/opendaylight/protocol/bgp/inet/IPv4RIBSupportTest.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
imports |
CustomImportOrder |
'com.google.common.collect.ImmutableMap' should be separated from previous import group. |
13 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 138). |
57 |
Warning |
indentation |
Indentation |
'.' have incorrect indentation level 4, expected level should be 8. |
58 |
Warning |
indentation |
Indentation |
'.' have incorrect indentation level 4, expected level should be 8. |
61 |
Warning |
indentation |
Indentation |
'new' have incorrect indentation level 4, expected level should be 8. |
62 |
Warning |
indentation |
Indentation |
'.' have incorrect indentation level 4, expected level should be 8. |
63 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 137). |
66 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 124). |
67 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 121). |
68 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 123). |
79 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 155). |
101 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 152). |
108 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 183). |
119 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 179). |
130 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 129). |
137 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 133). |
149 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 130). |
171 |
org/opendaylight/protocol/bgp/inet/IPv6RIBSupport.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 141). |
38 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 154). |
48 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 153). |
54 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 150). |
63 |
org/opendaylight/protocol/bgp/inet/IPv6RIBSupportTest.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
imports |
CustomImportOrder |
'com.google.common.collect.ImmutableMap' should be separated from previous import group. |
14 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 138). |
58 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 122). |
64 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 137). |
67 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 124). |
68 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 121). |
69 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 123). |
80 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 155). |
102 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 152). |
109 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 146). |
120 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 179). |
132 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 129). |
139 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 133). |
151 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 130). |
173 |
org/opendaylight/protocol/bgp/inet/Ipv6BgpPrefixSidParserTest.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
whitespace |
WhitespaceAround |
WhitespaceAround: '=' is not preceded with whitespace. |
27 |
Warning |
whitespace |
WhitespaceAround |
WhitespaceAround: '=' is not followed by whitespace. |
27 |
org/opendaylight/protocol/bgp/inet/RIBActivator.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 132). |
23 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 133). |
24 |
org/opendaylight/protocol/bgp/inet/TableTypeActivator.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 125). |
25 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 128). |
27 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 129). |
28 |
org/opendaylight/protocol/bgp/inet/TableTypeActivatorTest.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 129). |
26 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 129). |
27 |
org/opendaylight/protocol/bgp/inet/codec/BGPParserTest.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
naming |
LocalVariableName |
Local variable name 'nRead' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
79 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 155). |
166 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 147). |
197 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 121). |
199 |
org/opendaylight/protocol/bgp/inet/codec/Ipv4NlriParser.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 128). |
69 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 151). |
71 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 130). |
75 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 287). |
76 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 123). |
82 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 124). |
89 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 265). |
97 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 215). |
98 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 235). |
99 |
org/opendaylight/protocol/bgp/inet/codec/Ipv4NlriParserTest.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 194). |
74 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 199). |
75 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 229). |
94 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 154). |
96 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 234). |
100 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 158). |
102 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 124). |
123 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 126). |
137 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 228). |
171 |
org/opendaylight/protocol/bgp/inet/codec/Ipv6NlriParser.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 121). |
50 |
Warning |
whitespace |
SeparatorWrap |
'.' should be on a new line. |
75 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 185). |
80 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 287). |
81 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 123). |
87 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 124). |
94 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 265). |
102 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 215). |
103 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 235). |
104 |
org/opendaylight/protocol/bgp/inet/codec/nexthop/Ipv4NextHopParserSerializer.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 189). |
23 |
Warning |
naming |
ParameterName |
Parameter name 'cNextHop' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
28 |
Warning |
whitespace |
ParenPad |
'(' is followed by whitespace. |
30 |
org/opendaylight/protocol/bgp/inet/codec/nexthop/Ipv6NextHopParserSerializer.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
naming |
ParameterName |
Parameter name 'cNextHop' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
27 |
org/opendaylight/protocol/bgp/inet/codec/nexthop/NextHopParserSerializerTest.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
imports |
RedundantImport |
Redundant import from the same package - org.opendaylight.protocol.bgp.inet.codec.nexthop.Ipv4NextHopParserSerializer. |
19 |
Warning |
imports |
RedundantImport |
Redundant import from the same package - org.opendaylight.protocol.bgp.inet.codec.nexthop.Ipv6NextHopParserSerializer. |
20 |
Warning |
naming |
ConstantName |
Name 'ipv6lB' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
35 |
Warning |
naming |
ConstantName |
Name 'ipv6' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
38 |
Warning |
naming |
ConstantName |
Name 'ipv6l' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. |
39 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 141). |
69 |