Checkstyle Results

The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
12 0 142 0

Files

File  I  W  E
org/opendaylight/bgpcep/programming/impl/InstructionDeployerImpl.java 0 8 0
org/opendaylight/bgpcep/programming/impl/InstructionImpl.java 0 65 0
org/opendaylight/bgpcep/programming/impl/IntructionDeployer.java 0 6 0
org/opendaylight/bgpcep/programming/impl/MockedNotificationServiceWrapper.java 0 2 0
org/opendaylight/bgpcep/programming/impl/ProgrammingServiceImpl.java 0 46 0
org/opendaylight/bgpcep/programming/impl/ProgrammingServiceImplTest.java 0 8 0
org/opendaylight/bgpcep/programming/impl/QueueInstruction.java 0 2 0
org/opendaylight/controller/config/yang/programming/impl/InstructionSchedulerImplModule.java 0 3 0
org/opendaylight/controller/config/yang/programming/impl/InstructionSchedulerImplModuleFactory.java 0 2 0

Rules

Category Rule Violations Severity
coding IllegalCatch 1  Warning
imports CustomImportOrder
  • thirdPartyPackageRegExp: ".*"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
 1  Warning
indentation Indentation
  • throwsIndent: "4"
  • arrayInitIndent: "4"
  • caseIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
  • lineWrappingIndentation: "4"
 87  Warning
javadoc JavadocStyle
  • tokens: "ANNOTATION_DEF, ANNOTATION_FIELD_DEF, CLASS_DEF, CTOR_DEF, ENUM_CONSTANT_DEF, ENUM_DEF, INTERFACE_DEF, METHOD_DEF, VARIABLE_DEF"
  • checkEmptyJavadoc: "true"
 6  Warning
naming LocalVariableName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
  • allowOneCharVarInForLoop: "true"
  • tokens: "VARIABLE_DEF"
 1  Warning
ParameterName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
 12  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 19  Warning
whitespace OperatorWrap
  • tokens: "BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "
  • option: "NL"
 3  Warning
SeparatorWrap
  • tokens: "COMMA"
  • option: "EOL"
 1  Warning
SeparatorWrap
  • tokens: "DOT"
  • option: "nl"
 1  Warning
WhitespaceAround
  • allowEmptyConstructors: "true"
  • allowEmptyMethods: "true"
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
 5  Warning

Details

org/opendaylight/bgpcep/programming/impl/InstructionDeployerImpl.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 122). 88
 Warning naming ParameterName Parameter name 't' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 92
 Warning sizes LineLength Line is longer than 120 characters (found 121). 93
 Warning naming ParameterName Parameter name 't' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 110
 Warning naming ParameterName Parameter name 't' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 138
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 148
 Warning sizes LineLength Line is longer than 120 characters (found 121). 198
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 202

org/opendaylight/bgpcep/programming/impl/InstructionImpl.java

Severity Category Rule Message Line
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 68
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 69
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 70
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 71
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 72
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 73
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 74
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 75
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 76
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 77
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 78
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 79
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 97
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 98
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 99
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 100
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 101
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 102
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 103
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 104
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 105
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 106
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 107
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 108
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 109
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 110
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 111
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 112
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 113
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 114
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 115
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 116
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 117
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 118
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 119
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 150
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 151
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 152
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 153
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 154
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 155
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 156
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 157
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 158
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 159
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 160
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 161
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 162
 Warning naming ParameterName Parameter name 'd' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 203
 Warning naming ParameterName Parameter name 'd' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 207
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 238
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 239
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 240
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 241
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 242
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 243
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 244
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 245
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 246
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 247
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 248
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 250
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 251
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 252
 Warning sizes LineLength Line is longer than 120 characters (found 128). 256

org/opendaylight/bgpcep/programming/impl/IntructionDeployer.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 10
 Warning javadoc JavadocStyle First sentence should end with a period. 10
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 14
 Warning javadoc JavadocStyle First sentence should end with a period. 14
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 20
 Warning javadoc JavadocStyle First sentence should end with a period. 20

org/opendaylight/bgpcep/programming/impl/MockedNotificationServiceWrapper.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 124). 49
 Warning sizes LineLength Line is longer than 120 characters (found 123). 51

org/opendaylight/bgpcep/programming/impl/ProgrammingServiceImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.NotificationPublishService' import. Should be before 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType'. 37
 Warning sizes LineLength Line is longer than 120 characters (found 155). 111
 Warning naming ParameterName Parameter name 't' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 120
 Warning sizes LineLength Line is longer than 120 characters (found 143). 138
 Warning naming ParameterName Parameter name 't' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 147
 Warning sizes LineLength Line is longer than 120 characters (found 131). 164
 Warning whitespace WhitespaceAround WhitespaceAround: '+' is not preceded with whitespace. 166
 Warning naming ParameterName Parameter name 't' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 189
 Warning sizes LineLength Line is longer than 120 characters (found 130). 215
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 236
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 237
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 238
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 239
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 240
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 241
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 242
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 243
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 244
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 245
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 246
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 247
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 248
 Warning sizes LineLength Line is longer than 120 characters (found 125). 274
 Warning sizes LineLength Line is longer than 120 characters (found 147). 286
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 297
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 298
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 299
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 300
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 301
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 302
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 303
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 304
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 305
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 306
 Warning indentation Indentation 'case' child have incorrect indentation level 12, expected level should be 16. 307
 Warning indentation Indentation 'block' child have incorrect indentation level 16, expected level should be 20. 308
 Warning sizes LineLength Line is longer than 120 characters (found 137). 315
 Warning sizes LineLength Line is longer than 120 characters (found 144). 319
 Warning sizes LineLength Line is longer than 120 characters (found 148). 328
 Warning sizes LineLength Line is longer than 120 characters (found 134). 341
 Warning sizes LineLength Line is longer than 120 characters (found 128). 345
 Warning naming ParameterName Parameter name 'i' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 378
 Warning naming ParameterName Parameter name 'i' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 386
 Warning naming ParameterName Parameter name 't' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 396
 Warning naming ParameterName Parameter name 't' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 426
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 438

org/opendaylight/bgpcep/programming/impl/ProgrammingServiceImplTest.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 138). 153
 Warning whitespace WhitespaceAround WhitespaceAround: '+' is not preceded with whitespace. 153
 Warning whitespace WhitespaceAround WhitespaceAround: '+' is not preceded with whitespace. 217
 Warning whitespace OperatorWrap '*' should be on a new line. 222
 Warning whitespace OperatorWrap '*' should be on a new line. 242
 Warning whitespace OperatorWrap '*' should be on a new line. 267
 Warning naming LocalVariableName Local variable name 'i' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 306
 Warning whitespace SeparatorWrap '.' should be on a new line. 364

org/opendaylight/bgpcep/programming/impl/QueueInstruction.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 13
 Warning javadoc JavadocStyle Javadoc has empty description section. 13

org/opendaylight/controller/config/yang/programming/impl/InstructionSchedulerImplModule.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 27
 Warning javadoc JavadocStyle Javadoc has empty description section. 27
 Warning sizes LineLength Line is longer than 120 characters (found 126). 69

org/opendaylight/controller/config/yang/programming/impl/InstructionSchedulerImplModuleFactory.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 24
 Warning javadoc JavadocStyle Javadoc has empty description section. 24