Checkstyle Results
The following document contains the results of Checkstyle 7.6.1 with odl_checks.xml ruleset. 
Summary
| Files |
Info |
Warnings |
Errors |
| 32 |
0 |
113 |
0 |
Rules
| Category |
Rule |
Violations |
Severity |
| coding |
IllegalCatch |
2 |
Warning |
|
IllegalThrows |
1 |
Warning |
|
OverloadMethodsDeclarationOrder |
1 |
Warning |
| imports |
CustomImportOrder
- thirdPartyPackageRegExp: ".*"
- sortImportsInGroupAlphabetically: "true"
- customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
|
1 |
Warning |
| javadoc |
JavadocStyle
- tokens: "ANNOTATION_DEF, ANNOTATION_FIELD_DEF, CLASS_DEF, CTOR_DEF, ENUM_CONSTANT_DEF, ENUM_DEF, INTERFACE_DEF, METHOD_DEF, VARIABLE_DEF"
- checkEmptyJavadoc: "true"
|
1 |
Warning |
|
NonEmptyAtclauseDescription |
1 |
Warning |
| modifier |
ModifierOrder |
2 |
Warning |
|
RedundantModifier |
15 |
Warning |
| naming |
MemberName
- format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
|
1 |
Warning |
|
ParameterName
- format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
|
4 |
Warning |
| sizes |
LineLength
- max: "120"
- ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
|
68 |
Warning |
| whitespace |
MethodParamPad |
1 |
Warning |
|
OperatorWrap
- tokens: "BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "
- option: "NL"
|
4 |
Warning |
|
SeparatorWrap
- tokens: "COMMA"
- option: "EOL"
|
2 |
Warning |
|
SeparatorWrap
- tokens: "DOT"
- option: "nl"
|
2 |
Warning |
|
WhitespaceAround
- allowEmptyConstructors: "true"
- allowEmptyMethods: "true"
- allowEmptyLoops: "true"
- allowEmptyTypes: "true"
|
8 |
Warning |
Details
org/opendaylight/protocol/pcep/pcc/mock/Main.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 122). |
54 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 138). |
120 |
Warning |
whitespace |
OperatorWrap |
'+' should be on a new line. |
120 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 156). |
125 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 124). |
127 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 125). |
138 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 134). |
142 |
org/opendaylight/protocol/pcep/pcc/mock/PCCActivator.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 151). |
21 |
org/opendaylight/protocol/pcep/pcc/mock/PCCDispatcherImplTest.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 142). |
56 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 146). |
57 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 138). |
76 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 125). |
84 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 146). |
92 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 127). |
99 |
org/opendaylight/protocol/pcep/pcc/mock/PCCEndPointIpv4ObjectParser.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 129). |
26 |
org/opendaylight/protocol/pcep/pcc/mock/PCCEndPointIpv4ObjectParserTest.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
imports |
CustomImportOrder |
'io.netty.buffer.ByteBuf' should be separated from previous import group by one line. |
13 |
Warning |
modifier |
ModifierOrder |
'static' modifier out of order with the JLS suggestions. |
26 |
Warning |
modifier |
ModifierOrder |
'static' modifier out of order with the JLS suggestions. |
27 |
Warning |
whitespace |
WhitespaceAround |
WhitespaceAround: '=' is not preceded with whitespace. |
29 |
Warning |
whitespace |
WhitespaceAround |
WhitespaceAround: '=' is not followed by whitespace. |
29 |
Warning |
whitespace |
WhitespaceAround |
WhitespaceAround: '=' is not preceded with whitespace. |
51 |
Warning |
whitespace |
WhitespaceAround |
WhitespaceAround: '=' is not followed by whitespace. |
51 |
Warning |
whitespace |
WhitespaceAround |
WhitespaceAround: '=' is not preceded with whitespace. |
58 |
Warning |
whitespace |
WhitespaceAround |
WhitespaceAround: '=' is not followed by whitespace. |
58 |
org/opendaylight/protocol/pcep/pcc/mock/PCCIncrementalSyncTest.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 125). |
32 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 156). |
47 |
org/opendaylight/protocol/pcep/pcc/mock/PCCMockCommon.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
whitespace |
WhitespaceAround |
WhitespaceAround: '->' is not preceded with whitespace. |
138 |
Warning |
whitespace |
WhitespaceAround |
WhitespaceAround: '->' is not preceded with whitespace. |
164 |
org/opendaylight/protocol/pcep/pcc/mock/PCCMockTest.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 126). |
23 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 173). |
24 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 142). |
35 |
Warning |
whitespace |
OperatorWrap |
'+' should be on a new line. |
55 |
Warning |
whitespace |
OperatorWrap |
'+' should be on a new line. |
56 |
Warning |
coding |
IllegalThrows |
Throwing 'Throwable' is not allowed. |
73 |
org/opendaylight/protocol/pcep/pcc/mock/PCCSyncOptimization.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
modifier |
RedundantModifier |
Redundant 'public' modifier. |
33 |
Warning |
whitespace |
OperatorWrap |
'&&' should be on a new line. |
42 |
org/opendaylight/protocol/pcep/pcc/mock/PCCTunnel.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
modifier |
RedundantModifier |
Redundant 'public' modifier. |
24 |
org/opendaylight/protocol/pcep/pcc/mock/PCCTunnelBuilder.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 130). |
39 |
org/opendaylight/protocol/pcep/pcc/mock/PCCTunnelManagerImpl.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 157). |
119 |
Warning |
whitespace |
SeparatorWrap |
'.' should be on a new line. |
119 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 151). |
145 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 144). |
152 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 121). |
195 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 123). |
197 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 147). |
198 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 136). |
211 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 128). |
245 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 133). |
248 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 139). |
258 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 125). |
261 |
Warning |
javadoc |
SummaryJavadoc |
First sentence of Javadoc is incomplete (period is missing) or not present. |
313 |
Warning |
javadoc |
JavadocStyle |
First sentence should end with a period. |
313 |
Warning |
javadoc |
NonEmptyAtclauseDescription |
At-clause should have a non-empty description. |
316 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 167). |
327 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 124). |
332 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 136). |
333 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 136). |
355 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 154). |
386 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 122). |
397 |
org/opendaylight/protocol/pcep/pcc/mock/PCCTunnelManagerImplTest.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 128). |
63 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 129). |
317 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 136). |
320 |
Warning |
coding |
OverloadMethodsDeclarationOrder |
Overload methods should not be split. Previous overloaded method located at line '317'. |
343 |
org/opendaylight/protocol/pcep/pcc/mock/PCCsBuilder.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 121). |
54 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 121). |
56 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 123). |
84 |
org/opendaylight/protocol/pcep/pcc/mock/TestingSessionListener.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
naming |
ParameterName |
Parameter name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
54 |
Warning |
whitespace |
MethodParamPad |
'(' is preceded with whitespace. |
69 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 128). |
74 |
org/opendaylight/protocol/pcep/pcc/mock/TimerHandler.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 154). |
31 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 124). |
44 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 180). |
53 |
org/opendaylight/protocol/pcep/pcc/mock/api/PCCDispatcher.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
modifier |
RedundantModifier |
Redundant 'final' modifier. |
21 |
Warning |
modifier |
RedundantModifier |
Redundant 'final' modifier. |
22 |
Warning |
modifier |
RedundantModifier |
Redundant 'final' modifier. |
22 |
Warning |
modifier |
RedundantModifier |
Redundant 'final' modifier. |
23 |
Warning |
modifier |
RedundantModifier |
Redundant 'final' modifier. |
23 |
Warning |
modifier |
RedundantModifier |
Redundant 'final' modifier. |
24 |
Warning |
modifier |
RedundantModifier |
Redundant 'final' modifier. |
24 |
Warning |
modifier |
RedundantModifier |
Redundant 'final' modifier. |
26 |
Warning |
modifier |
RedundantModifier |
Redundant 'final' modifier. |
27 |
Warning |
modifier |
RedundantModifier |
Redundant 'final' modifier. |
27 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 136). |
28 |
Warning |
modifier |
RedundantModifier |
Redundant 'final' modifier. |
28 |
Warning |
modifier |
RedundantModifier |
Redundant 'final' modifier. |
28 |
Warning |
modifier |
RedundantModifier |
Redundant 'final' modifier. |
29 |
org/opendaylight/protocol/pcep/pcc/mock/protocol/PCCDispatcherImpl.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 152). |
61 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 130). |
63 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 129). |
68 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 125). |
69 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 121). |
79 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 154). |
84 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 125). |
98 |
org/opendaylight/protocol/pcep/pcc/mock/protocol/PCCPeerProposal.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 123). |
34 |
org/opendaylight/protocol/pcep/pcc/mock/protocol/PCCReconnectPromise.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
naming |
MemberName |
Member name 'b' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
34 |
Warning |
naming |
ParameterName |
Parameter name 'b' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
40 |
Warning |
coding |
IllegalCatch |
Catching 'Exception' is not allowed. |
55 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 131). |
103 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 123). |
114 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 123). |
120 |
org/opendaylight/protocol/pcep/pcc/mock/protocol/PCCServerPeerProposal.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 123). |
29 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 122). |
37 |
org/opendaylight/protocol/pcep/pcc/mock/protocol/PCCSessionListener.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 125). |
57 |
Warning |
naming |
ParameterName |
Parameter name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
69 |
Warning |
coding |
IllegalCatch |
Catching 'Exception' is not allowed. |
74 |
org/opendaylight/protocol/pcep/pcc/mock/spi/MsgBuilderUtil.java
| Severity |
Category |
Rule |
Message |
Line |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 151). |
76 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 130). |
90 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 160). |
109 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 138). |
126 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 140). |
127 |
Warning |
sizes |
LineLength |
Line is longer than 120 characters (found 179). |
131 |
Warning |
whitespace |
SeparatorWrap |
'.' should be on a new line. |
153 |
Warning |
naming |
ParameterName |
Parameter name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
165 |