Checkstyle Results

The following document contains the results of Checkstyle 7.6.1 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
29 0 150 0

Files

File  I  W  E
org/opendaylight/controller/config/yang/bmp/impl/BmpDispatcherImplModule.java 0 4 0
org/opendaylight/controller/config/yang/bmp/impl/BmpDispatcherImplModuleFactory.java 0 1 0
org/opendaylight/controller/config/yang/bmp/impl/BmpMonitorImplModule.java 0 10 0
org/opendaylight/controller/config/yang/bmp/impl/BmpMonitorImplModuleFactory.java 0 3 0
org/opendaylight/protocol/bmp/impl/BmpDispatcherImpl.java 0 4 0
org/opendaylight/protocol/bmp/impl/api/BmpDeployer.java 0 4 0
org/opendaylight/protocol/bmp/impl/app/BmpMonitorImplTest.java 0 16 0
org/opendaylight/protocol/bmp/impl/app/BmpMonitoringStationImpl.java 0 4 0
org/opendaylight/protocol/bmp/impl/app/BmpRibInWriter.java 0 23 0
org/opendaylight/protocol/bmp/impl/app/BmpRouterImpl.java 0 6 0
org/opendaylight/protocol/bmp/impl/app/BmpRouterPeerImpl.java 0 23 0
org/opendaylight/protocol/bmp/impl/app/RouterSessionManager.java 0 1 0
org/opendaylight/protocol/bmp/impl/app/TableContext.java 0 7 0
org/opendaylight/protocol/bmp/impl/app/TablesUtil.java 0 8 0
org/opendaylight/protocol/bmp/impl/config/BmpDeployerDependencies.java 0 2 0
org/opendaylight/protocol/bmp/impl/config/BmpDeployerImpl.java 0 3 0
org/opendaylight/protocol/bmp/impl/session/BmpDispatcherImplTest.java 0 2 0
org/opendaylight/protocol/bmp/impl/session/BmpSessionImpl.java 0 25 0
org/opendaylight/protocol/bmp/impl/session/BmpSessionImplTest.java 0 2 0
org/opendaylight/protocol/bmp/impl/session/BmpTestSessionListener.java 0 2 0

Rules

Category Rule Violations Severity
coding IllegalCatch 8  Warning
imports CustomImportOrder
  • thirdPartyPackageRegExp: ".*"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
 4  Warning
indentation Indentation
  • throwsIndent: "4"
  • arrayInitIndent: "4"
  • caseIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
  • lineWrappingIndentation: "4"
 23  Warning
javadoc JavadocStyle
  • tokens: "ANNOTATION_DEF, ANNOTATION_FIELD_DEF, CLASS_DEF, CTOR_DEF, ENUM_CONSTANT_DEF, ENUM_DEF, INTERFACE_DEF, METHOD_DEF, VARIABLE_DEF"
  • checkEmptyJavadoc: "true"
 11  Warning
NonEmptyAtclauseDescription 5  Warning
modifier ModifierOrder 1  Warning
RedundantModifier 2  Warning
naming ParameterName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
 3  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 71  Warning
whitespace EmptyLineSeparator
  • allowNoEmptyLineBetweenFields: "true"
  • tokens: "IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"
 1  Warning
MethodParamPad 3  Warning
OperatorWrap
  • tokens: "BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "
  • option: "NL"
 2  Warning
ParenPad 2  Warning
SeparatorWrap
  • tokens: "COMMA"
  • option: "EOL"
 5  Warning
SeparatorWrap
  • tokens: "DOT"
  • option: "nl"
 5  Warning
WhitespaceAround
  • allowEmptyConstructors: "true"
  • allowEmptyMethods: "true"
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
 3  Warning

Details

org/opendaylight/controller/config/yang/bmp/impl/BmpDispatcherImplModule.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 18
 Warning sizes LineLength Line is longer than 120 characters (found 194). 26
 Warning sizes LineLength Line is longer than 120 characters (found 327). 30
 Warning sizes LineLength Line is longer than 120 characters (found 126). 51

org/opendaylight/controller/config/yang/bmp/impl/BmpDispatcherImplModuleFactory.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 14

org/opendaylight/controller/config/yang/bmp/impl/BmpMonitorImplModule.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 121). 28
 Warning sizes LineLength Line is longer than 120 characters (found 191). 36
 Warning sizes LineLength Line is longer than 120 characters (found 321). 40
 Warning sizes LineLength Line is longer than 120 characters (found 126). 48
 Warning sizes LineLength Line is longer than 120 characters (found 136). 49
 Warning whitespace SeparatorWrap '.' should be on a new line. 59
 Warning whitespace SeparatorWrap '.' should be on a new line. 81
 Warning sizes LineLength Line is longer than 120 characters (found 121). 82
 Warning whitespace SeparatorWrap '.' should be on a new line. 86
 Warning whitespace SeparatorWrap '.' should be on a new line. 88

org/opendaylight/controller/config/yang/bmp/impl/BmpMonitorImplModuleFactory.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 135). 16
 Warning sizes LineLength Line is longer than 120 characters (found 135). 21
 Warning sizes LineLength Line is longer than 120 characters (found 140). 29

org/opendaylight/protocol/bmp/impl/BmpDispatcherImpl.java

Severity Category Rule Message Line
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 87
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 136
 Warning modifier RedundantModifier Redundant 'public' modifier. 162
 Warning whitespace OperatorWrap '+' should be on a new line. 176

org/opendaylight/protocol/bmp/impl/api/BmpDeployer.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 18
 Warning javadoc JavadocStyle First sentence should end with a period. 18
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 25
 Warning javadoc JavadocStyle First sentence should end with a period. 25

org/opendaylight/protocol/bmp/impl/app/BmpMonitorImplTest.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 148
 Warning sizes LineLength Line is longer than 120 characters (found 123). 170
 Warning sizes LineLength Line is longer than 120 characters (found 135). 171
 Warning sizes LineLength Line is longer than 120 characters (found 121). 202
 Warning sizes LineLength Line is longer than 120 characters (found 130). 333
 Warning sizes LineLength Line is longer than 120 characters (found 130). 383
 Warning sizes LineLength Line is longer than 120 characters (found 124). 387
 Warning sizes LineLength Line is longer than 120 characters (found 167). 391
 Warning sizes LineLength Line is longer than 120 characters (found 163). 392
 Warning sizes LineLength Line is longer than 120 characters (found 128). 405
 Warning sizes LineLength Line is longer than 120 characters (found 137). 406
 Warning sizes LineLength Line is longer than 120 characters (found 129). 416
 Warning sizes LineLength Line is longer than 120 characters (found 138). 417
 Warning sizes LineLength Line is longer than 120 characters (found 195). 423
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 435
 Warning whitespace SeparatorWrap '.' should be on a new line. 452

org/opendaylight/protocol/bmp/impl/app/BmpMonitoringStationImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. Should be before 'org.opendaylight.mdsal.singleton.common.api.ServiceGroupIdentifier'. 28
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException' import. Should be before 'org.opendaylight.mdsal.singleton.common.api.ServiceGroupIdentifier'. 29
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.dom.api.DOMDataBroker' import. Should be before 'org.opendaylight.mdsal.singleton.common.api.ServiceGroupIdentifier'. 30
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.dom.api.DOMDataWriteTransaction' import. Should be before 'org.opendaylight.mdsal.singleton.common.api.ServiceGroupIdentifier'. 31

org/opendaylight/protocol/bmp/impl/app/BmpRibInWriter.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 158). 58
 Warning sizes LineLength Line is longer than 120 characters (found 149). 59
 Warning sizes LineLength Line is longer than 120 characters (found 149). 65
 Warning sizes LineLength Line is longer than 120 characters (found 135). 75
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 81
 Warning javadoc JavadocStyle First sentence should end with a period. 81
 Warning javadoc NonEmptyAtclauseDescription At-clause should have a non-empty description. 84
 Warning sizes LineLength Line is longer than 120 characters (found 164). 89
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 113
 Warning javadoc JavadocStyle First sentence should end with a period. 113
 Warning javadoc NonEmptyAtclauseDescription At-clause should have a non-empty description. 116
 Warning javadoc NonEmptyAtclauseDescription At-clause should have a non-empty description. 117
 Warning javadoc NonEmptyAtclauseDescription At-clause should have a non-empty description. 118
 Warning javadoc NonEmptyAtclauseDescription At-clause should have a non-empty description. 119
 Warning sizes LineLength Line is longer than 120 characters (found 171). 138
 Warning sizes LineLength Line is longer than 120 characters (found 134). 145
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 175
 Warning javadoc JavadocStyle First sentence should end with a period. 175
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 197
 Warning javadoc JavadocStyle First sentence should end with a period. 197
 Warning sizes LineLength Line is longer than 120 characters (found 139). 208
 Warning sizes LineLength Line is longer than 120 characters (found 220). 210
 Warning sizes LineLength Line is longer than 120 characters (found 143). 259

org/opendaylight/protocol/bmp/impl/app/BmpRouterImpl.java

Severity Category Rule Message Line
 Warning naming ParameterName Parameter name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 107
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 134
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 158
 Warning whitespace WhitespaceAround WhitespaceAround: 'catch' is not followed by whitespace. 158
 Warning sizes LineLength Line is longer than 120 characters (found 136). 212
 Warning sizes LineLength Line is longer than 120 characters (found 130). 213

org/opendaylight/protocol/bmp/impl/app/BmpRouterPeerImpl.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 128). 107
 Warning sizes LineLength Line is longer than 120 characters (found 143). 133
 Warning whitespace ParenPad '(' is followed by whitespace. 218
 Warning whitespace OperatorWrap '||' should be on a new line. 218
 Warning whitespace ParenPad ')' is preceded with whitespace. 219
 Warning sizes LineLength Line is longer than 120 characters (found 126). 222
 Warning sizes LineLength Line is longer than 120 characters (found 124). 244
 Warning sizes LineLength Line is longer than 120 characters (found 131). 259
 Warning sizes LineLength Line is longer than 120 characters (found 130). 291
 Warning sizes LineLength Line is longer than 120 characters (found 121). 293
 Warning sizes LineLength Line is longer than 120 characters (found 134). 296
 Warning sizes LineLength Line is longer than 120 characters (found 123). 299
 Warning sizes LineLength Line is longer than 120 characters (found 131). 302
 Warning sizes LineLength Line is longer than 120 characters (found 126). 305
 Warning sizes LineLength Line is longer than 120 characters (found 128). 308
 Warning sizes LineLength Line is longer than 120 characters (found 128). 311
 Warning sizes LineLength Line is longer than 120 characters (found 139). 323
 Warning sizes LineLength Line is longer than 120 characters (found 156). 324
 Warning sizes LineLength Line is longer than 120 characters (found 137). 331
 Warning sizes LineLength Line is longer than 120 characters (found 156). 332
 Warning sizes LineLength Line is longer than 120 characters (found 130). 336
 Warning sizes LineLength Line is longer than 120 characters (found 131). 339
 Warning sizes LineLength Line is longer than 120 characters (found 122). 342

org/opendaylight/protocol/bmp/impl/app/RouterSessionManager.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 38

org/opendaylight/protocol/bmp/impl/app/TableContext.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 143). 54
 Warning sizes LineLength Line is longer than 120 characters (found 139). 58
 Warning sizes LineLength Line is longer than 120 characters (found 142). 80
 Warning sizes LineLength Line is longer than 120 characters (found 130). 81
 Warning sizes LineLength Line is longer than 120 characters (found 134). 82
 Warning sizes LineLength Line is longer than 120 characters (found 144). 90
 Warning sizes LineLength Line is longer than 120 characters (found 166). 95

org/opendaylight/protocol/bmp/impl/app/TablesUtil.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 146). 21
 Warning sizes LineLength Line is longer than 120 characters (found 154). 22
 Warning sizes LineLength Line is longer than 120 characters (found 146). 23
 Warning javadoc JavadocStyle First sentence should end with a period. 31
 Warning javadoc JavadocStyle First sentence should end with a period. 46
 Warning sizes LineLength Line is longer than 120 characters (found 126). 54
 Warning javadoc JavadocStyle First sentence should end with a period. 64
 Warning naming ParameterName Parameter name 'k' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 70

org/opendaylight/protocol/bmp/impl/config/BmpDeployerDependencies.java

Severity Category Rule Message Line
 Warning indentation Indentation 'final' have incorrect indentation level 4, expected level should be 8. 28
 Warning indentation Indentation 'final' have incorrect indentation level 4, expected level should be 8. 29

org/opendaylight/protocol/bmp/impl/config/BmpDeployerImpl.java

Severity Category Rule Message Line
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 58
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 122
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 134

org/opendaylight/protocol/bmp/impl/session/BmpDispatcherImplTest.java

Severity Category Rule Message Line
 Warning whitespace WhitespaceAround WhitespaceAround: '->' is not preceded with whitespace. 92
 Warning whitespace WhitespaceAround WhitespaceAround: '->' is not preceded with whitespace. 100

org/opendaylight/protocol/bmp/impl/session/BmpSessionImpl.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 125). 49
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 60
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 107
 Warning indentation Indentation 'if' have incorrect indentation level 12, expected level should be 16. 108
 Warning indentation Indentation 'if' child have incorrect indentation level 16, expected level should be 20. 109
 Warning indentation Indentation 'if' child have incorrect indentation level 16, expected level should be 20. 110
 Warning indentation Indentation 'if rcurly' have incorrect indentation level 12, expected level should be 16. 111
 Warning indentation Indentation 'else' child have incorrect indentation level 16, expected level should be 20. 112
 Warning indentation Indentation 'else' child have incorrect indentation level 16, expected level should be 20. 113
 Warning indentation Indentation 'else rcurly' have incorrect indentation level 12, expected level should be 16. 114
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 115
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 116
 Warning indentation Indentation 'if' have incorrect indentation level 12, expected level should be 16. 117
 Warning indentation Indentation 'if' child have incorrect indentation level 16, expected level should be 20. 118
 Warning sizes LineLength Line is longer than 120 characters (found 130). 118
 Warning indentation Indentation 'if' child have incorrect indentation level 16, expected level should be 20. 119
 Warning indentation Indentation 'if rcurly' have incorrect indentation level 12, expected level should be 16. 120
 Warning indentation Indentation 'else' child have incorrect indentation level 16, expected level should be 20. 121
 Warning indentation Indentation 'else rcurly' have incorrect indentation level 12, expected level should be 16. 122
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 123
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 124
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 125
 Warning sizes LineLength Line is longer than 120 characters (found 123). 125
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 126
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 127

org/opendaylight/protocol/bmp/impl/session/BmpSessionImplTest.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 80
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 91

org/opendaylight/protocol/bmp/impl/session/BmpTestSessionListener.java

Severity Category Rule Message Line
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 25
 Warning naming ParameterName Parameter name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 46