Checkstyle Results

The following document contains the results of Checkstyle 7.6.1 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
34 0 106 0

Files

File  I  W  E
org/opendaylight/protocol/bmp/api/BmpDispatcher.java 0 12 0
org/opendaylight/protocol/bmp/api/BmpSessionListener.java 0 1 0
org/opendaylight/protocol/bmp/spi/parser/AbstractBmpMessageParser.java 0 1 0
org/opendaylight/protocol/bmp/spi/parser/AbstractBmpMessageWithTlvParser.java 0 2 0
org/opendaylight/protocol/bmp/spi/parser/AbstractBmpMessageWithTlvParserTest.java 0 9 0
org/opendaylight/protocol/bmp/spi/parser/AbstractBmpPerPeerMessageParser.java 0 25 0
org/opendaylight/protocol/bmp/spi/parser/AbstractBmpPerPeerMessageParserTest.java 0 6 0
org/opendaylight/protocol/bmp/spi/parser/BmpDeserializationException.java 0 3 0
org/opendaylight/protocol/bmp/spi/parser/BmpMessageParser.java 0 1 0
org/opendaylight/protocol/bmp/spi/parser/BmpMessageSerializer.java 0 2 0
org/opendaylight/protocol/bmp/spi/parser/TlvUtil.java 0 1 0
org/opendaylight/protocol/bmp/spi/parser/TlvUtilTest.java 0 7 0
org/opendaylight/protocol/bmp/spi/registry/AbstractBmpExtensionProviderActivator.java 0 2 0
org/opendaylight/protocol/bmp/spi/registry/AbstractBmpExtensionProviderActivatorTest.java 0 4 0
org/opendaylight/protocol/bmp/spi/registry/BmpMessageRegistrator.java 0 1 0
org/opendaylight/protocol/bmp/spi/registry/SimpleBmpExtensionProviderContext.java 0 6 0
org/opendaylight/protocol/bmp/spi/registry/SimpleBmpExtensionProviderContextActivator.java 0 2 0
org/opendaylight/protocol/bmp/spi/registry/SimpleBmpExtensionProviderContextTest.java 0 1 0
org/opendaylight/protocol/bmp/spi/registry/SimpleBmpMessageRegistry.java 0 4 0
org/opendaylight/protocol/bmp/spi/registry/SimpleBmpMessageRegistryTest.java 0 11 0
org/opendaylight/protocol/bmp/spi/registry/SimpleBmpTlvRegistry.java 0 1 0
org/opendaylight/protocol/bmp/spi/registry/SimpleBmpTlvRegistryTest.java 0 4 0

Rules

Category Rule Violations Severity
coding IllegalCatch 1  Warning
IllegalThrows 2  Warning
OverloadMethodsDeclarationOrder 2  Warning
imports CustomImportOrder
  • thirdPartyPackageRegExp: ".*"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
 6  Warning
indentation Indentation
  • throwsIndent: "4"
  • arrayInitIndent: "4"
  • caseIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
  • lineWrappingIndentation: "4"
 26  Warning
javadoc JavadocStyle
  • tokens: "ANNOTATION_DEF, ANNOTATION_FIELD_DEF, CLASS_DEF, CTOR_DEF, ENUM_CONSTANT_DEF, ENUM_DEF, INTERFACE_DEF, METHOD_DEF, VARIABLE_DEF"
  • checkEmptyJavadoc: "true"
 1  Warning
modifier RedundantModifier 6  Warning
naming AbbreviationAsWordInName
  • ignoreFinal: "false"
  • allowedAbbreviationLength: "4"
 1  Warning
ConstantName 3  Warning
ParameterName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
 1  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 29  Warning
whitespace EmptyLineSeparator
  • allowNoEmptyLineBetweenFields: "true"
  • tokens: "IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"
 5  Warning
WhitespaceAround
  • allowEmptyConstructors: "true"
  • allowEmptyMethods: "true"
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
 22  Warning

Details

org/opendaylight/protocol/bmp/api/BmpDispatcher.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 125). 30
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 31
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 5, expected level should be 4. 45
 Warning sizes LineLength Line is longer than 120 characters (found 126). 46
 Warning indentation Indentation 'if' have incorrect indentation level 9, expected level should be 8. 47
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 47
 Warning indentation Indentation 'if' child have incorrect indentation level 13, expected level should be 12. 48
 Warning indentation Indentation 'if rcurly' have incorrect indentation level 9, expected level should be 8. 49
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 50
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 5, expected level should be 4. 51
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '29'. 61
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '45'. 71

org/opendaylight/protocol/bmp/api/BmpSessionListener.java

Severity Category Rule Message Line
 Warning naming ParameterName Parameter name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 18

org/opendaylight/protocol/bmp/spi/parser/AbstractBmpMessageParser.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder 'com.google.common.base.Preconditions' should be separated from previous import group by one line. 13

org/opendaylight/protocol/bmp/spi/parser/AbstractBmpMessageWithTlvParser.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 141). 40
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 47

org/opendaylight/protocol/bmp/spi/parser/AbstractBmpMessageWithTlvParserTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder 'com.google.common.base.Preconditions' should be separated from previous import group by one line. 15
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 74
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 74
 Warning modifier RedundantModifier Redundant 'public' modifier. 81
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 84
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 87
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 91
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 95
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 97

org/opendaylight/protocol/bmp/spi/parser/AbstractBmpPerPeerMessageParser.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 121). 33
 Warning sizes LineLength Line is longer than 120 characters (found 131). 54
 Warning sizes LineLength Line is longer than 120 characters (found 142). 55
 Warning sizes LineLength Line is longer than 120 characters (found 124). 56
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 70
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 71
 Warning sizes LineLength Line is longer than 120 characters (found 121). 71
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 72
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 73
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 74
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 75
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 76
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 77
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 78
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 79
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 104
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 105
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 106
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 107
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 108
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 109
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 110
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 111
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 112
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 113

org/opendaylight/protocol/bmp/spi/parser/AbstractBmpPerPeerMessageParserTest.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 127). 45
 Warning sizes LineLength Line is longer than 120 characters (found 122). 47
 Warning sizes LineLength Line is longer than 120 characters (found 122). 75
 Warning sizes LineLength Line is longer than 120 characters (found 129). 76
 Warning sizes LineLength Line is longer than 120 characters (found 128). 79
 Warning sizes LineLength Line is longer than 120 characters (found 122). 82

org/opendaylight/protocol/bmp/spi/parser/BmpDeserializationException.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 23
 Warning javadoc JavadocStyle Javadoc has empty description section. 23
 Warning whitespace EmptyLineSeparator 'CTOR_DEF' should be separated from previous statement. 27

org/opendaylight/protocol/bmp/spi/parser/BmpMessageParser.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 16

org/opendaylight/protocol/bmp/spi/parser/BmpMessageSerializer.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 16
 Warning modifier RedundantModifier Redundant 'final' modifier. 16

org/opendaylight/protocol/bmp/spi/parser/TlvUtil.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder 'io.netty.buffer.ByteBuf' should be separated from previous import group by one line. 14

org/opendaylight/protocol/bmp/spi/parser/TlvUtilTest.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'testFormatTlvASCII' must contain no more than '5' consecutive capital letters. 78
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 87
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 87
 Warning coding IllegalThrows Throwing 'Throwable' is not allowed. 88
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 98
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 98
 Warning coding IllegalThrows Throwing 'Throwable' is not allowed. 99

org/opendaylight/protocol/bmp/spi/registry/AbstractBmpExtensionProviderActivator.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 30
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 50

org/opendaylight/protocol/bmp/spi/registry/AbstractBmpExtensionProviderActivatorTest.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 124). 17
 Warning naming ConstantName Name 'context' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 18
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 27
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 27

org/opendaylight/protocol/bmp/spi/registry/BmpMessageRegistrator.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 124). 19

org/opendaylight/protocol/bmp/spi/registry/SimpleBmpExtensionProviderContext.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 144). 35
 Warning sizes LineLength Line is longer than 120 characters (found 133). 50
 Warning sizes LineLength Line is longer than 120 characters (found 129). 60
 Warning sizes LineLength Line is longer than 120 characters (found 133). 70
 Warning sizes LineLength Line is longer than 120 characters (found 134). 80
 Warning sizes LineLength Line is longer than 120 characters (found 137). 90

org/opendaylight/protocol/bmp/spi/registry/SimpleBmpExtensionProviderContextActivator.java

Severity Category Rule Message Line
 Warning whitespace WhitespaceAround WhitespaceAround: 'for' is not followed by whitespace. 36
 Warning whitespace WhitespaceAround WhitespaceAround: 'for' is not followed by whitespace. 45

org/opendaylight/protocol/bmp/spi/registry/SimpleBmpExtensionProviderContextTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder 'org.junit.Before' should be separated from previous import group by one line. 11

org/opendaylight/protocol/bmp/spi/registry/SimpleBmpMessageRegistry.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 124). 30
 Warning sizes LineLength Line is longer than 120 characters (found 140). 39
 Warning sizes LineLength Line is longer than 120 characters (found 121). 68
 Warning sizes LineLength Line is longer than 120 characters (found 140). 71

org/opendaylight/protocol/bmp/spi/registry/SimpleBmpMessageRegistryTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder 'io.netty.buffer.ByteBuf' should be separated from previous import group by one line. 13
 Warning sizes LineLength Line is longer than 120 characters (found 121). 49
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 56
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 56
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 62
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 62
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 68
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 68
 Warning whitespace WhitespaceAround WhitespaceAround: '-' is not preceded with whitespace. 70
 Warning whitespace WhitespaceAround WhitespaceAround: '-' is not followed by whitespace. 70
 Warning modifier RedundantModifier Redundant 'public' modifier. 95

org/opendaylight/protocol/bmp/spi/registry/SimpleBmpTlvRegistry.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 123). 58

org/opendaylight/protocol/bmp/spi/registry/SimpleBmpTlvRegistryTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder 'io.netty.buffer.ByteBuf' should be separated from previous import group by one line. 14
 Warning naming ConstantName Name 'descriptionTlvType' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 37
 Warning naming ConstantName Name 'otherTlvType' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 38
 Warning sizes LineLength Line is longer than 120 characters (found 125). 59