FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
Classes |
Bugs |
Errors |
Missing Classes |
108 |
36 |
0 |
0 |
org.opendaylight.lispflowmapping.implementation.MappingSystem
Bug |
Category |
Details |
Line |
Priority |
Useless control flow in org.opendaylight.lispflowmapping.implementation.MappingSystem.removeMapping(MappingOrigin, Eid) |
STYLE |
UCF_USELESS_CONTROL_FLOW |
235 |
Low |
org.opendaylight.lispflowmapping.implementation.authentication.LispAuthenticationUtil
Bug |
Category |
Details |
Line |
Priority |
Class org.opendaylight.lispflowmapping.implementation.authentication.LispAuthenticationUtil is final but declares protected field org.opendaylight.lispflowmapping.implementation.authentication.LispAuthenticationUtil.LOG |
STYLE |
CI_CONFUSED_INHERITANCE |
|
Low |
org.opendaylight.lispflowmapping.implementation.authentication.LispMACAuthentication
Bug |
Category |
Details |
Line |
Priority |
Found reliance on default encoding in org.opendaylight.lispflowmapping.implementation.authentication.LispMACAuthentication.getAuthenticationData(byte[], String): String.getBytes() |
I18N |
DM_DEFAULT_ENCODING |
62 |
High |
Should org.opendaylight.lispflowmapping.implementation.authentication.LispMACAuthentication.getAuthenticationData(byte[], String) return a zero length array rather than null? |
STYLE |
PZLA_PREFER_ZERO_LENGTH_ARRAYS |
73 |
Low |
org.opendaylight.lispflowmapping.implementation.authentication.LispNoAuthentication
Bug |
Category |
Details |
Line |
Priority |
Write to static field org.opendaylight.lispflowmapping.implementation.authentication.LispNoAuthentication.authenticationData from instance method new org.opendaylight.lispflowmapping.implementation.authentication.LispNoAuthentication() |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
25 |
Medium |
org.opendaylight.lispflowmapping.implementation.config.ConfigIni
Bug |
Category |
Details |
Line |
Priority |
Class org.opendaylight.lispflowmapping.implementation.config.ConfigIni is final but declares protected field org.opendaylight.lispflowmapping.implementation.config.ConfigIni.LOG |
STYLE |
CI_CONFUSED_INHERITANCE |
|
Low |
org.opendaylight.lispflowmapping.implementation.lisp.MapResolver
Bug |
Category |
Details |
Line |
Priority |
Useless condition: it's known that priority != 255 (0xff) at this point |
STYLE |
UC_USELESS_CONDITION |
211 |
Medium |
org.opendaylight.lispflowmapping.implementation.mapcache.FlatMapCache$1
Bug |
Category |
Details |
Line |
Priority |
The class org.opendaylight.lispflowmapping.implementation.mapcache.FlatMapCache$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
112 |
Low |
org.opendaylight.lispflowmapping.implementation.mapcache.MultiTableMapCache
Bug |
Category |
Details |
Line |
Priority |
Private method org.opendaylight.lispflowmapping.implementation.mapcache.MultiTableMapCache.getMappingExactSD(Eid, Eid, ILispDAO) is never called |
PERFORMANCE |
UPM_UNCALLED_PRIVATE_METHOD |
105 |
Low |
org.opendaylight.lispflowmapping.implementation.mapcache.MultiTableMapCache$1
Bug |
Category |
Details |
Line |
Priority |
The class org.opendaylight.lispflowmapping.implementation.mapcache.MultiTableMapCache$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
284 |
Low |
org.opendaylight.lispflowmapping.implementation.mapcache.MultiTableMapCache$2
Bug |
Category |
Details |
Line |
Priority |
The class org.opendaylight.lispflowmapping.implementation.mapcache.MultiTableMapCache$2 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
296 |
Low |
org.opendaylight.lispflowmapping.implementation.mapcache.MultiTableMapCache$3
Bug |
Category |
Details |
Line |
Priority |
The class org.opendaylight.lispflowmapping.implementation.mapcache.MultiTableMapCache$3 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
314 |
Low |
org.opendaylight.lispflowmapping.implementation.mapcache.SimpleMapCache$1
Bug |
Category |
Details |
Line |
Priority |
The class org.opendaylight.lispflowmapping.implementation.mapcache.SimpleMapCache$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
196 |
Low |
org.opendaylight.lispflowmapping.implementation.mapcache.SimpleMapCache$2
Bug |
Category |
Details |
Line |
Priority |
The class org.opendaylight.lispflowmapping.implementation.mapcache.SimpleMapCache$2 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
370 |
Low |
org.opendaylight.lispflowmapping.implementation.mapcache.SimpleMapCache$3
Bug |
Category |
Details |
Line |
Priority |
The class org.opendaylight.lispflowmapping.implementation.mapcache.SimpleMapCache$3 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
383 |
Low |
org.opendaylight.lispflowmapping.implementation.mdsal.AbstractDataListener
Bug |
Category |
Details |
Line |
Priority |
AbstractDataListener.broker not initialized in constructor and dereferenced in org.opendaylight.lispflowmapping.implementation.mdsal.AbstractDataListener.registerDataChangeListener() |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
28 |
Low |
AbstractDataListener.registration not initialized in constructor and dereferenced in org.opendaylight.lispflowmapping.implementation.mdsal.AbstractDataListener.closeDataChangeListener() |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
33 |
Low |
org.opendaylight.lispflowmapping.implementation.mdsal.DataStoreBackEnd$1
Bug |
Category |
Details |
Line |
Priority |
The class org.opendaylight.lispflowmapping.implementation.mdsal.DataStoreBackEnd$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
158 |
Low |
org.opendaylight.lispflowmapping.implementation.mdsal.DataStoreBackEnd$2
Bug |
Category |
Details |
Line |
Priority |
The class org.opendaylight.lispflowmapping.implementation.mdsal.DataStoreBackEnd$2 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
192 |
Low |
org.opendaylight.lispflowmapping.implementation.util.LispNotificationHelper
Bug |
Category |
Details |
Line |
Priority |
Class org.opendaylight.lispflowmapping.implementation.util.LispNotificationHelper is final but declares protected field org.opendaylight.lispflowmapping.implementation.util.LispNotificationHelper.LOG |
STYLE |
CI_CONFUSED_INHERITANCE |
|
Low |
Boxing/unboxing to parse a primitive org.opendaylight.lispflowmapping.implementation.util.LispNotificationHelper.getTransportAddressFromRloc(Rloc) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
63 |
High |
org.opendaylight.lispflowmapping.implementation.util.MappingMergeUtil
Bug |
Category |
Details |
Line |
Priority |
Class org.opendaylight.lispflowmapping.implementation.util.MappingMergeUtil is final but declares protected field org.opendaylight.lispflowmapping.implementation.util.MappingMergeUtil.LOG |
STYLE |
CI_CONFUSED_INHERITANCE |
|
Low |
Suspicious comparison of Boolean references in org.opendaylight.lispflowmapping.implementation.util.MappingMergeUtil.mergeCommonMappingRecordFields(MappingRecordBuilder, MappingRecord) |
BAD_PRACTICE |
RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN |
64 |
Medium |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.LispMappingserviceImplBuilder$LispMappingserviceImplImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.LispMappingserviceImplBuilder$LispMappingserviceImplImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.LispMappingserviceImplBuilder$LispMappingserviceImplImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
210 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.MappingserviceImplBuilder$MappingserviceImplImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.MappingserviceImplBuilder$MappingserviceImplImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.MappingserviceImplBuilder$MappingserviceImplImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
258 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.lisp.mappingservice.impl.MappingserviceBuilder$MappingserviceImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.lisp.mappingservice.impl.MappingserviceBuilder$MappingserviceImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.lisp.mappingservice.impl.MappingserviceBuilder$MappingserviceImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.lisp.mappingservice.impl.NotificationServiceBuilder$NotificationServiceImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.lisp.mappingservice.impl.NotificationServiceBuilder$NotificationServiceImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.lisp.mappingservice.impl.NotificationServiceBuilder$NotificationServiceImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.lisp.mappingservice.impl.OsgiBrokerBuilder$OsgiBrokerImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.lisp.mappingservice.impl.OsgiBrokerBuilder$OsgiBrokerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.lisp.mappingservice.impl.OsgiBrokerBuilder$OsgiBrokerImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.BrokerBuilder$BrokerImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.BrokerBuilder$BrokerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.BrokerBuilder$BrokerImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.DaoBuilder$DaoImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.DaoBuilder$DaoImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.DaoBuilder$DaoImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.DataBrokerBuilder$DataBrokerImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.DataBrokerBuilder$DataBrokerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.DataBrokerBuilder$DataBrokerImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.NotificationPublishServiceBuilder$NotificationPublishServiceImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.NotificationPublishServiceBuilder$NotificationPublishServiceImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.NotificationPublishServiceBuilder$NotificationPublishServiceImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.RpcRegistryBuilder$RpcRegistryImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.RpcRegistryBuilder$RpcRegistryImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.impl.rev150906.modules.module.configuration.mappingservice.impl.RpcRegistryBuilder$RpcRegistryImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.shell.impl.rev150925.modules.module.configuration.MappingserviceShellImplBuilder$MappingserviceShellImplImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.shell.impl.rev150925.modules.module.configuration.MappingserviceShellImplBuilder$MappingserviceShellImplImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.shell.impl.rev150925.modules.module.configuration.MappingserviceShellImplBuilder$MappingserviceShellImplImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
186 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.shell.impl.rev150925.modules.module.configuration.mappingservice.shell.impl.MappingserviceBuilder$MappingserviceImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.shell.impl.rev150925.modules.module.configuration.mappingservice.shell.impl.MappingserviceBuilder$MappingserviceImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.shell.impl.rev150925.modules.module.configuration.mappingservice.shell.impl.MappingserviceBuilder$MappingserviceImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.shell.impl.rev150925.modules.module.configuration.mappingservice.shell.impl.OsgiBrokerBuilder$OsgiBrokerImpl
Bug |
Category |
Details |
Line |
Priority |
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.shell.impl.rev150925.modules.module.configuration.mappingservice.shell.impl.OsgiBrokerBuilder$OsgiBrokerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.controller.config.lfm.mappingservice.shell.impl.rev150925.modules.module.configuration.mappingservice.shell.impl.OsgiBrokerBuilder$OsgiBrokerImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |