Checkstyle Results

The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
173 0 134 0

Files

File  I  W  E
org/opendaylight/lispflowmapping/integrationtest/MappingServiceIntegrationTest.java 0 44 0
org/opendaylight/lispflowmapping/integrationtest/MultiSiteScenario.java 0 39 0
org/opendaylight/lispflowmapping/integrationtest/MultiSiteScenarioUtil.java 0 20 0
org/opendaylight/lispflowmapping/integrationtest/SocketReader.java 0 11 0
org/opendaylight/lispflowmapping/tools/junit/BaseExpectations.java 0 15 0
org/opendaylight/lispflowmapping/tools/junit/BaseTestCase.java 0 5 0

Rules

Category Rule Violations Severity
blocks EmptyBlock
  • tokens: "LITERAL_TRY, LITERAL_CATCH, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"
  • option: "TEXT"
 2  Warning
coding IllegalCatch 4  Warning
IllegalThrows 6  Warning
OverloadMethodsDeclarationOrder 1  Warning
VariableDeclarationUsageDistance 3  Warning
imports CustomImportOrder
  • thirdPartyPackageRegExp: ".*"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
 1  Warning
indentation Indentation
  • throwsIndent: "4"
  • arrayInitIndent: "4"
  • caseIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
  • lineWrappingIndentation: "4"
 18  Warning
javadoc JavadocStyle
  • checkEmptyJavadoc: "true"
 10  Warning
misc ArrayTypeStyle 1  Warning
modifier ModifierOrder 14  Warning
RedundantModifier 2  Warning
naming AbbreviationAsWordInName
  • ignoreFinal: "false"
  • allowedAbbreviationLength: "4"
 10  Warning
ConstantName 1  Warning
LocalVariableName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
  • allowOneCharVarInForLoop: "true"
  • tokens: "VARIABLE_DEF"
 2  Warning
MemberName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
 13  Warning
MethodName
  • format: "^[a-z][a-zA-Z0-9_]*$"
 1  Warning
MethodName
  • format: "^[a-z][a-zA-Z0-9_]*$"
 1  Warning
whitespace EmptyLineSeparator
  • allowNoEmptyLineBetweenFields: "true"
  • tokens: "IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"
 3  Warning
MethodParamPad 2  Warning
OperatorWrap
  • tokens: "BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "
  • option: "NL"
 11  Warning
SeparatorWrap
  • tokens: "COMMA"
  • option: "EOL"
 8  Warning
SeparatorWrap
  • tokens: "DOT"
  • option: "nl"
 8  Warning
WhitespaceAround
  • allowEmptyConstructors: "true"
  • allowEmptyMethods: "true"
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
 11  Warning

Details

org/opendaylight/lispflowmapping/integrationtest/MappingServiceIntegrationTest.java

Severity Category Rule Message Line
 Warning naming ConstantName Name 'ourAddress' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 161
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 326
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 326
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 329
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 329
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 332
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 332
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 376
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 522
 Warning javadoc JavadocStyle First sentence should end with a period. 522
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 646
 Warning javadoc JavadocStyle First sentence should end with a period. 646
 Warning blocks EmptyBlock Empty catch block. 914
 Warning blocks EmptyBlock Empty catch block. 925
 Warning coding VariableDeclarationUsageDistance Distance between variable 'ipPrefix1' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 1675
 Warning coding VariableDeclarationUsageDistance Distance between variable 'hop1' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 1801
 Warning coding VariableDeclarationUsageDistance Distance between variable 'receivedHop2' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 1825
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 2006
 Warning coding IllegalThrows Throwing 'Throwable' is not allowed. 2110
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 12, expected level should be one of the following: 16, 20. 2131
 Warning indentation Indentation 'method def' child have incorrect indentation level 16, expected level should be one of the following: 20, 24. 2133
 Warning indentation Indentation 'method def' child have incorrect indentation level 16, expected level should be one of the following: 20, 24. 2135
 Warning indentation Indentation 'method def' child have incorrect indentation level 16, expected level should be one of the following: 20, 24. 2136
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 12, expected level should be one of the following: 16, 20. 2137
 Warning indentation Indentation 'object def rcurly' have incorrect indentation level 8, expected level should be one of the following: 12, 16. 2138
 Warning coding IllegalCatch Catching 'Throwable' is not allowed. 2220
 Warning coding IllegalCatch Catching 'Throwable' is not allowed. 2244
 Warning whitespace WhitespaceAround WhitespaceAround: '*' is not preceded with whitespace. 2252
 Warning whitespace WhitespaceAround WhitespaceAround: '*' is not followed by whitespace. 2252
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 2264
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 2264
 Warning naming AbbreviationAsWordInName Abbreviation in name 'HEADER_LEN' must contain no more than '4' capital letters. 2276
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 2295
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 2296
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 2297
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 2298
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 2299
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 2300
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 2301
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 2302
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 2303
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 2304
 Warning naming LocalVariableName Local variable name 'b' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 2313
 Warning misc ArrayTypeStyle Array brackets at illegal position. 2313

org/opendaylight/lispflowmapping/integrationtest/MultiSiteScenario.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.net.InetAddresses' import. Should be before 'org.slf4j.LoggerFactory'. 61
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_NETWORK_MASK' must contain no more than '4' capital letters. 71
 Warning naming MemberName Member name 'DEFAULT_NETWORK_MASK' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 71
 Warning naming MemberName Member name 'IP_MASK' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 72
 Warning naming MemberName Member name 'TTL' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 74
 Warning naming AbbreviationAsWordInName Abbreviation in name 'MAP_RECORD_A' must contain no more than '4' capital letters. 75
 Warning naming MemberName Member name 'MAP_RECORD_A' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 75
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_MULTICAST_PRIORITY' must contain no more than '4' capital letters. 77
 Warning naming MemberName Member name 'DEFAULT_MULTICAST_PRIORITY' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 77
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_MULTICAST_WEIGHT' must contain no more than '4' capital letters. 78
 Warning naming MemberName Member name 'DEFAULT_MULTICAST_WEIGHT' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 78
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_LOCAL_LOCATOR' must contain no more than '4' capital letters. 79
 Warning naming MemberName Member name 'DEFAULT_LOCAL_LOCATOR' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 79
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_RLOC_PROBED' must contain no more than '4' capital letters. 80
 Warning naming MemberName Member name 'DEFAULT_RLOC_PROBED' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 80
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_ROUTED' must contain no more than '4' capital letters. 81
 Warning naming MemberName Member name 'DEFAULT_ROUTED' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 81
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_XTR_ID' must contain no more than '4' capital letters. 82
 Warning naming MemberName Member name 'DEFAULT_XTR_ID' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 82
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_SITE_ID' must contain no more than '4' capital letters. 83
 Warning naming MemberName Member name 'DEFAULT_SITE_ID' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 83
 Warning naming MemberName Member name 'NULL_AUTH_KEY' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 85
 Warning indentation Indentation 'InstanceIdType' have incorrect indentation level 4, expected level should be 8. 158
 Warning whitespace OperatorWrap '!=' should be on a new line. 223
 Warning whitespace OperatorWrap '+' should be on a new line. 337
 Warning whitespace OperatorWrap '+' should be on a new line. 350
 Warning whitespace OperatorWrap '+' should be on a new line. 351
 Warning whitespace OperatorWrap '+' should be on a new line. 357
 Warning whitespace OperatorWrap '+' should be on a new line. 358
 Warning whitespace OperatorWrap '+' should be on a new line. 364
 Warning whitespace OperatorWrap '+' should be on a new line. 365
 Warning whitespace OperatorWrap '+' should be on a new line. 374
 Warning whitespace OperatorWrap '+' should be on a new line. 375
 Warning whitespace MethodParamPad '(' should be on the previous line. 401
 Warning whitespace MethodParamPad '(' should be on the previous line. 407
 Warning whitespace SeparatorWrap '.' should be on a new line. 412
 Warning whitespace SeparatorWrap '.' should be on a new line. 414
 Warning whitespace WhitespaceAround WhitespaceAround: 'for' is not followed by whitespace. 471
 Warning naming MethodName Method name 'SMRContainsExpectedEid' must match pattern '^[a-z][a-zA-Z0-9_]*$'. 483

org/opendaylight/lispflowmapping/integrationtest/MultiSiteScenarioUtil.java

Severity Category Rule Message Line
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 14
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 15
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 16
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 17
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 18
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 19
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 20
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 22
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 23
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 29
 Warning javadoc JavadocStyle First sentence should end with a period. 29
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 39
 Warning javadoc JavadocStyle First sentence should end with a period. 39
 Warning whitespace EmptyLineSeparator 'CTOR_DEF' should be separated from previous statement. 116
 Warning indentation Indentation 'array initialization' child have incorrect indentation level 20, expected level should be 16. 120
 Warning whitespace SeparatorWrap ',' should be on the previous line. 121
 Warning whitespace SeparatorWrap ',' should be on the previous line. 122
 Warning whitespace SeparatorWrap ',' should be on the previous line. 123
 Warning whitespace SeparatorWrap ',' should be on the previous line. 124
 Warning whitespace SeparatorWrap ',' should be on the previous line. 125

org/opendaylight/lispflowmapping/integrationtest/SocketReader.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 28
 Warning javadoc JavadocStyle First sentence should end with a period. 28
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 34
 Warning javadoc JavadocStyle First sentence should end with a period. 34
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 39
 Warning javadoc JavadocStyle First sentence should end with a period. 39
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 44
 Warning javadoc JavadocStyle First sentence should end with a period. 44
 Warning coding IllegalCatch Catching 'Throwable' is not allowed. 63
 Warning whitespace SeparatorWrap '.' should be on a new line. 72
 Warning whitespace OperatorWrap '+' should be on a new line. 95

org/opendaylight/lispflowmapping/tools/junit/BaseExpectations.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 133
 Warning coding IllegalThrows Throwing 'Throwable' is not allowed. 159
 Warning naming LocalVariableName Local variable name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 160
 Warning naming MemberName Member name 'i' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 178
 Warning modifier RedundantModifier Redundant 'public' modifier. 180
 Warning coding IllegalThrows Throwing 'Throwable' is not allowed. 184
 Warning coding IllegalThrows Throwing 'Throwable' is not allowed. 210
 Warning coding IllegalThrows Throwing 'Throwable' is not allowed. 264
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 278
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 304
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 324
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 346
 Warning javadoc JavadocStyle Javadoc has empty description section. 346
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 375
 Warning javadoc JavadocStyle Javadoc has empty description section. 375

org/opendaylight/lispflowmapping/tools/junit/BaseTestCase.java

Severity Category Rule Message Line
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '79'. 105
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 116
 Warning modifier ModifierOrder 'protected' modifier out of order with the JLS suggestions. 124
 Warning modifier ModifierOrder 'public' modifier out of order with the JLS suggestions. 125
 Warning coding IllegalThrows Throwing 'Throwable' is not allowed. 139