Checkstyle Results

The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
204 0 130 0

Files

File  I  W  E
org/opendaylight/lispflowmapping/integrationtest/MappingServiceIntegrationTest.java 0 46 0
org/opendaylight/lispflowmapping/integrationtest/MultiSiteScenario.java 0 37 0
org/opendaylight/lispflowmapping/integrationtest/MultiSiteScenarioUtil.java 0 21 0
org/opendaylight/lispflowmapping/integrationtest/SocketReader.java 0 11 0
org/opendaylight/lispflowmapping/tools/junit/BaseExpectations.java 0 12 0
org/opendaylight/lispflowmapping/tools/junit/BaseTestCase.java 0 3 0

Rules

Category Rule Violations Severity
blocks EmptyBlock
  • tokens: "LITERAL_TRY, LITERAL_CATCH, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"
  • option: "TEXT"
 2  Warning
coding IllegalCatch 3  Warning
IllegalThrows 6  Warning
OverloadMethodsDeclarationOrder 2  Warning
VariableDeclarationUsageDistance 4  Warning
imports CustomImportOrder
  • thirdPartyPackageRegExp: ".*"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
 2  Warning
indentation Indentation
  • throwsIndent: "4"
  • arrayInitIndent: "4"
  • caseIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
  • lineWrappingIndentation: "4"
 19  Warning
javadoc JavadocStyle
  • tokens: "ANNOTATION_DEF, ANNOTATION_FIELD_DEF, CLASS_DEF, CTOR_DEF, ENUM_CONSTANT_DEF, ENUM_DEF, INTERFACE_DEF, METHOD_DEF, VARIABLE_DEF"
  • checkEmptyJavadoc: "true"
 10  Warning
misc ArrayTypeStyle 1  Warning
modifier ModifierOrder 9  Warning
RedundantModifier 2  Warning
naming AbbreviationAsWordInName
  • ignoreFinal: "false"
  • allowedAbbreviationLength: "4"
 9  Warning
ConstantName 1  Warning
LocalVariableName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
  • allowOneCharVarInForLoop: "true"
  • tokens: "VARIABLE_DEF"
 2  Warning
MemberName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
 12  Warning
MethodName
  • format: "^[a-z][a-zA-Z0-9_]*$"
 1  Warning
MethodName
  • format: "^[a-z][a-zA-Z0-9_]*$"
 1  Warning
whitespace EmptyLineSeparator
  • allowNoEmptyLineBetweenFields: "true"
  • tokens: "IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"
 3  Warning
MethodParamPad 2  Warning
OperatorWrap
  • tokens: "BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "
  • option: "NL"
 11  Warning
SeparatorWrap
  • tokens: "COMMA"
  • option: "EOL"
 8  Warning
SeparatorWrap
  • tokens: "DOT"
  • option: "nl"
 8  Warning
WhitespaceAround
  • allowEmptyConstructors: "true"
  • allowEmptyMethods: "true"
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
 11  Warning

Details

org/opendaylight/lispflowmapping/integrationtest/MappingServiceIntegrationTest.java

Severity Category Rule Message Line
 Warning naming ConstantName Name 'ourAddress' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 171
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 337
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 337
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 340
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 340
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 343
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 343
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 387
 Warning coding VariableDeclarationUsageDistance Distance between variable 'timeout' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 437
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 684
 Warning javadoc JavadocStyle First sentence should end with a period. 684
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 810
 Warning javadoc JavadocStyle First sentence should end with a period. 810
 Warning blocks EmptyBlock Empty catch block. 1078
 Warning blocks EmptyBlock Empty catch block. 1089
 Warning coding VariableDeclarationUsageDistance Distance between variable 'ipPrefix1' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 1839
 Warning coding VariableDeclarationUsageDistance Distance between variable 'hop1' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 1965
 Warning coding VariableDeclarationUsageDistance Distance between variable 'receivedHop2' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 1989
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 2202
 Warning coding IllegalThrows Throwing 'Throwable' is not allowed. 2306
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 12, expected level should be one of the following: 16, 20. 2327
 Warning indentation Indentation 'method def' child have incorrect indentation level 16, expected level should be one of the following: 20, 24. 2329
 Warning indentation Indentation 'method def' child have incorrect indentation level 16, expected level should be one of the following: 20, 24. 2331
 Warning indentation Indentation 'method def' child have incorrect indentation level 16, expected level should be one of the following: 20, 24. 2332
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 12, expected level should be one of the following: 16, 20. 2333
 Warning indentation Indentation 'object def rcurly' have incorrect indentation level 8, expected level should be one of the following: 12, 16. 2334
 Warning coding IllegalCatch Catching 'Throwable' is not allowed. 2416
 Warning coding IllegalCatch Catching 'Throwable' is not allowed. 2440
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '2,381'. 2446
 Warning whitespace WhitespaceAround WhitespaceAround: '*' is not preceded with whitespace. 2466
 Warning whitespace WhitespaceAround WhitespaceAround: '*' is not followed by whitespace. 2466
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 2486
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not followed by whitespace. 2486
 Warning naming AbbreviationAsWordInName Abbreviation in name 'HEADER_LEN' must contain no more than '4' capital letters. 2499
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 2518
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 2519
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 2520
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 2521
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 2522
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 2523
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 2524
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 2525
 Warning indentation Indentation 'case' child have incorrect indentation level 8, expected level should be 12. 2526
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be 16. 2527
 Warning naming LocalVariableName Local variable name 'b' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 2536
 Warning misc ArrayTypeStyle Array brackets at illegal position. 2536

org/opendaylight/lispflowmapping/integrationtest/MultiSiteScenario.java

Severity Category Rule Message Line
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_NETWORK_MASK' must contain no more than '4' capital letters. 70
 Warning naming MemberName Member name 'DEFAULT_NETWORK_MASK' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 70
 Warning naming MemberName Member name 'IP_MASK' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 71
 Warning naming MemberName Member name 'TTL' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 73
 Warning naming AbbreviationAsWordInName Abbreviation in name 'MAP_RECORD_A' must contain no more than '4' capital letters. 74
 Warning naming MemberName Member name 'MAP_RECORD_A' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 74
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_MULTICAST_PRIORITY' must contain no more than '4' capital letters. 76
 Warning naming MemberName Member name 'DEFAULT_MULTICAST_PRIORITY' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 76
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_MULTICAST_WEIGHT' must contain no more than '4' capital letters. 77
 Warning naming MemberName Member name 'DEFAULT_MULTICAST_WEIGHT' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 77
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_LOCAL_LOCATOR' must contain no more than '4' capital letters. 78
 Warning naming MemberName Member name 'DEFAULT_LOCAL_LOCATOR' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 78
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_RLOC_PROBED' must contain no more than '4' capital letters. 79
 Warning naming MemberName Member name 'DEFAULT_RLOC_PROBED' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 79
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_ROUTED' must contain no more than '4' capital letters. 80
 Warning naming MemberName Member name 'DEFAULT_ROUTED' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 80
 Warning naming AbbreviationAsWordInName Abbreviation in name 'DEFAULT_SITE_ID' must contain no more than '4' capital letters. 81
 Warning naming MemberName Member name 'DEFAULT_SITE_ID' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 81
 Warning naming MemberName Member name 'NULL_AUTH_KEY' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 83
 Warning indentation Indentation 'InstanceIdType' have incorrect indentation level 4, expected level should be 8. 156
 Warning whitespace OperatorWrap '!=' should be on a new line. 224
 Warning whitespace OperatorWrap '+' should be on a new line. 338
 Warning whitespace OperatorWrap '+' should be on a new line. 351
 Warning whitespace OperatorWrap '+' should be on a new line. 352
 Warning whitespace OperatorWrap '+' should be on a new line. 358
 Warning whitespace OperatorWrap '+' should be on a new line. 359
 Warning whitespace OperatorWrap '+' should be on a new line. 365
 Warning whitespace OperatorWrap '+' should be on a new line. 366
 Warning whitespace OperatorWrap '+' should be on a new line. 375
 Warning whitespace OperatorWrap '+' should be on a new line. 376
 Warning whitespace MethodParamPad '(' should be on the previous line. 402
 Warning whitespace MethodParamPad '(' should be on the previous line. 408
 Warning whitespace SeparatorWrap '.' should be on a new line. 413
 Warning whitespace SeparatorWrap '.' should be on a new line. 415
 Warning whitespace WhitespaceAround WhitespaceAround: 'for' is not followed by whitespace. 476
 Warning naming MethodName Method name 'SMRContainsExpectedEid' must match pattern '^[a-z][a-zA-Z0-9_]*$'. 488
 Warning indentation Indentation 'if' child have incorrect indentation level 17, expected level should be 16. 492

org/opendaylight/lispflowmapping/integrationtest/MultiSiteScenarioUtil.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.lisp.address.types.rev151105.InstanceIdType' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.lfm.lisp.proto.rev151105.XtrId'. 12
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 15
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 16
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 17
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 18
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 19
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 20
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 21
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 23
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 24
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 30
 Warning javadoc JavadocStyle First sentence should end with a period. 30
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 40
 Warning javadoc JavadocStyle First sentence should end with a period. 40
 Warning whitespace EmptyLineSeparator 'CTOR_DEF' should be separated from previous statement. 117
 Warning indentation Indentation 'array initialization' child have incorrect indentation level 20, expected level should be 16. 121
 Warning whitespace SeparatorWrap ',' should be on the previous line. 122
 Warning whitespace SeparatorWrap ',' should be on the previous line. 123
 Warning whitespace SeparatorWrap ',' should be on the previous line. 124
 Warning whitespace SeparatorWrap ',' should be on the previous line. 125
 Warning whitespace SeparatorWrap ',' should be on the previous line. 126

org/opendaylight/lispflowmapping/integrationtest/SocketReader.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Import statement for 'org.junit.Assert.fail' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. 18
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 28
 Warning javadoc JavadocStyle First sentence should end with a period. 28
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 34
 Warning javadoc JavadocStyle First sentence should end with a period. 34
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 39
 Warning javadoc JavadocStyle First sentence should end with a period. 39
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 44
 Warning javadoc JavadocStyle First sentence should end with a period. 44
 Warning whitespace SeparatorWrap '.' should be on a new line. 77
 Warning whitespace OperatorWrap '+' should be on a new line. 103

org/opendaylight/lispflowmapping/tools/junit/BaseExpectations.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 133
 Warning coding IllegalThrows Throwing 'Throwable' is not allowed. 159
 Warning naming LocalVariableName Local variable name 'e' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 160
 Warning naming MemberName Member name 'i' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 178
 Warning modifier RedundantModifier Redundant 'public' modifier. 180
 Warning coding IllegalThrows Throwing 'Throwable' is not allowed. 184
 Warning coding IllegalThrows Throwing 'Throwable' is not allowed. 210
 Warning coding IllegalThrows Throwing 'Throwable' is not allowed. 264
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 346
 Warning javadoc JavadocStyle Javadoc has empty description section. 346
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 375
 Warning javadoc JavadocStyle Javadoc has empty description section. 375

org/opendaylight/lispflowmapping/tools/junit/BaseTestCase.java

Severity Category Rule Message Line
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '79'. 105
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 116
 Warning coding IllegalThrows Throwing 'Throwable' is not allowed. 139