FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 99 |
25 |
0 |
0 |
org.opendaylight.mdsal.binding.dom.codec.api.BindingCodecTree
| Bug |
Category |
Details |
Line |
Priority |
| The class name org.opendaylight.mdsal.binding.dom.codec.api.BindingCodecTree shadows the simple name of implemented interface org.opendaylight.yangtools.binding.data.codec.api.BindingCodecTree |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_INTERFACE |
|
Medium |
org.opendaylight.mdsal.binding.dom.codec.api.BindingCodecTreeFactory
| Bug |
Category |
Details |
Line |
Priority |
| The class name org.opendaylight.mdsal.binding.dom.codec.api.BindingCodecTreeFactory shadows the simple name of implemented interface org.opendaylight.yangtools.binding.data.codec.api.BindingCodecTreeFactory |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_INTERFACE |
|
Medium |
org.opendaylight.mdsal.binding.dom.codec.api.BindingCodecTreeNode
| Bug |
Category |
Details |
Line |
Priority |
| The class name org.opendaylight.mdsal.binding.dom.codec.api.BindingCodecTreeNode shadows the simple name of implemented interface org.opendaylight.yangtools.binding.data.codec.api.BindingCodecTreeNode |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_INTERFACE |
|
Medium |
org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeCachingCodec
| Bug |
Category |
Details |
Line |
Priority |
| The class name org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeCachingCodec shadows the simple name of implemented interface org.opendaylight.yangtools.binding.data.codec.api.BindingNormalizedNodeCachingCodec |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_INTERFACE |
|
Medium |
org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeCodec
| Bug |
Category |
Details |
Line |
Priority |
| The class name org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeCodec shadows the simple name of implemented interface org.opendaylight.yangtools.binding.data.codec.api.BindingNormalizedNodeCodec |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_INTERFACE |
|
Medium |
org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeSerializer
| Bug |
Category |
Details |
Line |
Priority |
| The class name org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeSerializer shadows the simple name of implemented interface org.opendaylight.yangtools.binding.data.codec.api.BindingNormalizedNodeSerializer |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_INTERFACE |
|
Medium |
org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeWriterFactory
| Bug |
Category |
Details |
Line |
Priority |
| The class name org.opendaylight.mdsal.binding.dom.codec.api.BindingNormalizedNodeWriterFactory shadows the simple name of implemented interface org.opendaylight.yangtools.binding.data.codec.api.BindingNormalizedNodeWriterFactory |
BAD_PRACTICE |
NM_SAME_SIMPLE_NAME_AS_INTERFACE |
|
Medium |
org.opendaylight.yangtools.binding.data.codec.gen.impl.AbstractStreamWriterGenerator
| Bug |
Category |
Details |
Line |
Priority |
| Invocation of reflect.Field.setAccessible(boolean), which should be invoked from within a doPrivileged block, in org.opendaylight.yangtools.binding.data.codec.gen.impl.AbstractStreamWriterGenerator.<static initializer for AbstractStreamWriterGenerator>() |
MALICIOUS_CODE |
DP_DO_INSIDE_DO_PRIVILEGED |
67 |
Low |
org.opendaylight.yangtools.binding.data.codec.gen.impl.AbstractStreamWriterGenerator$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.binding.data.codec.gen.impl.AbstractStreamWriterGenerator$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
200 |
Low |
org.opendaylight.yangtools.binding.data.codec.gen.impl.StreamWriterGenerator
| Bug |
Category |
Details |
Line |
Priority |
| Private method org.opendaylight.yangtools.binding.data.codec.gen.impl.StreamWriterGenerator.getChildSizeFromSchema(DataNodeContainer) is never called |
PERFORMANCE |
UPM_UNCALLED_PRIVATE_METHOD |
65 |
Low |
org.opendaylight.yangtools.binding.data.codec.gen.impl.StreamWriterGenerator$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.binding.data.codec.gen.impl.StreamWriterGenerator$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
72 |
Low |
org.opendaylight.yangtools.binding.data.codec.gen.impl.StreamWriterGenerator$2
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.binding.data.codec.gen.impl.StreamWriterGenerator$2 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
83 |
Low |
org.opendaylight.yangtools.binding.data.codec.gen.impl.StreamWriterGenerator$3
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.binding.data.codec.gen.impl.StreamWriterGenerator$3 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
93 |
Low |
org.opendaylight.yangtools.binding.data.codec.gen.impl.StreamWriterGenerator$4
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.binding.data.codec.gen.impl.StreamWriterGenerator$4 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
103 |
Low |
org.opendaylight.yangtools.binding.data.codec.gen.impl.StreamWriterGenerator$5
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.binding.data.codec.gen.impl.StreamWriterGenerator$5 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
114 |
Low |
org.opendaylight.yangtools.binding.data.codec.gen.impl.StreamWriterGenerator$6
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.binding.data.codec.gen.impl.StreamWriterGenerator$6 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
125 |
Low |
org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCodecRegistry
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.Notification to org.opendaylight.yangtools.yang.binding.DataObject in org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCodecRegistry.toNormalizedNodeNotification(Notification) |
STYLE |
BC_UNCONFIRMED_CAST |
125 |
Low |
org.opendaylight.yangtools.binding.data.codec.impl.BindingNormalizedNodeCodecRegistry$DeserializeFunction
org.opendaylight.yangtools.binding.data.codec.impl.ChoiceNodeCodecContext
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode<?,?> to org.opendaylight.yangtools.yang.data.api.schema.NormalizedNodeContainer in org.opendaylight.yangtools.binding.data.codec.impl.ChoiceNodeCodecContext.deserialize(NormalizedNode) |
STYLE |
BC_UNCONFIRMED_CAST |
156 |
Low |
| Method org.opendaylight.yangtools.binding.data.codec.impl.ChoiceNodeCodecContext.deserialize(NormalizedNode) overrides the return value nullness annotation in an incompatible way. |
STYLE |
NP_METHOD_RETURN_RELAXING_ANNOTATION |
155 |
High |
org.opendaylight.yangtools.binding.data.codec.impl.DataObjectCodecContext
| Bug |
Category |
Details |
Line |
Priority |
| Return value of putIfAbsent is ignored, but augProto is reused in org.opendaylight.yangtools.binding.data.codec.impl.DataObjectCodecContext.reloadAllAugmentations() |
MT_CORRECTNESS |
RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED |
138 |
Medium |
org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject
| Bug |
Category |
Details |
Line |
Priority |
| Return value of putIfAbsent is ignored, but cached is reused in org.opendaylight.yangtools.binding.data.codec.impl.LazyDataObject.getBindingData(Method) |
MT_CORRECTNESS |
RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED |
154 |
Low |
org.opendaylight.yangtools.binding.data.codec.impl.MissingSchemaForClassException
| Bug |
Category |
Details |
Line |
Priority |
| The field org.opendaylight.yangtools.binding.data.codec.impl.MissingSchemaForClassException.bindingClass is transient but isn't set by deserialization |
BAD_PRACTICE |
SE_TRANSIENT_FIELD_NOT_RESTORED |
|
Low |
org.opendaylight.yangtools.binding.data.codec.impl.NotificationCodecContext
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode<?,?> to org.opendaylight.yangtools.yang.data.api.schema.NormalizedNodeContainer in org.opendaylight.yangtools.binding.data.codec.impl.NotificationCodecContext.deserialize(NormalizedNode) |
STYLE |
BC_UNCONFIRMED_CAST |
27 |
Low |
org.opendaylight.yangtools.binding.data.codec.impl.SchemaRootCodecContext
| Bug |
Category |
Details |
Line |
Priority |
| Null passed for non-null parameter of org.opendaylight.yangtools.yang.model.util.SchemaNodeUtils.getRpcDataSchema(RpcDefinition, QName) in org.opendaylight.yangtools.binding.data.codec.impl.SchemaRootCodecContext.createRpcDataContext(Class) |
CORRECTNESS |
NP_NULL_PARAM_DEREF |
203 |
Medium |
