FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is low

Effort is max

Summary

Classes Bugs Errors Missing Classes
39 44 0 0

Files

Class Bugs
org.opendaylight.yangtools.sal.binding.generator.impl.BindingGeneratorImpl 2
org.opendaylight.yangtools.sal.binding.generator.impl.ModuleInfoBackedContext 1
org.opendaylight.yangtools.sal.binding.generator.impl.ModuleInfoBackedContext$1 1
org.opendaylight.yangtools.sal.binding.generator.impl.ModuleInfoBackedContext$2 1
org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate 28
org.opendaylight.yangtools.sal.binding.generator.util.BindingRuntimeContext 1
org.opendaylight.yangtools.sal.binding.generator.util.DefaultSourceCodeGenerator 2
org.opendaylight.yangtools.sal.binding.yang.types.TypeProviderImpl 4
org.opendaylight.yangtools.sal.binding.yang.types.TypeProviderImpl$2 1
org.opendaylight.yangtools.sal.binding.yang.types.UnionDependencySort$1 3

org.opendaylight.yangtools.sal.binding.generator.impl.BindingGeneratorImpl

Bug Category Details Line Priority
Possible null pointer dereference of node in org.opendaylight.yangtools.sal.binding.generator.impl.BindingGeneratorImpl.generateTypesFromAugmentedChoiceCases(Module, String, Type, ChoiceSchemaNode, Iterable, DataNodeContainer) CORRECTNESS NP_NULL_ON_SOME_PATH 1344 Medium
Null passed for non-null parameter of processUsesAugments(DataNodeContainer, Module) in org.opendaylight.yangtools.sal.binding.generator.impl.BindingGeneratorImpl.generateTypesFromChoiceCases(Module, String, Type, ChoiceSchemaNode) CORRECTNESS NP_NULL_PARAM_DEREF 1265 Medium

org.opendaylight.yangtools.sal.binding.generator.impl.ModuleInfoBackedContext

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in org.opendaylight.yangtools.sal.binding.generator.impl.ModuleInfoBackedContext.resolveModuleInfo(YangModuleInfo) STYLE REC_CATCH_EXCEPTION 114 Low

org.opendaylight.yangtools.sal.binding.generator.impl.ModuleInfoBackedContext$1

Bug Category Details Line Priority
The class org.opendaylight.yangtools.sal.binding.generator.impl.ModuleInfoBackedContext$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 121 Low

org.opendaylight.yangtools.sal.binding.generator.impl.ModuleInfoBackedContext$2

Bug Category Details Line Priority
The class org.opendaylight.yangtools.sal.binding.generator.impl.ModuleInfoBackedContext$2 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 163 Low

org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate

Bug Category Details Line Priority
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.formatToParagraph(String, int) CORRECTNESS DMI_DOH 1964 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.generateYangSnipet(Module) CORRECTNESS DMI_DOH 313 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.generateYangSnipet(SchemaNode) CORRECTNESS DMI_DOH 62 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeAugment(AugmentationSchema) CORRECTNESS DMI_DOH 1349 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeAugments(Set) CORRECTNESS DMI_DOH 1296 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeDeviation(Deviation) CORRECTNESS DMI_DOH 1266 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeDeviations(Set) CORRECTNESS DMI_DOH 1227 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeEnumPair(EnumTypeDefinition$EnumPair) CORRECTNESS DMI_DOH 176 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeExtension(ExtensionDefinition) CORRECTNESS DMI_DOH 1207 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeExtensions(List) CORRECTNESS DMI_DOH 1138 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeFeature(FeatureDefinition) CORRECTNESS DMI_DOH 1118 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeFeatures(Set) CORRECTNESS DMI_DOH 1062 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeGroupingDefs(Set) CORRECTNESS DMI_DOH 1325 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeIdentity(IdentitySchemaNode) CORRECTNESS DMI_DOH 961 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeIdentityNs(IdentitySchemaNode) CORRECTNESS DMI_DOH 1042 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeModuleImports(Set) CORRECTNESS DMI_DOH 220 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeNotifications(Set) CORRECTNESS DMI_DOH 645 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeRPC(RpcDefinition) CORRECTNESS DMI_DOH 527 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeRPCs(Set) CORRECTNESS DMI_DOH 476 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeRpcInput(ContainerSchemaNode) CORRECTNESS DMI_DOH 584 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeRpcOutput(ContainerSchemaNode) CORRECTNESS DMI_DOH 614 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeTypeDefinitions(Set) CORRECTNESS DMI_DOH 895 Low
D'oh! A nonsensical invocation of equal(Object, Object) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeUsesNodes(Set) CORRECTNESS DMI_DOH 795 Low
org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.formatToParagraph(String, int) invokes toString() method on a String PERFORMANCE DM_STRING_TOSTRING 2017 Low
Call to Character.equals(String) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.formatToParagraph(String, int) CORRECTNESS EC_UNRELATED_TYPES 1996 High
Call to Character.equals(String) in org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.formatToParagraph(String, int) CORRECTNESS EC_UNRELATED_TYPES 2005 High
Field only ever set to null: org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.module CORRECTNESS UWF_NULL_FIELD 1042 Low
org.opendaylight.yangtools.sal.binding.generator.impl.YangTemplate.writeRefines(Map) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 859 Medium

org.opendaylight.yangtools.sal.binding.generator.util.BindingRuntimeContext

Bug Category Details Line Priority
Return value of org.opendaylight.yangtools.sal.binding.generator.impl.ModuleContext.getTypedefs() ignored, but method has no side effect STYLE RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT 115 Medium

org.opendaylight.yangtools.sal.binding.generator.util.DefaultSourceCodeGenerator

Bug Category Details Line Priority
Found reliance on default encoding in org.opendaylight.yangtools.sal.binding.generator.util.DefaultSourceCodeGenerator.outputGeneratedSource(CtClass): new java.io.FileWriter(File) I18N DM_DEFAULT_ENCODING 133 High
Exceptional return value of java.io.File.mkdir() ignored in org.opendaylight.yangtools.sal.binding.generator.util.DefaultSourceCodeGenerator.outputGeneratedSource(CtClass) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 132 Medium

org.opendaylight.yangtools.sal.binding.yang.types.TypeProviderImpl

Bug Category Details Line Priority
Boxing/unboxing to parse a primitive org.opendaylight.yangtools.sal.binding.yang.types.TypeProviderImpl.provideAvailableNameForGenTOBuilder(String) PERFORMANCE DM_BOXED_PRIMITIVE_FOR_PARSING 1399 High
Redundant nullcheck of strXPath, which is known to be non-null in org.opendaylight.yangtools.sal.binding.yang.types.TypeProviderImpl.leafrefToDef(LeafSchemaNode, LeafrefTypeDefinition, String) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 1583 Low
Redundant nullcheck of strXPath, which is known to be non-null in org.opendaylight.yangtools.sal.binding.yang.types.TypeProviderImpl.provideTypeForLeafref(LeafrefTypeDefinition, SchemaNode) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 484 Low
Redundant nullcheck of listTypeDefinitions, which is known to be non-null in org.opendaylight.yangtools.sal.binding.yang.types.TypeProviderImpl.resolveTypeDefsFromContext() STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 706 Low

org.opendaylight.yangtools.sal.binding.yang.types.TypeProviderImpl$2

Bug Category Details Line Priority
The class org.opendaylight.yangtools.sal.binding.yang.types.TypeProviderImpl$2 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 1622 Low

org.opendaylight.yangtools.sal.binding.yang.types.UnionDependencySort$1

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.parser.util.TopologicalSort$Node to org.opendaylight.yangtools.sal.binding.yang.types.NodeWrappedType in org.opendaylight.yangtools.sal.binding.yang.types.UnionDependencySort$1.apply(TopologicalSort$Node) STYLE BC_UNCONFIRMED_CAST 55 Low
input must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 55 Low
The class org.opendaylight.yangtools.sal.binding.yang.types.UnionDependencySort$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 52 Low