Checkstyle Results

The following document contains the results of Checkstyle 6.2 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
28 0 124 0

Files

File  I  W  E
org/opendaylight/mdsal/common/api/AsyncDataBroker.java 0 4 0
org/opendaylight/mdsal/common/api/AsyncDataTransactionFactory.java 0 4 0
org/opendaylight/mdsal/common/api/AsyncReadTransaction.java 0 3 0
org/opendaylight/mdsal/common/api/AsyncTransaction.java 0 3 0
org/opendaylight/mdsal/common/api/AsyncWriteTransaction.java 0 26 0
org/opendaylight/mdsal/common/api/DataStoreUnavailableException.java 0 1 0
org/opendaylight/mdsal/common/api/DataValidationFailedException.java 0 6 0
org/opendaylight/mdsal/common/api/LogicalDatastoreType.java 0 3 0
org/opendaylight/mdsal/common/api/OptimisticLockFailedException.java 0 4 0
org/opendaylight/mdsal/common/api/PostCanCommitStep.java 0 6 0
org/opendaylight/mdsal/common/api/PostPreCommitStep.java 0 6 0
org/opendaylight/mdsal/common/api/ReadFailedException.java 0 3 0
org/opendaylight/mdsal/common/api/ThreePhaseCommitStep.java 0 4 0
org/opendaylight/mdsal/common/api/TransactionChain.java 0 7 0
org/opendaylight/mdsal/common/api/TransactionChainClosedException.java 0 1 0
org/opendaylight/mdsal/common/api/TransactionChainFactory.java 0 1 0
org/opendaylight/mdsal/common/api/TransactionChainListener.java 0 1 0
org/opendaylight/mdsal/common/api/TransactionCommitDeadlockException.java 0 3 0
org/opendaylight/mdsal/common/api/TransactionCommitFailedException.java 0 3 0
org/opendaylight/mdsal/common/api/clustering/CandidateAlreadyRegisteredException.java 0 3 0
org/opendaylight/mdsal/common/api/clustering/EntityOwnershipChangeState.java 0 4 0
org/opendaylight/mdsal/common/api/clustering/EntityOwnershipState.java 0 4 0
org/opendaylight/mdsal/common/api/clustering/GenericEntity.java 0 11 0
org/opendaylight/mdsal/common/api/clustering/GenericEntityOwnershipCandidateRegistration.java 0 3 0
org/opendaylight/mdsal/common/api/clustering/GenericEntityOwnershipChange.java 0 2 0
org/opendaylight/mdsal/common/api/clustering/GenericEntityOwnershipListenerRegistration.java 0 5 0
org/opendaylight/mdsal/common/api/clustering/GenericEntityOwnershipService.java 0 3 0

Rules

Category Rule Violations Severity
imports CustomImportOrder
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###STANDARD_JAVA_PACKAGE###THIRD_PARTY_PACKAGE###SPECIAL_IMPORTS"
  • thirdPartyPackageRegExp: ".*"
  • specialImportsRegExp: "^com.*"
 11  Warning
indentation Indentation
  • lineWrappingIndentation: "4"
  • caseIndent: "4"
  • arrayInitIndent: "4"
  • throwsIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
 4  Warning
javadoc JavadocMethod
  • allowMissingParamTags: "true"
  • allowedAnnotations: "Override, Test"
  • allowThrowsTagsForSubclasses: "true"
  • scope: "public"
  • allowMissingReturnTag: "true"
  • minLineCount: "2"
  • allowMissingThrowsTags: "true"
 4  Warning
JavadocParagraph 65  Warning
naming ParameterName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
 1  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 3  Warning
whitespace EmptyLineSeparator
  • allowNoEmptyLineBetweenFields: "true"
 22  Warning
OperatorWrap
  • tokens: "BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "
  • option: "NL"
 2  Warning
WhitespaceAround
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
  • allowEmptyMethods: "true"
  • allowEmptyConstructors: "true"
 4  Warning

Details

org/opendaylight/mdsal/common/api/AsyncDataBroker.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 14
 Warning javadoc SummaryJavadoc First sentence should be present. 52
 Warning javadoc SummaryJavadoc First sentence should be present. 59

org/opendaylight/mdsal/common/api/AsyncDataTransactionFactory.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 45
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 60
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 81

org/opendaylight/mdsal/common/api/AsyncReadTransaction.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 13
 Warning sizes LineLength Line is longer than 120 characters (found 166). 49

org/opendaylight/mdsal/common/api/AsyncTransaction.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 15
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 17

org/opendaylight/mdsal/common/api/AsyncWriteTransaction.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 21
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 26
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 34
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 41
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 51
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 58
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 64
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 70
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 75
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 78
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 91
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 93
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 96
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 119
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 122
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 128
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 135
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 139
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 173
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 191
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 197
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 275
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 442
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 456
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 460

org/opendaylight/mdsal/common/api/DataStoreUnavailableException.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8

org/opendaylight/mdsal/common/api/DataValidationFailedException.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.base.Preconditions' import. 14
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 17
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 19
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 22
 Warning javadoc JavadocMethod Missing a Javadoc comment. 36

org/opendaylight/mdsal/common/api/LogicalDatastoreType.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 15
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 24

org/opendaylight/mdsal/common/api/OptimisticLockFailedException.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yangtools.yang.common.RpcError.ErrorType' import. 12
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 15
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 18
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 22

org/opendaylight/mdsal/common/api/PostCanCommitStep.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 14
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 17
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 19
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 29
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 55

org/opendaylight/mdsal/common/api/PostPreCommitStep.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 15
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 25
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 48
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 50
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 53

org/opendaylight/mdsal/common/api/ReadFailedException.java

Severity Category Rule Message Line
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 16, expected level should be one of the following: 8, 12. 24
 Warning indentation Indentation 'method def' child have incorrect indentation level 20, expected level should be one of the following: 12, 16. 26
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 16, expected level should be one of the following: 8, 12. 27

org/opendaylight/mdsal/common/api/ThreePhaseCommitStep.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 14
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 18
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 30
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 33

org/opendaylight/mdsal/common/api/TransactionChain.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 17
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 32
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 38
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 53
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 76
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 82

org/opendaylight/mdsal/common/api/TransactionChainClosedException.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8

org/opendaylight/mdsal/common/api/TransactionChainFactory.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8

org/opendaylight/mdsal/common/api/TransactionChainListener.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8

org/opendaylight/mdsal/common/api/TransactionCommitDeadlockException.java

Severity Category Rule Message Line
 Warning whitespace OperatorWrap '+' should be on a new line. 28
 Warning whitespace OperatorWrap '+' should be on a new line. 29
 Warning sizes LineLength Line is longer than 120 characters (found 136). 31

org/opendaylight/mdsal/common/api/TransactionCommitFailedException.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 14
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 16

org/opendaylight/mdsal/common/api/clustering/CandidateAlreadyRegisteredException.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 12
 Warning javadoc JavadocMethod Missing a Javadoc comment. 24
 Warning javadoc SummaryJavadoc Forbidden summary fragment. 30

org/opendaylight/mdsal/common/api/clustering/EntityOwnershipChangeState.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 13
 Warning whitespace WhitespaceAround WhitespaceAround: 'for' is not followed by whitespace. 51
 Warning javadoc JavadocMethod Missing a Javadoc comment. 98

org/opendaylight/mdsal/common/api/clustering/EntityOwnershipState.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning javadoc JavadocMethod Missing a Javadoc comment. 31
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 32
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 34

org/opendaylight/mdsal/common/api/clustering/GenericEntity.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 11
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 12
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 19
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 26
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 30
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 33
 Warning javadoc SummaryJavadoc Forbidden summary fragment. 50
 Warning javadoc SummaryJavadoc Forbidden summary fragment. 59
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 63
 Warning naming ParameterName Parameter name 'o' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 69

org/opendaylight/mdsal/common/api/clustering/GenericEntityOwnershipCandidateRegistration.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning javadoc SummaryJavadoc First sentence should be present. 25
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 3, expected level should be 4. 28

org/opendaylight/mdsal/common/api/clustering/GenericEntityOwnershipChange.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 11

org/opendaylight/mdsal/common/api/clustering/GenericEntityOwnershipListenerRegistration.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning imports CustomImportOrder 'org.opendaylight.yangtools.concepts.ObjectRegistration'should be separated from previous import group. 11
 Warning sizes LineLength Line is longer than 120 characters (found 123). 24
 Warning javadoc SummaryJavadoc First sentence should be present. 27
 Warning javadoc SummaryJavadoc First sentence should be present. 32

org/opendaylight/mdsal/common/api/clustering/GenericEntityOwnershipService.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 11
 Warning javadoc JavadocParagraph <p> tag should be precede with empty line. 37