FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is low

Effort is max

Summary

Classes Bugs Errors Missing Classes
51 16 0 0

Files

Class Bugs
org.opendaylight.mdsal.dom.broker.AbstractDOMDataBroker 1
org.opendaylight.mdsal.dom.broker.CommitCoordinationTask 3
org.opendaylight.mdsal.dom.broker.DOMNotificationRouter 2
org.opendaylight.mdsal.dom.broker.DOMNotificationRouter$4 1
org.opendaylight.mdsal.dom.broker.DOMNotificationRouter$5 1
org.opendaylight.mdsal.dom.broker.DOMRpcRouter$1 1
org.opendaylight.mdsal.dom.broker.DOMRpcRouter$5 1
org.opendaylight.mdsal.dom.broker.DOMRpcRouter$7 1
org.opendaylight.mdsal.dom.broker.DOMRpcRoutingTable$1 1
org.opendaylight.mdsal.dom.broker.ShardedDOMDataTreeProducer 1
org.opendaylight.mdsal.dom.broker.osgi.OsgiBundleScanningSchemaService$BundleScanner 1
org.opendaylight.mdsal.dom.broker.osgi.SchemaServiceActivator 2

org.opendaylight.mdsal.dom.broker.AbstractDOMDataBroker

Bug Category Details Line Priority
Class org.opendaylight.mdsal.dom.broker.AbstractDOMDataBroker implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 34 Low

org.opendaylight.mdsal.dom.broker.CommitCoordinationTask

Bug Category Details Line Priority
Unchecked/unconfirmed cast from Exception to org.opendaylight.mdsal.common.api.TransactionCommitFailedException of return value in org.opendaylight.mdsal.dom.broker.CommitCoordinationTask.canCommitBlocking() STYLE BC_UNCONFIRMED_CAST_OF_RETURN_VALUE 101 Low
Unchecked/unconfirmed cast from Exception to org.opendaylight.mdsal.common.api.TransactionCommitFailedException of return value in org.opendaylight.mdsal.dom.broker.CommitCoordinationTask.commitBlocking() STYLE BC_UNCONFIRMED_CAST_OF_RETURN_VALUE 193 Low
Unchecked/unconfirmed cast from Exception to org.opendaylight.mdsal.common.api.TransactionCommitFailedException of return value in org.opendaylight.mdsal.dom.broker.CommitCoordinationTask.preCommitBlocking() STYLE BC_UNCONFIRMED_CAST_OF_RETURN_VALUE 147 Low

org.opendaylight.mdsal.dom.broker.DOMNotificationRouter

Bug Category Details Line Priority
Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in org.opendaylight.mdsal.dom.broker.DOMNotificationRouter.notifyListenerTypesChanged(Set) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 158 Low
Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in org.opendaylight.mdsal.dom.broker.DOMNotificationRouter.registerSubscriptionListener(DOMNotificationSubscriptionListener) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 177 Low

org.opendaylight.mdsal.dom.broker.DOMNotificationRouter$4

Bug Category Details Line Priority
The class org.opendaylight.mdsal.dom.broker.DOMNotificationRouter$4 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 158 Low

org.opendaylight.mdsal.dom.broker.DOMNotificationRouter$5

Bug Category Details Line Priority
The class org.opendaylight.mdsal.dom.broker.DOMNotificationRouter$5 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 177 Low

org.opendaylight.mdsal.dom.broker.DOMRpcRouter$1

Bug Category Details Line Priority
input must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 61 Medium

org.opendaylight.mdsal.dom.broker.DOMRpcRouter$5

Bug Category Details Line Priority
The class org.opendaylight.mdsal.dom.broker.DOMRpcRouter$5 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 129 Low

org.opendaylight.mdsal.dom.broker.DOMRpcRouter$7

Bug Category Details Line Priority
The class org.opendaylight.mdsal.dom.broker.DOMRpcRouter$7 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 152 Low

org.opendaylight.mdsal.dom.broker.DOMRpcRoutingTable$1

Bug Category Details Line Priority
input must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 51 Medium

org.opendaylight.mdsal.dom.broker.ShardedDOMDataTreeProducer

Bug Category Details Line Priority
ShardedDOMDataTreeProducer.children not guarded against concurrent access; locked 80% of time MT_CORRECTNESS IS_FIELD_NOT_GUARDED 173 Medium

org.opendaylight.mdsal.dom.broker.osgi.OsgiBundleScanningSchemaService$BundleScanner

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in org.opendaylight.mdsal.dom.broker.osgi.OsgiBundleScanningSchemaService$BundleScanner.addingBundle(Bundle, BundleEvent) STYLE REC_CATCH_EXCEPTION 205 Low

org.opendaylight.mdsal.dom.broker.osgi.SchemaServiceActivator

Bug Category Details Line Priority
SchemaServiceActivator.schemaService not initialized in constructor and dereferenced in org.opendaylight.mdsal.dom.broker.osgi.SchemaServiceActivator.stop(BundleContext) STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR 31 Low
SchemaServiceActivator.schemaServiceReg not initialized in constructor and dereferenced in org.opendaylight.mdsal.dom.broker.osgi.SchemaServiceActivator.stop(BundleContext) STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR 30 Low