The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset.
Category | Rule | Violations | Severity |
---|---|---|---|
imports | CustomImportOrder
|
11 | ![]() |
UnusedImports | 2 | ![]() | |
javadoc | JavadocParagraph
|
60 | ![]() |
JavadocStyle
|
4 | ![]() | |
NonEmptyAtclauseDescription | 4 | ![]() | |
modifier | RedundantModifier | 1 | ![]() |
naming | LocalVariableName
|
1 | ![]() |
MethodName
|
8 | ![]() | |
MethodName
|
8 | ![]() | |
ParameterName
|
1 | ![]() | |
sizes | LineLength
|
28 | ![]() |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
imports | UnusedImports | Unused import - org.opendaylight.mdsal.dom.api.DOMDataTreeCursor. | 15 |
![]() |
imports | UnusedImports | Unused import - org.opendaylight.mdsal.dom.api.DOMDataTreeWriteTransaction. | 22 |
![]() |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.CheckedFuture' import. Should be before 'org.opendaylight.mdsal.dom.api.DOMDataTreeWriteTransaction'. | 23 |
![]() |
imports | CustomImportOrder | Wrong lexicographical order for 'java.net.URI' import. Should be before 'org.opendaylight.mdsal.dom.api.DOMDataTreeWriteTransaction'. | 24 |
![]() |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.Collections' import. Should be before 'org.opendaylight.mdsal.dom.api.DOMDataTreeWriteTransaction'. | 25 |
![]() |
imports | CustomImportOrder | Wrong lexicographical order for 'javax.annotation.Nonnull' import. Should be before 'org.opendaylight.mdsal.dom.api.DOMDataTreeWriteTransaction'. | 26 |
![]() |
imports | CustomImportOrder | Wrong lexicographical order for 'org.junit.Test' import. Should be before 'org.opendaylight.mdsal.dom.api.DOMDataTreeWriteTransaction'. | 27 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 158). | 39 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 161). | 44 |
![]() |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 58 |
![]() |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 59 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 122). | 65 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 152). | 71 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 21 |
![]() |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 31 |
![]() |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 37 |
![]() |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 43 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 34 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 21 |
![]() |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 24 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 25 |
![]() |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 28 |
![]() |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 36 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 166). | 47 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 18 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 27 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 36 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 41 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 47 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 61 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 65 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 68 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 80 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 84 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 86 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 89 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 93 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 12 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 14 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 36 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 38 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 41 |
![]() |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 54 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 57 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 62 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.MoreObjects' import. Should be before 'org.opendaylight.mdsal.common.api.LogicalDatastoreType'. | 13 |
![]() |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Preconditions' import. Should be before 'org.opendaylight.mdsal.common.api.LogicalDatastoreType'. | 14 |
![]() |
imports | CustomImportOrder | Wrong lexicographical order for 'java.io.Serializable' import. Should be before 'org.opendaylight.mdsal.common.api.LogicalDatastoreType'. | 15 |
![]() |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.Iterator' import. Should be before 'org.opendaylight.mdsal.common.api.LogicalDatastoreType'. | 16 |
![]() |
imports | CustomImportOrder | Wrong lexicographical order for 'javax.annotation.Nonnull' import. Should be before 'org.opendaylight.mdsal.common.api.LogicalDatastoreType'. | 17 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 121). | 34 |
![]() |
naming | ParameterName | Parameter name 'o' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 92 |
![]() |
naming | LocalVariableName | Local variable name 'i' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 93 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 120 characters (found 123). | 36 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 124). | 65 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 123). | 79 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 120 characters (found 134). | 25 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 120 characters (found 143). | 32 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 18 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 22 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 26 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 32 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 164). | 33 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 61 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 65 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 70 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 30 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 31 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 20 |
![]() |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 27 |
![]() |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 52 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 53 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 18 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 22 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 37 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 43 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 18 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 23 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 152). | 38 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 18 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 122). | 21 |
![]() |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 26 |
![]() |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 28 |
![]() |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 47 |
![]() |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 49 |
![]() |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 63 |
![]() |
modifier | RedundantModifier | Redundant 'public' modifier. | 67 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 13 |
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 13 |
![]() |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 18 |
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 18 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
naming | MethodName | Method name 'DOMDataTreeInaccessibleExceptionTest' must match pattern '^[a-z][a-zA-Z0-9_]*$'. | 32 |
![]() |
naming | MethodName | Method name 'DOMDataTreeListeningExceptionTest' must match pattern '^[a-z][a-zA-Z0-9_]*$'. | 42 |
![]() |
naming | MethodName | Method name 'DOMDataTreeLoopExceptionTest' must match pattern '^[a-z][a-zA-Z0-9_]*$'. | 50 |
![]() |
naming | MethodName | Method name 'DOMDataTreeProducerBusyExceptionTest' must match pattern '^[a-z][a-zA-Z0-9_]*$'. | 58 |
![]() |
naming | MethodName | Method name 'DOMDataTreeProducerExceptionTest' must match pattern '^[a-z][a-zA-Z0-9_]*$'. | 66 |
![]() |
naming | MethodName | Method name 'DOMDataTreeShardingConflictExceptionTest' must match pattern '^[a-z][a-zA-Z0-9_]*$'. | 74 |
![]() |
naming | MethodName | Method name 'DOMNotificationRejectedExceptionTest' must match pattern '^[a-z][a-zA-Z0-9_]*$'. | 82 |
![]() |
naming | MethodName | Method name 'DOMRpcImplementationNotAvailableExceptionTest' must match pattern '^[a-z][a-zA-Z0-9_]*$'. | 90 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 126). | 91 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 120 characters (found 133). | 22 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier'. | 14 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 120 characters (found 156). | 31 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 38 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 41 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 44 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 47 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 52 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 56 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 131). | 67 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 120 characters (found 153). | 34 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 135). | 51 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 120 characters (found 133). | 28 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 141). | 78 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 141). | 128 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 120 characters (found 137). | 30 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 120 characters (found 138). | 23 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 120 characters (found 170). | 28 |
![]() |
sizes | LineLength | Line is longer than 120 characters (found 172). | 39 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
sizes | LineLength | Line is longer than 120 characters (found 132). | 34 |
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 40 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 17 |
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 17 |
![]() |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 19 |
![]() |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 23 |
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 23 |
![]() |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 26 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 17 |