Checkstyle Results
The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. 
InfoFiles
Rules
| Category | Rule | Violations | Severity |
|---|---|---|---|
| coding | IllegalCatch | 1 |  Warning |
| MultipleVariableDeclarations | 6 | Warning | |
| VariableDeclarationUsageDistance | 7 | Warning | |
| imports | AvoidStarImport | 12 | Warning |
CustomImportOrder
|
136 | Warning | |
| RedundantImport | 1 | Warning | |
| UnusedImports | 45 | Warning | |
| indentation | Indentation
|
144 | Warning |
| javadoc | JavadocStyle
|
16 | Warning |
| NonEmptyAtclauseDescription | 6 | Warning | |
| regexp | RegexpSingleline
|
18 |  Error |
| sizes | LineLength
|
11 | Warning |
| whitespace | EmptyLineSeparator
|
12 | Warning |
FileTabCharacter
|
210 | Error | |
| GenericWhitespace | 1 | Warning | |
| MethodParamPad | 1 | Warning | |
WhitespaceAround
|
4 | Warning |
Details
org/opendaylight/natapp/impl/NatFlow.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Uri'. | 12 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Uri'. | 13 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataBroker' import. Should be before 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Uri'. | 15 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.WriteTransaction' import. Should be before 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Uri'. | 16 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. Should be before 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Uri'. | 17 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Ipv4Prefix' import. Should be before 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Uri'. | 18 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.DropActionCaseBuilder. | 19 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.drop.action._case.DropAction. | 23 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.drop.action._case.DropActionBuilder. | 24 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.EthernetMatchBuilder'. | 49 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.EthernetMatchBuilder'. | 50 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.EthernetMatchBuilder'. | 51 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.EthernetMatchBuilder'. | 52 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.EthernetMatchBuilder'. | 53 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.collect.Lists' import. Should be before 'org.slf4j.LoggerFactory'. | 60 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 64 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 64 |
| Warning |
whitespace | EmptyLineSeparator | ',' should be separated from previous statement. | 66 |
| Warning |
coding | MultipleVariableDeclarations | Each variable declaration must be in its own statement. | 66 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 76 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 76 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 77 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 78 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 81 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 81 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 84 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'matchBuilderSrc' declaration and its first usage is 9, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 85 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'matchBuilderDst' declaration and its first usage is 10, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 87 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 125). | 93 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 119 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 136 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'isbDst' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 142 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 154 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 165 |
org/opendaylight/natapp/impl/NatFlowHandler.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.slf4j.LoggerFactory'. | 44 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 125 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not followed by whitespace. | 125 |
org/opendaylight/natapp/impl/NatFlowTest.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - java.util.concurrent.ExecutionException. | 10 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'java.util.concurrent.ExecutionException'. | 11 |
| Warning |
imports | UnusedImports | Unused import - com.google.common.base.Optional. | 11 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.CheckedFuture' import. Should be before 'java.util.concurrent.ExecutionException'. | 12 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.Futures' import. Should be before 'java.util.concurrent.ExecutionException'. | 13 |
| Warning |
imports | UnusedImports | Unused import - com.google.common.util.concurrent.Futures. | 13 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.junit.Before' import. Should be before 'org.junit.Test'. | 15 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yangtools.yang.binding.DataObject' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier'. | 23 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Mockito.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 26 |
| Warning |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.mockito.Mockito.*. | 26 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.junit.Assert.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 27 |
| Warning |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.junit.Assert.*. | 27 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 30 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 30 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 31 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 32 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 32 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 33 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 34 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 34 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 35 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 36 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 36 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 38 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 38 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 39 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 40 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 40 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 41 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 41 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 42 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 42 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 43 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 43 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 44 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 44 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 45 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 45 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 47 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 47 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 48 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 49 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 49 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 50 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 50 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 51 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 51 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 52 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 52 |
| Warning |
coding | MultipleVariableDeclarations | Each variable declaration must be in its own statement. | 52 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 53 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 53 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 54 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 157). | 54 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 54 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 55 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 55 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 56 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 56 |
org/opendaylight/natapp/impl/NatInventoryUtilityTest.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - org.mockito.Mock. | 10 |
| Warning |
whitespace | EmptyLineSeparator | 'import' should be separated from previous statement. | 11 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.junit.Assert.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 11 |
| Warning |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.junit.Assert.*. | 11 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.junit.Test' import. Should be before 'org.mockito.Mock'. | 12 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.junit.Before' import. Should be before 'org.mockito.Mock'. | 13 |
| Warning |
imports | UnusedImports | Unused import - org.mockito.MockitoAnnotations. | 14 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 26 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 26 |
| Warning |
indentation | Indentation | 'member def type' have incorrect indentation level 8, expected level should be 4. | 27 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 27 |
| Warning |
indentation | Indentation | 'member def type' have incorrect indentation level 8, expected level should be 4. | 28 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 28 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 29 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 29 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 30 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 30 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 31 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 31 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 32 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 32 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 33 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 33 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 34 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 35 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 35 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 12, expected level should be 8. | 36 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 36 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 37 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 38 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 12, expected level should be 8. | 39 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 39 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 40 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 40 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 41 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 41 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 42 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 42 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 43 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 44 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 44 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 45 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 45 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 46 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 46 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 47 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 47 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 48 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 49 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 49 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 50 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 50 |
org/opendaylight/natapp/impl/NatPacketHandler.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.io.IOException' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 13 |
| Warning |
imports | UnusedImports | Unused import - java.io.IOException. | 13 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.io.StringReader' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 14 |
| Warning |
imports | UnusedImports | Unused import - java.io.StringReader. | 14 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.concurrent.Future' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 15 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataBroker' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 16 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 17 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorRef' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 18 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 19 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeRef' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 20 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 21 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.node.NodeConnector' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 22 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.node.NodeConnectorKey' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 23 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 24 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 25 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketProcessingListener' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 26 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketProcessingService' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 27 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketReceived' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 28 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.TransmitPacketInput' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 29 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.TransmitPacketInputBuilder' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 30 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.NatappService' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 31 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.NatTypeInput' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 32 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.nat.type.input.NatType' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 33 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.nat.type.input.nat.type.Dynamic' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 34 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.nat.type.input.nat.type.Pat' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 35 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.nat.type.input.nat.type.Static' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 36 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 37 |
| Warning |
whitespace | EmptyLineSeparator | ',' should be separated from previous statement. | 51 |
| Warning |
coding | MultipleVariableDeclarations | Each variable declaration must be in its own statement. | 51 |
| Warning |
whitespace | EmptyLineSeparator | ',' should be separated from previous statement. | 52 |
| Warning |
coding | MultipleVariableDeclarations | Each variable declaration must be in its own statement. | 52 |
| Warning |
whitespace | EmptyLineSeparator | ',' should be separated from previous statement. | 56 |
| Warning |
coding | MultipleVariableDeclarations | Each variable declaration must be in its own statement. | 56 |
| Warning |
whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 72 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 96 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 97 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 106 |
org/opendaylight/natapp/impl/NatPacketHandlerTest.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.lang.InterruptedException' import. Should be before 'java.util.concurrent.Future'. | 12 |
| Warning |
imports | RedundantImport | Redundant import from the java.lang package - java.lang.InterruptedException. | 12 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes'. | 15 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorRef' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes'. | 16 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes'. | 17 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeRef' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes'. | 18 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeRef. | 18 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketProcessingListener. | 23 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketReceived. | 25 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.PacketReceivedBuilder. | 26 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.TransmitPacketInput. | 27 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.packet.service.rev130709.TransmitPacketInputBuilder. | 28 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.NatTypeInput' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.nat.type.input.NatType'. | 30 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.NatTypeInput. | 30 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.NatTypeInputBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.nat.type.input.NatType'. | 31 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier.PathArgument' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 37 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yangtools.yang.binding.InstanceIdentifier.PathArgument. | 37 |
| Warning |
whitespace | EmptyLineSeparator | 'import' should be separated from previous statement. | 38 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.junit.Assert.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 38 |
| Warning |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.junit.Assert.*. | 38 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.junit.Test' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 39 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.junit.Before' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 40 |
| Warning |
whitespace | EmptyLineSeparator | 'import' should be separated from previous statement. | 41 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Matchers.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 41 |
| Warning |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.mockito.Matchers.*. | 41 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.mockito.Mock' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 42 |
| Warning |
whitespace | EmptyLineSeparator | 'import' should be separated from previous statement. | 43 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Mockito.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 43 |
| Warning |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.mockito.Mockito.*. | 43 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.junit.runner.RunWith' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 44 |
| Warning |
imports | UnusedImports | Unused import - org.junit.runner.RunWith. | 44 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.mockito.MockitoAnnotations' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResult'. | 45 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 49 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 49 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 51 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 51 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 52 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 53 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 53 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 54 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 55 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 55 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 56 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 57 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 57 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 58 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 59 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 59 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 60 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 61 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 61 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 62 |
| Warning |
indentation | Indentation | 'member def type' have incorrect indentation level 8, expected level should be 4. | 64 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 64 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 65 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 66 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 68 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 68 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 69 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 69 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 71 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 71 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 72 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 73 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 73 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 74 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 74 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 75 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 75 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 76 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 76 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 77 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 77 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 78 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 78 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 79 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 79 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 80 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 80 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 81 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 81 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 82 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 82 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 83 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 83 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 84 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 84 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 85 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 85 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 86 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 86 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 87 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 87 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 88 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 88 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 90 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 91 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 93 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 94 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 95 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 96 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 97 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 99 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 100 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 101 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 102 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 103 |
org/opendaylight/natapp/impl/NatPacketParsing.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.MacAddress. | 11 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 18 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 18 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 18 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 21 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 21 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 22 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 22 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 24 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 24 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 29 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 29 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 34 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 34 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 39 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 39 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 43 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 44 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 44 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 47 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 50 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 50 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 55 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 55 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 60 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 60 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 65 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 65 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 69 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 72 |
| Warning |
javadoc | JavadocStyle | Javadoc has empty description section. | 72 |
| Warning |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 73 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 80 |
| Warning |
javadoc | JavadocStyle | Javadoc has empty description section. | 80 |
| Warning |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 81 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 88 |
| Warning |
javadoc | JavadocStyle | Javadoc has empty description section. | 88 |
| Warning |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 89 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 96 |
| Warning |
javadoc | JavadocStyle | Javadoc has empty description section. | 96 |
| Warning |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 97 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 104 |
| Warning |
javadoc | JavadocStyle | Javadoc has empty description section. | 104 |
| Warning |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 105 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 119 |
| Warning |
javadoc | JavadocStyle | Javadoc has empty description section. | 119 |
| Warning |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 120 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '=' is not followed by whitespace. | 124 |
org/opendaylight/natapp/impl/NatYangStore.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - java.util.ArrayList. | 12 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.HashMap' import. Should be before 'java.util.Map'. | 15 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction' import. Should be before 'org.opendaylight.controller.md.sal.binding.api.WriteTransaction'. | 18 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.DynamicNat' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.StaticNat'. | 22 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.PatNat' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.StaticNat'. | 23 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.PatMap' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.StaticNat'. | 24 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.StaticMap' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.StaticNat'. | 25 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.DynamicMap' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.StaticNat'. | 26 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.dynamicmap.DynamicMappingInfo' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.staticmap.StaticMappingInfoBuilder'. | 29 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.dynamicmap.DynamicMappingInfoBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.staticmap.StaticMappingInfoBuilder'. | 30 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.patmap.PatMappingInfo' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.staticmap.StaticMappingInfoBuilder'. | 31 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.patmap.PatMappingInfoBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.staticmap.StaticMappingInfoBuilder'. | 32 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 61 |
org/opendaylight/natapp/impl/NatYangStoreTest.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'java.util.concurrent.ExecutionException'. | 13 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.CheckedFuture' import. Should be before 'java.util.concurrent.ExecutionException'. | 14 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.Futures' import. Should be before 'java.util.concurrent.ExecutionException'. | 15 |
| Warning |
imports | UnusedImports | Unused import - com.google.common.util.concurrent.Futures. | 15 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.junit.Before' import. Should be before 'org.junit.Test'. | 17 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction' import. Should be before 'org.opendaylight.controller.md.sal.binding.api.WriteTransaction'. | 21 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException. | 23 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.ReadFailedException' import. Should be before 'org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException'. | 24 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.controller.md.sal.common.api.data.ReadFailedException. | 24 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.DynamicNat' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.staticmap.StaticMappingInfo'. | 28 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.DynamicNatBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.staticmap.StaticMappingInfo'. | 29 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.dynamicmap.DynamicMappingInfo' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.natapp.rev160125.staticmap.StaticMappingInfo'. | 30 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yangtools.yang.binding.DataObject. | 32 |
| Warning |
imports | UnusedImports | Unused import - org.slf4j.Logger. | 34 |
| Warning |
imports | UnusedImports | Unused import - org.slf4j.LoggerFactory. | 35 |
| Warning |
whitespace | EmptyLineSeparator | 'import' should be separated from previous statement. | 36 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Mockito.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 36 |
| Warning |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.mockito.Mockito.*. | 36 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.junit.Assert.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 37 |
| Warning |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.junit.Assert.*. | 37 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 41 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 41 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 42 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 43 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 43 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 44 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 45 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 45 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 46 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 47 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 47 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 49 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 49 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 50 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 51 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 51 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 52 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 52 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 54 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 54 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 55 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 55 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 56 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 56 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 57 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 58 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 58 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 59 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 59 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 61 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 61 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 62 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 64 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 64 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 65 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 65 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 66 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 66 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 67 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 67 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 68 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 68 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 69 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 69 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 70 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 70 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 72 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 72 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 73 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 73 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 74 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 74 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 75 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 76 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 76 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 77 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 77 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 78 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 78 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 80 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 80 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 81 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 82 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 82 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 83 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 83 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 84 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 84 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 85 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 85 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 86 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 86 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 87 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 87 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 88 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 88 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 90 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 90 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 92 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 92 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 93 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 93 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 94 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 95 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 95 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 96 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 96 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 97 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 97 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 99 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 99 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 100 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 101 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 101 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 102 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 102 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 102 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 103 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 103 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 104 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 104 |
org/opendaylight/natapp/impl/NatappProvider.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataBroker' import. Should be before 'org.opendaylight.controller.sal.binding.api.BindingAwareProvider'. | 12 |
| Warning |
whitespace | EmptyLineSeparator | 'METHOD_DEF' should be separated from previous statement. | 24 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 37 |
org/opendaylight/natapp/impl/NatappProviderTest.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.junit.Before' import. Should be before 'org.junit.Test'. | 11 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.controller.sal.binding.api.BindingAwareBroker. | 12 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataBroker' import. Should be before 'org.opendaylight.controller.sal.binding.api.BindingAwareBroker'. | 13 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yangtools.yang.binding.NotificationListener. | 15 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.sal.binding.api.BindingAwareBroker.ProviderContext' import. Should be before 'org.opendaylight.yangtools.yang.binding.NotificationListener'. | 16 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yangtools.concepts.ListenerRegistration' import. Should be before 'org.opendaylight.yangtools.yang.binding.NotificationListener'. | 17 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yangtools.concepts.ListenerRegistration. | 17 |
| Warning |
whitespace | EmptyLineSeparator | 'import' should be separated from previous statement. | 18 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Matchers.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 18 |
| Warning |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.mockito.Matchers.*. | 18 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Mockito.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 19 |
| Warning |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.mockito.Mockito.*. | 19 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.mockito.Mock' import. Should be before 'org.opendaylight.yangtools.yang.binding.NotificationListener'. | 21 |
| Warning |
imports | UnusedImports | Unused import - org.mockito.Mock. | 21 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.mockito.Mockito' import. Should be before 'org.opendaylight.yangtools.yang.binding.NotificationListener'. | 22 |
| Warning |
imports | UnusedImports | Unused import - org.mockito.Mockito. | 22 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.mockito.MockitoAnnotations' import. Should be before 'org.opendaylight.yangtools.yang.binding.NotificationListener'. | 23 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 27 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 27 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 28 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 29 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 29 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 31 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 31 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 32 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 33 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 33 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 34 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 34 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 35 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 35 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 37 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 37 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 38 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 39 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 39 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 40 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 40 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 41 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 41 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 43 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 43 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 44 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 44 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 45 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 45 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 47 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 47 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 49 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 49 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 50 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 52 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 52 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 53 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 53 |
org/opendaylight/natapp/impl/PatFlow.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'java.util.List'. | 12 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.DropActionCaseBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action'. | 17 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.DropActionCaseBuilder. | 17 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.OutputActionCaseBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action'. | 18 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.output.action._case.OutputActionBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action'. | 19 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.ActionKey. | 21 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorRef. | 25 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.node.NodeConnector. | 28 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.node.NodeConnectorKey. | 29 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.tables.Table' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey'. | 32 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.tables.TableKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey'. | 33 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.tables.table.Flow' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey'. | 34 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.tables.table.FlowBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey'. | 35 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.tables.table.FlowKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey'. | 36 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder. | 42 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.IpMatch' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 43 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.IpMatchBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 44 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.flow.MatchBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 45 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.FlowModFlags' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 46 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.FlowModFlags. | 46 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instruction.instruction.ApplyActionsCaseBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 47 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instruction.instruction.apply.actions._case.ApplyActionsBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 48 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instruction.list.Instruction' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 49 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instruction.list.InstructionBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 50 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instruction.list.InstructionKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 51 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.instruction.list.InstructionKey. | 51 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.flow.types.rev131026.flow.InstructionsBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 52 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.address.address.Ipv4Builder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 53 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Ipv4Prefix' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 54 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.SetNwSrcActionCaseBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 55 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.drop.action._case.DropAction' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 56 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.drop.action._case.DropAction. | 56 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.drop.action._case.DropActionBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 57 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.drop.action._case.DropActionBuilder. | 57 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.set.nw.src.action._case.SetNwSrcActionBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 58 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.SetNwDstActionCaseBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 59 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.set.nw.dst.action._case.SetNwDstActionBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 60 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.SetTpDstActionCaseBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 61 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.set.tp.dst.action._case.SetTpDstActionBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 62 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.SetTpSrcActionCaseBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 63 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.action.set.tp.src.action._case.SetTpSrcActionBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._3.match.Ipv4MatchBuilder'. | 64 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.PortNumber' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._4.match.TcpMatchBuilder'. | 66 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Uri' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.model.match.types.rev131026.match.layer._4.match.TcpMatchBuilder'. | 67 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 85 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 85 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'inport' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 86 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 86 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 87 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'matchBuilderSrc' declaration and its first usage is 11, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 101 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'matchBuilderDst' declaration and its first usage is 12, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 104 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 125). | 119 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 124 |
| Warning |
whitespace | MethodParamPad | '(' is preceded with whitespace. | 124 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 125). | 144 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'isb2' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 167 |
org/opendaylight/natapp/impl/PatFlowTest.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - java.util.concurrent.ExecutionException. | 10 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'java.util.concurrent.ExecutionException'. | 11 |
| Warning |
imports | UnusedImports | Unused import - com.google.common.base.Optional. | 11 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.CheckedFuture' import. Should be before 'java.util.concurrent.ExecutionException'. | 12 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.Futures' import. Should be before 'java.util.concurrent.ExecutionException'. | 13 |
| Warning |
imports | UnusedImports | Unused import - com.google.common.util.concurrent.Futures. | 13 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.junit.Before' import. Should be before 'org.junit.Test'. | 15 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yangtools.yang.binding.DataObject' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier'. | 23 |
| Warning |
whitespace | EmptyLineSeparator | 'import' should be separated from previous statement. | 24 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Mockito.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 24 |
| Warning |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.mockito.Mockito.*. | 24 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.junit.Assert.*' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 25 |
| Warning |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.junit.Assert.*. | 25 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 28 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 28 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 29 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 30 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 30 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 31 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 32 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 32 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 33 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 34 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 34 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 36 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 36 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 37 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 38 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 38 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 39 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 39 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 40 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 40 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 41 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 41 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 42 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 42 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 43 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 43 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 8, expected level should be 4. | 45 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 45 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 46 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 47 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 47 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 48 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 48 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 49 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 49 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 50 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 50 |
| Warning |
coding | MultipleVariableDeclarations | Each variable declaration must be in its own statement. | 50 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 51 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 51 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 52 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 157). | 52 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 52 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 16, expected level should be 8. | 53 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 53 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 8, expected level should be 4. | 54 |
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 54 |