FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is low

Effort is max

Summary

Classes Bugs Errors Missing Classes
71 37 0 0

Files

Class Bugs
org.opendaylight.netvirt.openstack.netvirt.providers.ConfigActivator$1 1
org.opendaylight.netvirt.openstack.netvirt.providers.ConfigActivator$2 1
org.opendaylight.netvirt.openstack.netvirt.providers.ConfigActivator$3 1
org.opendaylight.netvirt.openstack.netvirt.providers.NetvirtProvidersConfigImpl 1
org.opendaylight.netvirt.openstack.netvirt.providers.NetvirtProvidersProvider 3
org.opendaylight.netvirt.openstack.netvirt.providers.NetvirtProvidersProvider$ProviderEntityListener 1
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.OF13Provider 6
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.PipelineOrchestratorImpl 1
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.Service 1
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.EgressAclService 5
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.IngressAclService 6
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.L2ForwardingService 2
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.LoadBalancerService 1
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.arp.Arp$1 1
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.arp.GatewayMacResolverService$3 1
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.arp.GatewayMacResolverService$5 1
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.config.rev160109.NetvirtProvidersConfigBuilder$NetvirtProvidersConfigImpl 1
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.impl.rev150513.modules.module.configuration.NetvirtprovidersImplBuilder$NetvirtprovidersImplImpl 1
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.impl.rev150513.modules.module.configuration.netvirtproviders.impl.BrokerBuilder$BrokerImpl 1
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.impl.rev150513.modules.module.configuration.netvirtproviders.impl.ClusteringEntityOwnershipServiceBuilder$ClusteringEntityOwnershipServiceImpl 1

org.opendaylight.netvirt.openstack.netvirt.providers.ConfigActivator$1

Bug Category Details Line Priority
The class org.opendaylight.netvirt.openstack.netvirt.providers.ConfigActivator$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 169 Low

org.opendaylight.netvirt.openstack.netvirt.providers.ConfigActivator$2

Bug Category Details Line Priority
The class org.opendaylight.netvirt.openstack.netvirt.providers.ConfigActivator$2 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 185 Low

org.opendaylight.netvirt.openstack.netvirt.providers.ConfigActivator$3

Bug Category Details Line Priority
The class org.opendaylight.netvirt.openstack.netvirt.providers.ConfigActivator$3 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 201 Low

org.opendaylight.netvirt.openstack.netvirt.providers.NetvirtProvidersConfigImpl

Bug Category Details Line Priority
Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in org.opendaylight.netvirt.openstack.netvirt.providers.NetvirtProvidersConfigImpl.onDataChanged(AsyncDataChangeEvent) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 73 Low

org.opendaylight.netvirt.openstack.netvirt.providers.NetvirtProvidersProvider

Bug Category Details Line Priority
Write to static field org.opendaylight.netvirt.openstack.netvirt.providers.NetvirtProvidersProvider.dataBroker from instance method org.opendaylight.netvirt.openstack.netvirt.providers.NetvirtProvidersProvider.onSessionInitiated(BindingAwareBroker$ProviderContext) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 92 High
Write to static field org.opendaylight.netvirt.openstack.netvirt.providers.NetvirtProvidersProvider.providerContext from instance method org.opendaylight.netvirt.openstack.netvirt.providers.NetvirtProvidersProvider.onSessionInitiated(BindingAwareBroker$ProviderContext) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 93 High
Write to static field org.opendaylight.netvirt.openstack.netvirt.providers.NetvirtProvidersProvider.entityOwnershipService from instance method new org.opendaylight.netvirt.openstack.netvirt.providers.NetvirtProvidersProvider(BundleContext, EntityOwnershipService, short) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 50 Medium

org.opendaylight.netvirt.openstack.netvirt.providers.NetvirtProvidersProvider$ProviderEntityListener

Bug Category Details Line Priority
Should org.opendaylight.netvirt.openstack.netvirt.providers.NetvirtProvidersProvider$ProviderEntityListener be a _static_ inner class? PERFORMANCE SIC_INNER_SHOULD_BE_STATIC 120 Medium

org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.OF13Provider

Bug Category Details Line Priority
Dead store to opAction in org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.OF13Provider.createOutputGroupInstructions(NodeBuilder, InstructionBuilder, Long, Long, List) STYLE DLS_DEAD_LOCAL_STORE 1827 Medium
Write to static field org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.OF13Provider.groupId from instance method org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.OF13Provider.createOutputGroupInstructions(NodeBuilder, InstructionBuilder, Long, Long, List) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 1827 Low
Private method org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.OF13Provider.getTunnelReadinessStatus(Node, String) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 163 Low
Private method org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.OF13Provider.handleLocalVlanTableMiss(Long, Short, String, boolean) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 1607 Low
Private method org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.OF13Provider.handleVlanFloodOut(Long, Short, Short, String, Long, Long, boolean) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 1503 Low
Private method org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.OF13Provider.handleVlanOut(Long, Short, Short, String, Long, String, boolean) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 1473 Low

org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.PipelineOrchestratorImpl

Bug Category Details Line Priority
Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.PipelineOrchestratorImpl.start() BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 138 Low

org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.Service

Bug Category Details Line Priority
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.Service.insertComparator isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 47 High

org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.EgressAclService

Bug Category Details Line Priority
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.EgressAclService.egressOtherProtocolAclHandler(Long, String, String, NeutronSecurityRule, String, boolean, Integer) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead PERFORMANCE DM_NUMBER_CTOR 206 Medium
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.EgressAclService.egressAclTcp(Long, String, String, NeutronSecurityRule, String, boolean, Integer) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 457 Medium
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.EgressAclService.egressAclUdp(Long, String, String, NeutronSecurityRule, String, boolean, Integer) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 660 Medium
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.EgressAclService.egressAclTcp(Long, String, String, NeutronSecurityRule, String, boolean, Integer) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 456 Medium
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.EgressAclService.egressAclUdp(Long, String, String, NeutronSecurityRule, String, boolean, Integer) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 659 Medium

org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.IngressAclService

Bug Category Details Line Priority
Dead store to nodeName in org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.IngressAclService.programIngressAclFixedConntrackRule(Long, String, String, long, boolean) STYLE DLS_DEAD_LOCAL_STORE 246 Low
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.IngressAclService.ingressOtherProtocolAclHandler(Long, String, String, NeutronSecurityRule, String, boolean, Integer) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead PERFORMANCE DM_NUMBER_CTOR 192 Medium
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.IngressAclService.ingressAclTcp(Long, String, String, NeutronSecurityRule, String, boolean, Integer) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 423 Medium
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.IngressAclService.ingressAclUdp(Long, String, String, NeutronSecurityRule, String, boolean, Integer) concatenates strings using + in a loop PERFORMANCE SBSC_USE_STRINGBUFFER_CONCATENATION 511 Medium
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.IngressAclService.ingressAclTcp(Long, String, String, NeutronSecurityRule, String, boolean, Integer) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 422 Medium
org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.IngressAclService.ingressAclUdp(Long, String, String, NeutronSecurityRule, String, boolean, Integer) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 510 Medium

org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.L2ForwardingService

Bug Category Details Line Priority
Dead store to flow in org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.L2ForwardingService.programVlanFloodOut(Long, String, Long, boolean) STYLE DLS_DEAD_LOCAL_STORE 685 Medium
Useless object stored in variable isb of method org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.L2ForwardingService.removeOutputPortFromInstructions(InstructionBuilder, Long, Long, Long, List) STYLE UC_USELESS_OBJECT 391 Medium

org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.LoadBalancerService

Bug Category Details Line Priority
LoadBalancerService.southbound not initialized in constructor and dereferenced in org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.LoadBalancerService.getDpid(Node) STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR 82 Low

org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.arp.Arp$1

Bug Category Details Line Priority
The class org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.arp.Arp$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 45 Low

org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.arp.GatewayMacResolverService$3

Bug Category Details Line Priority
result must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 335 Low

org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.arp.GatewayMacResolverService$5

Bug Category Details Line Priority
The class org.opendaylight.netvirt.openstack.netvirt.providers.openflow13.services.arp.GatewayMacResolverService$5 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 432 Low

org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.config.rev160109.NetvirtProvidersConfigBuilder$NetvirtProvidersConfigImpl

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.config.rev160109.NetvirtProvidersConfigBuilder$NetvirtProvidersConfigImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.config.rev160109.NetvirtProvidersConfigBuilder$NetvirtProvidersConfigImpl.equals(Object) STYLE BC_UNCONFIRMED_CAST 171 Low

org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.impl.rev150513.modules.module.configuration.NetvirtprovidersImplBuilder$NetvirtprovidersImplImpl

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.impl.rev150513.modules.module.configuration.NetvirtprovidersImplBuilder$NetvirtprovidersImplImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.impl.rev150513.modules.module.configuration.NetvirtprovidersImplBuilder$NetvirtprovidersImplImpl.equals(Object) STYLE BC_UNCONFIRMED_CAST 219 Low

org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.impl.rev150513.modules.module.configuration.netvirtproviders.impl.BrokerBuilder$BrokerImpl

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.impl.rev150513.modules.module.configuration.netvirtproviders.impl.BrokerBuilder$BrokerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.impl.rev150513.modules.module.configuration.netvirtproviders.impl.BrokerBuilder$BrokerImpl.equals(Object) STYLE BC_UNCONFIRMED_CAST 211 Low

org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.impl.rev150513.modules.module.configuration.netvirtproviders.impl.ClusteringEntityOwnershipServiceBuilder$ClusteringEntityOwnershipServiceImpl

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.impl.rev150513.modules.module.configuration.netvirtproviders.impl.ClusteringEntityOwnershipServiceBuilder$ClusteringEntityOwnershipServiceImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.providers.impl.rev150513.modules.module.configuration.netvirtproviders.impl.ClusteringEntityOwnershipServiceBuilder$ClusteringEntityOwnershipServiceImpl.equals(Object) STYLE BC_UNCONFIRMED_CAST 211 Low