Checkstyle Results

The following document contains the results of Checkstyle 6.2 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
23 0 138 0

Files

File  I  W  E
org/opendaylight/netvirt/openstack/netvirt/sfc/DelegatingDataTreeListener.java 0 2 0
org/opendaylight/netvirt/openstack/netvirt/sfc/INetvirtSfcOF13Provider.java 0 9 0
org/opendaylight/netvirt/openstack/netvirt/sfc/NetvirtSfcClassifierDataProcessor.java 0 1 0
org/opendaylight/netvirt/openstack/netvirt/sfc/NetvirtSfcProvider.java 0 3 0
org/opendaylight/netvirt/openstack/netvirt/sfc/RspDataProcessor.java 0 2 0
org/opendaylight/netvirt/openstack/netvirt/sfc/RspListener.java 0 2 0
org/opendaylight/netvirt/openstack/netvirt/sfc/SfcUtils.java 0 27 0
org/opendaylight/netvirt/openstack/netvirt/sfc/standalone/openflow13/NetvirtSfcStandaloneOF13Provider.java 0 13 0
org/opendaylight/netvirt/openstack/netvirt/sfc/standalone/openflow13/SfcClassifier.java 0 17 0
org/opendaylight/netvirt/openstack/netvirt/sfc/standalone/openflow13/services/SfcClassifierService.java 0 7 0
org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/NetvirtSfcWorkaroundOF13Provider.java 0 10 0
org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/services/AclMatches.java 0 1 0
org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/services/AclUtils.java 0 10 0
org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/services/FlowCache.java 0 3 0
org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/services/SfcClassifierService.java 0 31 0

Rules

Category Rule Violations Severity
coding OverloadMethodsDeclarationOrder 7  Warning
VariableDeclarationUsageDistance 19  Warning
imports CustomImportOrder
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###STANDARD_JAVA_PACKAGE###THIRD_PARTY_PACKAGE###SPECIAL_IMPORTS"
  • thirdPartyPackageRegExp: ".*"
  • specialImportsRegExp: "^com.*"
 24  Warning
indentation Indentation
  • lineWrappingIndentation: "4"
  • caseIndent: "4"
  • arrayInitIndent: "4"
  • throwsIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
 1  Warning
javadoc JavadocMethod
  • allowMissingParamTags: "true"
  • allowedAnnotations: "Override, Test"
  • allowThrowsTagsForSubclasses: "true"
  • scope: "public"
  • allowMissingReturnTag: "true"
  • minLineCount: "2"
  • allowMissingThrowsTags: "true"
 34  Warning
misc ArrayTypeStyle 1  Warning
modifier ModifierOrder 2  Warning
naming AbbreviationAsWordInName
  • allowedAbbreviationLength: "1"
  • ignoreFinal: "false"
 9  Warning
ParameterName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
 1  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 9  Warning
whitespace EmptyLineSeparator
  • allowNoEmptyLineBetweenFields: "true"
 9  Warning
MethodParamPad 4  Warning
NoLineWrap 1  Warning
OperatorWrap
  • tokens: "BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "
  • option: "NL"
 8  Warning
WhitespaceAround
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
  • allowEmptyMethods: "true"
  • allowEmptyConstructors: "true"
 6  Warning

Details

org/opendaylight/netvirt/openstack/netvirt/sfc/DelegatingDataTreeListener.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.concurrent.Executors' import. 13
 Warning javadoc JavadocMethod Missing a Javadoc comment. 43

org/opendaylight/netvirt/openstack/netvirt/sfc/INetvirtSfcOF13Provider.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 32
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '32'. 43
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 44
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '41'. 44
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 45
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 46
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 47
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 48
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 49

org/opendaylight/netvirt/openstack/netvirt/sfc/NetvirtSfcClassifierDataProcessor.java

Severity Category Rule Message Line
 Warning whitespace NoLineWrap import statement should not be line-wrapped. 18

org/opendaylight/netvirt/openstack/netvirt/sfc/NetvirtSfcProvider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder 'org.opendaylight.controller.md.sal.binding.api.DataBroker'should be separated from previous import group. 13
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.netvirt.openstack.netvirt.api.Constants' import. 22
 Warning sizes LineLength Line is longer than 120 characters (found 122). 94

org/opendaylight/netvirt/openstack/netvirt/sfc/RspDataProcessor.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning javadoc SummaryJavadoc First sentence should be present. 14

org/opendaylight/netvirt/openstack/netvirt/sfc/RspListener.java

Severity Category Rule Message Line
 Warning whitespace EmptyLineSeparator 'package' should be separated from previous statement. 8
 Warning javadoc SummaryJavadoc First sentence should be present. 17

org/opendaylight/netvirt/openstack/netvirt/sfc/SfcUtils.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType'should be separated from previous import group. 12
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.common.rev151017.SffName' import. 19
 Warning javadoc JavadocMethod Missing a Javadoc comment. 76
 Warning javadoc JavadocMethod Missing a Javadoc comment. 91
 Warning javadoc JavadocMethod Missing a Javadoc comment. 115
 Warning whitespace OperatorWrap '||' should be on a new line. 129
 Warning sizes LineLength Line is longer than 120 characters (found 121). 130
 Warning whitespace OperatorWrap '||' should be on a new line. 130
 Warning sizes LineLength Line is longer than 120 characters (found 121). 131
 Warning javadoc JavadocMethod Missing a Javadoc comment. 149
 Warning javadoc JavadocMethod Missing a Javadoc comment. 161
 Warning javadoc JavadocMethod Missing a Javadoc comment. 171
 Warning javadoc JavadocMethod Missing a Javadoc comment. 181
 Warning javadoc JavadocMethod Missing a Javadoc comment. 190
 Warning javadoc JavadocMethod Missing a Javadoc comment. 201
 Warning whitespace OperatorWrap '&&' should be on a new line. 203
 Warning whitespace OperatorWrap '&&' should be on a new line. 204
 Warning whitespace OperatorWrap '&&' should be on a new line. 205
 Warning javadoc JavadocMethod Missing a Javadoc comment. 222
 Warning whitespace OperatorWrap '&&' should be on a new line. 223
 Warning whitespace OperatorWrap '&&' should be on a new line. 224
 Warning whitespace OperatorWrap '&&' should be on a new line. 225
 Warning javadoc JavadocMethod Missing a Javadoc comment. 235
 Warning javadoc JavadocMethod Missing a Javadoc comment. 241
 Warning javadoc JavadocMethod Missing a Javadoc comment. 251
 Warning whitespace WhitespaceAround WhitespaceAround: '-' is not preceded with whitespace. 258
 Warning whitespace WhitespaceAround WhitespaceAround: '-' is not followed by whitespace. 258

org/opendaylight/netvirt/openstack/netvirt/sfc/standalone/openflow13/NetvirtSfcStandaloneOF13Provider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 14
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 15
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.netvirt.openstack.netvirt.api.Southbound' import. 21
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '90'. 113
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '94'. 135
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 259
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 283
 Warning naming ParameterName Parameter name 's' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 334
 Warning javadoc JavadocMethod Missing a Javadoc comment. 362
 Warning javadoc JavadocMethod Missing a Javadoc comment. 376
 Warning javadoc JavadocMethod Missing a Javadoc comment. 391
 Warning javadoc JavadocMethod Missing a Javadoc comment. 411
 Warning javadoc JavadocMethod Missing a Javadoc comment. 425

org/opendaylight/netvirt/openstack/netvirt/sfc/standalone/openflow13/SfcClassifier.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 12
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 13
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 14
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.netvirt.openstack.netvirt.api.Southbound' import. 18
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 42
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 43
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 53
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 54
 Warning javadoc JavadocMethod Missing a Javadoc comment. 58
 Warning javadoc JavadocMethod Missing a Javadoc comment. 71
 Warning javadoc JavadocMethod Missing a Javadoc comment. 109
 Warning coding VariableDeclarationUsageDistance Distance between variable 'actionList' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 125
 Warning javadoc JavadocMethod Missing a Javadoc comment. 186
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 13, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 199
 Warning coding VariableDeclarationUsageDistance Distance between variable 'instructions' declaration and its first usage is 8, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 200
 Warning coding VariableDeclarationUsageDistance Distance between variable 'actionList' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 204
 Warning javadoc JavadocMethod Missing a Javadoc comment. 233

org/opendaylight/netvirt/openstack/netvirt/sfc/standalone/openflow13/services/SfcClassifierService.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.netvirt.openstack.netvirt.providers.ConfigInterface' import. 15
 Warning sizes LineLength Line is longer than 120 characters (found 146). 44
 Warning sizes LineLength Line is longer than 120 characters (found 164). 54
 Warning sizes LineLength Line is longer than 120 characters (found 141). 59
 Warning sizes LineLength Line is longer than 120 characters (found 147). 64
 Warning sizes LineLength Line is longer than 120 characters (found 131). 74
 Warning sizes LineLength Line is longer than 120 characters (found 124). 79

org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/NetvirtSfcWorkaroundOF13Provider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 12
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.rsp.rev140701.CreateRenderedPathInput' import. 28
 Warning javadoc JavadocMethod Missing a Javadoc comment. 67
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '88'. 99
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '94'. 106
 Warning whitespace WhitespaceAround WhitespaceAround: '-' is not preceded with whitespace. 178
 Warning whitespace WhitespaceAround WhitespaceAround: '-' is not followed by whitespace. 178
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 369
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 394
 Warning naming AbbreviationAsWordInName Abbreviation in name must contain no more than '1' capital letters. 456

org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/services/AclMatches.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence should be present. 32

org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/services/AclUtils.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.access.control.list.rev150317.AccessListsBuilder'should be separated from previous import group. 13
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 31
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 32
 Warning javadoc JavadocMethod Missing a Javadoc comment. 35
 Warning javadoc JavadocMethod Missing a Javadoc comment. 57
 Warning javadoc JavadocMethod Missing a Javadoc comment. 65
 Warning javadoc JavadocMethod Missing a Javadoc comment. 75
 Warning javadoc JavadocMethod Missing a Javadoc comment. 83
 Warning javadoc JavadocMethod Missing a Javadoc comment. 91
 Warning javadoc JavadocMethod Missing a Javadoc comment. 99

org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/services/FlowCache.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder 'org.opendaylight.netvirt.utils.mdsal.openflow.FlowUtils'should be separated from previous import group. 13
 Warning javadoc JavadocMethod Missing a Javadoc comment. 25
 Warning javadoc JavadocMethod Missing a Javadoc comment. 38

org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/services/SfcClassifierService.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 13
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 14
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 15
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 16
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.netvirt.openstack.netvirt.api.Constants' import. 24
 Warning naming AbbreviationAsWordInName Abbreviation in name must contain no more than '1' capital letters. 63
 Warning naming AbbreviationAsWordInName Abbreviation in name must contain no more than '1' capital letters. 73
 Warning naming AbbreviationAsWordInName Abbreviation in name must contain no more than '1' capital letters. 78
 Warning naming AbbreviationAsWordInName Abbreviation in name must contain no more than '1' capital letters. 99
 Warning naming AbbreviationAsWordInName Abbreviation in name must contain no more than '1' capital letters. 106
 Warning naming AbbreviationAsWordInName Abbreviation in name must contain no more than '1' capital letters. 114
 Warning naming AbbreviationAsWordInName Abbreviation in name must contain no more than '1' capital letters. 119
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 193
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 225
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 18, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 257
 Warning coding VariableDeclarationUsageDistance Distance between variable 'instructions' declaration and its first usage is 17, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 258
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 316
 Warning coding VariableDeclarationUsageDistance Distance between variable 'instructions' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 317
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 350
 Warning coding VariableDeclarationUsageDistance Distance between variable 'instructions' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 351
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 383
 Warning coding VariableDeclarationUsageDistance Distance between variable 'instructions' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 384
 Warning coding VariableDeclarationUsageDistance Distance between variable 'ib' declaration and its first usage is 34, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 417
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 38, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 418
 Warning coding VariableDeclarationUsageDistance Distance between variable 'instructions' declaration and its first usage is 37, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 419
 Warning coding VariableDeclarationUsageDistance Distance between variable 'aab' declaration and its first usage is 33, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 420
 Warning coding VariableDeclarationUsageDistance Distance between variable 'actionList' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 422
 Warning misc ArrayTypeStyle Array brackets at illegal position. 515
 Warning indentation Indentation 'array initialization' child have incorrect indentation level 12, expected level should be one of the following: 8, 39, 42. 516
 Warning naming AbbreviationAsWordInName Abbreviation in name must contain no more than '1' capital letters. 522
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '119'. 532