FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 33 |
22 |
0 |
0 |
org.opendaylight.netvirt.aclservice.AbstractEgressAclServiceImpl
| Bug |
Category |
Details |
Line |
Priority |
| Useless object stored in variable actionsInfos of method org.opendaylight.netvirt.aclservice.AbstractEgressAclServiceImpl.egressAclDhcpDropServerTraffic(BigInteger, String, int, int) |
STYLE |
UC_USELESS_OBJECT |
219 |
Medium |
| Useless object stored in variable actionsInfos of method org.opendaylight.netvirt.aclservice.AbstractEgressAclServiceImpl.egressAclDhcpv6DropServerTraffic(BigInteger, String, int, int) |
STYLE |
UC_USELESS_OBJECT |
241 |
Medium |
| Useless object stored in variable actionsInfos of method org.opendaylight.netvirt.aclservice.AbstractEgressAclServiceImpl.egressAclIcmpv6DropRouterAdvts(BigInteger, int, int) |
STYLE |
UC_USELESS_OBJECT |
260 |
Medium |
org.opendaylight.netvirt.aclservice.LearnEgressAclServiceImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.netvirt.aclservice.LearnEgressAclServiceImpl.addOtherProtocolsLearnActions(List) invokes toString() method on a String |
PERFORMANCE |
DM_STRING_TOSTRING |
102 |
Low |
| org.opendaylight.netvirt.aclservice.LearnEgressAclServiceImpl.addTcpLearnActions(List) invokes toString() method on a String |
PERFORMANCE |
DM_STRING_TOSTRING |
118 |
Low |
| org.opendaylight.netvirt.aclservice.LearnEgressAclServiceImpl.addUdpLearnActions(List) invokes toString() method on a String |
PERFORMANCE |
DM_STRING_TOSTRING |
134 |
Low |
org.opendaylight.netvirt.aclservice.LearnIngressAclServiceImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.netvirt.aclservice.LearnIngressAclServiceImpl.addOtherProtocolsLearnActions(List) invokes toString() method on a String |
PERFORMANCE |
DM_STRING_TOSTRING |
91 |
Low |
| org.opendaylight.netvirt.aclservice.LearnIngressAclServiceImpl.addTcpLearnActions(List) invokes toString() method on a String |
PERFORMANCE |
DM_STRING_TOSTRING |
107 |
Low |
| org.opendaylight.netvirt.aclservice.LearnIngressAclServiceImpl.addUdpLearnActions(List) invokes toString() method on a String |
PERFORMANCE |
DM_STRING_TOSTRING |
123 |
Low |
org.opendaylight.netvirt.aclservice.StatelessEgressAclServiceImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.netvirt.aclservice.StatelessEgressAclServiceImpl.programAllowSynRules(BigInteger, String, List, int, Short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
106 |
Medium |
org.opendaylight.netvirt.aclservice.StatelessIngressAclServiceImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.netvirt.aclservice.StatelessIngressAclServiceImpl.programAllowSynRules(BigInteger, String, List, int, Short) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead |
PERFORMANCE |
DM_NUMBER_CTOR |
104 |
Medium |
org.opendaylight.netvirt.aclservice.listeners.AclInterfaceStateListener
| Bug |
Category |
Details |
Line |
Priority |
| Class org.opendaylight.netvirt.aclservice.listeners.AclInterfaceStateListener implements same interface as superclass |
STYLE |
RI_REDUNDANT_INTERFACES |
34 |
Low |
org.opendaylight.netvirt.aclservice.listeners.AclNodeListener
| Bug |
Category |
Details |
Line |
Priority |
| Boxing/unboxing to parse a primitive org.opendaylight.netvirt.aclservice.listeners.AclNodeListener.addLearnEgressAclTableMissFlow(BigInteger) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
195 |
High |
| Boxing/unboxing to parse a primitive org.opendaylight.netvirt.aclservice.listeners.AclNodeListener.addLearnIngressAclTableMissFlow(BigInteger) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
240 |
High |
| Class org.opendaylight.netvirt.aclservice.listeners.AclNodeListener implements same interface as superclass |
STYLE |
RI_REDUNDANT_INTERFACES |
49 |
Low |
org.opendaylight.netvirt.aclservice.utils.AclServiceOFFlowBuilder
| Bug |
Category |
Details |
Line |
Priority |
| Repeated conditional test in org.opendaylight.netvirt.aclservice.utils.AclServiceOFFlowBuilder.getLayer4MaskForRange(int, int) |
CORRECTNESS |
RpC_REPEATED_CONDITIONAL_TEST |
369 |
Low |
| Repeated conditional test in org.opendaylight.netvirt.aclservice.utils.AclServiceOFFlowBuilder.getLayer4MaskForRange(int, int) |
CORRECTNESS |
RpC_REPEATED_CONDITIONAL_TEST |
380 |
Low |
| org.opendaylight.netvirt.aclservice.utils.AclServiceOFFlowBuilder.programTcpFlow(AceIp) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
183 |
Medium |
| org.opendaylight.netvirt.aclservice.utils.AclServiceOFFlowBuilder.programUdpFlow(AceIp) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
238 |
Medium |
org.opendaylight.netvirt.aclservice.utils.AclServiceUtils
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.netvirt.aclservice.utils.AclServiceUtils.getFlowForAllowedAddresses(List, Map, boolean) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
614 |
Medium |
| org.opendaylight.netvirt.aclservice.utils.AclServiceUtils.getFlowForRemoteAcl(Uuid, String, Map, boolean) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
556 |
Medium |
org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.aclservice.config.rev160806.AclserviceConfigBuilder$AclserviceConfigImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.aclservice.config.rev160806.AclserviceConfigBuilder$AclserviceConfigImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.aclservice.config.rev160806.AclserviceConfigBuilder$AclserviceConfigImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
426 |
Low |
