FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is low

Effort is max

Summary

Classes Bugs Errors Missing Classes
31 28 0 0

Files

Class Bugs
org.opendaylight.netvirt.dhcpservice.DhcpConfigListener 1
org.opendaylight.netvirt.dhcpservice.DhcpDesignatedDpnListener 3
org.opendaylight.netvirt.dhcpservice.DhcpExternalTunnelManager 6
org.opendaylight.netvirt.dhcpservice.DhcpExternalTunnelManager$1 1
org.opendaylight.netvirt.dhcpservice.DhcpExternalTunnelManager$2 1
org.opendaylight.netvirt.dhcpservice.DhcpExternalTunnelManager$3 1
org.opendaylight.netvirt.dhcpservice.DhcpHwvtepListener 1
org.opendaylight.netvirt.dhcpservice.DhcpInterfaceConfigListener 1
org.opendaylight.netvirt.dhcpservice.DhcpInterfaceEventListener 1
org.opendaylight.netvirt.dhcpservice.DhcpLogicalSwitchListener 1
org.opendaylight.netvirt.dhcpservice.DhcpNeutronPortListener 2
org.opendaylight.netvirt.dhcpservice.DhcpPktHandler 3
org.opendaylight.netvirt.dhcpservice.DhcpSubnetListener 2
org.opendaylight.netvirt.dhcpservice.DhcpUCastMacListener 2
org.opendaylight.netvirt.dhcpservice.NodeListener 1
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.dhcpservice.config.rev150710.DhcpserviceConfigBuilder$DhcpserviceConfigImpl 1

org.opendaylight.netvirt.dhcpservice.DhcpConfigListener

Bug Category Details Line Priority
Class org.opendaylight.netvirt.dhcpservice.DhcpConfigListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 20 Low

org.opendaylight.netvirt.dhcpservice.DhcpDesignatedDpnListener

Bug Category Details Line Priority
Redundant nullcheck of elanDpns, which is known to be non-null in org.opendaylight.netvirt.dhcpservice.DhcpDesignatedDpnListener.add(InstanceIdentifier, DesignatedSwitchForTunnel) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 85 Low
Redundant nullcheck of elanDpns, which is known to be non-null in org.opendaylight.netvirt.dhcpservice.DhcpDesignatedDpnListener.update(InstanceIdentifier, DesignatedSwitchForTunnel, DesignatedSwitchForTunnel) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 73 Low
Class org.opendaylight.netvirt.dhcpservice.DhcpDesignatedDpnListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 24 Low

org.opendaylight.netvirt.dhcpservice.DhcpExternalTunnelManager

Bug Category Details Line Priority
Use of non-localized String.toUpperCase() or String.toLowerCase() in org.opendaylight.netvirt.dhcpservice.DhcpExternalTunnelManager.readVniMacToPortCache(BigInteger, String) I18N DM_CONVERT_CASE 566 Low
Use of non-localized String.toUpperCase() or String.toLowerCase() in org.opendaylight.netvirt.dhcpservice.DhcpExternalTunnelManager.removeVniMacToPortCache(BigInteger, String) I18N DM_CONVERT_CASE 558 Low
Use of non-localized String.toUpperCase() or String.toLowerCase() in org.opendaylight.netvirt.dhcpservice.DhcpExternalTunnelManager.updateVniMacToPortCache(BigInteger, String, Port) I18N DM_CONVERT_CASE 548 Low
Redundant nullcheck of candidateDpns, which is known to be non-null in org.opendaylight.netvirt.dhcpservice.DhcpExternalTunnelManager.chooseDpn(IpAddress, String, List) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 396 Low
org.opendaylight.netvirt.dhcpservice.DhcpExternalTunnelManager.getTunnelIpBasedOnElan(String, String) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 781 Medium
org.opendaylight.netvirt.dhcpservice.DhcpExternalTunnelManager.removeFromLocalCache(String, String) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 511 Medium

org.opendaylight.netvirt.dhcpservice.DhcpExternalTunnelManager$1

Bug Category Details Line Priority
isOwner must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 178 Low

org.opendaylight.netvirt.dhcpservice.DhcpExternalTunnelManager$2

Bug Category Details Line Priority
isOwner must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 642 Low

org.opendaylight.netvirt.dhcpservice.DhcpExternalTunnelManager$3

Bug Category Details Line Priority
isOwner must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 754 Low

org.opendaylight.netvirt.dhcpservice.DhcpHwvtepListener

Bug Category Details Line Priority
Class org.opendaylight.netvirt.dhcpservice.DhcpHwvtepListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 29 Low

org.opendaylight.netvirt.dhcpservice.DhcpInterfaceConfigListener

Bug Category Details Line Priority
Class org.opendaylight.netvirt.dhcpservice.DhcpInterfaceConfigListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 35 Low

org.opendaylight.netvirt.dhcpservice.DhcpInterfaceEventListener

Bug Category Details Line Priority
Class org.opendaylight.netvirt.dhcpservice.DhcpInterfaceEventListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 31 Low

org.opendaylight.netvirt.dhcpservice.DhcpLogicalSwitchListener

Bug Category Details Line Priority
Class org.opendaylight.netvirt.dhcpservice.DhcpLogicalSwitchListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 36 Low

org.opendaylight.netvirt.dhcpservice.DhcpNeutronPortListener

Bug Category Details Line Priority
Use of non-localized String.toUpperCase() or String.toLowerCase() in org.opendaylight.netvirt.dhcpservice.DhcpNeutronPortListener.isVnicTypeDirectOrMacVtap(Port) I18N DM_CONVERT_CASE 140 Low
Class org.opendaylight.netvirt.dhcpservice.DhcpNeutronPortListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 26 Low

org.opendaylight.netvirt.dhcpservice.DhcpPktHandler

Bug Category Details Line Priority
org.opendaylight.netvirt.dhcpservice.DhcpPktHandler.getInterfaceNameFromTag(long) invokes inefficient new Integer(int) constructor; use Integer.valueOf(int) instead PERFORMANCE DM_NUMBER_CTOR 563 Medium
Should org.opendaylight.netvirt.dhcpservice.DhcpPktHandler.convertToClasslessRouteOption(String, String) return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 526 Low
Should org.opendaylight.netvirt.dhcpservice.DhcpPktHandler.getDhcpPacketOut(DHCP, Ethernet, String) return a zero length array rather than null? STYLE PZLA_PREFER_ZERO_LENGTH_ARRAYS 310 Low

org.opendaylight.netvirt.dhcpservice.DhcpSubnetListener

Bug Category Details Line Priority
Suspicious comparison of Boolean references in org.opendaylight.netvirt.dhcpservice.DhcpSubnetListener.update(InstanceIdentifier, Subnet, Subnet) BAD_PRACTICE RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN 82 Medium
Class org.opendaylight.netvirt.dhcpservice.DhcpSubnetListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 39 Low

org.opendaylight.netvirt.dhcpservice.DhcpUCastMacListener

Bug Category Details Line Priority
Load of known null value in org.opendaylight.netvirt.dhcpservice.DhcpUCastMacListener.remove(InstanceIdentifier, LocalUcastMacs) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 82 Medium
Class org.opendaylight.netvirt.dhcpservice.DhcpUCastMacListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 36 Low

org.opendaylight.netvirt.dhcpservice.NodeListener

Bug Category Details Line Priority
Class org.opendaylight.netvirt.dhcpservice.NodeListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 25 Low

org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.dhcpservice.config.rev150710.DhcpserviceConfigBuilder$DhcpserviceConfigImpl

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.dhcpservice.config.rev150710.DhcpserviceConfigBuilder$DhcpserviceConfigImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.dhcpservice.config.rev150710.DhcpserviceConfigBuilder$DhcpserviceConfigImpl.equals(Object) STYLE BC_UNCONFIRMED_CAST 161 Low