FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is low

Effort is max

Summary

Classes Bugs Errors Missing Classes
24 47 0 0

Files

Class Bugs
org.opendaylight.netvirt.fibmanager.FibRpcServiceImpl 6
org.opendaylight.netvirt.fibmanager.FibUtil 2
org.opendaylight.netvirt.fibmanager.L3VPNTransportTypes 1
org.opendaylight.netvirt.fibmanager.NexthopManager 13
org.opendaylight.netvirt.fibmanager.NexthopManager$AdjacencyResult 1
org.opendaylight.netvirt.fibmanager.VrfEntryListener 23
org.opendaylight.netvirt.fibmanager.VrfEntryListener$9 1

org.opendaylight.netvirt.fibmanager.FibRpcServiceImpl

Bug Category Details Line Priority
Dead store to serviceId in org.opendaylight.netvirt.fibmanager.FibRpcServiceImpl.removeFibEntry(RemoveFibEntryInput) STYLE DLS_DEAD_LOCAL_STORE 105 Medium
Private method org.opendaylight.netvirt.fibmanager.FibRpcServiceImpl.getIpAddress(byte[]) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 217 Low
Private method org.opendaylight.netvirt.fibmanager.FibRpcServiceImpl.makeLFibTableEntry(BigInteger, long, List) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 260 Low
Private method org.opendaylight.netvirt.fibmanager.FibRpcServiceImpl.makeTunnelTableEntry(BigInteger, long, List) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 203 Low
Private method org.opendaylight.netvirt.fibmanager.FibRpcServiceImpl.removeLFibTableEntry(BigInteger, long) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 171 Low
Private method org.opendaylight.netvirt.fibmanager.FibRpcServiceImpl.removeTunnelTableEntry(BigInteger, long) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 190 Low

org.opendaylight.netvirt.fibmanager.FibUtil

Bug Category Details Line Priority
Dead store to result in org.opendaylight.netvirt.fibmanager.FibUtil.read(DataBroker, LogicalDatastoreType, InstanceIdentifier) STYLE DLS_DEAD_LOCAL_STORE 84 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.fibmanager.FibUtil.addOrUpdateFibEntry(DataBroker, String, String, List, int, String, RouteOrigin, WriteTransaction) STYLE REC_CATCH_EXCEPTION 420 Low

org.opendaylight.netvirt.fibmanager.L3VPNTransportTypes

Bug Category Details Line Priority
org.opendaylight.netvirt.fibmanager.L3VPNTransportTypes.setL3VPNTransportTypes(String) unconditionally sets the field transportType BAD_PRACTICE ME_ENUM_FIELD_SETTER 27 Medium

org.opendaylight.netvirt.fibmanager.NexthopManager

Bug Category Details Line Priority
Dead store to actionKey in org.opendaylight.netvirt.fibmanager.NexthopManager.getEgressActionsForInterface(String, int) STYLE DLS_DEAD_LOCAL_STORE 229 Medium
Dead store to result in org.opendaylight.netvirt.fibmanager.NexthopManager.read(LogicalDatastoreType, InstanceIdentifier) STYLE DLS_DEAD_LOCAL_STORE 518 Low
Use of non-localized String.toUpperCase() or String.toLowerCase() in org.opendaylight.netvirt.fibmanager.NexthopManager.getTunnelInterfaceName(BigInteger, BigInteger) I18N DM_CONVERT_CASE 264 Low
Use of non-localized String.toUpperCase() or String.toLowerCase() in org.opendaylight.netvirt.fibmanager.NexthopManager.getTunnelInterfaceName(BigInteger, IpAddress) I18N DM_CONVERT_CASE 285 Low
Use of non-localized String.toUpperCase() or String.toLowerCase() in org.opendaylight.netvirt.fibmanager.NexthopManager.setConfTransType(String, String) I18N DM_CONVERT_CASE 576 Low
org.opendaylight.netvirt.fibmanager.NexthopManager.createLocalNextHop(long, BigInteger, String, String, String, String, String) invokes inefficient new String(String) constructor PERFORMANCE DM_STRING_CTOR 316 Medium
org.opendaylight.netvirt.fibmanager.NexthopManager.getNextHopKey(long, String) invokes inefficient new String(String) constructor PERFORMANCE DM_STRING_CTOR 177 Medium
org.opendaylight.netvirt.fibmanager.NexthopManager.getNextHopKey(String, String) invokes inefficient new String(String) constructor PERFORMANCE DM_STRING_CTOR 182 Medium
org.opendaylight.netvirt.fibmanager.NexthopManager.removeLocalNextHop(BigInteger, Long, String, String) invokes inefficient new String(String) constructor PERFORMANCE DM_STRING_CTOR 476 Medium
Private method org.opendaylight.netvirt.fibmanager.NexthopManager.getNextHopKey(String, String) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 182 Medium
Private method org.opendaylight.netvirt.fibmanager.NexthopManager.asyncWrite(LogicalDatastoreType, InstanceIdentifier, DataObject, FutureCallback) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 531 Low
Private method org.opendaylight.netvirt.fibmanager.NexthopManager.getAdjacencyIdentifier(String, String) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 563 Low
Private method org.opendaylight.netvirt.fibmanager.NexthopManager.getDpnId(String) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 170 Low

org.opendaylight.netvirt.fibmanager.NexthopManager$AdjacencyResult

Bug Category Details Line Priority
org.opendaylight.netvirt.fibmanager.NexthopManager$AdjacencyResult.equals(Object) does not check for null argument BAD_PRACTICE NP_EQUALS_SHOULD_HANDLE_NULL_ARGUMENT 755 Medium

org.opendaylight.netvirt.fibmanager.VrfEntryListener

Bug Category Details Line Priority
Boxed value is unboxed and then immediately reboxed in org.opendaylight.netvirt.fibmanager.VrfEntryListener.deleteLabelRouteInfo(LabelRouteInfo, String, WriteTransaction) PERFORMANCE BX_UNBOXING_IMMEDIATELY_REBOXED 883 Medium
Boxed value is unboxed and then immediately reboxed in org.opendaylight.netvirt.fibmanager.VrfEntryListener.getLabelRouteInfo(Long) PERFORMANCE BX_UNBOXING_IMMEDIATELY_REBOXED 872 Medium
Boxed value is unboxed and then immediately reboxed in org.opendaylight.netvirt.fibmanager.VrfEntryListener.updateVpnReferencesInLri(LabelRouteInfo, String, boolean) PERFORMANCE BX_UNBOXING_IMMEDIATELY_REBOXED 476 Medium
org.opendaylight.netvirt.fibmanager.VrfEntryListener.addTunnelInterfaceActions(String, long, VrfEntry, List) uses the same code for two branches STYLE DB_DUPLICATE_BRANCHES 1180 Medium
Dead store to vrfTableKey in org.opendaylight.netvirt.fibmanager.VrfEntryListener.update(InstanceIdentifier, VrfEntry, VrfEntry) STYLE DLS_DEAD_LOCAL_STORE 233 Medium
Dead store to result in org.opendaylight.netvirt.fibmanager.VrfEntryListener.read(DataBroker, LogicalDatastoreType, InstanceIdentifier) STYLE DLS_DEAD_LOCAL_STORE 703 Low
Dead store to prefixIpList in org.opendaylight.netvirt.fibmanager.VrfEntryListener.resolveAdjacency(BigInteger, long, VrfEntry, String) STYLE DLS_DEAD_LOCAL_STORE 2105 Low
org.opendaylight.netvirt.fibmanager.VrfEntryListener.add(InstanceIdentifier, VrfEntry) invokes toString() method on a String PERFORMANCE DM_STRING_TOSTRING 197 Low
org.opendaylight.netvirt.fibmanager.VrfEntryListener.createFibEntries(InstanceIdentifier, VrfEntry) invokes toString() method on a String PERFORMANCE DM_STRING_TOSTRING 348 Low
org.opendaylight.netvirt.fibmanager.VrfEntryListener.deleteFibEntries(InstanceIdentifier, VrfEntry) invokes toString() method on a String PERFORMANCE DM_STRING_TOSTRING 1380 Low
org.opendaylight.netvirt.fibmanager.VrfEntryListener.remove(InstanceIdentifier, VrfEntry) invokes toString() method on a String PERFORMANCE DM_STRING_TOSTRING 217 Low
org.opendaylight.netvirt.fibmanager.VrfEntryListener.update(InstanceIdentifier, VrfEntry, VrfEntry) invokes toString() method on a String PERFORMANCE DM_STRING_TOSTRING 238 Low
Load of known null value in org.opendaylight.netvirt.fibmanager.VrfEntryListener.cleanUpOpDataForFib(Long, String, VrfEntry) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 1252 Low
Redundant nullcheck of origNhList, which is known to be non-null in org.opendaylight.netvirt.fibmanager.VrfEntryListener.update(InstanceIdentifier, VrfEntry, VrfEntry) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 268 Medium
Nullcheck of lri at line 884 of value previously dereferenced in org.opendaylight.netvirt.fibmanager.VrfEntryListener.deleteLabelRouteInfo(LabelRouteInfo, String, WriteTransaction) CORRECTNESS RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE 881 High
Class org.opendaylight.netvirt.fibmanager.VrfEntryListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 126 Low
Write to static field org.opendaylight.netvirt.fibmanager.VrfEntryListener.batchInterval from instance method new org.opendaylight.netvirt.fibmanager.VrfEntryListener(DataBroker, IMdsalApiManager, NexthopManager, OdlInterfaceRpcService, IdManagerService, IVpnLinkService) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 164 Medium
Write to static field org.opendaylight.netvirt.fibmanager.VrfEntryListener.batchSize from instance method new org.opendaylight.netvirt.fibmanager.VrfEntryListener(DataBroker, IMdsalApiManager, NexthopManager, OdlInterfaceRpcService, IdManagerService, IVpnLinkService) STYLE ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD 163 Medium
Private method org.opendaylight.netvirt.fibmanager.VrfEntryListener.delIntfFromDpnToVpnList(long, BigInteger, String, String) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 1192 Low
Private method org.opendaylight.netvirt.fibmanager.VrfEntryListener.get(byte[]) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 1597 Low
Private method org.opendaylight.netvirt.fibmanager.VrfEntryListener.getDpnIdForPrefix(DataBroker, Long, String, VrfEntry) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 714 Low
Private method org.opendaylight.netvirt.fibmanager.VrfEntryListener.getVrfEntryId(String, String) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 2222 Low
Private method org.opendaylight.netvirt.fibmanager.VrfEntryListener.makeProtocolTableFlow(BigInteger, int) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 2159 Low

org.opendaylight.netvirt.fibmanager.VrfEntryListener$9

Bug Category Details Line Priority
Dead store to nhList in org.opendaylight.netvirt.fibmanager.VrfEntryListener$9.call() STYLE DLS_DEAD_LOCAL_STORE 1916 Medium