Checkstyle Results

The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
7 0 145 0

Files

File  I  W  E
org/opendaylight/netvirt/neutronvpn/shell/ConfigureL3VpnCommand.java 0 7 0
org/opendaylight/netvirt/neutronvpn/shell/DhcpConfigureCommand.java 0 13 0
org/opendaylight/netvirt/neutronvpn/shell/DhcpShowCommand.java 0 8 0
org/opendaylight/netvirt/neutronvpn/shell/ShowSubnet.java 0 58 0
org/opendaylight/netvirt/neutronvpn/shell/ShowVpnIpToPort.java 0 59 0

Rules

Category Rule Violations Severity
coding IllegalCatch 8  Warning
MissingSwitchDefault 1  Warning
VariableDeclarationUsageDistance 1  Warning
imports CustomImportOrder
  • thirdPartyPackageRegExp: ".*"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
 20  Warning
naming MemberName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
 5  Warning
regexp RegexpSinglelineJava
  • ignoreComments: "false"
  • format: "System\.(out)|(err)\.print(ln)?\("
  • message: "Line contains console output."
 37  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 24  Warning
whitespace EmptyLineSeparator
  • allowNoEmptyLineBetweenFields: "true"
  • tokens: "IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"
 1  Warning
MethodParamPad 3  Warning
OperatorWrap
  • tokens: "BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "
  • option: "NL"
 7  Warning
SeparatorWrap
  • tokens: "COMMA"
  • option: "EOL"
 1  Warning
SeparatorWrap
  • tokens: "DOT"
  • option: "nl"
 1  Warning
WhitespaceAround
  • allowEmptyConstructors: "true"
  • allowEmptyMethods: "true"
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
 37  Warning

Details

org/opendaylight/netvirt/neutronvpn/shell/ConfigureL3VpnCommand.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. 32
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.Arrays' import. Should be before 'org.slf4j.LoggerFactory'. 33
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. 34
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.concurrent.ExecutionException' import. Should be before 'org.slf4j.LoggerFactory'. 35
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.concurrent.Future' import. Should be before 'org.slf4j.LoggerFactory'. 36
 Warning naming MemberName Member name 'Logger' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 41
 Warning coding MissingSwitchDefault switch without "default" clause. 282

org/opendaylight/netvirt/neutronvpn/shell/DhcpConfigureCommand.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.slf4j.LoggerFactory'. 27
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.util.concurrent.CheckedFuture' import. Should be before 'org.slf4j.LoggerFactory'. 28
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.Arrays' import. Should be before 'org.slf4j.LoggerFactory'. 30
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. 31
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.concurrent.ExecutionException' import. Should be before 'org.slf4j.LoggerFactory'. 32
 Warning naming MemberName Member name 'Logger' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 37
 Warning sizes LineLength Line is longer than 120 characters (found 127). 39
 Warning sizes LineLength Line is longer than 120 characters (found 127). 42
 Warning coding VariableDeclarationUsageDistance Distance between variable 'dcBuilder' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 62
 Warning whitespace OperatorWrap '&&' should be on a new line. 66
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 83
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 85
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 108

org/opendaylight/netvirt/neutronvpn/shell/DhcpShowCommand.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.slf4j.LoggerFactory'. 21
 Warning naming MemberName Member name 'Logger' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 26
 Warning whitespace WhitespaceAround WhitespaceAround: ':' is not preceded with whitespace. 51
 Warning whitespace WhitespaceAround WhitespaceAround: ':' is not followed by whitespace. 51
 Warning whitespace WhitespaceAround WhitespaceAround: ':' is not preceded with whitespace. 52
 Warning whitespace WhitespaceAround WhitespaceAround: ':' is not followed by whitespace. 52
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 53
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 66

org/opendaylight/netvirt/neutronvpn/shell/ShowSubnet.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.SubnetOpData' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.subnetmaps.SubnetmapKey'. 21
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.SubnetOpDataEntry' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.subnetmaps.SubnetmapKey'. 22
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.SubnetOpDataEntryKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.subnetmaps.SubnetmapKey'. 23
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. 29
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.HashMap' import. Should be before 'org.slf4j.LoggerFactory'. 30
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. 31
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.Map' import. Should be before 'org.slf4j.LoggerFactory'. 32
 Warning sizes LineLength Line is longer than 120 characters (found 131). 34
 Warning sizes LineLength Line is longer than 120 characters (found 122). 37
 Warning sizes LineLength Line is longer than 120 characters (found 131). 40
 Warning naming MemberName Member name 'LOG' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 44
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 54
 Warning whitespace WhitespaceAround WhitespaceAround: 'try' is not followed by whitespace. 56
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 56
 Warning regexp RegexpSinglelineJava Line contains console output. 59
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 60
 Warning regexp RegexpSinglelineJava Line contains console output. 63
 Warning regexp RegexpSinglelineJava Line contains console output. 66
 Warning regexp RegexpSinglelineJava Line contains console output. 70
 Warning whitespace WhitespaceAround WhitespaceAround: 'else' is not preceded with whitespace. 74
 Warning whitespace WhitespaceAround WhitespaceAround: '}' is not followed by whitespace. 74
 Warning whitespace SeparatorWrap '.' should be on a new line. 75
 Warning regexp RegexpSinglelineJava Line contains console output. 79
 Warning regexp RegexpSinglelineJava Line contains console output. 80
 Warning regexp RegexpSinglelineJava Line contains console output. 81
 Warning whitespace OperatorWrap '+' should be on a new line. 81
 Warning whitespace WhitespaceAround WhitespaceAround: '+' is not followed by whitespace. 82
 Warning whitespace OperatorWrap '+' should be on a new line. 82
 Warning whitespace OperatorWrap '+' should be on a new line. 83
 Warning regexp RegexpSinglelineJava Line contains console output. 85
 Warning whitespace WhitespaceAround WhitespaceAround: 'else' is not preceded with whitespace. 86
 Warning whitespace WhitespaceAround WhitespaceAround: '}' is not followed by whitespace. 86
 Warning regexp RegexpSinglelineJava Line contains console output. 91
 Warning regexp RegexpSinglelineJava Line contains console output. 92
 Warning regexp RegexpSinglelineJava Line contains console output. 93
 Warning whitespace OperatorWrap '+' should be on a new line. 93
 Warning sizes LineLength Line is longer than 120 characters (found 132). 96
 Warning regexp RegexpSinglelineJava Line contains console output. 99
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 101
 Warning whitespace WhitespaceAround WhitespaceAround: 'catch' is not preceded with whitespace. 101
 Warning whitespace WhitespaceAround WhitespaceAround: '}' is not followed by whitespace. 101
 Warning regexp RegexpSinglelineJava Line contains console output. 102
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 117
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 124
 Warning regexp RegexpSinglelineJava Line contains console output. 131
 Warning whitespace WhitespaceAround WhitespaceAround: 'else' is not preceded with whitespace. 132
 Warning whitespace WhitespaceAround WhitespaceAround: '}' is not followed by whitespace. 132
 Warning whitespace WhitespaceAround WhitespaceAround: 'else' is not followed by whitespace. 132
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 132
 Warning regexp RegexpSinglelineJava Line contains console output. 138
 Warning whitespace WhitespaceAround WhitespaceAround: 'else' is not preceded with whitespace. 139
 Warning whitespace WhitespaceAround WhitespaceAround: '}' is not followed by whitespace. 139
 Warning whitespace WhitespaceAround WhitespaceAround: 'else' is not followed by whitespace. 139
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 139
 Warning regexp RegexpSinglelineJava Line contains console output. 149
 Warning sizes LineLength Line is longer than 120 characters (found 128). 149
 Warning regexp RegexpSinglelineJava Line contains console output. 150
 Warning sizes LineLength Line is longer than 120 characters (found 134). 150

org/opendaylight/netvirt/neutronvpn/shell/ShowVpnIpToPort.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. 28
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. 29
 Warning sizes LineLength Line is longer than 120 characters (found 184). 31
 Warning sizes LineLength Line is longer than 120 characters (found 126). 34
 Warning sizes LineLength Line is longer than 120 characters (found 148). 36
 Warning naming MemberName Member name 'LOG' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 39
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 47
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 48
 Warning whitespace WhitespaceAround WhitespaceAround: 'try' is not followed by whitespace. 50
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 50
 Warning regexp RegexpSinglelineJava Line contains console output. 54
 Warning regexp RegexpSinglelineJava Line contains console output. 55
 Warning regexp RegexpSinglelineJava Line contains console output. 56
 Warning sizes LineLength Line is longer than 120 characters (found 136). 56
 Warning regexp RegexpSinglelineJava Line contains console output. 57
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 58
 Warning regexp RegexpSinglelineJava Line contains console output. 59
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 64
 Warning regexp RegexpSinglelineJava Line contains console output. 65
 Warning regexp RegexpSinglelineJava Line contains console output. 70
 Warning regexp RegexpSinglelineJava Line contains console output. 71
 Warning whitespace WhitespaceAround WhitespaceAround: 'else' is not preceded with whitespace. 72
 Warning whitespace WhitespaceAround WhitespaceAround: '}' is not followed by whitespace. 72
 Warning regexp RegexpSinglelineJava Line contains console output. 73
 Warning sizes LineLength Line is longer than 120 characters (found 130). 73
 Warning whitespace WhitespaceAround WhitespaceAround: 'else' is not preceded with whitespace. 74
 Warning whitespace WhitespaceAround WhitespaceAround: '}' is not followed by whitespace. 74
 Warning whitespace WhitespaceAround WhitespaceAround: 'else' is not followed by whitespace. 74
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 74
 Warning sizes LineLength Line is longer than 120 characters (found 121). 75
 Warning whitespace MethodParamPad '(' should be on the previous line. 76
 Warning regexp RegexpSinglelineJava Line contains console output. 80
 Warning sizes LineLength Line is longer than 120 characters (found 136). 80
 Warning regexp RegexpSinglelineJava Line contains console output. 81
 Warning sizes LineLength Line is longer than 120 characters (found 135). 81
 Warning whitespace OperatorWrap '+' should be on a new line. 81
 Warning regexp RegexpSinglelineJava Line contains console output. 83
 Warning sizes LineLength Line is longer than 120 characters (found 134). 83
 Warning sizes LineLength Line is longer than 120 characters (found 132). 85
 Warning whitespace MethodParamPad '(' should be on the previous line. 86
 Warning sizes LineLength Line is longer than 120 characters (found 123). 87
 Warning regexp RegexpSinglelineJava Line contains console output. 89
 Warning regexp RegexpSinglelineJava Line contains console output. 93
 Warning sizes LineLength Line is longer than 120 characters (found 136). 93
 Warning regexp RegexpSinglelineJava Line contains console output. 94
 Warning sizes LineLength Line is longer than 120 characters (found 135). 94
 Warning whitespace OperatorWrap '+' should be on a new line. 94
 Warning regexp RegexpSinglelineJava Line contains console output. 96
 Warning sizes LineLength Line is longer than 120 characters (found 134). 96
 Warning regexp RegexpSinglelineJava Line contains console output. 98
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 100
 Warning regexp RegexpSinglelineJava Line contains console output. 101
 Warning sizes LineLength Line is longer than 120 characters (found 126). 101
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 114
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 120
 Warning regexp RegexpSinglelineJava Line contains console output. 126
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 132
 Warning regexp RegexpSinglelineJava Line contains console output. 139
 Warning sizes LineLength Line is longer than 120 characters (found 125). 147