Checkstyle Results

The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
24 0 98 0

Files

File  I  W  E
org/opendaylight/netvirt/openstack/netvirt/sfc/DelegatingDataTreeListener.java 0 4 0
org/opendaylight/netvirt/openstack/netvirt/sfc/INetvirtSfcDataProcessor.java 0 1 0
org/opendaylight/netvirt/openstack/netvirt/sfc/INetvirtSfcOF13Provider.java 0 10 0
org/opendaylight/netvirt/openstack/netvirt/sfc/NetvirtSfcClassifierDataProcessor.java 0 1 0
org/opendaylight/netvirt/openstack/netvirt/sfc/NetvirtSfcProvider.java 0 3 0
org/opendaylight/netvirt/openstack/netvirt/sfc/RspDataProcessor.java 0 2 0
org/opendaylight/netvirt/openstack/netvirt/sfc/RspListener.java 0 2 0
org/opendaylight/netvirt/openstack/netvirt/sfc/SfcUtils.java 0 12 0
org/opendaylight/netvirt/openstack/netvirt/sfc/standalone/openflow13/NetvirtSfcStandaloneOF13Provider.java 0 9 0
org/opendaylight/netvirt/openstack/netvirt/sfc/standalone/openflow13/SfcClassifier.java 0 7 0
org/opendaylight/netvirt/openstack/netvirt/sfc/standalone/openflow13/services/SfcClassifierService.java 0 8 0
org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/NetvirtSfcWorkaroundOF13Provider.java 0 15 0
org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/services/AclMatches.java 0 2 0
org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/services/AclUtils.java 0 2 0
org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/services/SfcClassifierService.java 0 20 0

Rules

Category Rule Violations Severity
coding IllegalCatch 2  Warning
OverloadMethodsDeclarationOrder 7  Warning
VariableDeclarationUsageDistance 17  Warning
imports CustomImportOrder
  • thirdPartyPackageRegExp: ".*"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
 19  Warning
UnusedImports 1  Warning
indentation Indentation
  • throwsIndent: "4"
  • arrayInitIndent: "4"
  • caseIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
  • lineWrappingIndentation: "4"
 1  Warning
javadoc JavadocStyle
  • checkEmptyJavadoc: "true"
 6  Warning
misc ArrayTypeStyle 1  Warning
modifier ModifierOrder 2  Warning
naming ConstantName 1  Warning
ParameterName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
 1  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 11  Warning
whitespace EmptyLineSeparator
  • allowNoEmptyLineBetweenFields: "true"
  • tokens: "IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"
 7  Warning
MethodParamPad 4  Warning
NoLineWrap 1  Warning
OperatorWrap
  • tokens: "BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "
  • option: "NL"
 8  Warning
WhitespaceAround
  • allowEmptyConstructors: "true"
  • allowEmptyMethods: "true"
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
 6  Warning

Details

org/opendaylight/netvirt/openstack/netvirt/sfc/DelegatingDataTreeListener.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.base.Preconditions' import. Should be before 'javax.annotation.Nonnull'. 18
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.util.concurrent.ThreadFactoryBuilder' import. Should be before 'javax.annotation.Nonnull'. 19
 Warning naming ConstantName Name 'threadFactory' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 37
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 55

org/opendaylight/netvirt/openstack/netvirt/sfc/INetvirtSfcDataProcessor.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle First sentence should end with a period. 14

org/opendaylight/netvirt/openstack/netvirt/sfc/INetvirtSfcOF13Provider.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle First sentence should end with a period. 18
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 32
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '32'. 43
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 44
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '41'. 44
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 45
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 46
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 47
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 48
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 49

org/opendaylight/netvirt/openstack/netvirt/sfc/NetvirtSfcClassifierDataProcessor.java

Severity Category Rule Message Line
 Warning whitespace NoLineWrap import statement should not be line-wrapped. 19

org/opendaylight/netvirt/openstack/netvirt/sfc/NetvirtSfcProvider.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 136). 44
 Warning sizes LineLength Line is longer than 120 characters (found 128). 48
 Warning sizes LineLength Line is longer than 120 characters (found 122). 98

org/opendaylight/netvirt/openstack/netvirt/sfc/RspDataProcessor.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 14
 Warning javadoc JavadocStyle First sentence should end with a period. 14

org/opendaylight/netvirt/openstack/netvirt/sfc/RspListener.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 17
 Warning javadoc JavadocStyle First sentence should end with a period. 17

org/opendaylight/netvirt/openstack/netvirt/sfc/SfcUtils.java

Severity Category Rule Message Line
 Warning whitespace OperatorWrap '||' should be on a new line. 127
 Warning sizes LineLength Line is longer than 120 characters (found 121). 128
 Warning whitespace OperatorWrap '||' should be on a new line. 128
 Warning sizes LineLength Line is longer than 120 characters (found 121). 129
 Warning whitespace OperatorWrap '&&' should be on a new line. 201
 Warning whitespace OperatorWrap '&&' should be on a new line. 202
 Warning whitespace OperatorWrap '&&' should be on a new line. 203
 Warning whitespace OperatorWrap '&&' should be on a new line. 221
 Warning whitespace OperatorWrap '&&' should be on a new line. 222
 Warning whitespace OperatorWrap '&&' should be on a new line. 223
 Warning whitespace WhitespaceAround WhitespaceAround: '-' is not preceded with whitespace. 256
 Warning whitespace WhitespaceAround WhitespaceAround: '-' is not followed by whitespace. 256

org/opendaylight/netvirt/openstack/netvirt/sfc/standalone/openflow13/NetvirtSfcStandaloneOF13Provider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.netvirt.openstack.netvirt.api.Southbound' import. Should be before 'org.opendaylight.netvirt.openstack.netvirt.sfc.NshUtils'. 21
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.netvirt.openstack.netvirt.sfc.INetvirtSfcOF13Provider' import. Should be before 'org.opendaylight.netvirt.openstack.netvirt.sfc.NshUtils'. 22
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.netvirt.openstack.netvirt.sfc.ISfcClassifierService' import. Should be before 'org.opendaylight.netvirt.openstack.netvirt.sfc.NshUtils'. 23
 Warning javadoc JavadocStyle First sentence should end with a period. 56
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '90'. 113
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '94'. 135
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 259
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 283
 Warning naming ParameterName Parameter name 's' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 334

org/opendaylight/netvirt/openstack/netvirt/sfc/standalone/openflow13/SfcClassifier.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.netvirt.openstack.netvirt.api.Southbound' import. Should be before 'org.opendaylight.netvirt.openstack.netvirt.sfc.NshUtils'. 18
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 53
 Warning modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 54
 Warning coding VariableDeclarationUsageDistance Distance between variable 'actionList' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 125
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 13, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 208
 Warning coding VariableDeclarationUsageDistance Distance between variable 'instructions' declaration and its first usage is 8, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 209
 Warning coding VariableDeclarationUsageDistance Distance between variable 'actionList' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 213

org/opendaylight/netvirt/openstack/netvirt/sfc/standalone/openflow13/services/SfcClassifierService.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.netvirt.openstack.netvirt.providers.ConfigInterface' import. Should be before 'org.opendaylight.netvirt.openstack.netvirt.sfc.NshUtils'. 15
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.netvirt.openstack.netvirt.sfc.ISfcClassifierService' import. Should be before 'org.opendaylight.netvirt.openstack.netvirt.sfc.NshUtils'. 16
 Warning sizes LineLength Line is longer than 120 characters (found 146). 44
 Warning sizes LineLength Line is longer than 120 characters (found 164). 54
 Warning sizes LineLength Line is longer than 120 characters (found 141). 59
 Warning sizes LineLength Line is longer than 120 characters (found 147). 64
 Warning sizes LineLength Line is longer than 120 characters (found 131). 74
 Warning sizes LineLength Line is longer than 120 characters (found 124). 79

org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/NetvirtSfcWorkaroundOF13Provider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.rsp.rev140701.CreateRenderedPathInput' import. Should be before 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.sl.rev140701.data.plane.locator.locator.type.Ip'. 28
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.rsp.rev140701.CreateRenderedPathInputBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.sl.rev140701.data.plane.locator.locator.type.Ip'. 29
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.rsp.rev140701.rendered.service.path.first.hop.info.RenderedServicePathFirstHop' import. Should be before 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.sl.rev140701.data.plane.locator.locator.type.Ip'. 30
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.rsp.rev140701.rendered.service.paths.RenderedServicePath' import. Should be before 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.sl.rev140701.data.plane.locator.locator.type.Ip'. 31
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.rsp.rev140701.rendered.service.paths.rendered.service.path.RenderedServicePathHop' import. Should be before 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.sl.rev140701.data.plane.locator.locator.type.Ip'. 32
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.sf.rev140701.service.functions.ServiceFunction' import. Should be before 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.sl.rev140701.data.plane.locator.locator.type.Ip'. 33
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.sff.rev140701.service.function.forwarders.ServiceFunctionForwarder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.sl.rev140701.data.plane.locator.locator.type.Ip'. 34
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.sfp.rev140701.service.function.paths.ServiceFunctionPath' import. Should be before 'org.opendaylight.yang.gen.v1.urn.cisco.params.xml.ns.yang.sfc.sl.rev140701.data.plane.locator.locator.type.Ip'. 35
 Warning imports UnusedImports Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.ovsdb.rev150105.ovsdb.node.attributes.ConnectionInfo. 46
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '87'. 98
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '93'. 105
 Warning whitespace WhitespaceAround WhitespaceAround: '-' is not preceded with whitespace. 177
 Warning whitespace WhitespaceAround WhitespaceAround: '-' is not followed by whitespace. 177
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 382
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 407

org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/services/AclMatches.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 32
 Warning javadoc JavadocStyle First sentence should end with a period. 32

org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/services/AclUtils.java

Severity Category Rule Message Line
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 31
 Warning whitespace WhitespaceAround WhitespaceAround: '=' is not preceded with whitespace. 32

org/opendaylight/netvirt/openstack/netvirt/sfc/workaround/services/SfcClassifierService.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.netvirt.openstack.netvirt.api.Constants' import. Should be before 'org.opendaylight.netvirt.openstack.netvirt.sfc.NshUtils'. 24
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.netvirt.openstack.netvirt.providers.ConfigInterface' import. Should be before 'org.opendaylight.netvirt.openstack.netvirt.sfc.NshUtils'. 25
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.netvirt.openstack.netvirt.sfc.ISfcClassifierService' import. Should be before 'org.opendaylight.netvirt.openstack.netvirt.sfc.NshUtils'. 26
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 193
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 225
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 18, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 257
 Warning coding VariableDeclarationUsageDistance Distance between variable 'instructions' declaration and its first usage is 17, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 258
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 370
 Warning coding VariableDeclarationUsageDistance Distance between variable 'instructions' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 371
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 403
 Warning coding VariableDeclarationUsageDistance Distance between variable 'instructions' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 404
 Warning coding VariableDeclarationUsageDistance Distance between variable 'ib' declaration and its first usage is 34, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 437
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isb' declaration and its first usage is 38, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 438
 Warning coding VariableDeclarationUsageDistance Distance between variable 'instructions' declaration and its first usage is 37, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 439
 Warning coding VariableDeclarationUsageDistance Distance between variable 'aab' declaration and its first usage is 33, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 440
 Warning coding VariableDeclarationUsageDistance Distance between variable 'actionList' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 442
 Warning misc ArrayTypeStyle Array brackets at illegal position. 547
 Warning indentation Indentation 'array initialization' child have incorrect indentation level 12, expected level should be one of the following: 8, 39, 42. 548
 Warning coding OverloadMethodsDeclarationOrder Overload methods should not be split. Previous overloaded method located at line '119'. 564
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 572