FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 200 |
60 |
0 |
0 |
org.opendaylight.netvirt.openstack.netvirt.ConfigActivator$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.netvirt.openstack.netvirt.ConfigActivator$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
307 |
Low |
org.opendaylight.netvirt.openstack.netvirt.NetvirtProvider
| Bug |
Category |
Details |
Line |
Priority |
| Write to static field org.opendaylight.netvirt.openstack.netvirt.NetvirtProvider.entityOwnershipService from instance method new org.opendaylight.netvirt.openstack.netvirt.NetvirtProvider(DataBroker, EntityOwnershipService, boolean, boolean) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
42 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.PortSecurityHandler
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of portNodeCache, which is known to be non-null in org.opendaylight.netvirt.openstack.netvirt.PortSecurityHandler.processNeutronSecurityRuleAdded(NeutronSecurityRule) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
158 |
Low |
| Redundant nullcheck of portNodeCache, which is known to be non-null in org.opendaylight.netvirt.openstack.netvirt.PortSecurityHandler.processNeutronSecurityRuleDeleted(NeutronSecurityRule) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
172 |
Low |
org.opendaylight.netvirt.openstack.netvirt.SouthboundEvent
| Bug |
Category |
Details |
Line |
Priority |
| Unwritten field: org.opendaylight.netvirt.openstack.netvirt.SouthboundEvent.context |
CORRECTNESS |
UWF_UNWRITTEN_FIELD |
74 |
Medium |
| Unwritten field: org.opendaylight.netvirt.openstack.netvirt.SouthboundEvent.tableName |
CORRECTNESS |
UWF_UNWRITTEN_FIELD |
68 |
Medium |
| Unwritten field: org.opendaylight.netvirt.openstack.netvirt.SouthboundEvent.uuid |
CORRECTNESS |
UWF_UNWRITTEN_FIELD |
71 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.VLANProvider
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to lstMacAddress in org.opendaylight.netvirt.openstack.netvirt.VLANProvider.populateVLANProviderCaches() |
STYLE |
DLS_DEAD_LOCAL_STORE |
120 |
Medium |
| Possible null pointer dereference of VLANProvider.vlanProviderCache in org.opendaylight.netvirt.openstack.netvirt.VLANProvider.populateVLANProviderCaches() |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
143 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.api.Constants
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.netvirt.openstack.netvirt.api.Constants.OPENFLOW_CONNECTION_PROTOCOL isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
109 |
High |
| org.opendaylight.netvirt.openstack.netvirt.api.Constants.OPENFLOW_PORT isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
108 |
High |
| Unread field: org.opendaylight.netvirt.openstack.netvirt.api.Constants.groupId |
PERFORMANCE |
URF_UNREAD_FIELD |
105 |
Low |
org.opendaylight.netvirt.openstack.netvirt.api.LearnConstants
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.netvirt.openstack.netvirt.api.LearnConstants.ICMP_TYPE_MAP is a mutable collection which should be package protected |
MALICIOUS_CODE |
MS_MUTABLE_COLLECTION_PKGPROTECT |
23 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.api.LoadBalancerConfiguration
| Bug |
Category |
Details |
Line |
Priority |
| Confusing to have methods org.opendaylight.netvirt.openstack.netvirt.api.LoadBalancerConfiguration.getProviderSegmentationId() and org.opendaylight.netvirt.openstack.netvirt.translator.NeutronNetwork.getProviderSegmentationID() |
BAD_PRACTICE |
NM_CONFUSING |
228 |
Low |
| Confusing to have methods org.opendaylight.netvirt.openstack.netvirt.api.LoadBalancerConfiguration.setProviderSegmentationId(String) and org.opendaylight.netvirt.openstack.netvirt.translator.NeutronNetwork.setProviderSegmentationID(String) |
BAD_PRACTICE |
NM_CONFUSING |
224 |
Low |
org.opendaylight.netvirt.openstack.netvirt.api.LoadBalancerConfiguration$LoadBalancerPoolMember
| Bug |
Category |
Details |
Line |
Priority |
| Should org.opendaylight.netvirt.openstack.netvirt.api.LoadBalancerConfiguration$LoadBalancerPoolMember be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
31 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.impl.BridgeConfigurationManagerImpl
| Bug |
Category |
Details |
Line |
Priority |
| D'oh! A nonsensical invocation of checkNotNull(Object) in org.opendaylight.netvirt.openstack.netvirt.impl.BridgeConfigurationManagerImpl.prepareNode(Node) |
CORRECTNESS |
DMI_DOH |
202 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.impl.DistributedArpService
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.util.concurrent.ExecutorService.submit(Callable) ignored in org.opendaylight.netvirt.openstack.netvirt.impl.DistributedArpService.handleArpRule(Node, NeutronPort, String, boolean, Action) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
224 |
Low |
org.opendaylight.netvirt.openstack.netvirt.impl.EventDispatcherImpl
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in org.opendaylight.netvirt.openstack.netvirt.impl.EventDispatcherImpl.start() |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
45 |
Low |
org.opendaylight.netvirt.openstack.netvirt.impl.HostConfigService
| Bug |
Category |
Details |
Line |
Priority |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.opendaylight.netvirt.openstack.netvirt.impl.HostConfigService.extractHostConfig(Node) |
I18N |
DM_CONVERT_CASE |
99 |
Low |
| Redundant nullcheck of hostType, which is known to be non-null in org.opendaylight.netvirt.openstack.netvirt.impl.HostConfigService.extractHostConfig(Node) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
95 |
Low |
| Private method org.opendaylight.netvirt.openstack.netvirt.impl.HostConfigService.createInstanceIdentifier() is never called |
PERFORMANCE |
UPM_UNCALLED_PRIVATE_METHOD |
139 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.impl.NeutronL3Adapter
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of neutronTenantPortUuid, which is known to be non-null in org.opendaylight.netvirt.openstack.netvirt.impl.NeutronL3Adapter.getFloatingIPWithMetadata(String) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
362 |
Medium |
| Private method org.opendaylight.netvirt.openstack.netvirt.impl.NeutronL3Adapter.getDpidForExternalBridge(Node) is never called |
PERFORMANCE |
UPM_UNCALLED_PRIVATE_METHOD |
1465 |
Low |
| Private method org.opendaylight.netvirt.openstack.netvirt.impl.NeutronL3Adapter.getExternalBridgeNode() is never called |
PERFORMANCE |
UPM_UNCALLED_PRIVATE_METHOD |
1476 |
Low |
org.opendaylight.netvirt.openstack.netvirt.impl.NeutronL3Adapter$FloatIpData
| Bug |
Category |
Details |
Line |
Priority |
| Should org.opendaylight.netvirt.openstack.netvirt.impl.NeutronL3Adapter$FloatIpData be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
107 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.impl.OvsdbDataChangeListener
| Bug |
Category |
Details |
Line |
Priority |
| Load of known null value in org.opendaylight.netvirt.openstack.netvirt.impl.OvsdbDataChangeListener.processOvsdbDisconnect(AsyncDataChangeEvent) |
STYLE |
NP_LOAD_OF_KNOWN_NULL_VALUE |
111 |
Medium |
| Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in org.opendaylight.netvirt.openstack.netvirt.impl.OvsdbDataChangeListener.onDataChanged(AsyncDataChangeEvent) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
77 |
Low |
org.opendaylight.netvirt.openstack.netvirt.impl.OvsdbInventoryServiceImpl
| Bug |
Category |
Details |
Line |
Priority |
| Write to static field org.opendaylight.netvirt.openstack.netvirt.impl.OvsdbInventoryServiceImpl.mdsalUtils from instance method new org.opendaylight.netvirt.openstack.netvirt.impl.OvsdbInventoryServiceImpl(DataBroker) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
58 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.impl.ProviderNetworkManagerImpl$ProviderEntry
| Bug |
Category |
Details |
Line |
Priority |
| Should org.opendaylight.netvirt.openstack.netvirt.impl.ProviderNetworkManagerImpl$ProviderEntry be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
96 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.impl.SecurityGroupCacheManagerImpl
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to securityRules in org.opendaylight.netvirt.openstack.netvirt.impl.SecurityGroupCacheManagerImpl.retrieveAndSyncSecurityRules(String, NeutronPort, NodeId, Map, NeutronPort, boolean) |
STYLE |
DLS_DEAD_LOCAL_STORE |
153 |
Medium |
| Redundant nullcheck of securityRuleList, which is known to be non-null in org.opendaylight.netvirt.openstack.netvirt.impl.SecurityGroupCacheManagerImpl.init() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
189 |
Low |
| org.opendaylight.netvirt.openstack.netvirt.impl.SecurityGroupCacheManagerImpl.removeFromCache(String, String, NodeId) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
98 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.impl.SecurityServicesImpl
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference of neutronPort in org.opendaylight.netvirt.openstack.netvirt.impl.SecurityServicesImpl.getDhcpServerPort(OvsdbTerminationPointAugmentation) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
143 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.impl.SouthboundImpl
| Bug |
Category |
Details |
Line |
Priority |
| Confusing to have methods org.opendaylight.netvirt.openstack.netvirt.impl.SouthboundImpl.getDatabroker() and org.opendaylight.netvirt.openstack.netvirt.translator.crud.impl.AbstractNeutronInterface.getDataBroker() |
BAD_PRACTICE |
NM_CONFUSING |
92 |
Low |
org.opendaylight.netvirt.openstack.netvirt.impl.VlanConfigurationCacheImpl
| Bug |
Category |
Details |
Line |
Priority |
| Boxed value is unboxed and then immediately reboxed in org.opendaylight.netvirt.openstack.netvirt.impl.VlanConfigurationCacheImpl.getInternalVlan(Node, String) |
PERFORMANCE |
BX_UNBOXING_IMMEDIATELY_REBOXED |
111 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.translator.NeutronFirewall
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronFirewall.extractFields(List) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
143 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.translator.NeutronFirewallPolicy
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronFirewallPolicy.extractFields(List) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
132 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.translator.NeutronFirewallRule
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronFirewallRule.extractFields(List) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
240 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.translator.NeutronFloatingIP
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronFloatingIP.extractFields(List) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
142 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.translator.NeutronLoadBalancer
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronLoadBalancer.extractFields(List) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
141 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.translator.NeutronLoadBalancerHealthMonitor
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronLoadBalancerHealthMonitor.extractFields(List) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
180 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.translator.NeutronLoadBalancerListener
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronLoadBalancerListener.extractFields(List) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
169 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.translator.NeutronLoadBalancerPool
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronLoadBalancerPool.extractFields(List) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
197 |
Medium |
| NeutronLoadBalancerPool.loadBalancerPoolMembers not initialized in constructor and dereferenced in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronLoadBalancerPool.addLoadBalancerPoolMember(NeutronLoadBalancerPoolMember) |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
187 |
Low |
| NeutronLoadBalancerPool.loadBalancerPoolMembers not initialized in constructor and dereferenced in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronLoadBalancerPool.removeLoadBalancerPoolMember(NeutronLoadBalancerPoolMember) |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
191 |
Low |
org.opendaylight.netvirt.openstack.netvirt.translator.NeutronLoadBalancerPoolMember
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronLoadBalancerPoolMember.extractFields(List) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
134 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.translator.NeutronNetwork
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronNetwork.extractFields(List) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
219 |
Medium |
| NeutronNetwork.adminStateUp not initialized in constructor and dereferenced in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronNetwork.extractFields(List) |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
227 |
Low |
| NeutronNetwork.adminStateUp not initialized in constructor and dereferenced in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronNetwork.isAdminStateUp() |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
117 |
Low |
| NeutronNetwork.routerExternal not initialized in constructor and dereferenced in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronNetwork.isRouterExternal() |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
142 |
Low |
| NeutronNetwork.shared not initialized in constructor and dereferenced in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronNetwork.extractFields(List) |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
233 |
Low |
| NeutronNetwork.shared not initialized in constructor and dereferenced in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronNetwork.isShared() |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
126 |
Low |
org.opendaylight.netvirt.openstack.netvirt.translator.NeutronRouter
| Bug |
Category |
Details |
Line |
Priority |
| Class org.opendaylight.netvirt.openstack.netvirt.translator.NeutronRouter defines non-transient non-serializable instance field routes |
BAD_PRACTICE |
SE_BAD_FIELD |
|
Medium |
| Switch statement found in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronRouter.extractFields(List) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
151 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.translator.NeutronSecurityGroup
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronSecurityGroup.extractFields(List) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
97 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.translator.NeutronSecurityRule
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronSecurityRule.extractFields(List) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
178 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.translator.NeutronSubnet
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.opendaylight.netvirt.openstack.netvirt.translator.NeutronSubnet.extractFields(List) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
221 |
Medium |
org.opendaylight.netvirt.openstack.netvirt.translator.crud.impl.AbstractNeutronInterface
| Bug |
Category |
Details |
Line |
Priority |
| Exception is caught when Exception is not thrown in org.opendaylight.netvirt.openstack.netvirt.translator.crud.impl.AbstractNeutronInterface.overwrite(Object, Object) |
STYLE |
REC_CATCH_EXCEPTION |
148 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.impl.config.rev160517.NetvirtImplConfigBuilder$NetvirtImplConfigImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.impl.config.rev160517.NetvirtImplConfigBuilder$NetvirtImplConfigImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.impl.config.rev160517.NetvirtImplConfigBuilder$NetvirtImplConfigImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
184 |
Low |
