Checkstyle Results

The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
3 0 25 0

Files

File  I  W  E
org/opendaylight/netvirt/utils/mdsal/utils/MdsalUtilsTest.java 0 9 0
org/opendaylight/netvirt/utils/mdsal/utils/NotifyingDataChangeListener.java 0 16 0

Rules

Category Rule Violations Severity
coding IllegalCatch 1  Warning
imports CustomImportOrder
  • thirdPartyPackageRegExp: ".*"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
 5  Warning
javadoc JavadocStyle
  • checkEmptyJavadoc: "true"
 2  Warning
NonEmptyAtclauseDescription 3  Warning
naming AbbreviationAsWordInName
  • ignoreFinal: "false"
  • allowedAbbreviationLength: "4"
 1  Warning
LocalVariableName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
  • allowOneCharVarInForLoop: "true"
  • tokens: "VARIABLE_DEF"
 3  Warning
MemberName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
 2  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 5  Warning
whitespace WhitespaceAround
  • allowEmptyConstructors: "true"
  • allowEmptyMethods: "true"
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
 1  Warning

Details

org/opendaylight/netvirt/utils/mdsal/utils/MdsalUtilsTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier'. 33
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.util.concurrent.CheckedFuture' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier'. 34
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 36
 Warning javadoc JavadocStyle First sentence should end with a period. 36
 Warning sizes LineLength Line is longer than 120 characters (found 134). 70
 Warning sizes LineLength Line is longer than 120 characters (found 150). 72
 Warning sizes LineLength Line is longer than 120 characters (found 132). 85
 Warning sizes LineLength Line is longer than 120 characters (found 148). 87
 Warning sizes LineLength Line is longer than 120 characters (found 122). 101

org/opendaylight/netvirt/utils/mdsal/utils/NotifyingDataChangeListener.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.HashSet' import. Should be before 'org.slf4j.LoggerFactory'. 21
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. 22
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.Set' import. Should be before 'org.slf4j.LoggerFactory'. 23
 Warning naming MemberName Member name 'RETRY_WAIT' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 37
 Warning naming AbbreviationAsWordInName Abbreviation in name 'MDSAL_TIMEOUT' must contain no more than '4' capital letters. 38
 Warning naming MemberName Member name 'MDSAL_TIMEOUT' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 38
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 42
 Warning javadoc JavadocStyle First sentence should end with a period. 42
 Warning javadoc NonEmptyAtclauseDescription At-clause should have a non-empty description. 44
 Warning whitespace WhitespaceAround WhitespaceAround: 'if' is not followed by whitespace. 53
 Warning javadoc NonEmptyAtclauseDescription At-clause should have a non-empty description. 60
 Warning javadoc NonEmptyAtclauseDescription At-clause should have a non-empty description. 62
 Warning naming LocalVariableName Local variable name '_start' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 114
 Warning naming LocalVariableName Local variable name '_start' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 129
 Warning naming LocalVariableName Local variable name '_start' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 144
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 158