Checkstyle Results
The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. 
InfoFiles
Rules
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | EmptyBlock
|
8 |  Warning |
LeftCurly
|
5 | Warning | |
| NeedBraces | 9 | Warning | |
RightCurly
|
8 | Warning | |
| RightCurly | 8 | Warning | |
| coding | EmptyStatement | 1 | Warning |
| IllegalCatch | 99 | Warning | |
| VariableDeclarationUsageDistance | 10 | Warning | |
| imports | AvoidStarImport | 1 | Warning |
CustomImportOrder
|
176 | Warning | |
| RedundantImport | 19 | Warning | |
| UnusedImports | 57 | Warning | |
| indentation | Indentation
|
171 | Warning |
| javadoc | JavadocParagraph
|
9 | Warning |
JavadocStyle
|
57 | Warning | |
| JavadocTagContinuationIndentation | 6 | Warning | |
| NonEmptyAtclauseDescription | 5 | Warning | |
| misc | ArrayTypeStyle | 1 | Warning |
| modifier | ModifierOrder | 1 | Warning |
| RedundantModifier | 6 | Warning | |
| naming | AbbreviationAsWordInName
|
6 | Warning |
| ConstantName | 9 | Warning | |
LocalVariableName
|
11 | Warning | |
MemberName
|
4 | Warning | |
ParameterName
|
26 | Warning | |
| regexp | RegexpSingleline
|
3 |  Error |
| sizes | LineLength
|
310 | Warning |
| whitespace | EmptyLineSeparator
|
11 | Warning |
FileTabCharacter
|
1 | Error | |
| GenericWhitespace | 6 | Warning | |
| MethodParamPad | 19 | Warning | |
| NoLineWrap | 2 | Warning | |
OperatorWrap
|
63 | Warning | |
SeparatorWrap
|
38 | Warning | |
SeparatorWrap
|
38 | Warning | |
WhitespaceAround
|
118 | Warning |
Details
org/opendaylight/netvirt/vpnmanager/AbstractDataChangeListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.Collections' import. Should be before 'org.slf4j.LoggerFactory'. | 20 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.Map' import. Should be before 'org.slf4j.LoggerFactory'. | 21 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.Set' import. Should be before 'org.slf4j.LoggerFactory'. | 22 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 33 |
| Warning |
javadoc | JavadocStyle | Javadoc has empty description section. | 33 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 34 |
| Warning |
whitespace | EmptyLineSeparator | 'CTOR_DEF' should be separated from previous statement. | 37 |
| Warning |
indentation | Indentation | 'try' child have incorrect indentation level 8, expected level should be 12. | 44 |
| Warning |
indentation | Indentation | 'try' child have incorrect indentation level 8, expected level should be 12. | 47 |
| Warning |
indentation | Indentation | 'try' child have incorrect indentation level 8, expected level should be 12. | 50 |
| Warning |
indentation | Indentation | 'try' child have incorrect indentation level 8, expected level should be 12. | 53 |
| Warning |
indentation | Indentation | 'try' child have incorrect indentation level 8, expected level should be 12. | 56 |
| Warning |
indentation | Indentation | 'try' child have incorrect indentation level 8, expected level should be 12. | 59 |
| Warning |
indentation | Indentation | 'try' child have incorrect indentation level 8, expected level should be 12. | 60 |
| Warning |
indentation | Indentation | 'try' child have incorrect indentation level 8, expected level should be 12. | 61 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 62 |
| Warning |
coding | IllegalCatch | Catching 'Throwable' is not allowed. | 63 |
org/opendaylight/netvirt/vpnmanager/AlivenessMonitorUtils.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.slf4j.LoggerFactory'. | 47 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'gatewayMac' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 67 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 68 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 75 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 80 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 84 |
| Warning |
naming | AbbreviationAsWordInName | Abbreviation in name 'FAILURE_THRESHOLD' must contain no more than '4' capital letters. | 136 |
| Warning |
naming | AbbreviationAsWordInName | Abbreviation in name 'MONITORING_INTERVAL' must contain no more than '4' capital letters. | 136 |
| Warning |
naming | ParameterName | Parameter name 'FAILURE_THRESHOLD' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 136 |
| Warning |
naming | ParameterName | Parameter name 'MONITORING_INTERVAL' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 136 |
| Warning |
naming | AbbreviationAsWordInName | Abbreviation in name 'MONITORING_WINDOW' must contain no more than '4' capital letters. | 137 |
| Warning |
naming | ParameterName | Parameter name 'MONITORING_WINDOW' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 137 |
| Warning |
whitespace | GenericWhitespace | GenericWhitespace '<' is preceded with whitespace. | 147 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 132). | 149 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 151 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'try' is not followed by whitespace. | 156 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 156 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 159 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 141). | 160 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 162 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 165 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 167 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'catch' is not followed by whitespace. | 167 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 145). | 180 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 143). | 181 |
| Warning |
indentation | Indentation | 'method call' child have incorrect indentation level 8, expected level should be 12. | 185 |
| Warning |
indentation | Indentation | '.' have incorrect indentation level 4, expected level should be 8. | 195 |
org/opendaylight/netvirt/vpnmanager/ArpConstants.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 12 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 13 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 14 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 15 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 15 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 16 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 17 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 18 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 19 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 21 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 8, expected level should be 4. | 22 |
org/opendaylight/netvirt/vpnmanager/ArpMonitorEventListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 39 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 44 |
org/opendaylight/netvirt/vpnmanager/ArpMonitorStartTask.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.ListenableFuture' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.rpcs.rev160406.OdlInterfaceRpcService'. | 17 |
org/opendaylight/netvirt/vpnmanager/ArpMonitorStopTask.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.slf4j.LoggerFactory'. | 26 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.ListenableFuture' import. Should be before 'org.slf4j.LoggerFactory'. | 27 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 67 |
org/opendaylight/netvirt/vpnmanager/ArpMonitoringHandler.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - java.math.BigInteger. | 10 |
| Warning |
imports | UnusedImports | Unused import - java.util.ArrayList. | 12 |
| Warning |
imports | UnusedImports | Unused import - java.util.List. | 13 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.genius.mdsalutil.NwConstants. | 22 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.IpAddress. | 26 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.NeutronVpnPortipPortData. | 33 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.neutron.vpn.portip.port.data.VpnPortipToPort. | 34 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.neutron.vpn.portip.port.data.VpnPortipToPortKey. | 35 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.slf4j.LoggerFactory'. | 40 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 126). | 42 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 55 |
| Warning |
whitespace | GenericWhitespace | GenericWhitespace '<' is preceded with whitespace. | 68 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 71 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 101 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 141). | 102 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 107 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 159). | 108 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 118 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 130 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 141 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 160 |
org/opendaylight/netvirt/vpnmanager/ArpNotificationHandler.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.learnt.vpn.vip.to.port.data.LearntVpnVipToPort' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.id.to.vpn.instance.VpnIds'. | 41 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 70 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 79 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 101 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 120 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 130 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 168 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 199 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 205 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 224 |
org/opendaylight/netvirt/vpnmanager/ArpReplyOrRequest.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
whitespace | EmptyLineSeparator | 'METHOD_DEF' should be separated from previous statement. | 32 |
org/opendaylight/netvirt/vpnmanager/ArpUtils.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - java.util.concurrent.ExecutionException. | 15 |
| Warning |
imports | UnusedImports | Unused import - java.util.concurrent.Future. | 16 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.action.types.rev131112.action.list.Action. | 24 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yangtools.yang.common.RpcResult. | 27 |
| Warning |
naming | ConstantName | Name 's_logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 32 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 119 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 142 |
org/opendaylight/netvirt/vpnmanager/CentralizedSwitchChangeListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 132). | 105 |
org/opendaylight/netvirt/vpnmanager/DpnInVpnChangeListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.slf4j.LoggerFactory'. | 32 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.CheckedFuture' import. Should be before 'org.slf4j.LoggerFactory'. | 33 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 53 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 76 |
| Warning |
naming | LocalVariableName | Local variable name 'VpnToDpnId' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 106 |
org/opendaylight/netvirt/vpnmanager/FibEntriesListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. Should be before 'org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase'. | 14 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 61 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 63 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 93 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 95 |
org/opendaylight/netvirt/vpnmanager/InterfaceStateChangeListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase' import. Should be before 'org.opendaylight.genius.datastoreutils.DataStoreJobCoordinator'. | 17 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.router.interfaces.RouterInterface. | 23 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.math.BigInteger' import. Should be before 'org.slf4j.LoggerFactory'. | 27 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. | 28 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. | 29 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.concurrent.Callable' import. Should be before 'org.slf4j.LoggerFactory'. | 30 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 149). | 32 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 135). | 76 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 131). | 85 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 91 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 149). | 92 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 106 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 113 |
| Warning |
indentation | Indentation | 'catch' child have incorrect indentation level 10, expected level should be 12. | 114 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 136). | 136 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 141 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 133). | 142 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 142 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 149 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 161 |
| Warning |
whitespace | OperatorWrap | '||' should be on a new line. | 172 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 173 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 127). | 192 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 127). | 200 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 214 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'catch' is not preceded with whitespace. | 214 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '}' is not followed by whitespace. | 214 |
org/opendaylight/netvirt/vpnmanager/MacEntry.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 69 |
org/opendaylight/netvirt/vpnmanager/SubnetMacHandler.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 9, expected level should be 4. | 50 |
| Warning |
blocks | RightCurly | '}' at column 9 should be alone on a line. | 50 |
| Warning |
blocks | RightCurly | '}' at column 10 should be on a new line. | 50 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '}' is not followed by whitespace. | 50 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '}' is not preceded with whitespace. | 50 |
org/opendaylight/netvirt/vpnmanager/SubnetOpDpnManager.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.subnet.op.data.entry.subnet.to.dpn.VpnInterfacesKey'. | 23 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.PortOpData' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.subnet.op.data.entry.subnet.to.dpn.VpnInterfacesKey'. | 24 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.SubnetOpData' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.subnet.op.data.entry.subnet.to.dpn.VpnInterfacesKey'. | 25 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.SubnetOpDataEntry' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.subnet.op.data.entry.subnet.to.dpn.VpnInterfacesKey'. | 26 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.SubnetOpDataEntryKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.subnet.op.data.entry.subnet.to.dpn.VpnInterfacesKey'. | 27 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.subnet.op.data.entry.SubnetToDpn' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.subnet.op.data.entry.subnet.to.dpn.VpnInterfacesKey'. | 28 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.subnet.op.data.entry.SubnetToDpnBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.subnet.op.data.entry.subnet.to.dpn.VpnInterfacesKey'. | 29 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.subnet.op.data.entry.SubnetToDpnKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.subnet.op.data.subnet.op.data.entry.subnet.to.dpn.VpnInterfacesKey'. | 30 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.math.BigInteger' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier'. | 33 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.slf4j.LoggerFactory'. | 38 |
| Warning |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 42 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 53 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 55 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 58 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 66 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 68 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 69 |
| Warning |
blocks | EmptyBlock | Empty finally block. | 72 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 79 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 81 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '=' is not followed by whitespace. | 81 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 84 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 88 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 90 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 91 |
| Warning |
blocks | EmptyBlock | Empty finally block. | 93 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 101 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 104 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 138). | 114 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 119 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 121 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 122 |
| Warning |
blocks | EmptyBlock | Empty finally block. | 125 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 136 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 128). | 138 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 141 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 151 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 153 |
| Warning |
indentation | Indentation | 'catch' child have incorrect indentation level 10, expected level should be 12. | 154 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 154 |
| Warning |
blocks | EmptyBlock | Empty finally block. | 156 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 163 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 165 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 168 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 138). | 175 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 185 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 186 |
| Warning |
blocks | EmptyBlock | Empty finally block. | 189 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 196 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 199 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 201 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 214 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 216 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 218 |
org/opendaylight/netvirt/vpnmanager/SubnetRouteInterfaceStateChangeListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'java.util.concurrent.Callable'. | 15 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.ListenableFuture' import. Should be before 'java.util.concurrent.Callable'. | 16 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.controller.md.sal.binding.api.WriteTransaction. | 18 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase' import. Should be before 'org.opendaylight.netvirt.vpnmanager.utilities.InterfaceUtils'. | 22 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.port.op.data.PortOpDataEntry. | 27 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yangtools.concepts.ListenerRegistration. | 28 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 134). | 77 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 135). | 78 |
| Warning |
indentation | Indentation | 'configInterface' have incorrect indentation level 32, expected level should be 36. | 79 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 152). | 80 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 131). | 81 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 86 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 131). | 87 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 88 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 150). | 97 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 105 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 142). | 106 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 139). | 122 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 136). | 125 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 131 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 134). | 132 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 132 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 149). | 139 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 146 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 147 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 128). | 155 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 127). | 167 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 172 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 140). | 173 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 147). | 188 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 195 |
org/opendaylight/netvirt/vpnmanager/SubnetRoutePacketInHandler.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - java.util.ArrayList. | 15 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '=' is not followed by whitespace. | 54 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 73 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 141). | 97 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 98 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 161). | 100 |
| Warning |
whitespace | OperatorWrap | '!=' should be on a new line. | 105 |
| Warning |
whitespace | OperatorWrap | '!=' should be on a new line. | 111 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 120 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 131). | 131 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 136 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 161 |
| Warning |
blocks | LeftCurly | '{' at column 5 should be on the previous line. | 184 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'catch' is not followed by whitespace. | 192 |
| Warning |
indentation | Indentation | 'getVpnIdToVpnInstanceIdentifier' have incorrect indentation level 4, expected level should be 8. | 204 |
org/opendaylight/netvirt/vpnmanager/TransactionUtil.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
whitespace | EmptyLineSeparator | ';' should be separated from previous statement. | 38 |
| Warning |
blocks | RightCurly | '}' at column 9 should be alone on a line. | 38 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 49 |
org/opendaylight/netvirt/vpnmanager/TunnelEndPointChangeListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 168). | 103 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 130). | 111 |
org/opendaylight/netvirt/vpnmanager/TunnelInterfaceStateListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.util.*. | 12 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.ListenableFuture' import. Should be before 'java.util.concurrent.Future'. | 16 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. Should be before 'org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase'. | 20 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.huawei.params.xml.ns.yang.l3vpn.rev140815.VpnInstances. | 25 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.huawei.params.xml.ns.yang.l3vpn.rev140815.vpn.instances.VpnInstance. | 26 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.op.rev160406.TunnelOperStatus' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.op.rev160406.TunnelsState'. | 36 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.rpcs.rev160406.IsDcgwPresentInputBuilder. | 38 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.rpcs.rev160406.IsDcgwPresentOutput. | 39 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.fibmanager.rev150330.vrfentries.VrfEntry. | 41 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.op.data.vpn.instance.op.data.entry.VpnToDpnList. | 47 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 54 |
| Warning |
whitespace | EmptyLineSeparator | 'ENUM_DEF' should be separated from previous statement. | 63 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 72 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 72 |
| Warning |
whitespace | EmptyLineSeparator | 'CTOR_DEF' should be separated from previous statement. | 80 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 128). | 140 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 166 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 125). | 182 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 134). | 185 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 189 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 134). | 190 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 132). | 197 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 138). | 200 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 204 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 138). | 205 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 233 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 140). | 235 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 266 |
| Warning |
whitespace | OperatorWrap | '&&' should be on a new line. | 269 |
| Warning |
whitespace | OperatorWrap | '&&' should be on a new line. | 274 |
| Warning |
whitespace | OperatorWrap | '&&' should be on a new line. | 289 |
| Warning |
whitespace | OperatorWrap | '&&' should be on a new line. | 292 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 311 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 347 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 348 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 351 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 127). | 352 |
| Warning |
whitespace | MethodParamPad | '(' is preceded with whitespace. | 361 |
org/opendaylight/netvirt/vpnmanager/VpnConstants.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
indentation | Indentation | 'array initialization' child have incorrect indentation level 12, expected level should be one of the following: 8, 70, 72. | 41 |
| Warning |
whitespace | EmptyLineSeparator | 'ENUM_DEF' should be separated from previous statement. | 43 |
| Warning |
blocks | LeftCurly | '{' at column 34 should have line break after. | 47 |
| Warning |
blocks | RightCurly | '}' at column 52 should be alone on a line. | 47 |
| Warning |
whitespace | EmptyLineSeparator | 'METHOD_DEF' should be separated from previous statement. | 48 |
| Warning |
blocks | LeftCurly | '{' at column 31 should have line break after. | 48 |
| Warning |
blocks | RightCurly | '}' at column 46 should be alone on a line. | 48 |
| Warning |
whitespace | EmptyLineSeparator | 'ENUM_DEF' should be separated from previous statement. | 50 |
| Warning |
blocks | LeftCurly | '{' at column 35 should have line break after. | 54 |
| Warning |
blocks | RightCurly | '}' at column 55 should be alone on a line. | 54 |
| Warning |
whitespace | EmptyLineSeparator | 'METHOD_DEF' should be separated from previous statement. | 55 |
| Warning |
blocks | LeftCurly | '{' at column 31 should have line break after. | 55 |
| Warning |
blocks | RightCurly | '}' at column 48 should be alone on a line. | 55 |
org/opendaylight/netvirt/vpnmanager/VpnFootprintService.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 75 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 76 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 239 |
| Warning |
javadoc | JavadocStyle | Javadoc has empty description section. | 246 |
| Warning |
javadoc | JavadocStyle | Javadoc has empty description section. | 259 |
| Warning |
javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 263 |
| Warning |
javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 264 |
| Warning |
javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 265 |
org/opendaylight/netvirt/vpnmanager/VpnInstanceListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.controller.md.sal.binding.api.DataChangeListener. | 20 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.WriteTransaction' import. Should be before 'org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase'. | 22 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. Should be before 'org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase'. | 23 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException' import. Should be before 'org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase'. | 24 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 87 |
| Warning |
blocks | EmptyBlock | Empty catch block. | 125 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 153). | 154 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 176). | 158 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 164). | 162 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 176 |
| Warning |
whitespace | EmptyLineSeparator | 'METHOD_DEF' should be separated from previous statement. | 183 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 199 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 219 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 249 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 255 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 269 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 314 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 151). | 356 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 151). | 357 |
| Warning |
indentation | Indentation | 'else' child have incorrect indentation level 13, expected level should be 12. | 370 |
| Warning |
indentation | Indentation | 'else' child have incorrect indentation level 13, expected level should be 12. | 383 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 393 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 399 |
| Warning |
indentation | Indentation | 'else' child have incorrect indentation level 17, expected level should be 16. | 412 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 193). | 420 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 143). | 426 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 127). | 427 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 428 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 140). | 429 |
| Warning |
indentation | Indentation | 'else' child have incorrect indentation level 17, expected level should be 16. | 442 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 455 |
| Warning |
javadoc | JavadocStyle | Javadoc has empty description section. | 460 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 503 |
| Warning |
javadoc | JavadocStyle | Javadoc has empty description section. | 516 |
| Warning |
javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 520 |
| Warning |
javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 521 |
| Warning |
javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 522 |
| Warning |
whitespace | OperatorWrap | '||' should be on a new line. | 537 |
| Warning |
whitespace | OperatorWrap | '||' should be on a new line. | 538 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 551 |
org/opendaylight/netvirt/vpnmanager/VpnInterfaceManager.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - com.google.common.util.concurrent.FutureCallback. | 16 |
| Warning |
imports | UnusedImports | Unused import - com.google.common.util.concurrent.Futures. | 17 |
| Warning |
imports | UnusedImports | Unused import - com.google.common.util.concurrent.JdkFutureAdapters. | 18 |
| Warning |
imports | UnusedImports | Unused import - java.util.Set. | 29 |
| Warning |
imports | UnusedImports | Unused import - java.util.concurrent.Future. | 36 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.PhysAddress. | 67 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.arputil.rev160406.SendArpResponseInput. | 72 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.arputil.rev160406.SendArpResponseInputBuilder. | 73 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.learnt.vpn.vip.to.port.data.LearntVpnVipToPort' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ext.routers.Routers'. | 110 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yangtools.yang.common.RpcResult. | 116 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 170). | 192 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 140). | 194 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 130). | 204 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 134). | 221 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 227 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 271 |
| Warning |
naming | ParameterName | Parameter name 'lPortTag' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 276 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 298 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 144). | 305 |
| Warning |
blocks | EmptyBlock | Empty catch block. | 354 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 363 |
| Warning |
naming | ParameterName | Parameter name 'lPortTag' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 382 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'adjacencies' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 420 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 429 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 439 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 150). | 452 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 149). | 454 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 455 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'catch' is not followed by whitespace. | 455 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 464 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 476 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 493 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'catch' is not followed by whitespace. | 493 |
| Warning |
naming | ParameterName | Parameter name 'lPortTag' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 503 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 517 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 131). | 518 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 131). | 522 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 137). | 523 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 188). | 526 |
| Warning |
naming | ParameterName | Parameter name 'lPortTag' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 534 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 557 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 562 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 160). | 576 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 149). | 611 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 158). | 637 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 129). | 707 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 142). | 711 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 128). | 715 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 142). | 719 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 730 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 785 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 157). | 786 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 128). | 794 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 142). | 798 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 809 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 129). | 847 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 853 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 854 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 125). | 878 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 883 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 884 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 175). | 897 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 189). | 902 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 174). | 907 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 909 |
| Warning |
whitespace | OperatorWrap | '||' should be on a new line. | 909 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 923 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 133). | 925 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 950 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 175). | 956 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 961 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 251). | 962 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 130). | 976 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '!=' is not preceded with whitespace. | 979 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 984 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'catch' is not followed by whitespace. | 984 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 134). | 999 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 1001 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'try' is not followed by whitespace. | 1002 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 1002 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 1004 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'catch' is not preceded with whitespace. | 1004 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '}' is not followed by whitespace. | 1004 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 1004 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 1021 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 1026 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 125). | 1033 |
| Warning |
naming | ParameterName | Parameter name 'lPortTag' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 1059 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 1069 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 1069 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 139). | 1070 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'else' is not preceded with whitespace. | 1072 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '}' is not followed by whitespace. | 1072 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'else' is not followed by whitespace. | 1072 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 1072 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 1075 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 1075 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 129). | 1076 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'else' is not preceded with whitespace. | 1086 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '}' is not followed by whitespace. | 1086 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'else' is not followed by whitespace. | 1086 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 1086 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 135). | 1087 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 1095 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 1095 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 153). | 1096 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'else' is not preceded with whitespace. | 1098 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '}' is not followed by whitespace. | 1098 |
| Warning |
naming | ParameterName | Parameter name 'lPortTag' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 1104 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 131). | 1145 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 166). | 1155 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 137). | 1156 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 1169 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 1180 |
| Warning |
naming | ParameterName | Parameter name 'lPortTag' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 1201 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 1202 |
| Warning |
naming | ParameterName | Parameter name 'lPortTag' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 1212 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 133). | 1222 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 1255 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'catch' is not followed by whitespace. | 1255 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 134). | 1261 |
| Warning |
whitespace | OperatorWrap | '?' should be on a new line. | 1269 |
| Warning |
whitespace | OperatorWrap | '?' should be on a new line. | 1272 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 137). | 1283 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 129). | 1331 |
| Warning |
naming | LocalVariableName | Local variable name 'max_wait_time' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 1331 |
| Warning |
naming | LocalVariableName | Local variable name 'wait_time' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 1332 |
| Warning |
blocks | EmptyBlock | Empty catch block. | 1338 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 126). | 1355 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 146). | 1360 |
| Warning |
whitespace | OperatorWrap | '?' should be on a new line. | 1364 |
| Warning |
whitespace | OperatorWrap | '?' should be on a new line. | 1367 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 1378 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 183). | 1396 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 126). | 1401 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 126). | 1434 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 1465 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 130). | 1484 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 159). | 1489 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 175). | 1491 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 147). | 1492 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 127). | 1496 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 1509 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 1514 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 1523 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 129). | 1528 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 186). | 1533 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 215). | 1549 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 167). | 1564 |
| Warning |
indentation | Indentation | 'for' child have incorrect indentation level 19, expected level should be 20. | 1570 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 185). | 1577 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: ':' is not followed by whitespace. | 1590 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 1646 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 141). | 1678 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 1681 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 148). | 1699 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 1739 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 1741 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 134). | 1742 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 162). | 1749 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 126). | 1766 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 1768 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 135). | 1769 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 166). | 1777 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 1792 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 1803 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 135). | 1804 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 166). | 1812 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 135). | 1825 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 126). | 1925 |
| Warning |
whitespace | MethodParamPad | '(' is preceded with whitespace. | 1925 |
| Warning |
modifier | RedundantModifier | Redundant 'public' modifier. | 1950 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1967 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1969 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1971 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1975 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1977 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1980 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 1982 |
org/opendaylight/netvirt/vpnmanager/VpnInterfaceOpListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - com.google.common.util.concurrent.CheckedFuture. | 11 |
| Warning |
imports | UnusedImports | Unused import - java.util.concurrent.ConcurrentHashMap. | 16 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.WriteTransaction' import. Should be before 'org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase'. | 21 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. Should be before 'org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase'. | 22 |
| Warning |
blocks | NeedBraces | 'if' construct must use '{}'s. | 134 |
org/opendaylight/netvirt/vpnmanager/VpnManagerImpl.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
naming | ParameterName | Parameter name 'lPortTag' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 234 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 252 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 264 |
org/opendaylight/netvirt/vpnmanager/VpnNodeListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 127). | 40 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 50 |
| Warning |
naming | AbbreviationAsWordInName | Abbreviation in name 'COOKIE_TABLE_MISS' must contain no more than '4' capital letters. | 109 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 167). | 111 |
| Warning |
naming | AbbreviationAsWordInName | Abbreviation in name 'COOKIE_TABLE_MISS' must contain no more than '4' capital letters. | 128 |
| Warning |
whitespace | GenericWhitespace | GenericWhitespace '<' is preceded with whitespace. | 131 |
| Warning |
whitespace | GenericWhitespace | GenericWhitespace '<' is preceded with whitespace. | 131 |
| Warning |
whitespace | MethodParamPad | '(' is preceded with whitespace. | 131 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 127). | 135 |
| Warning |
naming | AbbreviationAsWordInName | Abbreviation in name 'COOKIE_TABLE_MISS' must contain no more than '4' capital letters. | 150 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 158 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 177). | 169 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 137). | 170 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 133). | 173 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 3, expected level should be 4. | 177 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 209). | 190 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 142). | 191 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 137). | 194 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 3, expected level should be 4. | 197 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 136). | 205 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 137). | 206 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 136). | 209 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 3, expected level should be 4. | 212 |
org/opendaylight/netvirt/vpnmanager/VpnNotifyTask.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 14 |
| Warning |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 15 |
org/opendaylight/netvirt/vpnmanager/VpnOpDataSyncer.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.collect.ImmutableMap' import. Should be before 'org.slf4j.LoggerFactory'. | 23 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 25 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 25 |
| Warning |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 32 |
| Warning |
naming | ConstantName | Name 'threadFactory' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 51 |
org/opendaylight/netvirt/vpnmanager/VpnRpcServiceImpl.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.vpn.rpc.rev160201.AddStaticRouteOutput' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.vpn.rpc.rev160201.AddStaticRouteOutputBuilder'. | 22 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. | 37 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.Collection' import. Should be before 'org.slf4j.LoggerFactory'. | 38 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.concurrent.Future' import. Should be before 'org.slf4j.LoggerFactory'. | 39 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 50 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 63 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 63 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 87 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 87 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 166 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 232 |
org/opendaylight/netvirt/vpnmanager/VpnSubnetRouteHandler.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 61 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 147). | 107 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 107 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 119 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 127 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 127). | 129 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 143). | 131 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 136 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 142 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 146 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'subOpEntry' declaration and its first usage is 11, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 148 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 130). | 153 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 130). | 158 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 175 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 131). | 182 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 187 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 125). | 208 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 158). | 217 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 220 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 227 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 228 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'else' is not preceded with whitespace. | 232 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '}' is not followed by whitespace. | 232 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'else' is not followed by whitespace. | 232 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 232 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 240 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 241 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 246 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 264 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 271 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 281 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 128). | 291 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 291 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 144). | 305 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 310 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 311 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 314 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 315 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 320 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 134). | 321 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 337 |
| Warning |
coding | EmptyStatement | Empty statement. | 352 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 370 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 130). | 376 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 376 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 389 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 396 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 404 |
| Warning |
whitespace | OperatorWrap | '||' should be on a new line. | 421 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 188). | 428 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 431 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 438 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 439 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 439 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 445 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 447 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 448 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 453 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 128). | 464 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 132). | 475 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 129). | 478 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 480 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 134). | 485 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 485 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 129). | 500 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 509 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 134). | 510 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 510 |
| Warning |
indentation | Indentation | 'subnetId' have incorrect indentation level 34, expected level should be 36. | 511 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 142). | 517 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 198). | 524 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 130). | 527 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 534 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 535 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 536 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 133). | 545 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 546 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 547 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 552 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 553 |
| Warning |
indentation | Indentation | 'if' child have incorrect indentation level 12, expected level should be 16. | 571 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 578 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 583 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'subOpBuilder' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 588 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 130). | 606 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 191). | 612 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 615 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 616 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 622 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 623 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 630 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 631 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 636 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 141). | 637 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 658 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 660 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 666 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 135). | 681 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 690 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 126). | 691 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 691 |
| Warning |
indentation | Indentation | 'subnetId' have incorrect indentation level 34, expected level should be 36. | 692 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 142). | 698 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 206). | 704 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 130). | 707 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 708 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 714 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 135). | 715 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 715 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 725 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 726 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 731 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 143). | 732 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 750 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 756 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 756 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 130). | 767 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 132). | 774 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 775 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 781 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'catch' is not followed by whitespace. | 781 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 147). | 782 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 782 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 144). | 790 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 793 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 794 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 799 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 125). | 800 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 810 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 816 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 816 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 149). | 827 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 830 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 831 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 836 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 127). | 837 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 850 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 235). | 855 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 856 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 861 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 885 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 916 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 180). | 917 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 931 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 131). | 932 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 932 |
org/opendaylight/netvirt/vpnmanager/VpnUtil.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - java.util.LinkedList. | 17 |
| Warning |
imports | UnusedImports | Unused import - java.util.Objects. | 19 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.genius.mdsalutil.NWUtil' import. Should be before 'org.opendaylight.genius.mdsalutil.NwConstants'. | 36 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.genius.mdsalutil.NWUtil. | 36 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.genius.utils.clustering.ClusteringUtils' import. Should be before 'org.opendaylight.netvirt.fibmanager.api.RouteOrigin'. | 41 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.netvirt.neutronvpn.api.utils.NeutronConstants. | 42 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeId. | 78 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.Nodes. | 79 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.Node. | 80 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeBuilder. | 81 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.nodes.NodeKey. | 82 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.fibmanager.rev150330.VrfEntries. | 87 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.fibmanager.rev150330.fibentries.VrfTablesBuilder. | 89 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.LearntVpnVipToPortData' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.RouterInterfaces'. | 100 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.learnt.vpn.vip.to.port.data.LearntVpnVipToPort' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.to.extraroute.vpn.ExtrarouteKey'. | 126 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.learnt.vpn.vip.to.port.data.LearntVpnVipToPortBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.to.extraroute.vpn.ExtrarouteKey'. | 127 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.learnt.vpn.vip.to.port.data.LearntVpnVipToPortKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.to.extraroute.vpn.ExtrarouteKey'. | 128 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.fibmanager.rev150330.FibEntries' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 138 |
| Warning |
imports | RedundantImport | Duplicate import to line 86 - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.fibmanager.rev150330.FibEntries. | 138 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.fibmanager.rev150330.fibentries.VrfTables' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 139 |
| Warning |
imports | RedundantImport | Duplicate import to line 88 - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.fibmanager.rev150330.fibentries.VrfTables. | 139 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.fibmanager.rev150330.fibentries.VrfTablesKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 140 |
| Warning |
imports | RedundantImport | Duplicate import to line 90 - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.fibmanager.rev150330.fibentries.VrfTablesKey. | 140 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.IdPools' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 141 |
| Warning |
imports | RedundantImport | Duplicate import to line 63 - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.IdPools. | 141 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.id.pools.IdPool' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 142 |
| Warning |
imports | RedundantImport | Duplicate import to line 66 - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.id.pools.IdPool. | 142 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.id.pools.IdPoolKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 143 |
| Warning |
imports | RedundantImport | Duplicate import to line 67 - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.id.pools.IdPoolKey. | 143 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.FlowCapableNodeConnector' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 144 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.flow.inventory.rev130819.FlowCapableNodeConnector. | 144 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.AllocateIdInput' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 145 |
| Warning |
imports | RedundantImport | Duplicate import to line 59 - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.AllocateIdInput. | 145 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.AllocateIdInputBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 146 |
| Warning |
imports | RedundantImport | Duplicate import to line 60 - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.AllocateIdInputBuilder. | 146 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.AllocateIdOutput' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 147 |
| Warning |
imports | RedundantImport | Duplicate import to line 61 - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.AllocateIdOutput. | 147 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.ReleaseIdInput' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 148 |
| Warning |
imports | RedundantImport | Duplicate import to line 64 - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.ReleaseIdInput. | 148 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.ReleaseIdInputBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 149 |
| Warning |
imports | RedundantImport | Duplicate import to line 65 - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.ReleaseIdInputBuilder. | 149 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.IdManagerService' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 150 |
| Warning |
imports | RedundantImport | Duplicate import to line 62 - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.IdManagerService. | 150 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.meta.rev160406.IfIndexesInterfaceMap' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 151 |
| Warning |
imports | RedundantImport | Duplicate import to line 68 - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.meta.rev160406.IfIndexesInterfaceMap. | 151 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.meta.rev160406._if.indexes._interface.map.IfIndexInterface' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 152 |
| Warning |
imports | RedundantImport | Duplicate import to line 69 - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.meta.rev160406._if.indexes._interface.map.IfIndexInterface. | 152 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.meta.rev160406._if.indexes._interface.map.IfIndexInterfaceKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 153 |
| Warning |
imports | RedundantImport | Duplicate import to line 70 - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.meta.rev160406._if.indexes._interface.map.IfIndexInterfaceKey. | 153 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.rpcs.rev160406.GetPortFromInterfaceInputBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 154 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.rpcs.rev160406.GetPortFromInterfaceInputBuilder. | 154 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.rpcs.rev160406.GetPortFromInterfaceOutput' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 155 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.rpcs.rev160406.GetPortFromInterfaceOutput. | 155 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.rpcs.rev160406.OdlInterfaceRpcService' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 156 |
| Warning |
imports | RedundantImport | Duplicate import to line 71 - org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.rpcs.rev160406.OdlInterfaceRpcService. | 156 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3nexthop.rev150409.L3nexthop' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 157 |
| Warning |
imports | RedundantImport | Duplicate import to line 93 - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3nexthop.rev150409.L3nexthop. | 157 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3nexthop.rev150409.l3nexthop.VpnNexthops' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 158 |
| Warning |
imports | RedundantImport | Duplicate import to line 94 - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3nexthop.rev150409.l3nexthop.VpnNexthops. | 158 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3nexthop.rev150409.l3nexthop.VpnNexthopsKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.napt.switches.RouterToNaptSwitchKey'. | 159 |
| Warning |
imports | RedundantImport | Duplicate import to line 95 - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3nexthop.rev150409.l3nexthop.VpnNexthopsKey. | 159 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.neutron.vpn.portip.port.data.VpnPortipToPortBuilder. | 164 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.ports.rev150712.port.attributes.FixedIps. | 169 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.ports.rev150712.ports.attributes.Ports. | 170 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.ports.rev150712.ports.attributes.ports.PortKey. | 172 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.slf4j.LoggerFactory'. | 184 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.primitives.Ints' import. Should be before 'org.slf4j.LoggerFactory'. | 185 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.CheckedFuture' import. Should be before 'org.slf4j.LoggerFactory'. | 186 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.FutureCallback' import. Should be before 'org.slf4j.LoggerFactory'. | 187 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.Futures' import. Should be before 'org.slf4j.LoggerFactory'. | 188 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.ListenableFuture' import. Should be before 'org.slf4j.LoggerFactory'. | 189 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 138). | 206 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 207 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 247 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 247 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 261 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 261 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 299 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 299 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 332 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 367 |
| Warning |
naming | ParameterName | Parameter name 'lPortTag' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 435 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 475 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 475 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 135). | 498 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 134). | 500 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 510 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 510 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 135). | 518 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 134). | 520 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 530 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 530 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 550 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 550 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 566 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 604 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 135). | 618 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 134). | 621 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 154). | 622 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 149). | 626 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 627 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 127). | 635 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 137). | 640 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 129). | 643 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 161). | 644 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 130). | 656 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 129). | 658 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 690 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 123). | 707 |
| Warning |
naming | LocalVariableName | Local variable name 'RouterInterfacesMap' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 707 |
| Warning |
indentation | Indentation | 'if' child have incorrect indentation level 14, expected level should be 12. | 709 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 198). | 709 |
| Warning |
indentation | Indentation | 'for' have incorrect indentation level 14, expected level should be 12. | 710 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 164). | 710 |
| Warning |
indentation | Indentation | 'for' child have incorrect indentation level 18, expected level should be 16. | 711 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 188). | 711 |
| Warning |
indentation | Indentation | 'for' have incorrect indentation level 18, expected level should be 16. | 712 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 163). | 712 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 712 |
| Warning |
indentation | Indentation | 'if' have incorrect indentation level 22, expected level should be 20. | 713 |
| Warning |
indentation | Indentation | 'if' child have incorrect indentation level 26, expected level should be 24. | 714 |
| Warning |
indentation | Indentation | 'if rcurly' have incorrect indentation level 22, expected level should be 20. | 715 |
| Warning |
indentation | Indentation | 'for rcurly' have incorrect indentation level 18, expected level should be 16. | 716 |
| Warning |
indentation | Indentation | 'for rcurly' have incorrect indentation level 14, expected level should be 12. | 717 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 744 |
| Warning |
misc | ArrayTypeStyle | Array brackets at illegal position. | 756 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 16, expected level should be one of the following: 8, 12. | 765 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 20, expected level should be one of the following: 12, 16. | 767 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 16, expected level should be one of the following: 8, 12. | 768 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 16, expected level should be one of the following: 8, 12. | 770 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 20, expected level should be one of the following: 12, 16. | 772 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 16, expected level should be one of the following: 8, 12. | 773 |
| Warning |
indentation | Indentation | 'object def rcurly' have incorrect indentation level 12, expected level should be one of the following: 4, 8. | 776 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 786 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 126). | 801 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 125). | 813 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 825 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 127). | 876 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 915 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 927 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 927 |
| Warning |
indentation | Indentation | 'getVpnToDpnInterfacePath' have incorrect indentation level 4, expected level should be 8. | 937 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 129). | 946 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 126). | 959 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 962 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 121). | 972 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 978 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 992 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 1005 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 1018 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 128). | 1028 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 127). | 1031 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 1034 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 129). | 1044 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 128). | 1047 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 1050 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 1057 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 132). | 1059 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 1074 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 1077 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 125). | 1082 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 1084 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 1098 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 1150 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 1159 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 126). | 1190 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '!=' is not followed by whitespace. | 1195 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 139). | 1255 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 1255 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not followed by whitespace. | 1255 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 1255 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not followed by whitespace. | 1255 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 1255 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not followed by whitespace. | 1255 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 1255 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not followed by whitespace. | 1255 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 1255 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not followed by whitespace. | 1255 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 1255 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '+' is not followed by whitespace. | 1255 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 136). | 1259 |
| Warning |
indentation | Indentation | 'if' child have incorrect indentation level 20, expected level should be 16. | 1264 |
| Warning |
whitespace | GenericWhitespace | GenericWhitespace '<' is preceded with whitespace. | 1291 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 149). | 1295 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 132). | 1296 |
| Warning |
whitespace | GenericWhitespace | GenericWhitespace '<' is preceded with whitespace. | 1306 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 127). | 1308 |
| Warning |
indentation | Indentation | 'vpnIdsInstanceIdentifier' have incorrect indentation level 8, expected level should be 12. | 1309 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 132). | 1310 |
| Warning |
indentation | Indentation | '=' have incorrect indentation level 8, expected level should be 12. | 1311 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 142). | 1321 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 1322 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '!=' is not preceded with whitespace. | 1364 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 152). | 1376 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 139). | 1378 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 154). | 1379 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 151). | 1381 |
org/opendaylight/netvirt/vpnmanager/arp/responder/ArpResponderConstant.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 12 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 12 |
| Warning |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 14 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 18 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 18 |
| Warning |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 20 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 24 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 24 |
| Warning |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 26 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 30 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 30 |
| Warning |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 32 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 39 |
| Warning |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 41 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 45 |
| Warning |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 47 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 52 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 52 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 57 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 57 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 67 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 67 |
org/opendaylight/netvirt/vpnmanager/arp/responder/ArpResponderUtil.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 51 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 51 |
| Warning |
modifier | ModifierOrder | 'static' modifier out of order with the JLS suggestions. | 58 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 63 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 63 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 70 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 70 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 99 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 99 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 118 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 118 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 152 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 152 |
| Warning |
naming | ParameterName | Parameter name 'lPortTag' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 175 |
| Warning |
naming | LocalVariableName | Local variable name 'mIndex' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 179 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 201 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 201 |
| Warning |
javadoc | JavadocParagraph | Empty line should be followed by <p> tag on the next line. | 203 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 132). | 242 |
| Warning |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 263 |
| Warning |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 264 |
| Warning |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 265 |
| Warning |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 266 |
| Warning |
javadoc | NonEmptyAtclauseDescription | At-clause should have a non-empty description. | 267 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 305 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 305 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 340 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 340 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 362 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 362 |
| Warning |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 364 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 378 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 378 |
| Warning |
javadoc | JavadocParagraph | <p> tag should be preceded with an empty line. | 380 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 398 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 398 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 424 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 424 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 132). | 447 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 132). | 452 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 125). | 478 |
org/opendaylight/netvirt/vpnmanager/cache/listeners/VpnOpInstanceCacheManager.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.genius.datastoreutils.AsyncClusteredDataChangeListenerBase' import. Should be before 'org.opendaylight.netvirt.vpnmanager.VpnConstants'. | 16 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.genius.utils.cache.DataStoreCache' import. Should be before 'org.opendaylight.netvirt.vpnmanager.VpnConstants'. | 17 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 25 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 25 |
| Warning |
naming | ConstantName | Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 36 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 50 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 60 |
org/opendaylight/netvirt/vpnmanager/intervpnlink/IVpnLinkServiceImpl.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 12, expected level should be 8. | 273 |
org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkCacheFeeder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.AsyncDataBroker.DataChangeScope' import. Should be before 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType'. | 16 |
| Warning |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 35 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 48 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 59 |
org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. Should be before 'org.opendaylight.genius.datastoreutils.InvalidJobException'. | 27 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.netvirt.vpnmanager.VpnOpDataSyncer' import. Should be before 'org.opendaylight.netvirt.vpnmanager.intervpnlink.tasks.InterVpnLinkRemoverTask'. | 43 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 187 |
| Warning |
whitespace | OperatorWrap | '+' should be on a new line. | 200 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'iVpnLink' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 223 |
| Warning |
naming | LocalVariableName | Local variable name 'iVpnLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 223 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 133). | 298 |
| Warning |
blocks | RightCurly | '}' at column 13 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). | 358 |
| Warning |
naming | LocalVariableName | Local variable name 'iVpnLinkName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 403 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 425 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 521 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 521 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 530 |
org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkLocator.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
whitespace | OperatorWrap | '||' should be on a new line. | 145 |
org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkNodeAddTask.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
indentation | Indentation | 'if' child have incorrect indentation level 11, expected level should be 12. | 86 |
| Warning |
indentation | Indentation | 'if' child have incorrect indentation level 11, expected level should be 12. | 87 |
| Warning |
indentation | Indentation | 'if' child have incorrect indentation level 11, expected level should be 12. | 88 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 128). | 115 |
org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkNodeListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.WriteTransaction' import. Should be before 'org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase'. | 15 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. Should be before 'org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase'. | 16 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException' import. Should be before 'org.opendaylight.genius.datastoreutils.AsyncDataTreeChangeListenerBase'. | 17 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Uri' import. Should be before 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node'. | 28 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.inter.vpn.link.rev160311.inter.vpn.link.states.InterVpnLinkState' import. Should be before 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node'. | 29 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.inter.vpn.link.rev160311.inter.vpn.links.InterVpnLink' import. Should be before 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node'. | 30 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.inter.vpn.link.rev160311.inter.vpn.links.InterVpnLinkBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node'. | 31 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.math.BigInteger' import. Should be before 'org.slf4j.LoggerFactory'. | 36 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. | 37 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. | 38 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.concurrent.Callable' import. Should be before 'org.slf4j.LoggerFactory'. | 39 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 41 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 41 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 72 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 87 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 102 |
| Warning |
whitespace | EmptyLineSeparator | 'METHOD_DEF' should be separated from previous statement. | 125 |
org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkStateCacheFeeder.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.AsyncDataBroker.DataChangeScope' import. Should be before 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType'. | 16 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.inter.vpn.link.rev160311.InterVpnLinks. | 20 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.inter.vpn.link.rev160311.inter.vpn.links.InterVpnLink. | 22 |
| Warning |
naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 37 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 52 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 63 |
org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkStateListener.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 23 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 23 |
org/opendaylight/netvirt/vpnmanager/intervpnlink/InterVpnLinkUtil.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.ListenableFuture' import. Should be before 'org.slf4j.LoggerFactory'. | 52 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.math.BigInteger' import. Should be before 'org.slf4j.LoggerFactory'. | 53 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. | 54 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.Arrays' import. Should be before 'org.slf4j.LoggerFactory'. | 55 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.Collections' import. Should be before 'org.slf4j.LoggerFactory'. | 56 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. | 57 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.stream.Collectors' import. Should be before 'org.slf4j.LoggerFactory'. | 58 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 69 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 69 |
| Warning |
naming | ParameterName | Parameter name 'iVpnLinkName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 76 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 82 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 82 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 138 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 153 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 153 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 191 |
| Warning |
naming | ParameterName | Parameter name 'lPortTagOfOtherEndpoint' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 213 |
| Warning |
naming | LocalVariableName | Local variable name 'lPortDispatcherFlow' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 218 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 226 |
| Warning |
naming | LocalVariableName | Local variable name 'lPortDispatcherFlow' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 243 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 250 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 250 |
| Warning |
whitespace | MethodParamPad | '(' is preceded with whitespace. | 271 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 282 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 282 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 299 |
| Warning |
naming | ParameterName | Parameter name 'iVpnLinkName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 307 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 311 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 311 |
| Warning |
naming | ParameterName | Parameter name 'iVpnLinkName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 318 |
| Warning |
naming | LocalVariableName | Local variable name 'iVpnLinkState' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 323 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 346 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 367 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 367 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 383 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 383 |
| Warning |
javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 405 |
| Warning |
javadoc | JavadocStyle | First sentence should end with a period. | 405 |
| Warning |
naming | LocalVariableName | Local variable name 'iVpnLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 415 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 507 |
| Warning |
naming | ParameterName | Parameter name 'iVpnLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 517 |
| Warning |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 545 |
org/opendaylight/netvirt/vpnmanager/intervpnlink/tasks/InterVpnLinkCleanedCheckerTask.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
naming | MemberName | Member name 'iVpnLinkToCheck' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 40 |
| Warning |
naming | ParameterName | Parameter name 'iVpnLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 44 |
| Warning |
naming | ParameterName | Parameter name 'iVpnLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 52 |
| Warning |
naming | ParameterName | Parameter name 'iVpnLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 56 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '-' is not preceded with whitespace. | 82 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: '-' is not followed by whitespace. | 82 |
org/opendaylight/netvirt/vpnmanager/intervpnlink/tasks/InterVpnLinkCreatorTask.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
naming | MemberName | Member name 'iVpnLinkToPersist' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 28 |
| Warning |
naming | ParameterName | Parameter name 'iVpnLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 31 |
| Warning |
naming | ParameterName | Parameter name 'iVpnLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 37 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 124). | 43 |
org/opendaylight/netvirt/vpnmanager/intervpnlink/tasks/InterVpnLinkRemoverTask.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | UnusedImports | Unused import - java.util.concurrent.Callable. | 14 |
| Warning |
imports | UnusedImports | Unused import - org.opendaylight.genius.mdsalutil.MDSALUtil. | 21 |
| Warning |
naming | MemberName | Member name 'iVpnLinkIid' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 31 |
| Warning |
naming | MemberName | Member name 'iVpnLinkName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 32 |
| Warning |
naming | ParameterName | Parameter name 'iVpnLinkPath' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 36 |
| Warning |
naming | ParameterName | Parameter name 'iVpnLinkPath' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 40 |
org/opendaylight/netvirt/vpnmanager/test/MockDataChangedEvent.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
indentation | Indentation | 'member def type' have incorrect indentation level 2, expected level should be 4. | 19 |
| Warning |
indentation | Indentation | 'member def type' have incorrect indentation level 2, expected level should be 4. | 20 |
| Warning |
indentation | Indentation | 'member def type' have incorrect indentation level 2, expected level should be 4. | 21 |
| Warning |
indentation | Indentation | 'member def type' have incorrect indentation level 2, expected level should be 4. | 22 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 24 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 6, expected level should be 8. | 26 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 27 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 29 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 6, expected level should be 8. | 31 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 32 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 34 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 6, expected level should be 8. | 36 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 37 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 39 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 6, expected level should be 8. | 41 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 42 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 44 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 6, expected level should be 8. | 46 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 47 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 49 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 6, expected level should be 8. | 51 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 52 |
org/opendaylight/netvirt/vpnmanager/test/SubnetOpDpnManagerTest.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.math.BigInteger' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier'. | 41 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier'. | 42 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier'. | 43 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Matchers.any' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 45 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Mockito.verify' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 46 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Mockito.doReturn' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 47 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Mockito.when' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 48 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 62 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 65 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 104 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 106 |
org/opendaylight/netvirt/vpnmanager/test/VpnServiceTest.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataBroker' import. Should be before 'org.opendaylight.netvirt.bgpmanager.api.IBgpManager'. | 19 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataChangeListener' import. Should be before 'org.opendaylight.netvirt.bgpmanager.api.IBgpManager'. | 20 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.AsyncDataBroker.DataChangeScope' import. Should be before 'org.opendaylight.netvirt.bgpmanager.api.IBgpManager'. | 21 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. Should be before 'org.opendaylight.netvirt.bgpmanager.api.IBgpManager'. | 22 |
| Warning |
whitespace | NoLineWrap | import statement should not be line-wrapped. | 25 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.huawei.params.xml.ns.yang.l3vpn.rev140815.VpnInstances' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier.InstanceIdentifierBuilder'. | 37 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.huawei.params.xml.ns.yang.l3vpn.rev140815.vpn.af.config.ApplyLabelBuilder' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier.InstanceIdentifierBuilder'. | 38 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.huawei.params.xml.ns.yang.l3vpn.rev140815.vpn.instances.vpn.instance.Ipv4FamilyBuilder' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier.InstanceIdentifierBuilder'. | 39 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier.InstanceIdentifierBuilder'. | 41 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier.InstanceIdentifierBuilder'. | 42 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 82 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 7, expected level should be 8. | 90 |
| Warning |
regexp | RegexpSingleline | Line has trailing spaces. | 90 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 7, expected level should be 8. | 92 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 7, expected level should be 8. | 93 |
org/opendaylight/netvirt/vpnmanager/test/VpnSubnetRouteHandlerTest.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataBroker' import. Should be before 'org.opendaylight.netvirt.bgpmanager.api.IBgpManager'. | 21 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataChangeListener' import. Should be before 'org.opendaylight.netvirt.bgpmanager.api.IBgpManager'. | 22 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction' import. Should be before 'org.opendaylight.netvirt.bgpmanager.api.IBgpManager'. | 23 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.WriteTransaction' import. Should be before 'org.opendaylight.netvirt.bgpmanager.api.IBgpManager'. | 24 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.AsyncDataBroker' import. Should be before 'org.opendaylight.netvirt.bgpmanager.api.IBgpManager'. | 25 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. Should be before 'org.opendaylight.netvirt.bgpmanager.api.IBgpManager'. | 26 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.genius.interfacemanager.globals.IfmConstants' import. Should be before 'org.opendaylight.netvirt.bgpmanager.api.IBgpManager'. | 27 |
| Warning |
whitespace | NoLineWrap | import statement should not be line-wrapped. | 35 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.TaskState' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.VpnInstanceToVpnId'. | 49 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.AllocateIdInput' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.to.vpn.id.VpnInstanceKey'. | 65 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.AllocateIdInputBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.to.vpn.id.VpnInstanceKey'. | 66 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.AllocateIdOutput' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.to.vpn.id.VpnInstanceKey'. | 67 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.AllocateIdOutputBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.to.vpn.id.VpnInstanceKey'. | 68 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.IdManagerService' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.to.vpn.id.VpnInstanceKey'. | 69 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.op.rev160406.DpnEndpoints' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.to.vpn.id.VpnInstanceKey'. | 70 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.op.rev160406.dpn.endpoints.DPNTEPsInfo' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.to.vpn.id.VpnInstanceKey'. | 71 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.op.rev160406.dpn.endpoints.DPNTEPsInfoBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.to.vpn.id.VpnInstanceKey'. | 72 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.op.rev160406.dpn.endpoints.DPNTEPsInfoKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.to.vpn.id.VpnInstanceKey'. | 73 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.op.rev160406.dpn.endpoints.dpn.teps.info.TunnelEndPoints' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.to.vpn.id.VpnInstanceKey'. | 74 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.op.rev160406.dpn.endpoints.dpn.teps.info.TunnelEndPointsBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.vpn.instance.to.vpn.id.VpnInstanceKey'. | 75 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.PortAddedToSubnetBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.PortRemovedFromSubnet'. | 78 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.SubnetDeletedFromVpn' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.SubnetUpdatedInVpn'. | 82 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.SubnetAddedToVpnBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.SubnetUpdatedInVpn'. | 83 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.SubnetDeletedFromVpnBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.SubnetUpdatedInVpnBuilder'. | 85 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ExternalNetworks' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.subnetmaps.SubnetmapKey'. | 90 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.external.networks.Networks' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.subnetmaps.SubnetmapKey'. | 91 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.external.networks.NetworksBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.subnetmaps.SubnetmapKey'. | 92 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.external.networks.NetworksKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.subnetmaps.SubnetmapKey'. | 93 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.math.BigInteger' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResultBuilder'. | 99 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResultBuilder'. | 100 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResultBuilder'. | 101 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.concurrent.Future' import. Should be before 'org.opendaylight.yangtools.yang.common.RpcResultBuilder'. | 102 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Matchers.any' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 104 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Matchers.anyString' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 105 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Mockito.doReturn' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 106 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Mockito.verify' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 107 |
| Warning |
imports | CustomImportOrder | Import statement for 'org.mockito.Mockito.when' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 108 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 153 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 158 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 160 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 167 |
| Warning |
whitespace | SeparatorWrap | '.' should be on a new line. | 172 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'idOutputOptional' declaration and its first usage is 22, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 215 |
| Warning |
indentation | Indentation | 'operator new lparen' have incorrect indentation level 16, expected level should be 8. | 266 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 266 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'subToDpn' declaration and its first usage is 7, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 268 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'portList' declaration and its first usage is 8, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 269 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'listPortOpDataEntry' declaration and its first usage is 9, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 270 |
| Warning |
coding | VariableDeclarationUsageDistance | Distance between variable 'tunnelEndPoints' declaration and its first usage is 21, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 271 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 277 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 294 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 298 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 300 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 307 |
| Warning |
whitespace | MethodParamPad | '(' should be on the previous line. | 315 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 122). | 420 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 154). | 424 |
org/opendaylight/netvirt/vpnmanager/utilities/InterfaceUtils.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.rpcs.rev160406.GetDpidFromInterfaceInput' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 22 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.rpcs.rev160406.GetDpidFromInterfaceInputBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 23 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.rpcs.rev160406.GetDpidFromInterfaceOutput' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 24 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.rpcs.rev160406.OdlInterfaceRpcService' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 25 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.servicebinding.rev160406.ServiceBindings' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 26 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.servicebinding.rev160406.ServiceTypeFlowBased' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 27 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.servicebinding.rev160406.StypeOpenflow' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 28 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.servicebinding.rev160406.StypeOpenflowBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 29 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.servicebinding.rev160406.ServiceModeIngress' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 30 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.servicebinding.rev160406.service.bindings.ServicesInfo' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 31 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.servicebinding.rev160406.service.bindings.ServicesInfoKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 32 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.servicebinding.rev160406.service.bindings.services.info.BoundServices' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 33 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.servicebinding.rev160406.service.bindings.services.info.BoundServicesBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 34 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.interfacemanager.servicebinding.rev160406.service.bindings.services.info.BoundServicesKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 35 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.op.rev160406.DpnEndpoints' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 36 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.op.rev160406.dpn.endpoints.DPNTEPsInfo' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 37 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.op.rev160406.dpn.endpoints.DPNTEPsInfoKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 38 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.itm.op.rev160406.dpn.endpoints.dpn.teps.info.TunnelEndPoints' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorId'. | 39 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.math.BigInteger' import. Should be before 'org.slf4j.LoggerFactory'. | 45 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. | 46 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.concurrent.ExecutionException' import. Should be before 'org.slf4j.LoggerFactory'. | 47 |
| Warning |
imports | CustomImportOrder | Wrong lexicographical order for 'java.util.concurrent.Future' import. Should be before 'org.slf4j.LoggerFactory'. | 48 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 2, expected level should be 4. | 51 |
| Warning |
indentation | Indentation | 'member def modifier' have incorrect indentation level 2, expected level should be 4. | 52 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 54 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 55 |
| Warning |
indentation | Indentation | 'try' have incorrect indentation level 4, expected level should be 8. | 56 |
| Warning |
indentation | Indentation | 'try' child have incorrect indentation level 6, expected level should be 12. | 57 |
| Warning |
indentation | Indentation | 'try' child have incorrect indentation level 6, expected level should be 12. | 60 |
| Warning |
indentation | Indentation | 'try' child have incorrect indentation level 6, expected level should be 12. | 63 |
| Warning |
indentation | Indentation | 'if' have incorrect indentation level 6, expected level should be 12. | 64 |
| Warning |
indentation | Indentation | 'if' child have incorrect indentation level 8, expected level should be 16. | 65 |
| Warning |
indentation | Indentation | 'if rcurly' have incorrect indentation level 6, expected level should be 12. | 66 |
| Warning |
indentation | Indentation | 'else' child have incorrect indentation level 8, expected level should be 16. | 67 |
| Warning |
indentation | Indentation | 'else rcurly' have incorrect indentation level 6, expected level should be 12. | 68 |
| Warning |
indentation | Indentation | 'try rcurly' have incorrect indentation level 4, expected level should be 8. | 69 |
| Warning |
indentation | Indentation | 'catch' child have incorrect indentation level 6, expected level should be 12. | 70 |
| Warning |
indentation | Indentation | 'catch rcurly' have incorrect indentation level 4, expected level should be 8. | 71 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 72 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 73 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 75 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 76 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 77 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 79 |
| Warning |
indentation | Indentation | 'if' have incorrect indentation level 4, expected level should be 8. | 80 |
| Warning |
indentation | Indentation | 'if' child have incorrect indentation level 6, expected level should be 12. | 81 |
| Warning |
indentation | Indentation | 'if' have incorrect indentation level 6, expected level should be 12. | 82 |
| Warning |
indentation | Indentation | 'if' child have incorrect indentation level 8, expected level should be 16. | 83 |
| Warning |
indentation | Indentation | 'if rcurly' have incorrect indentation level 6, expected level should be 12. | 84 |
| Warning |
indentation | Indentation | 'if rcurly' have incorrect indentation level 4, expected level should be 8. | 85 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 86 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 87 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 89 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 90 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 151). | 90 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 92 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 94 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 96 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 146). | 96 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 97 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 100 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 102 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 103 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 104 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 106 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 107 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 135). | 109 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 152). | 110 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 111 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 157). | 111 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 112 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 113 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 115 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 200). | 115 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 116 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 145). | 116 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 118 |
| Warning |
indentation | Indentation | 'if' have incorrect indentation level 4, expected level should be 8. | 120 |
| Warning |
indentation | Indentation | 'if' child have incorrect indentation level 6, expected level should be 12. | 121 |
| Warning |
indentation | Indentation | 'if rcurly' have incorrect indentation level 4, expected level should be 8. | 122 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 124 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 125 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 127 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 175). | 127 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 128 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 132). | 128 |
| Warning |
indentation | Indentation | 'if' have incorrect indentation level 4, expected level should be 8. | 130 |
| Warning |
whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 130 |
| Warning |
indentation | Indentation | 'if' child have incorrect indentation level 6, expected level should be 12. | 131 |
| Warning |
indentation | Indentation | 'if rcurly' have incorrect indentation level 4, expected level should be 8. | 132 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 133 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 134 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 136 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 6, expected level should be 8. | 137 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 6, expected level should be 8. | 138 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 147). | 138 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 6, expected level should be 8. | 140 |
| Warning |
indentation | Indentation | 'if' have incorrect indentation level 6, expected level should be 8. | 141 |
| Warning |
indentation | Indentation | 'if' child have incorrect indentation level 10, expected level should be 12. | 142 |
| Warning |
indentation | Indentation | 'if' have incorrect indentation level 10, expected level should be 12. | 143 |
| Warning |
indentation | Indentation | 'if' child have incorrect indentation level 14, expected level should be 16. | 144 |
| Warning |
indentation | Indentation | 'if rcurly' have incorrect indentation level 10, expected level should be 12. | 145 |
| Warning |
indentation | Indentation | 'if rcurly' have incorrect indentation level 6, expected level should be 8. | 146 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 6, expected level should be 8. | 147 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 148 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 150 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 186). | 150 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 151 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 164). | 153 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 154 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 156 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 160 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 161 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 162 |
| Warning |
indentation | Indentation | 'method def modifier' have incorrect indentation level 2, expected level should be 4. | 164 |
| Warning |
sizes | LineLength | Line is longer than 120 characters (found 168). | 164 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 165 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 166 |
| Warning |
indentation | Indentation | 'method def' child have incorrect indentation level 4, expected level should be 8. | 167 |
| Warning |
indentation | Indentation | 'method def rcurly' have incorrect indentation level 2, expected level should be 4. | 168 |
org/opendaylight/netvirt/vpnmanager/utilities/VpnManagerCounters.java
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Warning |
whitespace | FileTabCharacter | Line contains a tab character. | 19 |
| Warning |
modifier | RedundantModifier | Redundant 'private' modifier. | 23 |