The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. 
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | RightCurly
|
1 | |
| RightCurly | 1 | ||
| coding | IllegalCatch | 1 | |
| OverloadMethodsDeclarationOrder | 14 | ||
| imports | CustomImportOrder
|
68 | |
| indentation | Indentation
|
20 | |
| javadoc | JavadocStyle
|
4 | |
| naming | AbbreviationAsWordInName
|
6 | |
LocalVariableName
|
6 | ||
MemberName
|
4 | ||
| sizes | LineLength
|
40 | |
| whitespace | GenericWhitespace | 1 | |
WhitespaceAround
|
129 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.slf4j.LoggerFactory'. | 36 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Preconditions' import. Should be before 'org.slf4j.LoggerFactory'. | 37 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.CheckedFuture' import. Should be before 'org.slf4j.LoggerFactory'. | 38 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.neutron.spi.INeutronCRUD' import. Should be before 'org.slf4j.LoggerFactory'. | 40 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.neutron.spi.INeutronObject' import. Should be before 'org.slf4j.LoggerFactory'. | 41 | |
| sizes | LineLength | Line is longer than 120 characters (found 196). | 43 | |
| sizes | LineLength | Line is longer than 120 characters (found 121). | 78 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'catch' is not followed by whitespace. | 169 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 172 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 195 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 195 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 196 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 197 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 205 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 205 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 208 | |
| indentation | Indentation | 'method def rcurly' have incorrect indentation level 5, expected level should be 4. | 334 | |
| sizes | LineLength | Line is longer than 120 characters (found 123). | 336 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| sizes | LineLength | Line is longer than 120 characters (found 132). | 31 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 63 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 66 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 69 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 74 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 81 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 88 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 95 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 102 | |
| indentation | Indentation | 'for' child have incorrect indentation level 15, expected level should be 16. | 103 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 109 | |
| indentation | Indentation | 'for' child have incorrect indentation level 15, expected level should be 16. | 110 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 143 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 150 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 157 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 164 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 171 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 178 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. | 24 | |
| sizes | LineLength | Line is longer than 120 characters (found 142). | 26 | |
| indentation | Indentation | 'if' child have incorrect indentation level 13, expected level should be 12. | 68 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 27 | |
| javadoc | JavadocStyle | Javadoc has empty description section. | 27 | |
| sizes | LineLength | Line is longer than 120 characters (found 173). | 30 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.collect.ImmutableBiMap' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier'. | 33 | |
| sizes | LineLength | Line is longer than 120 characters (found 162). | 37 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| sizes | LineLength | Line is longer than 120 characters (found 152). | 25 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 52 | |
| blocks | RightCurly | '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). | 72 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| indentation | Indentation | 'AbstractNeutronInterface' have incorrect indentation level 0, expected level should be 4. | 25 | |
| indentation | Indentation | 'implements' have incorrect indentation level 0, expected level should be 4. | 26 | |
| indentation | Indentation | 'createInstanceIdentifier' have incorrect indentation level 4, expected level should be 8. | 46 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 52 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 57 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 59 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 62 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 65 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 68 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 71 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 74 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 77 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 87 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 90 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 93 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 96 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 99 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 102 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataBroker' import. Should be before 'org.slf4j.LoggerFactory'. | 16 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.neutron.spi.INeutronL2gatewayCRUD' import. Should be before 'org.slf4j.LoggerFactory'. | 17 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.neutron.spi.NeutronL2gatewayDevice' import. Should be before 'org.slf4j.LoggerFactory'. | 18 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.neutron.spi.NeutronL2gatewayDeviceInterface' import. Should be before 'org.slf4j.LoggerFactory'. | 19 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.neutron.spi.NeutronL2gateway' import. Should be before 'org.slf4j.LoggerFactory'. | 20 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.l2gateways.rev150712.l2gateway.attributes.Devices' import. Should be before 'org.slf4j.LoggerFactory'. | 21 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.l2gateways.rev150712.l2gateway.attributes.DevicesBuilder' import. Should be before 'org.slf4j.LoggerFactory'. | 22 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.l2gateways.rev150712.l2gateway.attributes.devices.Interfaces' import. Should be before 'org.slf4j.LoggerFactory'. | 23 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.l2gateways.rev150712.l2gateway.attributes.devices.InterfacesBuilder' import. Should be before 'org.slf4j.LoggerFactory'. | 24 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.l2gateways.rev150712.l2gateways.attributes.L2gateways' import. Should be before 'org.slf4j.LoggerFactory'. | 25 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.l2gateways.rev150712.l2gateways.attributes.l2gateways.L2gateway' import. Should be before 'org.slf4j.LoggerFactory'. | 26 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.l2gateways.rev150712.l2gateways.attributes.l2gateways.L2gatewayBuilder' import. Should be before 'org.slf4j.LoggerFactory'. | 27 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.rev150712.Neutron' import. Should be before 'org.slf4j.LoggerFactory'. | 28 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier' import. Should be before 'org.slf4j.LoggerFactory'. | 29 | |
| indentation | Indentation | 'createInstanceIdentifier' have incorrect indentation level 4, expected level should be 8. | 52 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 63 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 67 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 70 | |
| indentation | Indentation | 'if' child have incorrect indentation level 8, expected level should be 12. | 71 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 73 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 76 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 79 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 80 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 84 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 90 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 90 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 91 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 91 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 96 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 100 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 101 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 101 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 121 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 124 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 127 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 131 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 133 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 133 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 136 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 137 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 141 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 142 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 143 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.collect.ImmutableBiMap' import. Should be before 'org.slf4j.LoggerFactory'. | 32 | |
| sizes | LineLength | Line is longer than 120 characters (found 203). | 34 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '55'. | 76 | |
| naming | LocalVariableName | Local variable name 'neutron_id' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 94 | |
| sizes | LineLength | Line is longer than 120 characters (found 132). | 108 | |
| indentation | Indentation | 'if' child have incorrect indentation level 13, expected level should be 12. | 124 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| sizes | LineLength | Line is longer than 120 characters (found 162). | 25 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '38'. | 85 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.collect.ImmutableBiMap' import. Should be before 'org.slf4j.LoggerFactory'. | 32 | |
| sizes | LineLength | Line is longer than 120 characters (found 178). | 34 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '54'. | 75 | |
| naming | LocalVariableName | Local variable name 'neutron_id' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 87 | |
| sizes | LineLength | Line is longer than 120 characters (found 135). | 98 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataBroker' import. Should be before 'org.opendaylight.controller.md.sal.common.api.data.TransactionCommitFailedException'. | 22 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.slf4j.LoggerFactory'. | 47 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.collect.ImmutableBiMap' import. Should be before 'org.slf4j.LoggerFactory'. | 48 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.CheckedFuture' import. Should be before 'org.slf4j.LoggerFactory'. | 49 | |
| sizes | LineLength | Line is longer than 120 characters (found 158). | 51 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '71'. | 91 | |
| naming | LocalVariableName | Local variable name 'neutron_id' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 103 | |
| sizes | LineLength | Line is longer than 120 characters (found 123). | 119 | |
| sizes | LineLength | Line is longer than 120 characters (found 123). | 168 | |
| sizes | LineLength | Line is longer than 120 characters (found 123). | 205 | |
| sizes | LineLength | Line is longer than 120 characters (found 121). | 323 | |
| sizes | LineLength | Line is longer than 120 characters (found 130). | 326 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| sizes | LineLength | Line is longer than 120 characters (found 167). | 24 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '51'. | 86 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.collect.ImmutableBiMap' import. Should be before 'org.slf4j.LoggerFactory'. | 28 | |
| sizes | LineLength | Line is longer than 120 characters (found 134). | 30 | |
| sizes | LineLength | Line is longer than 120 characters (found 141). | 79 | |
| sizes | LineLength | Line is longer than 120 characters (found 121). | 82 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '64'. | 111 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.networks.rev150712.NetworkTypeBase' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.provider.ext.rev150712.neutron.networks.network.SegmentsBuilder'. | 27 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.networks.rev150712.NetworkTypeFlat' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.provider.ext.rev150712.neutron.networks.network.SegmentsBuilder'. | 28 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.networks.rev150712.NetworkTypeGre' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.provider.ext.rev150712.neutron.networks.network.SegmentsBuilder'. | 29 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.networks.rev150712.NetworkTypeVlan' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.provider.ext.rev150712.neutron.networks.network.SegmentsBuilder'. | 30 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.networks.rev150712.NetworkTypeVxlan' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.provider.ext.rev150712.neutron.networks.network.SegmentsBuilder'. | 31 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.provider.ext.rev150712.NetworkProviderExtension' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.provider.ext.rev150712.neutron.networks.network.SegmentsBuilder'. | 32 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.provider.ext.rev150712.NetworkProviderExtensionBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.provider.ext.rev150712.neutron.networks.network.SegmentsBuilder'. | 33 | |
| sizes | LineLength | Line is longer than 120 characters (found 137). | 41 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 90 | |
| sizes | LineLength | Line is longer than 120 characters (found 133). | 114 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 119 | |
| sizes | LineLength | Line is longer than 120 characters (found 132). | 131 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.HashMap' import. Should be before 'java.util.HashSet'. | 13 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.binding.rev150712.PortBindingExtension' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.binding.rev150712.binding.attributes.VifDetailsBuilder'. | 30 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.binding.rev150712.PortBindingExtensionBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.binding.rev150712.binding.attributes.VifDetailsBuilder'. | 31 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.collect.ImmutableBiMap' import. Should be before 'org.slf4j.LoggerFactory'. | 54 | |
| sizes | LineLength | Line is longer than 120 characters (found 122). | 56 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 105 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 112 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 216 | |
| indentation | Indentation | 'for' child have incorrect indentation level 20, expected level should be 16. | 219 | |
| indentation | Indentation | 'for' child have incorrect indentation level 20, expected level should be 16. | 220 | |
| sizes | LineLength | Line is longer than 120 characters (found 133). | 220 | |
| indentation | Indentation | 'for' child have incorrect indentation level 20, expected level should be 16. | 221 | |
| indentation | Indentation | 'for' child have incorrect indentation level 20, expected level should be 16. | 222 | |
| naming | LocalVariableName | Local variable name 'neutron_IPs' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 250 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. | 27 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. | 28 | |
| whitespace | GenericWhitespace | GenericWhitespace '<' is preceded with whitespace. | 30 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.neutron.spi.NeutronRouter' import. Should be before 'org.opendaylight.neutron.spi.Neutron_IPs'. | 17 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.neutron.spi.NeutronRouter_NetworkReference' import. Should be before 'org.opendaylight.neutron.spi.Neutron_IPs'. | 18 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.l3.rev150712.routers.attributes.routers.router.external_gateway_info.ExternalFixedIps' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.l3.rev150712.routers.attributes.routers.router.external_gateway_info.ExternalFixedIpsBuilder'. | 29 | |
| sizes | LineLength | Line is longer than 120 characters (found 132). | 35 | |
| sizes | LineLength | Line is longer than 120 characters (found 137). | 85 | |
| naming | LocalVariableName | Local variable name 'eIP' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 93 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '51'. | 125 | |
| indentation | Indentation | 'for' child have incorrect indentation level 21, expected level should be 20. | 161 | |
| indentation | Indentation | 'for' child have incorrect indentation level 21, expected level should be 20. | 162 | |
| indentation | Indentation | 'for' child have incorrect indentation level 21, expected level should be 20. | 163 | |
| indentation | Indentation | 'for' child have incorrect indentation level 21, expected level should be 20. | 164 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 85 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 88 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 91 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 94 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 109 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 112 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 115 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 118 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 121 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 124 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 127 | |
| whitespace | WhitespaceAround | WhitespaceAround: '!=' is not followed by whitespace. | 127 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 130 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 133 | |
| whitespace | WhitespaceAround | WhitespaceAround: '!=' is not preceded with whitespace. | 133 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 135 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 162 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 165 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 168 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 171 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 174 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 177 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 180 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 183 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 186 | |
| whitespace | WhitespaceAround | WhitespaceAround: '!=' is not followed by whitespace. | 186 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 189 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 192 | |
| whitespace | WhitespaceAround | WhitespaceAround: '!=' is not preceded with whitespace. | 192 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 194 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. | 25 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.HashMap' import. Should be before 'org.slf4j.LoggerFactory'. | 26 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. | 27 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 29 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 69 | |
| whitespace | WhitespaceAround | WhitespaceAround: '=' is not preceded with whitespace. | 75 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 76 | |
| whitespace | WhitespaceAround | WhitespaceAround: '!=' is not preceded with whitespace. | 81 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 83 | |
| whitespace | WhitespaceAround | WhitespaceAround: '!=' is not followed by whitespace. | 110 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 112 | |
| whitespace | WhitespaceAround | WhitespaceAround: '!=' is not followed by whitespace. | 117 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 119 | |
| whitespace | WhitespaceAround | WhitespaceAround: '!=' is not preceded with whitespace. | 124 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 126 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. | 22 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. | 23 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 25 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 60 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 85 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. | 25 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.HashMap' import. Should be before 'org.slf4j.LoggerFactory'. | 26 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. | 27 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 29 | |
| whitespace | WhitespaceAround | WhitespaceAround: '!=' is not preceded with whitespace. | 68 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 70 | |
| whitespace | WhitespaceAround | WhitespaceAround: '!=' is not followed by whitespace. | 97 | |
| whitespace | WhitespaceAround | WhitespaceAround: '!=' is not preceded with whitespace. | 103 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 105 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| sizes | LineLength | Line is longer than 120 characters (found 167). | 25 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '52'. | 83 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.secgroups.rev150712.SecurityRuleAttributes.Protocol' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.secgroups.rev150712.security.rules.attributes.security.rules.SecurityRuleBuilder'. | 28 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.collect.ImmutableBiMap' import. Should be before 'org.slf4j.LoggerFactory'. | 33 | |
| sizes | LineLength | Line is longer than 120 characters (found 162). | 36 | |
| sizes | LineLength | Line is longer than 120 characters (found 131). | 111 | |
| sizes | LineLength | Line is longer than 120 characters (found 131). | 131 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '101'. | 160 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.collect.ImmutableBiMap' import. Should be before 'org.slf4j.LoggerFactory'. | 41 | |
| sizes | LineLength | Line is longer than 120 characters (found 132). | 43 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 108 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 108 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 110 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 179 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 181 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '122'. | 209 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.neutron.spi.INeutronQosPolicyCRUD' import. Should be before 'org.opendaylight.neutron.spi.INeutronVPNServiceCRUD'. | 41 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. | 47 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. | 48 | |
| naming | AbbreviationAsWordInName | Abbreviation in name 'vPNIKEPolicyInterface' must contain no more than '4' capital letters. | 78 | |
| naming | MemberName | Member name 'vPNIKEPolicyInterface' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 78 | |
| naming | AbbreviationAsWordInName | Abbreviation in name 'vPNIPSECPolicyInterface' must contain no more than '4' capital letters. | 79 | |
| naming | MemberName | Member name 'vPNIPSECPolicyInterface' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 79 | |
| naming | AbbreviationAsWordInName | Abbreviation in name 'vPNIPSECSiteConnectionsInterface' must contain no more than '4' capital letters. | 80 | |
| naming | MemberName | Member name 'vPNIPSECSiteConnectionsInterface' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 80 | |
| naming | MemberName | Member name 'vPNServiceInterface' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 81 | |
| indentation | Indentation | 'void' have incorrect indentation level 4, expected level should be 8. | 95 | |
| naming | LocalVariableName | Local variable name 'sCrudInterface' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 98 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ikepolicies.attributes.IkePolicies' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ikepolicy.attributes.LifetimeBuilder'. | 18 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ikepolicies.attributes.ike.policies.Ikepolicy' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ikepolicy.attributes.LifetimeBuilder'. | 19 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ikepolicies.attributes.ike.policies.IkepolicyBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ikepolicy.attributes.LifetimeBuilder'. | 20 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.rev150712.Neutron' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ikepolicy.attributes.LifetimeBuilder'. | 21 | |
| naming | AbbreviationAsWordInName | Abbreviation in name 'NeutronVPNIKEPolicyInterface' must contain no more than '4' capital letters. | 26 | |
| sizes | LineLength | Line is longer than 120 characters (found 157). | 26 | |
| indentation | Indentation | 'if' child have incorrect indentation level 0, expected level should be 12. | 65 | |
| whitespace | WhitespaceAround | WhitespaceAround: '!=' is not followed by whitespace. | 100 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '76'. | 128 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ipsecpolicies.attributes.IpsecPolicies' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ipsecpolicy.attributes.LifetimeBuilder'. | 18 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ipsecpolicies.attributes.ipsec.policies.Ipsecpolicy' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ipsecpolicy.attributes.LifetimeBuilder'. | 19 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ipsecpolicies.attributes.ipsec.policies.IpsecpolicyBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ipsecpolicy.attributes.LifetimeBuilder'. | 20 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.rev150712.Neutron' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ipsecpolicy.attributes.LifetimeBuilder'. | 21 | |
| naming | AbbreviationAsWordInName | Abbreviation in name 'NeutronVPNIPSECPolicyInterface' must contain no more than '4' capital letters. | 26 | |
| sizes | LineLength | Line is longer than 120 characters (found 167). | 26 | |
| whitespace | WhitespaceAround | WhitespaceAround: '!=' is not followed by whitespace. | 63 | |
| whitespace | WhitespaceAround | WhitespaceAround: '!=' is not followed by whitespace. | 99 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '75'. | 128 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.rev150712.Neutron' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.ipsecconnections.attributes.ipsec.site.connections.IpsecsiteconnectionBuilder'. | 22 | |
| naming | AbbreviationAsWordInName | Abbreviation in name 'NeutronVPNIPSECSiteConnectionsInterface' must contain no more than '4' capital letters. | 27 | |
| sizes | LineLength | Line is longer than 120 characters (found 208). | 27 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 62 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 125 | |
| sizes | LineLength | Line is longer than 120 characters (found 121). | 180 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '107'. | 186 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.rev150712.Neutron' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.vpnaas.rev150712.vpnservices.attributes.vpn.services.VpnserviceBuilder'. | 19 | |
| sizes | LineLength | Line is longer than 120 characters (found 152). | 24 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '65'. | 105 |