FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 105 |
32 |
0 |
0 |
org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to databases in org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager.connected(OvsdbClient) |
STYLE |
DLS_DEAD_LOCAL_STORE |
114 |
Medium |
| Dead store to connectionManager in org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager.retryConnection(InstanceIdentifier, HwvtepGlobalAugmentation, HwvtepConnectionManager$ConnectionReconciliationTriggers) |
STYLE |
DLS_DEAD_LOCAL_STORE |
418 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager$1
org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager$2
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager$2 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
515 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager$HwvtepDeviceEntityOwnershipListener
| Bug |
Category |
Details |
Line |
Priority |
| Should org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager$HwvtepDeviceEntityOwnershipListener be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
531 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepDataChangeListener
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepDataChangeListener.getOriginal(DataObjectModification) uses the same code for two switch clauses |
STYLE |
DB_DUPLICATE_SWITCH_CLAUSES |
246 |
Low |
| Dead store to e in org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepDataChangeListener.connect(Collection) |
STYLE |
DLS_DEAD_LOCAL_STORE |
137 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepSouthboundProvider
| Bug |
Category |
Details |
Line |
Priority |
| Write to static field org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepSouthboundProvider.db from instance method org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepSouthboundProvider.onSessionInitiated(BindingAwareBroker$ProviderContext) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
69 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepSouthboundProvider$HwvtepsbPluginInstanceEntityOwnershipListener
| Bug |
Category |
Details |
Line |
Priority |
| Should org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepSouthboundProvider$HwvtepsbPluginInstanceEntityOwnershipListener be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
174 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.InstanceIdentifierCodec
| Bug |
Category |
Details |
Line |
Priority |
| InstanceIdentifierCodec.context not initialized in constructor and dereferenced in org.opendaylight.ovsdb.hwvtepsouthbound.InstanceIdentifierCodec.moduleForPrefix(String) |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
44 |
Low |
| InstanceIdentifierCodec.context not initialized in constructor and dereferenced in org.opendaylight.ovsdb.hwvtepsouthbound.InstanceIdentifierCodec.prefixForNamespace(URI) |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
49 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.reconciliation.ReconciliationManager$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.ovsdb.hwvtepsouthbound.reconciliation.ReconciliationManager$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
78 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.reconciliation.connection.ConnectionReconciliationTask
| Bug |
Category |
Details |
Line |
Priority |
| Result of integer multiplication cast to long in org.opendaylight.ovsdb.hwvtepsouthbound.reconciliation.connection.ConnectionReconciliationTask.retryDelayInMills() |
STYLE |
ICAST_INTEGER_MULTIPLY_CAST_TO_LONG |
86 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transact.PhysicalPortUpdateCommand
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.ovsdb.hwvtepsouthbound.transact.PhysicalPortUpdateCommand.setDescription(PhysicalPort, HwvtepPhysicalPortAugmentation) invokes toString() method on a String |
PERFORMANCE |
DM_STRING_TOSTRING |
148 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transact.PhysicalSwitchUpdateCommand
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to uuid in org.opendaylight.ovsdb.hwvtepsouthbound.transact.PhysicalSwitchUpdateCommand.setTunnels(TransactionBuilder, InstanceIdentifier, PhysicalSwitch, PhysicalSwitchAugmentation, boolean) |
STYLE |
DLS_DEAD_LOCAL_STORE |
214 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.transact.TransactUtils
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.ovsdb.hwvtepsouthbound.transact.TransactUtils.getOriginal(DataObjectModification) uses the same code for two switch clauses |
STYLE |
DB_DUPLICATE_SWITCH_CLAUSES |
85 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepGlobalRemoveCommand
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to onlyConnectedManager in org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepGlobalRemoveCommand.checkIfOnlyConnectedManager(HwvtepGlobalAugmentation) |
STYLE |
DLS_DEAD_LOCAL_STORE |
82 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepTunnelUpdateCommand
| Bug |
Category |
Details |
Line |
Priority |
| Nullcheck of pSwitch at line 83 of value previously dereferenced in org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepTunnelUpdateCommand.updateTunnel(ReadWriteTransaction, Tunnel) |
CORRECTNESS |
RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE |
83 |
Medium |
| org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepTunnelUpdateCommand.setBfdLocalConfigs(TunnelsBuilder, Tunnel) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
113 |
Medium |
| org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepTunnelUpdateCommand.setBfdParams(TunnelsBuilder, Tunnel) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
152 |
Medium |
| org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepTunnelUpdateCommand.setBfdRemoteConfigs(TunnelsBuilder, Tunnel) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
132 |
Medium |
| org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepTunnelUpdateCommand.setBfdStatus(TunnelsBuilder, Tunnel) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
171 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl.invoke(TransactionCommand) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
64 |
Medium |
| Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl.onTransactionChainFailed(TransactionChain, AsyncTransaction, Throwable) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
70 |
Medium |
| Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in new org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl(DataBroker) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
58 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl$1
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl$1.onSuccess(Void) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
92 |
Medium |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.HwvtepsouthboundBuilder$HwvtepsouthboundImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.HwvtepsouthboundBuilder$HwvtepsouthboundImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.HwvtepsouthboundBuilder$HwvtepsouthboundImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
258 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.BindingNormalizedNodeSerializerBuilder$BindingNormalizedNodeSerializerImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.BindingNormalizedNodeSerializerBuilder$BindingNormalizedNodeSerializerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.BindingNormalizedNodeSerializerBuilder$BindingNormalizedNodeSerializerImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.BrokerBuilder$BrokerImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.BrokerBuilder$BrokerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.BrokerBuilder$BrokerImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.ClusteringEntityOwnershipServiceBuilder$ClusteringEntityOwnershipServiceImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.ClusteringEntityOwnershipServiceBuilder$ClusteringEntityOwnershipServiceImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.ClusteringEntityOwnershipServiceBuilder$ClusteringEntityOwnershipServiceImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.ConnectionServiceBuilder$ConnectionServiceImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.ConnectionServiceBuilder$ConnectionServiceImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.ConnectionServiceBuilder$ConnectionServiceImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.SchemaServiceBuilder$SchemaServiceImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.SchemaServiceBuilder$SchemaServiceImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.hwvtepsouthbound.impl.rev150901.modules.module.configuration.hwvtepsouthbound.SchemaServiceBuilder$SchemaServiceImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
