The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
InstanceIdentifierCodec.context not initialized in constructor and dereferenced in org.opendaylight.ovsdb.southbound.InstanceIdentifierCodec.moduleForPrefix(String) | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 44 | Low |
InstanceIdentifierCodec.context not initialized in constructor and dereferenced in org.opendaylight.ovsdb.southbound.InstanceIdentifierCodec.prefixForNamespace(URI) | STYLE | UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR | 49 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to databases in org.opendaylight.ovsdb.southbound.OvsdbConnectionManager.connected(OvsdbClient) | STYLE | DLS_DEAD_LOCAL_STORE | 108 | Medium |
Dead store to connectionManager in org.opendaylight.ovsdb.southbound.OvsdbConnectionManager.retryConnection(InstanceIdentifier, OvsdbNodeAugmentation, OvsdbConnectionManager$ConnectionReconciliationTriggers) | STYLE | DLS_DEAD_LOCAL_STORE | 587 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class org.opendaylight.ovsdb.southbound.OvsdbConnectionManager$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 447 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
node must be non-null but is marked as nullable | STYLE | NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE | 591 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.opendaylight.ovsdb.southbound.OvsdbConnectionManager$OvsdbDeviceEntityOwnershipListener be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 626 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Write to static field org.opendaylight.ovsdb.southbound.SouthboundProvider.db from instance method org.opendaylight.ovsdb.southbound.SouthboundProvider.onSessionInitiated(BindingAwareBroker$ProviderContext) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 70 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.opendaylight.ovsdb.southbound.SouthboundProvider$SouthboundPluginInstanceEntityOwnershipListener be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 164 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Private method org.opendaylight.ovsdb.southbound.ovsdb.transact.AutoAttachRemovedCommand.deleteAutoAttach(TransactionBuilder, InstanceIdentifier, Uuid) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 98 | Low |
Private method org.opendaylight.ovsdb.southbound.ovsdb.transact.AutoAttachRemovedCommand.getAutoAttachUuid(List, Uri) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 128 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Private method org.opendaylight.ovsdb.southbound.ovsdb.transact.AutoAttachUpdateCommand.getAutoAttachUuid(List, Uri) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 189 | Low |
Private method org.opendaylight.ovsdb.southbound.ovsdb.transact.AutoAttachUpdateCommand.getBridge(InstanceIdentifier, Uri) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 169 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Redundant nullcheck of nodeCreateOrUpdate, which is known to be non-null in new org.opendaylight.ovsdb.southbound.ovsdb.transact.BridgeOperationalState(DataBroker, AsyncDataChangeEvent) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 47 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.opendaylight.ovsdb.southbound.ovsdb.transact.QosUpdateCommand.execute(TransactionBuilder, BridgeOperationalState, Map): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 124 | High |
Found reliance on default encoding in org.opendaylight.ovsdb.southbound.ovsdb.transact.QosUpdateCommand.getQueueUuid(OvsdbQueueRef, OvsdbNodeAugmentation): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 152 | High |
Return value of org.opendaylight.ovsdb.lib.operations.TransactionBuilder.build() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 126 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.opendaylight.ovsdb.southbound.ovsdb.transact.QueueUpdateCommand.execute(TransactionBuilder, BridgeOperationalState, Map): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 115 | High |
org.opendaylight.ovsdb.southbound.ovsdb.transact.QueueUpdateCommand.execute(TransactionBuilder, BridgeOperationalState, Map) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 72 | Medium |
Return value of org.opendaylight.ovsdb.lib.operations.TransactionBuilder.build() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 117 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Found reliance on default encoding in org.opendaylight.ovsdb.southbound.ovsdb.transact.TerminationPointUpdateCommand.updatePortQos(OvsdbTerminationPointAugmentation, Port, OvsdbBridgeAugmentation): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 181 | High |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class org.opendaylight.ovsdb.southbound.reconciliation.ReconciliationManager$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 116 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class org.opendaylight.ovsdb.southbound.reconciliation.ReconciliationManager$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 199 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Should org.opendaylight.ovsdb.southbound.reconciliation.ReconciliationManager$NodeConnectionMetadata be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 274 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class org.opendaylight.ovsdb.southbound.reconciliation.configuration.BridgeConfigReconciliationTask$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 157 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class org.opendaylight.ovsdb.southbound.reconciliation.configuration.TerminationPointConfigReconciliationTask$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 62 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
The class org.opendaylight.ovsdb.southbound.reconciliation.configuration.TerminationPointConfigReconciliationTask$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 69 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Result of integer multiplication cast to long in org.opendaylight.ovsdb.southbound.reconciliation.connection.ConnectionReconciliationTask.retryDelayInMills() | STYLE | ICAST_INTEGER_MULTIPLY_CAST_TO_LONG | 80 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.opendaylight.ovsdb.southbound.transactions.md.OpenVSwitchUpdateCommand.setNewExternalIds(OvsdbNodeAugmentationBuilder, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 187 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OpenVSwitchUpdateCommand.setNewOtherConfigs(OvsdbNodeAugmentationBuilder, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 138 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbAutoAttachUpdateCommand.setMappings(AutoattachBuilder, AutoAttach) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 144 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbAutoAttachUpdateCommand.setMappings(AutoattachBuilder, AutoAttach) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 144 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to bridgeControllerPortNumber in org.opendaylight.ovsdb.southbound.transactions.md.OvsdbBridgeUpdateCommand.setOpenFlowNodeRef(OvsdbBridgeAugmentationBuilder, Bridge) | STYLE | DLS_DEAD_LOCAL_STORE | 357 | Medium |
Redundant nullcheck of org.opendaylight.ovsdb.southbound.SouthboundMapper.createMdsalProtocols(Bridge), which is known to be non-null in org.opendaylight.ovsdb.southbound.transactions.md.OvsdbBridgeUpdateCommand.setProtocol(OvsdbBridgeAugmentationBuilder, Bridge) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 326 | Low |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbBridgeUpdateCommand.setExternalIds(OvsdbBridgeAugmentationBuilder, Bridge) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 312 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbBridgeUpdateCommand.setOtherConfig(OvsdbBridgeAugmentationBuilder, Bridge) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 291 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortRemoveCommand.execute(ReadWriteTransaction) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 51 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Dead store to bridgeId in org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateTerminationPoints(ReadWriteTransaction, Node) | STYLE | DLS_DEAD_LOCAL_STORE | 132 | Low |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateQos(ReadWriteTransaction, Node, InstanceIdentifier, Map$Entry, OvsdbTerminationPointAugmentationBuilder) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 363 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.getTerminationPointBridge(UUID) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 221 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateInterfaceBfd(Interface, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 632 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateInterfaceBfdStatus(Interface, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 608 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateInterfaceExternalIds(Interface, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 486 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateInterfaceLldp(Interface, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 565 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateInterfaceOtherConfig(Interface, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 589 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateOptions(Interface, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 526 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updatePortExternalIds(Port, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 506 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updatePortOtherConfig(Port, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 546 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbQosUpdateCommand.removeOldQueues(ReadWriteTransaction, QosEntriesBuilder, Map, Qos, InstanceIdentifier) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 304 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbQosUpdateCommand.updateQos(ReadWriteTransaction, Map) invokes toString() method on a String | PERFORMANCE | DM_STRING_TOSTRING | 101 | Low |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbQosUpdateCommand.setNewExternalIds(QosEntriesBuilder, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 267 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbQosUpdateCommand.setNewOtherConfigs(QosEntriesBuilder, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 217 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbQueueUpdateCommand.setNewExternalIds(QueuesBuilder, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 220 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbQueueUpdateCommand.setNewOtherConfigs(QueuesBuilder, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 170 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opendaylight.ovsdb.southbound.transactions.md.TransactionInvokerImpl.invoke(TransactionCommand) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 62 | Medium |
Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opendaylight.ovsdb.southbound.transactions.md.TransactionInvokerImpl.onTransactionChainFailed(TransactionChain, AsyncTransaction, Throwable) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 68 | Medium |
Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in new org.opendaylight.ovsdb.southbound.transactions.md.TransactionInvokerImpl(DataBroker) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 56 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opendaylight.ovsdb.southbound.transactions.md.TransactionInvokerImpl$1.onSuccess(Void) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 89 | Medium |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.southbound.impl.rev141210.modules.module.configuration.SouthboundImplBuilder$SouthboundImplImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.southbound.impl.rev141210.modules.module.configuration.SouthboundImplBuilder$SouthboundImplImpl.equals(Object) | STYLE | BC_UNCONFIRMED_CAST | 258 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.southbound.impl.rev141210.modules.module.configuration.southbound.impl.BindingNormalizedNodeSerializerBuilder$BindingNormalizedNodeSerializerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.southbound.impl.rev141210.modules.module.configuration.southbound.impl.BindingNormalizedNodeSerializerBuilder$BindingNormalizedNodeSerializerImpl.equals(Object) | STYLE | BC_UNCONFIRMED_CAST | 211 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.southbound.impl.rev141210.modules.module.configuration.southbound.impl.BrokerBuilder$BrokerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.southbound.impl.rev141210.modules.module.configuration.southbound.impl.BrokerBuilder$BrokerImpl.equals(Object) | STYLE | BC_UNCONFIRMED_CAST | 211 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.southbound.impl.rev141210.modules.module.configuration.southbound.impl.ClusteringEntityOwnershipServiceBuilder$ClusteringEntityOwnershipServiceImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.southbound.impl.rev141210.modules.module.configuration.southbound.impl.ClusteringEntityOwnershipServiceBuilder$ClusteringEntityOwnershipServiceImpl.equals(Object) | STYLE | BC_UNCONFIRMED_CAST | 211 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.southbound.impl.rev141210.modules.module.configuration.southbound.impl.ConnectionServiceBuilder$ConnectionServiceImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.southbound.impl.rev141210.modules.module.configuration.southbound.impl.ConnectionServiceBuilder$ConnectionServiceImpl.equals(Object) | STYLE | BC_UNCONFIRMED_CAST | 211 | Low |
Bug | Category | Details | Line | Priority |
---|---|---|---|---|
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.southbound.impl.rev141210.modules.module.configuration.southbound.impl.SchemaServiceBuilder$SchemaServiceImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.southbound.impl.rev141210.modules.module.configuration.southbound.impl.SchemaServiceBuilder$SchemaServiceImpl.equals(Object) | STYLE | BC_UNCONFIRMED_CAST | 211 | Low |