FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 96 |
39 |
0 |
0 |
org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to databases in org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager.connected(OvsdbClient) |
STYLE |
DLS_DEAD_LOCAL_STORE |
115 |
Medium |
| Dead store to connectionManager in org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager.retryConnection(InstanceIdentifier, HwvtepGlobalAugmentation, HwvtepConnectionManager$ConnectionReconciliationTriggers) |
STYLE |
DLS_DEAD_LOCAL_STORE |
450 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager$1
org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager$HwvtepDeviceEntityOwnershipListener
| Bug |
Category |
Details |
Line |
Priority |
| Should org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepConnectionManager$HwvtepDeviceEntityOwnershipListener be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
569 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepDataChangeListener
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepDataChangeListener.getOriginal(DataObjectModification) uses the same code for two switch clauses |
STYLE |
DB_DUPLICATE_SWITCH_CLAUSES |
246 |
Low |
| Dead store to e in org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepDataChangeListener.connect(Collection) |
STYLE |
DLS_DEAD_LOCAL_STORE |
136 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepDeviceInfo$DeviceData
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepDeviceInfo$DeviceData.key |
PERFORMANCE |
URF_UNREAD_FIELD |
66 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepSouthboundProvider
| Bug |
Category |
Details |
Line |
Priority |
| Write to static field org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepSouthboundProvider.db from instance method new org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepSouthboundProvider(DataBroker, EntityOwnershipService, OvsdbConnection, SchemaService, BindingNormalizedNodeSerializer) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
64 |
High |
org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepSouthboundProvider$HwvtepsbPluginInstanceEntityOwnershipListener
| Bug |
Category |
Details |
Line |
Priority |
| Should org.opendaylight.ovsdb.hwvtepsouthbound.HwvtepSouthboundProvider$HwvtepsbPluginInstanceEntityOwnershipListener be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
164 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.InstanceIdentifierCodec
| Bug |
Category |
Details |
Line |
Priority |
| InstanceIdentifierCodec.context not initialized in constructor and dereferenced in org.opendaylight.ovsdb.hwvtepsouthbound.InstanceIdentifierCodec.moduleForPrefix(String) |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
44 |
Low |
| InstanceIdentifierCodec.context not initialized in constructor and dereferenced in org.opendaylight.ovsdb.hwvtepsouthbound.InstanceIdentifierCodec.prefixForNamespace(URI) |
STYLE |
UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR |
49 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.reconciliation.configuration.HwvtepReconciliationManager
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to key in org.opendaylight.ovsdb.hwvtepsouthbound.reconciliation.configuration.HwvtepReconciliationManager.processConnectedNodes(Collection) |
STYLE |
DLS_DEAD_LOCAL_STORE |
80 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.reconciliation.configuration.HwvtepReconciliationTask
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to tx in org.opendaylight.ovsdb.hwvtepsouthbound.reconciliation.configuration.HwvtepReconciliationTask.reconcileConfiguration(HwvtepConnectionManager) |
STYLE |
DLS_DEAD_LOCAL_STORE |
65 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.reconciliation.connection.ConnectionReconciliationTask
| Bug |
Category |
Details |
Line |
Priority |
| Result of integer multiplication cast to long in org.opendaylight.ovsdb.hwvtepsouthbound.reconciliation.connection.ConnectionReconciliationTask.retryDelayInMills() |
STYLE |
ICAST_INTEGER_MULTIPLY_CAST_TO_LONG |
86 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transact.AbstractTransactCommand
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to removed in org.opendaylight.ovsdb.hwvtepsouthbound.transact.AbstractTransactCommand.extractRemoved(Collection, Class) |
STYLE |
DLS_DEAD_LOCAL_STORE |
162 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transact.DependencyQueue
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in org.opendaylight.ovsdb.hwvtepsouthbound.transact.DependencyQueue.processReadyJobs(HwvtepConnectionInstance, LinkedBlockingQueue) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
86 |
Low |
| Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in org.opendaylight.ovsdb.hwvtepsouthbound.transact.DependencyQueue.submit(Runnable) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
131 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transact.DependencyQueue$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.ovsdb.hwvtepsouthbound.transact.DependencyQueue$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
86 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transact.DependentJob
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.ovsdb.hwvtepsouthbound.transact.DependentJob.areDependenciesMet(HwvtepDeviceInfo) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
65 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.transact.LogicalSwitchRemoveCommand
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of removeds, which is known to be non-null in org.opendaylight.ovsdb.hwvtepsouthbound.transact.LogicalSwitchRemoveCommand.execute(TransactionBuilder) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
47 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transact.PhysicalSwitchUpdateCommand
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to uuid in org.opendaylight.ovsdb.hwvtepsouthbound.transact.PhysicalSwitchUpdateCommand.setTunnels(TransactionBuilder, InstanceIdentifier, PhysicalSwitch, PhysicalSwitchAugmentation, boolean) |
STYLE |
DLS_DEAD_LOCAL_STORE |
214 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.transact.TransactCommandAggregator
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to pathArgument in org.opendaylight.ovsdb.hwvtepsouthbound.transact.TransactCommandAggregator.extractDataChanged(Collection, Map, Map) |
STYLE |
DLS_DEAD_LOCAL_STORE |
147 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transact.TransactInvokerImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.ovsdb.hwvtepsouthbound.transact.TransactInvokerImpl.printError(TransactionBuilder) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
78 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.transact.TransactUtils
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.ovsdb.hwvtepsouthbound.transact.TransactUtils.getOriginal(DataObjectModification) uses the same code for two switch clauses |
STYLE |
DB_DUPLICATE_SWITCH_CLAUSES |
89 |
Low |
| Redundant nullcheck of locatorUuid, which is known to be non-null in org.opendaylight.ovsdb.hwvtepsouthbound.transact.TransactUtils.createPhysicalLocatorSet(HwvtepOperationalState, TransactionBuilder, List) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
158 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transact.UnMetDependencyGetter$DependencyGetter
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.ovsdb.hwvtepsouthbound.transact.UnMetDependencyGetter$DependencyGetter.retrieveUnMetDependencies(HwvtepOperationalState, HwvtepDeviceInfo, Identifiable) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
70 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepGlobalRemoveCommand
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to onlyConnectedManager in org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepGlobalRemoveCommand.checkIfOnlyConnectedManager(HwvtepGlobalAugmentation) |
STYLE |
DLS_DEAD_LOCAL_STORE |
82 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepPhysicalSwitchUpdateCommand
| Bug |
Category |
Details |
Line |
Priority |
| Null passed for non-null parameter of getInstanceIdentifier(PhysicalSwitch) in org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepPhysicalSwitchUpdateCommand.updateTunnelIps(PhysicalSwitch, PhysicalSwitch, ReadWriteTransaction) |
CORRECTNESS |
NP_NULL_PARAM_DEREF |
129 |
Medium |
| Private method org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepPhysicalSwitchUpdateCommand.setTunnelIps(PhysicalSwitchAugmentationBuilder, PhysicalSwitch) is never called |
PERFORMANCE |
UPM_UNCALLED_PRIVATE_METHOD |
198 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepTunnelUpdateCommand
| Bug |
Category |
Details |
Line |
Priority |
| Nullcheck of pSwitch at line 84 of value previously dereferenced in org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepTunnelUpdateCommand.updateTunnel(ReadWriteTransaction, Tunnel) |
CORRECTNESS |
RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE |
84 |
Medium |
| org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepTunnelUpdateCommand.setBfdLocalConfigs(TunnelsBuilder, Tunnel) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
113 |
Medium |
| org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepTunnelUpdateCommand.setBfdParams(TunnelsBuilder, Tunnel) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
152 |
Medium |
| org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepTunnelUpdateCommand.setBfdRemoteConfigs(TunnelsBuilder, Tunnel) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
132 |
Medium |
| org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.HwvtepTunnelUpdateCommand.setBfdStatus(TunnelsBuilder, Tunnel) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
171 |
Medium |
org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl.invoke(TransactionCommand) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
64 |
Medium |
| Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl.onTransactionChainFailed(TransactionChain, AsyncTransaction, Throwable) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
70 |
Medium |
| Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl.run() |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
117 |
Medium |
| Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in new org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl(DataBroker) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
58 |
Low |
org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl$1
| Bug |
Category |
Details |
Line |
Priority |
| Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opendaylight.ovsdb.hwvtepsouthbound.transactions.md.TransactionInvokerImpl$1.onSuccess(Void) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
102 |
Medium |
