FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 122 |
27 |
0 |
0 |
org.opendaylight.ovsdb.lib.MonitorHandle
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.ovsdb.lib.MonitorHandle is Serializable; consider declaring a serialVersionUID |
BAD_PRACTICE |
SE_NO_SERIALVERSIONID |
16 |
Low |
org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService
| Bug |
Category |
Details |
Line |
Priority |
| Incorrect lazy initialization of static field org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.connectionService in org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.getService() |
MT_CORRECTNESS |
LI_LAZY_INIT_STATIC |
121 |
Medium |
| Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.notifyAlreadyExistingConnectionsToListener(OvsdbConnectionListener) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
207 |
Low |
| Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.notifyListenerForPassiveConnection(OvsdbClient) |
BAD_PRACTICE |
RV_RETURN_VALUE_IGNORED_BAD_PRACTICE |
525 |
Low |
| Write to static field org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.certManagerSrv from instance method org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.setCertificatManager(ICertificateManager) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
568 |
High |
| Write to static field org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.jsonRpcDecoderMaxFrameLength from instance method org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.setJsonRpcDecoderMaxFrameLength(int) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
544 |
High |
| Write to static field org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.useSSL from instance method org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.setUseSsl(boolean) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
559 |
High |
| Write to static field org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.listenerPort from instance method org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.setOvsdbListenerPort(int) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
550 |
Medium |
| Write to static field org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.useSSL from instance method org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.updateConfigParameter(Map) |
STYLE |
ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD |
578 |
Medium |
| org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService.getClient(Channel) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
501 |
Medium |
org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.ovsdb.lib.impl.OvsdbConnectionService$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
154 |
Low |
org.opendaylight.ovsdb.lib.impl.StalePassiveConnectionService
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.ovsdb.lib.impl.StalePassiveConnectionService.clientDisconnected(OvsdbClient) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
100 |
Medium |
| org.opendaylight.ovsdb.lib.impl.StalePassiveConnectionService.lambda$handleNewPassiveConnection$0(Map) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
65 |
Medium |
org.opendaylight.ovsdb.lib.impl.StalePassiveConnectionService$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.ovsdb.lib.impl.StalePassiveConnectionService$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
115 |
Low |
org.opendaylight.ovsdb.lib.jsonrpc.JsonRpcEndpoint
| Bug |
Category |
Details |
Line |
Priority |
| Load of known null value in org.opendaylight.ovsdb.lib.jsonrpc.JsonRpcEndpoint.processRequest(Object, JsonNode) |
STYLE |
NP_LOAD_OF_KNOWN_NULL_VALUE |
203 |
Low |
org.opendaylight.ovsdb.lib.jsonrpc.JsonRpcEndpoint$CallContext
| Bug |
Category |
Details |
Line |
Priority |
| Should org.opendaylight.ovsdb.lib.jsonrpc.JsonRpcEndpoint$CallContext be a _static_ inner class? |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC |
58 |
Medium |
org.opendaylight.ovsdb.lib.notation.Version
| Bug |
Category |
Details |
Line |
Priority |
| Boxing/unboxing to parse a primitive org.opendaylight.ovsdb.lib.notation.Version.fromString(String) |
PERFORMANCE |
DM_BOXED_PRIMITIVE_FOR_PARSING |
42 |
High |
org.opendaylight.ovsdb.lib.notation.json.OvsdbMapSerializer
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.ovsdb.lib.notation.json.OvsdbMapSerializer.serialize(OvsdbMap, JsonGenerator, SerializerProvider) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
29 |
Medium |
org.opendaylight.ovsdb.lib.notation.json.OvsdbTypesIdResolver
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: org.opendaylight.ovsdb.lib.notation.json.OvsdbTypesIdResolver.baseType |
PERFORMANCE |
URF_UNREAD_FIELD |
24 |
Medium |
org.opendaylight.ovsdb.lib.operations.Mutate
| Bug |
Category |
Details |
Line |
Priority |
| Return value of org.opendaylight.ovsdb.lib.schema.ColumnSchema.validate(Object) ignored, but method has no side effect |
STYLE |
RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT |
35 |
Medium |
org.opendaylight.ovsdb.lib.operations.Operations
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.ovsdb.lib.operations.Operations.op isn't final but should be |
MALICIOUS_CODE |
MS_SHOULD_BE_FINAL |
16 |
Low |
| Unread public/protected field: org.opendaylight.ovsdb.lib.operations.Operations.op |
STYLE |
URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD |
16 |
Low |
org.opendaylight.ovsdb.lib.operations.Update
| Bug |
Category |
Details |
Line |
Priority |
| Return value of org.opendaylight.ovsdb.lib.schema.ColumnSchema.validate(Object) ignored, but method has no side effect |
STYLE |
RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT |
55 |
Medium |
org.opendaylight.ovsdb.lib.schema.typed.TyperUtils
| Bug |
Category |
Details |
Line |
Priority |
| Use of non-localized String.toUpperCase() or String.toLowerCase() in org.opendaylight.ovsdb.lib.schema.typed.TyperUtils.getColumnName(Method) |
I18N |
DM_CONVERT_CASE |
88 |
Low |
org.opendaylight.ovsdb.lib.schema.typed.TyperUtils$1
| Bug |
Category |
Details |
Line |
Priority |
| Equals method for org.opendaylight.ovsdb.lib.schema.typed.TyperUtils$1 assumes the argument is of type TyperUtils$1 |
BAD_PRACTICE |
BC_EQUALS_METHOD_SHOULD_WORK_FOR_ALL_OBJECTS |
385 |
Medium |
| org.opendaylight.ovsdb.lib.schema.typed.TyperUtils$1.equals(Object) checks for operand being a TypedBaseTable |
BAD_PRACTICE |
EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS |
385 |
Medium |
| Possible null pointer dereference of TyperUtils$1.val$row in org.opendaylight.ovsdb.lib.schema.typed.TyperUtils$1.equals(Object) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
389 |
Medium |
