FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Files
org.opendaylight.ovsdb.southbound.OvsdbConnectionManager
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to databases in org.opendaylight.ovsdb.southbound.OvsdbConnectionManager.connected(OvsdbClient) | STYLE | DLS_DEAD_LOCAL_STORE | 109 | Medium |
| Dead store to connectionManager in org.opendaylight.ovsdb.southbound.OvsdbConnectionManager.retryConnection(InstanceIdentifier, OvsdbNodeAugmentation, OvsdbConnectionManager$ConnectionReconciliationTriggers) | STYLE | DLS_DEAD_LOCAL_STORE | 585 | Medium |
org.opendaylight.ovsdb.southbound.OvsdbConnectionManager$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| node must be non-null but is marked as nullable | STYLE | NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE | 589 | Medium |
org.opendaylight.ovsdb.southbound.OvsdbConnectionManager$OvsdbDeviceEntityOwnershipListener
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.opendaylight.ovsdb.southbound.OvsdbConnectionManager$OvsdbDeviceEntityOwnershipListener be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 624 | Medium |
org.opendaylight.ovsdb.southbound.SouthboundProvider
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Write to static field org.opendaylight.ovsdb.southbound.SouthboundProvider.db from instance method new org.opendaylight.ovsdb.southbound.SouthboundProvider(DataBroker, EntityOwnershipService, OvsdbConnection, SchemaService, BindingNormalizedNodeSerializer) | STYLE | ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD | 64 | High |
org.opendaylight.ovsdb.southbound.SouthboundProvider$SouthboundPluginInstanceEntityOwnershipListener
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.opendaylight.ovsdb.southbound.SouthboundProvider$SouthboundPluginInstanceEntityOwnershipListener be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 154 | Medium |
org.opendaylight.ovsdb.southbound.ovsdb.transact.AutoAttachRemovedCommand
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.opendaylight.ovsdb.southbound.ovsdb.transact.AutoAttachRemovedCommand.deleteAutoAttach(TransactionBuilder, InstanceIdentifier, Uuid) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 100 | Low |
| Private method org.opendaylight.ovsdb.southbound.ovsdb.transact.AutoAttachRemovedCommand.getAutoAttachUuid(List, Uri) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 130 | Low |
org.opendaylight.ovsdb.southbound.ovsdb.transact.AutoAttachUpdateCommand
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Private method org.opendaylight.ovsdb.southbound.ovsdb.transact.AutoAttachUpdateCommand.getAutoAttachUuid(List, Uri) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 191 | Low |
| Private method org.opendaylight.ovsdb.southbound.ovsdb.transact.AutoAttachUpdateCommand.getBridge(InstanceIdentifier, Uri) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 171 | Low |
org.opendaylight.ovsdb.southbound.ovsdb.transact.BridgeOperationalState
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Redundant nullcheck of nodeCreateOrUpdate, which is known to be non-null in new org.opendaylight.ovsdb.southbound.ovsdb.transact.BridgeOperationalState(DataBroker, AsyncDataChangeEvent) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 47 | Low |
org.opendaylight.ovsdb.southbound.ovsdb.transact.QosUpdateCommand
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.opendaylight.ovsdb.southbound.ovsdb.transact.QosUpdateCommand.execute(TransactionBuilder, BridgeOperationalState, Map, InstanceIdentifierCodec): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 120 | High |
| Found reliance on default encoding in org.opendaylight.ovsdb.southbound.ovsdb.transact.QosUpdateCommand.getQueueUuid(OvsdbQueueRef, OvsdbNodeAugmentation): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 146 | High |
| Return value of org.opendaylight.ovsdb.lib.operations.TransactionBuilder.build() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 121 | Medium |
org.opendaylight.ovsdb.southbound.ovsdb.transact.QueueUpdateCommand
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.opendaylight.ovsdb.southbound.ovsdb.transact.QueueUpdateCommand.execute(TransactionBuilder, BridgeOperationalState, Map, InstanceIdentifierCodec): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 110 | High |
| org.opendaylight.ovsdb.southbound.ovsdb.transact.QueueUpdateCommand.execute(TransactionBuilder, BridgeOperationalState, Map, InstanceIdentifierCodec) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 76 | Medium |
| Return value of org.opendaylight.ovsdb.lib.operations.TransactionBuilder.build() ignored, but method has no side effect | STYLE | RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT | 111 | Medium |
org.opendaylight.ovsdb.southbound.ovsdb.transact.TerminationPointUpdateCommand
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in org.opendaylight.ovsdb.southbound.ovsdb.transact.TerminationPointUpdateCommand.updatePortQos(OvsdbTerminationPointAugmentation, Port, OvsdbBridgeAugmentation): String.getBytes() | I18N | DM_DEFAULT_ENCODING | 188 | High |
org.opendaylight.ovsdb.southbound.reconciliation.ReconciliationManager$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.opendaylight.ovsdb.southbound.reconciliation.ReconciliationManager$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 198 | Low |
org.opendaylight.ovsdb.southbound.reconciliation.ReconciliationManager$NodeConnectionMetadata
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Should org.opendaylight.ovsdb.southbound.reconciliation.ReconciliationManager$NodeConnectionMetadata be a _static_ inner class? | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC | 274 | Medium |
org.opendaylight.ovsdb.southbound.reconciliation.configuration.BridgeConfigReconciliationTask$2
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.opendaylight.ovsdb.southbound.reconciliation.configuration.BridgeConfigReconciliationTask$2 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 159 | Low |
org.opendaylight.ovsdb.southbound.reconciliation.configuration.TerminationPointConfigReconciliationTask$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| The class org.opendaylight.ovsdb.southbound.reconciliation.configuration.TerminationPointConfigReconciliationTask$1 could be refactored into a named _static_ inner class | PERFORMANCE | SIC_INNER_SHOULD_BE_STATIC_ANON | 60 | Low |
org.opendaylight.ovsdb.southbound.reconciliation.connection.ConnectionReconciliationTask
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Result of integer multiplication cast to long in org.opendaylight.ovsdb.southbound.reconciliation.connection.ConnectionReconciliationTask.retryDelayInMills() | STYLE | ICAST_INTEGER_MULTIPLY_CAST_TO_LONG | 80 | Low |
org.opendaylight.ovsdb.southbound.transactions.md.OpenVSwitchUpdateCommand
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opendaylight.ovsdb.southbound.transactions.md.OpenVSwitchUpdateCommand.setNewExternalIds(OvsdbNodeAugmentationBuilder, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 192 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OpenVSwitchUpdateCommand.setNewOtherConfigs(OvsdbNodeAugmentationBuilder, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 142 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbAutoAttachUpdateCommand
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbAutoAttachUpdateCommand.setMappings(AutoattachBuilder, AutoAttach) invokes inefficient new Integer(String) constructor; use Integer.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 144 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbAutoAttachUpdateCommand.setMappings(AutoattachBuilder, AutoAttach) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 144 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbBridgeUpdateCommand
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to bridgeControllerPortNumber in org.opendaylight.ovsdb.southbound.transactions.md.OvsdbBridgeUpdateCommand.setOpenFlowNodeRef(OvsdbBridgeAugmentationBuilder, Bridge) | STYLE | DLS_DEAD_LOCAL_STORE | 362 | Medium |
| Redundant nullcheck of org.opendaylight.ovsdb.southbound.SouthboundMapper.createMdsalProtocols(Bridge), which is known to be non-null in org.opendaylight.ovsdb.southbound.transactions.md.OvsdbBridgeUpdateCommand.setProtocol(OvsdbBridgeAugmentationBuilder, Bridge) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 330 | Low |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbBridgeUpdateCommand.setExternalIds(OvsdbBridgeAugmentationBuilder, Bridge) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 316 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbBridgeUpdateCommand.setOtherConfig(OvsdbBridgeAugmentationBuilder, Bridge) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 295 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortRemoveCommand
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortRemoveCommand.execute(ReadWriteTransaction) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 55 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Dead store to bridgeId in org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateTerminationPoints(ReadWriteTransaction, Node) | STYLE | DLS_DEAD_LOCAL_STORE | 135 | Low |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateQos(ReadWriteTransaction, Node, InstanceIdentifier, Map$Entry, OvsdbTerminationPointAugmentationBuilder) invokes inefficient new Long(long) constructor; use Long.valueOf(long) instead | PERFORMANCE | DM_NUMBER_CTOR | 370 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.getTerminationPointBridge(UUID) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 224 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateInterfaceBfd(Interface, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 636 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateInterfaceBfdStatus(Interface, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 612 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateInterfaceExternalIds(Interface, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 490 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateInterfaceLldp(Interface, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 569 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateInterfaceOtherConfig(Interface, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 593 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updateOptions(Interface, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 530 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updatePortExternalIds(Port, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 510 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbPortUpdateCommand.updatePortOtherConfig(Port, OvsdbTerminationPointAugmentationBuilder) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 550 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbQosUpdateCommand
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbQosUpdateCommand.removeOldQueues(ReadWriteTransaction, QosEntriesBuilder, Map, Qos, InstanceIdentifier) invokes inefficient new Long(String) constructor; use Long.valueOf(String) instead | PERFORMANCE | DM_NUMBER_CTOR | 311 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbQosUpdateCommand.setNewExternalIds(QosEntriesBuilder, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 272 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbQosUpdateCommand.setNewOtherConfigs(QosEntriesBuilder, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 222 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.OvsdbQueueUpdateCommand
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbQueueUpdateCommand.setNewExternalIds(QueuesBuilder, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 224 | Medium |
| org.opendaylight.ovsdb.southbound.transactions.md.OvsdbQueueUpdateCommand.setNewOtherConfigs(QueuesBuilder, Map) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 174 | Medium |
org.opendaylight.ovsdb.southbound.transactions.md.TransactionInvokerImpl
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opendaylight.ovsdb.southbound.transactions.md.TransactionInvokerImpl.invoke(TransactionCommand) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 62 | Medium |
| Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opendaylight.ovsdb.southbound.transactions.md.TransactionInvokerImpl.onTransactionChainFailed(TransactionChain, AsyncTransaction, Throwable) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 68 | Medium |
| Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opendaylight.ovsdb.southbound.transactions.md.TransactionInvokerImpl.run() | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 114 | Medium |
| Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in new org.opendaylight.ovsdb.southbound.transactions.md.TransactionInvokerImpl(DataBroker) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 56 | Low |
org.opendaylight.ovsdb.southbound.transactions.md.TransactionInvokerImpl$1
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exceptional return value of java.util.concurrent.BlockingQueue.offer(Object) ignored in org.opendaylight.ovsdb.southbound.transactions.md.TransactionInvokerImpl$1.onSuccess(Void) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 99 | Medium |