Checkstyle Results

The following document contains the results of Checkstyle 6.2 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
15 0 183 0

Rules

Category Rule Violations Severity
blocks LeftCurly
  • maxLineLength: "100"
6  Warning
RightCurly
  • tokens: "CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"
  • option: "alone"
1  Warning
RightCurly 1  Warning
imports CustomImportOrder
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###STANDARD_JAVA_PACKAGE###THIRD_PARTY_PACKAGE###SPECIAL_IMPORTS"
  • thirdPartyPackageRegExp: ".*"
  • specialImportsRegExp: "^com.*"
25  Warning
indentation Indentation
  • lineWrappingIndentation: "4"
  • caseIndent: "4"
  • arrayInitIndent: "4"
  • throwsIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
118  Warning
javadoc JavadocMethod
  • allowMissingParamTags: "true"
  • allowedAnnotations: "Override, Test"
  • allowThrowsTagsForSubclasses: "true"
  • scope: "public"
  • allowMissingReturnTag: "true"
  • minLineCount: "2"
  • allowMissingThrowsTags: "true"
19  Warning
naming LocalVariableName
  • allowOneCharVarInForLoop: "true"
  • tokens: "VARIABLE_DEF"
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
5  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
8  Warning
whitespace WhitespaceAround
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
  • allowEmptyMethods: "true"
  • allowEmptyConstructors: "true"
1  Warning

Details

org/opendaylight/topology/mlmt/utility/MlmtAbstractTopologyUpdate.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. 12
 Warning javadoc JavadocMethod Missing a Javadoc comment. 21

org/opendaylight/topology/mlmt/utility/MlmtDataChangeObserver.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yangtools.yang.binding.DataObject' import. 14
 Warning sizes LineLength Line is longer than 120 characters (found 121). 18

org/opendaylight/topology/mlmt/utility/MlmtOperationProcessor.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.OptimisticLockFailedException' import. 19
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 23
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 24
 Warning javadoc JavadocMethod Missing a Javadoc comment. 40
 Warning javadoc JavadocMethod Missing a Javadoc comment. 46
 Warning indentation Indentation 'while' have incorrect indentation level 12, expected level should be 8. 72
 Warning indentation Indentation 'try' have incorrect indentation level 16, expected level should be 12. 73
 Warning indentation Indentation 'member def type' have incorrect indentation level 20, expected level should be 16. 74
 Warning indentation Indentation 'try' child have incorrect indentation level 20, expected level should be 16. 74
 Warning indentation Indentation 'try' child have incorrect indentation level 20, expected level should be 16. 75
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 20, expected level should be 16. 76
 Warning indentation Indentation 'try' child have incorrect indentation level 20, expected level should be 16. 76
 Warning indentation Indentation 'member def type' have incorrect indentation level 20, expected level should be 16. 77
 Warning indentation Indentation 'try' child have incorrect indentation level 20, expected level should be 16. 77
 Warning indentation Indentation 'do..while' have incorrect indentation level 20, expected level should be 16. 78
 Warning indentation Indentation 'do..while' child have incorrect indentation level 24, expected level should be 20. 79
 Warning indentation Indentation 'do..while' child have incorrect indentation level 24, expected level should be 20. 80
 Warning indentation Indentation 'if' have incorrect indentation level 24, expected level should be 20. 81
 Warning indentation Indentation 'if' child have incorrect indentation level 28, expected level should be 24. 82
 Warning indentation Indentation 'if rcurly' have incorrect indentation level 24, expected level should be 20. 83
 Warning indentation Indentation 'else' child have incorrect indentation level 28, expected level should be 24. 84
 Warning indentation Indentation 'else rcurly' have incorrect indentation level 24, expected level should be 20. 85
 Warning indentation Indentation 'do..while' child have incorrect indentation level 24, expected level should be 20. 87
 Warning indentation Indentation 'do..while rcurly' have incorrect indentation level 20, expected level should be 16. 88
 Warning indentation Indentation 'try' child have incorrect indentation level 20, expected level should be 16. 90
 Warning indentation Indentation 'try' have incorrect indentation level 20, expected level should be 16. 91
 Warning indentation Indentation 'try' child have incorrect indentation level 24, expected level should be 20. 92
 Warning indentation Indentation 'try rcurly' have incorrect indentation level 20, expected level should be 16. 93
 Warning indentation Indentation 'catch' child have incorrect indentation level 24, expected level should be 20. 94
 Warning indentation Indentation 'catch' child have incorrect indentation level 24, expected level should be 20. 95
 Warning indentation Indentation 'catch' child have incorrect indentation level 24, expected level should be 20. 96
 Warning indentation Indentation 'catch' child have incorrect indentation level 24, expected level should be 20. 97
 Warning indentation Indentation 'catch rcurly' have incorrect indentation level 20, expected level should be 16. 98
 Warning indentation Indentation 'try rcurly' have incorrect indentation level 16, expected level should be 12. 99
 Warning indentation Indentation 'catch' child have incorrect indentation level 20, expected level should be 16. 100
 Warning indentation Indentation 'catch' child have incorrect indentation level 20, expected level should be 16. 101
 Warning indentation Indentation 'catch' child have incorrect indentation level 20, expected level should be 16. 102
 Warning indentation Indentation 'catch' child have incorrect indentation level 20, expected level should be 16. 103
 Warning indentation Indentation 'catch rcurly' have incorrect indentation level 16, expected level should be 12. 104
 Warning indentation Indentation 'catch' child have incorrect indentation level 20, expected level should be 16. 105
 Warning indentation Indentation 'catch' child have incorrect indentation level 20, expected level should be 16. 106
 Warning indentation Indentation 'catch rcurly' have incorrect indentation level 16, expected level should be 12. 107
 Warning indentation Indentation 'catch' child have incorrect indentation level 20, expected level should be 16. 108
 Warning indentation Indentation 'catch rcurly' have incorrect indentation level 16, expected level should be 12. 109
 Warning indentation Indentation 'while rcurly' have incorrect indentation level 12, expected level should be 8. 110
 Warning sizes LineLength Line is longer than 120 characters (found 125). 122
 Warning sizes LineLength Line is longer than 120 characters (found 126). 123

org/opendaylight/topology/mlmt/utility/MlmtProviderFactory.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.topology.mlmt.utility.MlmtConsequentAction' import. 18
 Warning sizes LineLength Line is longer than 120 characters (found 121). 23

org/opendaylight/topology/mlmt/utility/MlmtTopologyBuilder.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 13
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 14
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 15
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 16
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction' import. 19
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataBroker' import. 21
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.TopologyKey' import. 25
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.TopologyId' import. 26
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Link' import. 30
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.LinkId' import. 33
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.TpId' import. 46
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier' import. 48
 Warning javadoc JavadocMethod Missing a Javadoc comment. 56
 Warning javadoc JavadocMethod Missing a Javadoc comment. 62
 Warning naming LocalVariableName Local variable name 'lUnderlayTopology' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 79
 Warning javadoc JavadocMethod Missing a Javadoc comment. 89
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 14, expected level should be one of the following: 12, 16. 110
 Warning indentation Indentation 'object def rcurly' have incorrect indentation level 9, expected level should be one of the following: 8, 12. 111
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 5, expected level should be 4. 112
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 5, expected level should be 4. 114
 Warning javadoc JavadocMethod Missing a Javadoc comment. 114
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 116
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 14, expected level should be one of the following: 12, 16. 119
 Warning indentation Indentation 'method def' child have incorrect indentation level 18, expected level should be one of the following: 16, 20. 121
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 14, expected level should be one of the following: 12, 16. 122
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 14, expected level should be one of the following: 12, 16. 124
 Warning blocks LeftCurly '{' should have line break after. 125
 Warning indentation Indentation 'object def rcurly' have incorrect indentation level 9, expected level should be one of the following: 8, 12. 126
 Warning javadoc JavadocMethod Missing a Javadoc comment. 129
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 147
 Warning blocks LeftCurly '{' should have line break after. 159
 Warning javadoc JavadocMethod Missing a Javadoc comment. 168
 Warning sizes LineLength Line is longer than 120 characters (found 126). 185
 Warning naming LocalVariableName Local variable name 'lSupporting' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 187
 Warning naming LocalVariableName Local variable name 'lTp' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 195
 Warning javadoc JavadocMethod Missing a Javadoc comment. 203
 Warning blocks LeftCurly '{' should have line break after. 217
 Warning javadoc JavadocMethod Missing a Javadoc comment. 221
 Warning javadoc JavadocMethod Missing a Javadoc comment. 237
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 13, expected level should be one of the following: 12, 16. 245
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 17, expected level should be one of the following: 16, 20. 247
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 247
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 17, expected level should be one of the following: 16, 20. 248
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 248
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 17, expected level should be one of the following: 16, 20. 249
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 249
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 250
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 251
 Warning indentation Indentation 'member def type' have incorrect indentation level 17, expected level should be one of the following: 16, 20. 252
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 252
 Warning naming LocalVariableName Local variable name 'lTpId' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 252
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 253
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 254
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 17, expected level should be one of the following: 16, 20. 255
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 255
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 257
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 13, expected level should be one of the following: 12, 16. 258
 Warning javadoc JavadocMethod Missing a Javadoc comment. 262
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 8, expected level should be one of the following: 12, 16. 270
 Warning indentation Indentation 'member def type' have incorrect indentation level 17, expected level should be one of the following: 16, 20. 272
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 272
 Warning indentation Indentation 'member def type' have incorrect indentation level 17, expected level should be one of the following: 16, 20. 273
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 273
 Warning sizes LineLength Line is longer than 120 characters (found 121). 273
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 274
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 13, expected level should be one of the following: 12, 16. 275
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 13, expected level should be one of the following: 12, 16. 277
 Warning blocks LeftCurly '{' should have line break after. 278
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 3, expected level should be 4. 282
 Warning javadoc JavadocMethod Missing a Javadoc comment. 282
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 13, expected level should be one of the following: 12, 16. 290
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 17, expected level should be one of the following: 16, 20. 292
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 292
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 294
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 13, expected level should be one of the following: 12, 16. 295
 Warning javadoc JavadocMethod Missing a Javadoc comment. 299
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 9, expected level should be 8. 304
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 304
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 9, expected level should be 8. 305
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 305
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 9, expected level should be 8. 306
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 306
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 308
 Warning indentation Indentation 'method def' child have incorrect indentation level 18, expected level should be one of the following: 17, 21. 311
 Warning indentation Indentation 'method def' child have incorrect indentation level 18, expected level should be one of the following: 17, 21. 312
 Warning indentation Indentation 'method def' child have incorrect indentation level 18, expected level should be one of the following: 17, 21. 313
 Warning indentation Indentation 'method def' child have incorrect indentation level 18, expected level should be one of the following: 17, 21. 314
 Warning indentation Indentation 'member def type' have incorrect indentation level 18, expected level should be one of the following: 17, 21. 315
 Warning indentation Indentation 'method def' child have incorrect indentation level 18, expected level should be one of the following: 17, 21. 315
 Warning indentation Indentation 'method def' child have incorrect indentation level 18, expected level should be one of the following: 17, 21. 316
 Warning indentation Indentation 'member def type' have incorrect indentation level 18, expected level should be one of the following: 17, 21. 317
 Warning indentation Indentation 'method def' child have incorrect indentation level 18, expected level should be one of the following: 17, 21. 317
 Warning indentation Indentation 'method def' child have incorrect indentation level 18, expected level should be one of the following: 17, 21. 318
 Warning indentation Indentation 'member def type' have incorrect indentation level 18, expected level should be one of the following: 17, 21. 319
 Warning indentation Indentation 'method def' child have incorrect indentation level 18, expected level should be one of the following: 17, 21. 319
 Warning naming LocalVariableName Local variable name 'lSupporting' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 319
 Warning indentation Indentation 'method def' child have incorrect indentation level 18, expected level should be one of the following: 17, 21. 320
 Warning indentation Indentation 'method def' child have incorrect indentation level 18, expected level should be one of the following: 17, 21. 321
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 18, expected level should be one of the following: 17, 21. 322
 Warning indentation Indentation 'method def' child have incorrect indentation level 18, expected level should be one of the following: 17, 21. 322
 Warning indentation Indentation 'method def' child have incorrect indentation level 18, expected level should be one of the following: 17, 21. 324
 Warning indentation Indentation 'object def rcurly' have incorrect indentation level 8, expected level should be one of the following: 9, 13. 326
 Warning javadoc JavadocMethod Missing a Javadoc comment. 329
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 13, expected level should be one of the following: 12, 16. 335
 Warning indentation Indentation 'member def type' have incorrect indentation level 17, expected level should be one of the following: 16, 20. 337
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 337
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 338
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 13, expected level should be one of the following: 12, 16. 339
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 13, expected level should be one of the following: 12, 16. 341
 Warning blocks LeftCurly '{' should have line break after. 342
 Warning javadoc JavadocMethod Missing a Javadoc comment. 346
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 13, expected level should be one of the following: 12, 16. 352
 Warning indentation Indentation 'member def type' have incorrect indentation level 17, expected level should be one of the following: 16, 20. 354
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 354
 Warning indentation Indentation 'method def' child have incorrect indentation level 17, expected level should be one of the following: 16, 20. 355
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 13, expected level should be one of the following: 12, 16. 356

org/opendaylight/topology/mlmt/utility/MlmtTopologyNotify.java

Severity Category Rule Message Line
 Warning javadoc JavadocMethod Missing a Javadoc comment. 29
 Warning indentation Indentation 'ctor def rcurly' have incorrect indentation level 5, expected level should be 4. 33

org/opendaylight/topology/mlmt/utility/MlmtTopologyOperation.java

Severity Category Rule Message Line
 Warning blocks LeftCurly '{' should have line break after. 25
 Warning blocks RightCurly '}' should be alone on a line. 25

org/opendaylight/topology/mlmt/utility/MlmtTopologyProvider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. 12
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Link' import. 18

org/opendaylight/topology/mlmt/utility/MlmtTopologyUpdate.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. 12
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Link' import. 17

org/opendaylight/topology/mlmt/utility/MlmtTopologyUpdateOnLink.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. 12
 Warning sizes LineLength Line is longer than 120 characters (found 121). 23

org/opendaylight/topology/mlmt/utility/MlmtTopologyUpdateOnNode.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. 12
 Warning sizes LineLength Line is longer than 120 characters (found 121). 23

org/opendaylight/topology/mlmt/utility/MlmtTopologyUpdateOnTp.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. 12
 Warning javadoc JavadocMethod Missing a Javadoc comment. 24