Checkstyle Results

The following document contains the results of Checkstyle 6.2 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
3 0 98 0

Rules

Category Rule Violations Severity
blocks RightCurly
  • tokens: "CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"
  • option: "alone"
1  Warning
RightCurly 1  Warning
imports CustomImportOrder
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###STANDARD_JAVA_PACKAGE###THIRD_PARTY_PACKAGE###SPECIAL_IMPORTS"
  • thirdPartyPackageRegExp: ".*"
  • specialImportsRegExp: "^com.*"
21  Warning
indentation Indentation
  • lineWrappingIndentation: "4"
  • caseIndent: "4"
  • arrayInitIndent: "4"
  • throwsIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
51  Warning
javadoc JavadocMethod
  • allowMissingParamTags: "true"
  • allowedAnnotations: "Override, Test"
  • allowThrowsTagsForSubclasses: "true"
  • scope: "public"
  • allowMissingReturnTag: "true"
  • minLineCount: "2"
  • allowMissingThrowsTags: "true"
1  Warning
naming LocalVariableName
  • allowOneCharVarInForLoop: "true"
  • tokens: "VARIABLE_DEF"
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
6  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
15  Warning
whitespace FileTabCharacter
  • eachLine: "true"
2  Error
MethodParamPad 1  Warning

Details

org/opendaylight/topology/mlmt/parser/InventoryAttributesParserImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.inventory.rev130819.NodeConnectorRef' import. 12
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.topology.mlmt.inventory.InventoryAttributesParser' import. 18

org/opendaylight/topology/mlmt/parser/MultilayerAttributesParserImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'java.util.UUID' import. 15
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.LinkId' import. 19
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.LinkBuilder' import. 22
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.link.attributes.SourceBuilder' import. 24
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.link.attributes.DestinationBuilder' import. 25
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.link.attributes.Source' import. 27
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.link.attributes.Destination' import. 28
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.ForwardingAdjacencyAttributes' import. 29
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.FaId' import. 30
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.FaEndPoint' import. 31
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.fa.parameters.directionality.info.Bidirectional' import. 33
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.fa.parameters.DirectionalityInfo' import. 34
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multitechnology.rev150122.MtInfo' import. 38
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.topology.multilayer.MultilayerAttributesParser' import. 44
 Warning javadoc JavadocMethod Missing a Javadoc comment. 61
 Warning sizes LineLength Line is longer than 120 characters (found 152). 68
 Warning sizes LineLength Line is longer than 120 characters (found 186). 69
 Warning sizes LineLength Line is longer than 120 characters (found 138). 70
 Warning sizes LineLength Line is longer than 120 characters (found 173). 71
 Warning sizes LineLength Line is longer than 120 characters (found 154). 75
 Warning sizes LineLength Line is longer than 120 characters (found 189). 76
 Warning sizes LineLength Line is longer than 120 characters (found 139). 77
 Warning sizes LineLength Line is longer than 120 characters (found 175). 78
 Warning indentation Indentation 'if' child have incorrect indentation level 11, expected level should be 12. 119
 Warning indentation Indentation 'if' child have incorrect indentation level 11, expected level should be 12. 128
 Warning blocks RightCurly '}' should be on the same line. 129
 Warning indentation Indentation 'else' child have incorrect indentation level 11, expected level should be 12. 131
 Warning indentation Indentation 'member def type' have incorrect indentation level 16, expected level should be 8. 151
 Warning indentation Indentation 'method def' child have incorrect indentation level 16, expected level should be 8. 151
 Warning whitespace FileTabCharacter Line contains a tab character. 151
 Warning indentation Indentation 'member def type' have incorrect indentation level 16, expected level should be 8. 162
 Warning indentation Indentation 'method def' child have incorrect indentation level 16, expected level should be 8. 162
 Warning whitespace FileTabCharacter Line contains a tab character. 162
 Warning naming LocalVariableName Local variable name 'r' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 169
 Warning naming LocalVariableName Local variable name 'm' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 170
 Warning naming LocalVariableName Local variable name 'r' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 184
 Warning naming LocalVariableName Local variable name 'm' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 185
 Warning naming LocalVariableName Local variable name 'r' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 199
 Warning naming LocalVariableName Local variable name 'm' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 200
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 5, expected level should be 4. 237

org/opendaylight/topology/mlmt/parser/MultitechnologyAttributesParserImpl.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Link' import. 12
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.ted.rev131021.TedNodeAttributes' import. 13
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.ted.rev131021.TedLinkAttributes' import. 14
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.nt.l3.unicast.igp.topology.rev131021.Link1' import. 17
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.topology.multitechnology.MultitechnologyAttributesParser' import. 20
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 5, expected level should be 4. 24
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 5, expected level should be 4. 26
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 27
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 5, expected level should be 4. 28
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 5, expected level should be 4. 30
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 9, expected level should be 8. 32
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 32
 Warning indentation Indentation 'if' have incorrect indentation level 9, expected level should be 8. 33
 Warning indentation Indentation 'if' child have incorrect indentation level 13, expected level should be 12. 34
 Warning indentation Indentation 'if rcurly' have incorrect indentation level 9, expected level should be 8. 35
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 37
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 5, expected level should be 4. 38
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 5, expected level should be 4. 40
 Warning sizes LineLength Line is longer than 120 characters (found 140). 40
 Warning indentation Indentation 'member def type' have incorrect indentation level 9, expected level should be 8. 43
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 43
 Warning sizes LineLength Line is longer than 120 characters (found 139). 45
 Warning indentation Indentation 'if' have incorrect indentation level 9, expected level should be 8. 46
 Warning indentation Indentation 'if' child have incorrect indentation level 13, expected level should be 12. 47
 Warning indentation Indentation 'if rcurly' have incorrect indentation level 9, expected level should be 8. 48
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 50
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 5, expected level should be 4. 51
 Warning indentation Indentation 'method def modifier' have incorrect indentation level 5, expected level should be 4. 53
 Warning indentation Indentation 'member def type' have incorrect indentation level 9, expected level should be 8. 56
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 56
 Warning indentation Indentation 'if' have incorrect indentation level 9, expected level should be 8. 57
 Warning indentation Indentation 'if' child have incorrect indentation level 13, expected level should be 12. 58
 Warning indentation Indentation 'if rcurly' have incorrect indentation level 9, expected level should be 8. 59
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 9, expected level should be 8. 60
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 60
 Warning sizes LineLength Line is longer than 120 characters (found 142). 60
 Warning indentation Indentation 'if' have incorrect indentation level 9, expected level should be 8. 62
 Warning indentation Indentation 'if' child have incorrect indentation level 13, expected level should be 12. 63
 Warning indentation Indentation 'if rcurly' have incorrect indentation level 9, expected level should be 8. 64
 Warning indentation Indentation 'member def modifier' have incorrect indentation level 9, expected level should be 8. 65
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 65
 Warning sizes LineLength Line is longer than 120 characters (found 148). 65
 Warning indentation Indentation 'ted' have incorrect indentation level 9, expected level should be 13. 66
 Warning indentation Indentation 'method def' child have incorrect indentation level 9, expected level should be 8. 68
 Warning indentation Indentation 'if' child have incorrect indentation level 11, expected level should be 12. 76
 Warning indentation Indentation 'method call' child have incorrect indentation level 11, expected level should be 12. 76
 Warning indentation Indentation 'if' child have incorrect indentation level 11, expected level should be 12. 77
 Warning sizes LineLength Line is longer than 120 characters (found 139). 85
 Warning sizes LineLength Line is longer than 120 characters (found 141). 89
 Warning sizes LineLength Line is longer than 120 characters (found 147). 94
 Warning indentation Indentation 'ted' have incorrect indentation level 8, expected level should be 12. 95
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 3, expected level should be 4. 98
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 101
 Warning indentation Indentation 'if' child have incorrect indentation level 11, expected level should be 12. 105
 Warning indentation Indentation 'method call' child have incorrect indentation level 11, expected level should be 12. 105
 Warning indentation Indentation 'if' child have incorrect indentation level 11, expected level should be 12. 106