Checkstyle Results

The following document contains the results of Checkstyle 6.2 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
3 0 111 0

Files

File  I  W  E
org/opendaylight/topology/multilayer/MultilayerAttributesParser.java 0 5 0
org/opendaylight/topology/multilayer/MultilayerForwardingAdjacency.java 0 3 0
org/opendaylight/topology/multilayer/MultilayerTopologyProvider.java 0 103 0

Rules

Category Rule Violations Severity
coding VariableDeclarationUsageDistance 2  Warning
imports CustomImportOrder
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###STANDARD_JAVA_PACKAGE###THIRD_PARTY_PACKAGE###SPECIAL_IMPORTS"
  • thirdPartyPackageRegExp: ".*"
  • specialImportsRegExp: "^com.*"
 37  Warning
indentation Indentation
  • lineWrappingIndentation: "4"
  • caseIndent: "4"
  • arrayInitIndent: "4"
  • throwsIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
 11  Warning
javadoc JavadocMethod
  • allowMissingParamTags: "true"
  • allowedAnnotations: "Override, Test"
  • allowThrowsTagsForSubclasses: "true"
  • scope: "public"
  • allowMissingReturnTag: "true"
  • minLineCount: "2"
  • allowMissingThrowsTags: "true"
 3  Warning
naming LocalVariableName
  • allowOneCharVarInForLoop: "true"
  • tokens: "VARIABLE_DEF"
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
 5  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 27  Warning
whitespace GenericWhitespace 17  Warning
OperatorWrap
  • tokens: "BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "
  • option: "NL"
 8  Warning
WhitespaceAround
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
  • allowEmptyMethods: "true"
  • allowEmptyConstructors: "true"
 1  Warning

Details

org/opendaylight/topology/multilayer/MultilayerAttributesParser.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.LinkId' import. 15
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.LinkBuilder' import. 17
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.ForwardingAdjacencyAttributes' import. 18
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.FaId' import. 19
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.FaEndPoint' import. 20

org/opendaylight/topology/multilayer/MultilayerForwardingAdjacency.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 125). 22
 Warning sizes LineLength Line is longer than 120 characters (found 125). 31
 Warning sizes LineLength Line is longer than 120 characters (found 125). 34

org/opendaylight/topology/multilayer/MultilayerTopologyProvider.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 13
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 14
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 15
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 16
 Warning imports CustomImportOrder Import statement is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group. 17
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.sal.binding.api.BindingAwareBroker.RoutedRpcRegistration' import. 20
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.DataBroker' import. 21
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.ReadOnlyTransaction' import. 23
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.BindingTransactionChain' import. 25
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType' import. 30
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Node' import. 34
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.TopologyKey' import. 35
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.NodeId' import. 36
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.TpId' import. 38
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.node.TerminationPointBuilder' import. 41
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.Link' import. 42
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.LinkId' import. 43
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.tbd.params.xml.ns.yang.network.topology.rev131021.network.topology.topology.LinkBuilder' import. 45
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.topology.mlmt.utility.MlmtOperationProcessor' import. 46
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multitechnology.rev150122.MtTopologyType' import. 50
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.MultilayerTopologyService' import. 51
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.ForwardingAdjAnnounceInput' import. 52
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.FaEndPoint' import. 61
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.MlTopologyTypeBuilder' import. 63
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.MlTopologyType' import. 64
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.MultilayerTopologyProviderRuntimeMXBean' import. 66
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.ForwardingAdjUpdateOutputBuilder' import. 70
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.fa.parameters.DirectionalityInfo' import. 73
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yangtools.yang.common.RpcResult' import. 79
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier' import. 80
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.rev150123.MultilayerTopologyContext' import. 82
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.util.concurrent.Futures' import. 84
 Warning javadoc JavadocMethod Missing a Javadoc comment. 96
 Warning javadoc JavadocMethod Missing a Javadoc comment. 106
 Warning sizes LineLength Line is longer than 120 characters (found 125). 112
 Warning javadoc JavadocMethod Missing a Javadoc comment. 112
 Warning sizes LineLength Line is longer than 120 characters (found 122). 114
 Warning sizes LineLength Line is longer than 120 characters (found 125). 124
 Warning sizes LineLength Line is longer than 120 characters (found 136). 125
 Warning sizes LineLength Line is longer than 120 characters (found 123). 225
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 312
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 318
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 5, expected level should be 4. 320
 Warning naming LocalVariableName Local variable name 'aLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 350
 Warning indentation Indentation 'if' child have incorrect indentation level 17, expected level should be 16. 356
 Warning indentation Indentation 'if' child have incorrect indentation level 17, expected level should be 16. 359
 Warning whitespace OperatorWrap '+' should be on a new line. 361
 Warning whitespace OperatorWrap '+' should be on a new line. 363
 Warning naming LocalVariableName Local variable name 'aLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 405
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 409
 Warning whitespace OperatorWrap '&&' should be on a new line. 425
 Warning whitespace OperatorWrap '&&' should be on a new line. 435
 Warning whitespace OperatorWrap '&&' should be on a new line. 461
 Warning whitespace OperatorWrap '&&' should be on a new line. 471
 Warning sizes LineLength Line is longer than 120 characters (found 123). 486
 Warning sizes LineLength Line is longer than 120 characters (found 158). 488
 Warning sizes LineLength Line is longer than 120 characters (found 196). 489
 Warning sizes LineLength Line is longer than 120 characters (found 143). 490
 Warning sizes LineLength Line is longer than 120 characters (found 174). 491
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 5, expected level should be 4. 527
 Warning sizes LineLength Line is longer than 120 characters (found 138). 533
 Warning sizes LineLength Line is longer than 120 characters (found 169). 534
 Warning naming LocalVariableName Local variable name 'iErrorBuilder' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 534
 Warning sizes LineLength Line is longer than 120 characters (found 132). 535
 Warning sizes LineLength Line is longer than 120 characters (found 162). 536
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 551
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 557
 Warning whitespace OperatorWrap '+' should be on a new line. 562
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 565
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 571
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 576
 Warning sizes LineLength Line is longer than 120 characters (found 121). 602
 Warning indentation Indentation 'catch' child have incorrect indentation level 13, expected level should be 12. 619
 Warning indentation Indentation 'catch' child have incorrect indentation level 13, expected level should be 12. 620
 Warning indentation Indentation 'catch' child have incorrect indentation level 13, expected level should be 12. 621
 Warning indentation Indentation 'catch' child have incorrect indentation level 13, expected level should be 12. 622
 Warning indentation Indentation 'catch' child have incorrect indentation level 13, expected level should be 12. 623
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 623
 Warning sizes LineLength Line is longer than 120 characters (found 129). 627
 Warning sizes LineLength Line is longer than 120 characters (found 155). 628
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 630
 Warning sizes LineLength Line is longer than 120 characters (found 131). 638
 Warning coding VariableDeclarationUsageDistance Distance between variable 'okBuilder' declaration and its first usage is 17, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 639
 Warning sizes LineLength Line is longer than 120 characters (found 157). 639
 Warning sizes LineLength Line is longer than 120 characters (found 140). 641
 Warning sizes LineLength Line is longer than 120 characters (found 171). 642
 Warning naming LocalVariableName Local variable name 'iErrorBuilder' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 642
 Warning sizes LineLength Line is longer than 120 characters (found 134). 643
 Warning sizes LineLength Line is longer than 120 characters (found 164). 644
 Warning naming LocalVariableName Local variable name 'aLinkToExclude' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 647
 Warning coding VariableDeclarationUsageDistance Distance between variable 'directionalityInfo' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 649
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 663
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 669
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 673
 Warning whitespace OperatorWrap '+' should be on a new line. 674
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 677
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 683
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 688
 Warning sizes LineLength Line is longer than 120 characters (found 143). 731
 Warning indentation Indentation 'catch' child have incorrect indentation level 20, expected level should be 12. 747
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 747
 Warning indentation Indentation 'method def' child have incorrect indentation level 16, expected level should be 8. 752
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 752