FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 102 |
31 |
0 |
0 |
org.opendaylight.topoprocessing.impl.operator.LinkCalculator
| Bug |
Category |
Details |
Line |
Priority |
| Inconsistent synchronization of org.opendaylight.topoprocessing.impl.operator.LinkCalculator.aggregator; locked 90% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
380 |
Medium |
| Inconsistent synchronization of org.opendaylight.topoprocessing.impl.operator.LinkCalculator.manager; locked 83% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
369 |
Medium |
org.opendaylight.topoprocessing.impl.operator.NodeAndTPAggregator
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of removedOverlayItem, which is known to be non-null in org.opendaylight.topoprocessing.impl.operator.NodeAndTPAggregator.addTPsToWrapperExceptRemoved(OverlayItemWrapper, int, OverlayItem) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
237 |
Medium |
| Repeated conditional test in org.opendaylight.topoprocessing.impl.operator.NodeAndTPAggregator.addTPsToWrapperExceptRemoved(OverlayItemWrapper, int, OverlayItem) |
CORRECTNESS |
RpC_REPEATED_CONDITIONAL_TEST |
237 |
Low |
org.opendaylight.topoprocessing.impl.operator.NodeAndTPAggregator$2
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to aggregatedTPsOpt in org.opendaylight.topoprocessing.impl.operator.NodeAndTPAggregator$2.addOverlayItem(OverlayItem) |
STYLE |
DLS_DEAD_LOCAL_STORE |
138 |
Low |
org.opendaylight.topoprocessing.impl.operator.NotificationInterConnector
| Bug |
Category |
Details |
Line |
Priority |
| Inconsistent synchronization of org.opendaylight.topoprocessing.impl.operator.NotificationInterConnector.operator; locked 66% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
202 |
Medium |
| org.opendaylight.topoprocessing.impl.operator.NotificationInterConnector.processCreatedChanges(YangInstanceIdentifier, UnderlayItem, String) makes inefficient use of keySet iterator instead of entrySet iterator |
PERFORMANCE |
WMI_WRONG_MAP_ITERATOR |
64 |
Medium |
org.opendaylight.topoprocessing.impl.operator.TerminationPointAggregator
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference of tpMapNodeOpt in org.opendaylight.topoprocessing.impl.operator.TerminationPointAggregator.processCreatedChanges(YangInstanceIdentifier, UnderlayItem, String) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
138 |
Medium |
| Possible null pointer dereference of tpBuilder in org.opendaylight.topoprocessing.impl.operator.TerminationPointAggregator.setTpToNode(List, NormalizedNode, String, String, Class) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
349 |
Medium |
| Repeated conditional test in org.opendaylight.topoprocessing.impl.operator.TerminationPointAggregator.processUpdatedChanges(YangInstanceIdentifier, UnderlayItem, String) |
CORRECTNESS |
RpC_REPEATED_CONDITIONAL_TEST |
178 |
Low |
org.opendaylight.topoprocessing.impl.operator.TerminationPointAggregator$TemporaryTerminationPoint
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.topoprocessing.impl.operator.TerminationPointAggregator$TemporaryTerminationPoint could be refactored into a _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS |
78 |
Low |
org.opendaylight.topoprocessing.impl.operator.TerminationPointFiltrator
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference of tpMapNodeOpt in org.opendaylight.topoprocessing.impl.operator.TerminationPointFiltrator.processCreatedChanges(YangInstanceIdentifier, UnderlayItem, String) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
77 |
Medium |
| Possible null pointer dereference of tpMapNodeOpt in org.opendaylight.topoprocessing.impl.operator.TerminationPointFiltrator.processUpdatedChanges(YangInstanceIdentifier, UnderlayItem, String) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
104 |
Medium |
org.opendaylight.topoprocessing.impl.operator.TerminationPointPreAggregationFiltrator
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference of tpMapNodeOpt in org.opendaylight.topoprocessing.impl.operator.TerminationPointPreAggregationFiltrator.processCreatedChanges(YangInstanceIdentifier, UnderlayItem, String) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
62 |
Medium |
org.opendaylight.topoprocessing.impl.operator.TopologyAggregator
| Bug |
Category |
Details |
Line |
Priority |
| Inconsistent synchronization of org.opendaylight.topoprocessing.impl.operator.TopologyAggregator.scriptEngine; locked 40% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
290 |
Medium |
org.opendaylight.topoprocessing.impl.operator.TopologyManager
| Bug |
Category |
Details |
Line |
Priority |
| Inconsistent synchronization of org.opendaylight.topoprocessing.impl.operator.TopologyManager.writer; locked 66% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
120 |
Medium |
org.opendaylight.topoprocessing.impl.operator.filtrator.Ipv4AddressFiltrator
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode<?,?> to org.opendaylight.yangtools.yang.data.api.schema.LeafNode in org.opendaylight.topoprocessing.impl.operator.filtrator.Ipv4AddressFiltrator.isFiltered(NormalizedNode) |
STYLE |
BC_UNCONFIRMED_CAST |
51 |
Low |
org.opendaylight.topoprocessing.impl.operator.filtrator.Ipv6AddressFiltrator
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode<?,?> to org.opendaylight.yangtools.yang.data.api.schema.LeafNode in org.opendaylight.topoprocessing.impl.operator.filtrator.Ipv6AddressFiltrator.isFiltered(NormalizedNode) |
STYLE |
BC_UNCONFIRMED_CAST |
51 |
Low |
org.opendaylight.topoprocessing.impl.operator.filtrator.RangeStringFiltrator
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode<?,?> to org.opendaylight.yangtools.yang.data.api.schema.LeafNode in org.opendaylight.topoprocessing.impl.operator.filtrator.RangeStringFiltrator.isFiltered(NormalizedNode) |
STYLE |
BC_UNCONFIRMED_CAST |
42 |
Low |
org.opendaylight.topoprocessing.impl.operator.filtrator.SpecificValueFiltrator
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode<?,?> to org.opendaylight.yangtools.yang.data.api.schema.LeafNode in org.opendaylight.topoprocessing.impl.operator.filtrator.SpecificValueFiltrator.isFiltered(NormalizedNode) |
STYLE |
BC_UNCONFIRMED_CAST |
46 |
Low |
org.opendaylight.topoprocessing.impl.request.TopologyRequestHandler
| Bug |
Category |
Details |
Line |
Priority |
| Load of known null value in org.opendaylight.topoprocessing.impl.request.TopologyRequestHandler.initRendering(Correlation) |
STYLE |
NP_LOAD_OF_KNOWN_NULL_VALUE |
511 |
Low |
org.opendaylight.topoprocessing.impl.rpc.OverlayRpcImplementation
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.data.api.schema.NormalizedNode<?,?> to org.opendaylight.yangtools.yang.data.api.schema.ContainerNode in org.opendaylight.topoprocessing.impl.rpc.OverlayRpcImplementation.invokeRpc(DOMRpcIdentifier, NormalizedNode) |
STYLE |
BC_UNCONFIRMED_CAST |
82 |
Low |
org.opendaylight.topoprocessing.impl.rpc.OverlayRpcImplementation$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.topoprocessing.impl.rpc.OverlayRpcImplementation$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
77 |
Low |
org.opendaylight.topoprocessing.impl.structure.IdentifierGenerator
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.topoprocessing.impl.structure.IdentifierGenerator.getNextIdentifier(CorrelationItemEnum) invokes inefficient new String(String) constructor |
PERFORMANCE |
DM_STRING_CTOR |
54 |
Medium |
org.opendaylight.topoprocessing.impl.util.IgnoreAddQueue$1
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.topoprocessing.impl.util.IgnoreAddQueue$1.next() can't throw NoSuchElementException |
BAD_PRACTICE |
IT_NO_SUCH_ELEMENT |
62 |
Medium |
org.opendaylight.topoprocessing.impl.writer.TopologyWriter$2
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.topoprocessing.impl.writer.TopologyWriter$2 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
245 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.TopoprocessingProviderImplBuilder$TopoprocessingProviderImplImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.TopoprocessingProviderImplBuilder$TopoprocessingProviderImplImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.TopoprocessingProviderImplBuilder$TopoprocessingProviderImplImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
258 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.topoprocessing.provider.impl.BindingNormalizedNodeSerializerBuilder$BindingNormalizedNodeSerializerImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.topoprocessing.provider.impl.BindingNormalizedNodeSerializerBuilder$BindingNormalizedNodeSerializerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.topoprocessing.provider.impl.BindingNormalizedNodeSerializerBuilder$BindingNormalizedNodeSerializerImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.topoprocessing.provider.impl.BrokerBuilder$BrokerImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.topoprocessing.provider.impl.BrokerBuilder$BrokerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.topoprocessing.provider.impl.BrokerBuilder$BrokerImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.topoprocessing.provider.impl.DomDataBrokerBuilder$DomDataBrokerImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.topoprocessing.provider.impl.DomDataBrokerBuilder$DomDataBrokerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.topoprocessing.provider.impl.DomDataBrokerBuilder$DomDataBrokerImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.topoprocessing.provider.impl.SchemaServiceBuilder$SchemaServiceImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.topoprocessing.provider.impl.SchemaServiceBuilder$SchemaServiceImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.topoprocessing.provider.impl.rev150209.modules.module.configuration.topoprocessing.provider.impl.SchemaServiceBuilder$SchemaServiceImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
