mlmt-topology-common-impl – Checkstyle Results

Checkstyle Results

The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset.

Summary

Files	Info	Warnings	Errors
38	0	156	0

Files

File	I	W	E
org/opendaylight/topology/mlmt/utility/MlmtOperationProcessor.java	0	1	0
org/opendaylight/topology/mlmt/utility/MlmtOperationProcessorTest.java	0	17	0
org/opendaylight/topology/mlmt/utility/MlmtResourceNameCorrelation.java	0	38	0
org/opendaylight/topology/mlmt/utility/MlmtResourceNameCorrelator.java	0	5	0
org/opendaylight/topology/mlmt/utility/MlmtTopologyBuilder.java	0	27	0
org/opendaylight/topology/mlmt/utility/MlmtTopologyBuilderTest.java	0	49	0
org/opendaylight/topology/mlmt/utility/MlmtTopologyNotify.java	0	1	0
org/opendaylight/topology/mlmt/utility/MlmtTopologyNotifyTest.java	0	3	0
org/opendaylight/topology/mlmt/utility/MlmtTopologyOperation.java	0	2	0
org/opendaylight/topology/mlmt/utility/MlmtTopologyUpdateTest.java	0	4	0
org/opendaylight/topology/mlmt/utility/MlmtTpIdIpAddress.java	0	4	0
org/opendaylight/topology/mlmt/utility/instanceidentifier/InstanceIdentifiersTest.java	0	5	0

Rules

Category	Rule	Violations	Severity
blocks	EmptyBlock tokens: `"LITERAL_TRY, LITERAL_CATCH, LITERAL_FINALLY, LITERAL_IF, LITERAL_ELSE, LITERAL_SWITCH"` option: `"TEXT"`	2	Warning
	LeftCurly maxLineLength: `"100"`	15	Warning
	RightCurly tokens: `"CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"` option: `"alone"`	15	Warning
	RightCurly	15	Warning
coding	IllegalCatch	2	Warning
	OverloadMethodsDeclarationOrder	10	Warning
	VariableDeclarationUsageDistance	7	Warning
naming	LocalVariableName format: `"^[a-z][a-z0-9][a-zA-Z0-9]*$"` allowOneCharVarInForLoop: `"true"` tokens: `"VARIABLE_DEF"`	69	Warning
	ParameterName format: `"^[a-z][a-z0-9][a-zA-Z0-9]*$"`	1	Warning
sizes	LineLength max: `"120"` ignorePattern: `"^package.\|^import.\|a href\|href\|http://\|https://\|ftp://"`	1	Warning
whitespace	EmptyLineSeparator allowNoEmptyLineBetweenFields: `"true"` tokens: `"IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"`	33	Warning
	WhitespaceAround allowEmptyConstructors: `"true"` allowEmptyMethods: `"true"` allowEmptyLoops: `"true"` allowEmptyTypes: `"true"`	1	Warning

Details

org/opendaylight/topology/mlmt/utility/MlmtOperationProcessor.java

Severity	Category	Rule	Message	Line
Warning	coding	IllegalCatch	Catching 'Exception' is not allowed.	112

org/opendaylight/topology/mlmt/utility/MlmtOperationProcessorTest.java

Severity	Category	Rule	Message	Line
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	114
Warning	blocks	LeftCurly	'{' at column 43 should have line break after.	137
Warning	blocks	RightCurly	'}' at column 58 should be alone on a line.	137
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	144
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	171
Warning	blocks	LeftCurly	'{' at column 43 should have line break after.	194
Warning	blocks	RightCurly	'}' at column 58 should be alone on a line.	194
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	201
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	228
Warning	blocks	LeftCurly	'{' at column 42 should have line break after.	251
Warning	blocks	RightCurly	'}' at column 57 should be alone on a line.	251
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	258
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	285
Warning	blocks	LeftCurly	'{' at column 42 should have line break after.	308
Warning	blocks	RightCurly	'}' at column 57 should be alone on a line.	308
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	315
Warning	blocks	EmptyBlock	Empty catch block.	360

org/opendaylight/topology/mlmt/utility/MlmtResourceNameCorrelation.java

Severity	Category	Rule	Message	Line
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	22
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	23
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	24
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	27
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	28
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	29
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	32
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	33
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	34
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	37
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	38
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	39
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	42
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	43
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	46
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	47
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	50
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	51
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	54
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	55
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	56
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	57
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	60
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	61
Warning	coding	OverloadMethodsDeclarationOrder	Overload methods should not be split. Previous overloaded method located at line '51'.	61
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	64
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	65
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	66
Warning	coding	OverloadMethodsDeclarationOrder	Overload methods should not be split. Previous overloaded method located at line '56'.	66
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	67
Warning	naming	ParameterName	Parameter name 'TpId' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	69
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	70
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	71
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	74
Warning	coding	OverloadMethodsDeclarationOrder	Overload methods should not be split. Previous overloaded method located at line '61'.	74
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	77
Warning	coding	OverloadMethodsDeclarationOrder	Overload methods should not be split. Previous overloaded method located at line '66'.	77
Warning	coding	OverloadMethodsDeclarationOrder	Overload methods should not be split. Previous overloaded method located at line '70'.	82

org/opendaylight/topology/mlmt/utility/MlmtResourceNameCorrelator.java

Severity	Category	Rule	Message	Line
Warning	coding	OverloadMethodsDeclarationOrder	Overload methods should not be split. Previous overloaded method located at line '334'.	403
Warning	coding	OverloadMethodsDeclarationOrder	Overload methods should not be split. Previous overloaded method located at line '375'.	410
Warning	coding	OverloadMethodsDeclarationOrder	Overload methods should not be split. Previous overloaded method located at line '403'.	504
Warning	coding	OverloadMethodsDeclarationOrder	Overload methods should not be split. Previous overloaded method located at line '410'.	511
Warning	coding	OverloadMethodsDeclarationOrder	Overload methods should not be split. Previous overloaded method located at line '470'.	538

org/opendaylight/topology/mlmt/utility/MlmtTopologyBuilder.java

Severity	Category	Rule	Message	Line
Warning	blocks	LeftCurly	'{' at column 42 should have line break after.	132
Warning	blocks	RightCurly	'}' at column 57 should be alone on a line.	132
Warning	blocks	LeftCurly	'{' at column 42 should have line break after.	160
Warning	blocks	RightCurly	'}' at column 57 should be alone on a line.	160
Warning	blocks	LeftCurly	'{' at column 42 should have line break after.	175
Warning	blocks	RightCurly	'}' at column 57 should be alone on a line.	175
Warning	blocks	LeftCurly	'{' at column 46 should have line break after.	208
Warning	blocks	RightCurly	'}' at column 61 should be alone on a line.	208
Warning	blocks	LeftCurly	'{' at column 46 should have line break after.	248
Warning	blocks	RightCurly	'}' at column 61 should be alone on a line.	248
Warning	blocks	LeftCurly	'{' at column 46 should have line break after.	289
Warning	blocks	RightCurly	'}' at column 61 should be alone on a line.	289
Warning	naming	LocalVariableName	Local variable name 'lSupporting' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	317
Warning	naming	LocalVariableName	Local variable name 'lTp' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	325
Warning	blocks	LeftCurly	'{' at column 42 should have line break after.	345
Warning	blocks	RightCurly	'}' at column 57 should be alone on a line.	345
Warning	naming	LocalVariableName	Local variable name 'lSupporting' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	368
Warning	naming	LocalVariableName	Local variable name 'lTpId' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	390
Warning	blocks	LeftCurly	'{' at column 42 should have line break after.	416
Warning	blocks	RightCurly	'}' at column 57 should be alone on a line.	416
Warning	naming	LocalVariableName	Local variable name 'lTpId' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	433
Warning	naming	LocalVariableName	Local variable name 'lSupporting' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	462
Warning	blocks	LeftCurly	'{' at column 42 should have line break after.	484
Warning	blocks	RightCurly	'}' at column 57 should be alone on a line.	484
Warning	naming	LocalVariableName	Local variable name 'lSupporting' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	504
Warning	blocks	LeftCurly	'{' at column 42 should have line break after.	524
Warning	blocks	RightCurly	'}' at column 57 should be alone on a line.	524

org/opendaylight/topology/mlmt/utility/MlmtTopologyBuilderTest.java

Severity	Category	Rule	Message	Line
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	136
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	153
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	188
Warning	naming	LocalVariableName	Local variable name 'lNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	196
Warning	naming	LocalVariableName	Local variable name 'lNodeNames' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	202
Warning	naming	LocalVariableName	Local variable name 'cNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	203
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	222
Warning	naming	LocalVariableName	Local variable name 'lNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	231
Warning	naming	LocalVariableName	Local variable name 'lNodeNames' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	234
Warning	naming	LocalVariableName	Local variable name 'cNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	235
Warning	naming	LocalVariableName	Local variable name 'sNodeName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	236
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	255
Warning	naming	LocalVariableName	Local variable name 'lNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	264
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	293
Warning	naming	LocalVariableName	Local variable name 'lNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	302
Warning	naming	LocalVariableName	Local variable name 'lNodeNames' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	307
Warning	naming	LocalVariableName	Local variable name 'lTpNames' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	308
Warning	naming	LocalVariableName	Local variable name 'cNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	309
Warning	naming	LocalVariableName	Local variable name 'sNodeName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	310
Warning	whitespace	WhitespaceAround	WhitespaceAround: 'if' is not followed by whitespace.	312
Warning	naming	LocalVariableName	Local variable name 'lTp' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	313
Warning	naming	LocalVariableName	Local variable name 'cTpName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	316
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	341
Warning	naming	LocalVariableName	Local variable name 'lNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	350
Warning	naming	LocalVariableName	Local variable name 'cNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	353
Warning	naming	LocalVariableName	Local variable name 'sNodeName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	354
Warning	coding	VariableDeclarationUsageDistance	Distance between variable 'linkBuilder' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value).	370
Warning	naming	LocalVariableName	Local variable name 'sLinkName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	371
Warning	coding	VariableDeclarationUsageDistance	Distance between variable 'linkKey' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value).	373
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	392
Warning	naming	LocalVariableName	Local variable name 'lLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	401
Warning	naming	LocalVariableName	Local variable name 'lLinkNames' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	404
Warning	naming	LocalVariableName	Local variable name 'cLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	405
Warning	naming	LocalVariableName	Local variable name 'cLinkName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	406
Warning	naming	LocalVariableName	Local variable name 'sLinkName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	418
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	428
Warning	naming	LocalVariableName	Local variable name 'lLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	437
Warning	naming	LocalVariableName	Local variable name 'lLinkNames' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	440
Warning	naming	LocalVariableName	Local variable name 'cLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	441
Warning	naming	LocalVariableName	Local variable name 'cLinkName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	442
Warning	naming	LocalVariableName	Local variable name 'sLinkName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	454
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	464
Warning	naming	LocalVariableName	Local variable name 'lLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	473
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	555
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	577
Warning	coding	VariableDeclarationUsageDistance	Distance between variable 'tpName' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value).	603
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	618
Warning	naming	LocalVariableName	Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	657
Warning	blocks	EmptyBlock	Empty catch block.	687

org/opendaylight/topology/mlmt/utility/MlmtTopologyNotify.java

Severity	Category	Rule	Message	Line
Warning	coding	IllegalCatch	Catching 'Exception' is not allowed.	52

org/opendaylight/topology/mlmt/utility/MlmtTopologyNotifyTest.java

Severity	Category	Rule	Message	Line
Warning	coding	VariableDeclarationUsageDistance	Distance between variable 'linkBuilder' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value).	176
Warning	naming	LocalVariableName	Local variable name 'sLinkName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	181
Warning	coding	VariableDeclarationUsageDistance	Distance between variable 'linkKey' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value).	183

org/opendaylight/topology/mlmt/utility/MlmtTopologyOperation.java

Severity	Category	Rule	Message	Line
Warning	blocks	LeftCurly	'{' at column 34 should have line break after.	25
Warning	blocks	RightCurly	'}' at column 50 should be alone on a line.	25

org/opendaylight/topology/mlmt/utility/MlmtTopologyUpdateTest.java

Severity	Category	Rule	Message	Line
Warning	sizes	LineLength	Line is longer than 120 characters (found 121).	54
Warning	coding	VariableDeclarationUsageDistance	Distance between variable 'linkBuilder' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value).	188
Warning	naming	LocalVariableName	Local variable name 'sLinkName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	189
Warning	coding	VariableDeclarationUsageDistance	Distance between variable 'linkKey' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value).	191

org/opendaylight/topology/mlmt/utility/MlmtTpIdIpAddress.java

Severity	Category	Rule	Message	Line
Warning	naming	LocalVariableName	Local variable name 'r' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	26
Warning	naming	LocalVariableName	Local variable name 'm' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	27
Warning	naming	LocalVariableName	Local variable name 'r' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	32
Warning	naming	LocalVariableName	Local variable name 'm' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	33

org/opendaylight/topology/mlmt/utility/instanceidentifier/InstanceIdentifiersTest.java

Severity	Category	Rule	Message	Line
Warning	whitespace	EmptyLineSeparator	'METHOD_DEF' should be separated from previous statement.	34
Warning	naming	LocalVariableName	Local variable name 'i' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	63
Warning	naming	LocalVariableName	Local variable name 'i' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	73
Warning	naming	LocalVariableName	Local variable name 'i' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	85
Warning	naming	LocalVariableName	Local variable name 'i' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'.	97