Checkstyle Results

The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
6 0 39 0

Files

File  I  W  E
org/opendaylight/topology/mlmt/parser/InventoryAttributesParserImplTest.java 0 3 0
org/opendaylight/topology/mlmt/parser/MultilayerAttributesParserImpl.java 0 15 0
org/opendaylight/topology/mlmt/parser/MultilayerAttributesParserImplTest.java 0 4 0
org/opendaylight/topology/mlmt/parser/MultitechnologyAttributesParserImpl.java 0 8 0
org/opendaylight/topology/mlmt/parser/MultitechnologyAttributesParserImplTest.java 0 9 0

Rules

Category Rule Violations Severity
blocks RightCurly
  • tokens: "CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_WHILE, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"
  • option: "alone"
 1  Warning
RightCurly 1  Warning
coding VariableDeclarationUsageDistance 7  Warning
indentation Indentation
  • throwsIndent: "4"
  • arrayInitIndent: "4"
  • caseIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
  • lineWrappingIndentation: "4"
 1  Warning
naming ConstantName 5  Warning
LocalVariableName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
  • allowOneCharVarInForLoop: "true"
  • tokens: "VARIABLE_DEF"
 9  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 15  Warning
whitespace MethodParamPad 1  Warning

Details

org/opendaylight/topology/mlmt/parser/InventoryAttributesParserImplTest.java

Severity Category Rule Message Line
 Warning naming ConstantName Name 'topologyName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 44
 Warning naming ConstantName Name 'inventoryNodeName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 45
 Warning naming ConstantName Name 'inventoryTpName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 46

org/opendaylight/topology/mlmt/parser/MultilayerAttributesParserImpl.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 152). 69
 Warning sizes LineLength Line is longer than 120 characters (found 186). 70
 Warning sizes LineLength Line is longer than 120 characters (found 138). 71
 Warning sizes LineLength Line is longer than 120 characters (found 173). 72
 Warning sizes LineLength Line is longer than 120 characters (found 154). 76
 Warning sizes LineLength Line is longer than 120 characters (found 189). 77
 Warning sizes LineLength Line is longer than 120 characters (found 139). 78
 Warning sizes LineLength Line is longer than 120 characters (found 175). 79
 Warning blocks RightCurly '}' at column 9 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else or try/catch/finally). 130
 Warning naming LocalVariableName Local variable name 'r' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 170
 Warning naming LocalVariableName Local variable name 'm' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 171
 Warning naming LocalVariableName Local variable name 'r' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 185
 Warning naming LocalVariableName Local variable name 'm' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 186
 Warning naming LocalVariableName Local variable name 'r' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 200
 Warning naming LocalVariableName Local variable name 'm' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 201

org/opendaylight/topology/mlmt/parser/MultilayerAttributesParserImplTest.java

Severity Category Rule Message Line
 Warning coding VariableDeclarationUsageDistance Distance between variable 'attributeKey' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 123
 Warning naming LocalVariableName Local variable name 'lMtInfo' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 137
 Warning naming LocalVariableName Local variable name 'lTpId' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 143
 Warning naming LocalVariableName Local variable name 'b' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 181

org/opendaylight/topology/mlmt/parser/MultitechnologyAttributesParserImpl.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 139). 37
 Warning sizes LineLength Line is longer than 120 characters (found 138). 42
 Warning sizes LineLength Line is longer than 120 characters (found 141). 57
 Warning sizes LineLength Line is longer than 120 characters (found 147). 62
 Warning sizes LineLength Line is longer than 120 characters (found 139). 82
 Warning sizes LineLength Line is longer than 120 characters (found 141). 86
 Warning sizes LineLength Line is longer than 120 characters (found 147). 91
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 98

org/opendaylight/topology/mlmt/parser/MultitechnologyAttributesParserImplTest.java

Severity Category Rule Message Line
 Warning naming ConstantName Name 'topologyName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 45
 Warning naming ConstantName Name 'nodeName' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 46
 Warning coding VariableDeclarationUsageDistance Distance between variable 'tedBuilder' declaration and its first usage is 13, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 62
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isisNodeAttributesBuilder' declaration and its first usage is 7, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 63
 Warning coding VariableDeclarationUsageDistance Distance between variable 'igpNodeAttributes1Builder' declaration and its first usage is 7, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 64
 Warning coding VariableDeclarationUsageDistance Distance between variable 'tedBuilder' declaration and its first usage is 17, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 100
 Warning coding VariableDeclarationUsageDistance Distance between variable 'isisLinkAttributedBuilder' declaration and its first usage is 11, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 103
 Warning coding VariableDeclarationUsageDistance Distance between variable 'igpLinkAttributes1Builder' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 104
 Warning indentation Indentation 'method def rcurly' have incorrect indentation level 3, expected level should be 4. 138