FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 36 |
20 |
0 |
0 |
org.opendaylight.topology.multilayer.MultilayerTopologyProvider
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to headEndTpId in org.opendaylight.topology.multilayer.MultilayerTopologyProvider.forwardingAdjUpdate(ForwardingAdjUpdateInput) |
STYLE |
DLS_DEAD_LOCAL_STORE |
688 |
Medium |
| Dead store to tailEndTpId in org.opendaylight.topology.multilayer.MultilayerTopologyProvider.forwardingAdjUpdate(ForwardingAdjUpdateInput) |
STYLE |
DLS_DEAD_LOCAL_STORE |
701 |
Medium |
| Dead store to headTpKey in org.opendaylight.topology.multilayer.MultilayerTopologyProvider.createMtLink(InstanceIdentifier, ForwardingAdjAnnounceInput, boolean) |
STYLE |
DLS_DEAD_LOCAL_STORE |
315 |
Low |
| Dead store to tailTpKey in org.opendaylight.topology.multilayer.MultilayerTopologyProvider.createMtLink(InstanceIdentifier, ForwardingAdjAnnounceInput, boolean) |
STYLE |
DLS_DEAD_LOCAL_STORE |
323 |
Low |
| org.opendaylight.topology.multilayer.MultilayerTopologyProvider.forwardingAdjUpdate(ForwardingAdjUpdateInput) invokes toString() method on a String |
PERFORMANCE |
DM_STRING_TOSTRING |
618 |
Low |
| org.opendaylight.topology.multilayer.MultilayerTopologyProvider.forwardingAdjWithdraw(ForwardingAdjWithdrawInput) invokes toString() method on a String |
PERFORMANCE |
DM_STRING_TOSTRING |
806 |
Low |
| Possible null pointer dereference of headStitchingPoint in org.opendaylight.topology.multilayer.MultilayerTopologyProvider.forwardingAdjAnnounce(ForwardingAdjAnnounceInput) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
456 |
Medium |
| Nullcheck of headStitchingPoint at line 456 of value previously dereferenced in org.opendaylight.topology.multilayer.MultilayerTopologyProvider.forwardingAdjAnnounce(ForwardingAdjAnnounceInput) |
CORRECTNESS |
RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE |
456 |
Medium |
| Nullcheck of tailStitchingPoint at line 457 of value previously dereferenced in org.opendaylight.topology.multilayer.MultilayerTopologyProvider.forwardingAdjAnnounce(ForwardingAdjAnnounceInput) |
CORRECTNESS |
RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE |
457 |
Medium |
| Useless object stored in variable aLinkToExclude of method org.opendaylight.topology.multilayer.MultilayerTopologyProvider.forwardingAdjWithdraw(ForwardingAdjWithdrawInput) |
STYLE |
UC_USELESS_OBJECT |
778 |
Medium |
| Private method org.opendaylight.topology.multilayer.MultilayerTopologyProvider.checkLinkPresence(InstanceIdentifier, TpId, List) is never called |
PERFORMANCE |
UPM_UNCALLED_PRIVATE_METHOD |
405 |
Low |
org.opendaylight.topology.multilayer.MultilayerTopologyProvider$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.topology.multilayer.MultilayerTopologyProvider$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
161 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.MultilayerTopologyProviderModule
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to rpcRegistration in org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.MultilayerTopologyProviderModule.createInstance() |
STYLE |
DLS_DEAD_LOCAL_STORE |
36 |
Medium |
org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.MultilayerTopologyProviderModule$1AutoCloseableMultilayerTopology
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.MultilayerTopologyProviderModule$1AutoCloseableMultilayerTopology could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
41 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.MultilayerTopologyProviderRuntimeRegistration
| Bug |
Category |
Details |
Line |
Priority |
| Unread field: org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.MultilayerTopologyProviderRuntimeRegistration.unkeyedMap |
PERFORMANCE |
URF_UNREAD_FIELD |
3 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.configuration.MultilayerTopologyProviderImplBuilder$MultilayerTopologyProviderImplImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.configuration.MultilayerTopologyProviderImplBuilder$MultilayerTopologyProviderImplImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.configuration.MultilayerTopologyProviderImplBuilder$MultilayerTopologyProviderImplImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
210 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.configuration.multilayer.topology.provider.impl.DataBrokerBuilder$DataBrokerImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.configuration.multilayer.topology.provider.impl.DataBrokerBuilder$DataBrokerImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.configuration.multilayer.topology.provider.impl.DataBrokerBuilder$DataBrokerImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.configuration.multilayer.topology.provider.impl.NotificationServiceBuilder$NotificationServiceImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.configuration.multilayer.topology.provider.impl.NotificationServiceBuilder$NotificationServiceImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.configuration.multilayer.topology.provider.impl.NotificationServiceBuilder$NotificationServiceImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.configuration.multilayer.topology.provider.impl.RpcRegistryBuilder$RpcRegistryImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.configuration.multilayer.topology.provider.impl.RpcRegistryBuilder$RpcRegistryImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.configuration.multilayer.topology.provider.impl.RpcRegistryBuilder$RpcRegistryImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
211 |
Low |
org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.state.MultilayerTopologyProviderImplBuilder$MultilayerTopologyProviderImplImpl
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.state.MultilayerTopologyProviderImplBuilder$MultilayerTopologyProviderImplImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multilayer.impl.rev150123.modules.module.state.MultilayerTopologyProviderImplBuilder$MultilayerTopologyProviderImplImpl.equals(Object) |
STYLE |
BC_UNCONFIRMED_CAST |
141 |
Low |
