Checkstyle Results
The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. 
Summary
| Files |
 Info |
 Warnings |
 Errors |
| 4 |
0 |
30 |
0 |
Rules
| Category |
Rule |
Violations |
Severity |
| coding |
IllegalCatch |
3 |
Warning |
|
VariableDeclarationUsageDistance |
3 |
Warning |
| imports |
CustomImportOrder
- thirdPartyPackageRegExp: ".*"
- sortImportsInGroupAlphabetically: "true"
- customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
|
2 |
Warning |
|
UnusedImports |
1 |
Warning |
| naming |
LocalVariableName
- format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
- allowOneCharVarInForLoop: "true"
- tokens: "VARIABLE_DEF"
|
18 |
Warning |
| whitespace |
EmptyLineSeparator
- allowNoEmptyLineBetweenFields: "true"
- tokens: "IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"
|
1 |
Warning |
|
MethodParamPad |
1 |
Warning |
|
WhitespaceAround
- allowEmptyConstructors: "true"
- allowEmptyMethods: "true"
- allowEmptyLoops: "true"
- allowEmptyTypes: "true"
|
1 |
Warning |
Details
org/opendaylight/topology/mlmt/observer/AbstractMlmtTopologyObserver.java
| Severity |
Category |
Rule |
Message |
Line |
| Warning |
imports |
CustomImportOrder |
Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.NotificationPublishService' import. Should be before 'org.opendaylight.controller.sal.binding.api.RpcProviderRegistry'. |
27 |
| Warning |
whitespace |
EmptyLineSeparator |
'METHOD_DEF' should be separated from previous statement. |
102 |
| Warning |
naming |
LocalVariableName |
Local variable name 'sTopologyName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
135 |
| Warning |
naming |
LocalVariableName |
Local variable name 'lNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
137 |
| Warning |
naming |
LocalVariableName |
Local variable name 'lLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
138 |
| Warning |
naming |
LocalVariableName |
Local variable name 'lTp' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
146 |
| Warning |
naming |
LocalVariableName |
Local variable name 'lNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
173 |
| Warning |
naming |
LocalVariableName |
Local variable name 'lLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
174 |
| Warning |
naming |
LocalVariableName |
Local variable name 'lTp' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
179 |
| Warning |
naming |
LocalVariableName |
Local variable name 'lUnderlay' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
225 |
| Warning |
naming |
LocalVariableName |
Local variable name 'r' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
230 |
| Warning |
naming |
LocalVariableName |
Local variable name 'm' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
231 |
| Warning |
whitespace |
MethodParamPad |
'(' is preceded with whitespace. |
275 |
| Warning |
naming |
LocalVariableName |
Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
280 |
| Warning |
whitespace |
WhitespaceAround |
WhitespaceAround: '{' is not preceded with whitespace. |
486 |
| Warning |
coding |
IllegalCatch |
Catching 'Exception' is not allowed. |
646 |
org/opendaylight/topology/mlmt/observer/MlmtDataChangeEventListener.java
| Severity |
Category |
Rule |
Message |
Line |
| Warning |
coding |
IllegalCatch |
Catching 'Exception' is not allowed. |
50 |
| Warning |
coding |
IllegalCatch |
Catching 'Exception' is not allowed. |
61 |
org/opendaylight/topology/mlmt/observer/MlmtTopologyObserver.java
| Severity |
Category |
Rule |
Message |
Line |
| Warning |
imports |
CustomImportOrder |
Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.NotificationPublishService' import. Should be before 'org.opendaylight.controller.sal.binding.api.RpcProviderRegistry'. |
18 |
org/opendaylight/topology/mlmt/observer/MlmtTopologyObserverTest.java
| Severity |
Category |
Rule |
Message |
Line |
| Warning |
imports |
UnusedImports |
Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.topology.multitechnology.rev150122.multitechnology.topology.type.MultitechnologyTopology. |
47 |
| Warning |
coding |
VariableDeclarationUsageDistance |
Distance between variable 'key' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). |
151 |
| Warning |
naming |
LocalVariableName |
Local variable name 'lUnderlayTopology' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
160 |
| Warning |
naming |
LocalVariableName |
Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
194 |
| Warning |
coding |
VariableDeclarationUsageDistance |
Distance between variable 'mlmtTopologyIid' declaration and its first usage is 38, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). |
217 |
| Warning |
naming |
LocalVariableName |
Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
291 |
| Warning |
coding |
VariableDeclarationUsageDistance |
Distance between variable 'exampleIid' declaration and its first usage is 37, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). |
404 |
| Warning |
naming |
LocalVariableName |
Local variable name 'lTp' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
420 |
| Warning |
naming |
LocalVariableName |
Local variable name 'lNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
424 |
| Warning |
naming |
LocalVariableName |
Local variable name 'lLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
467 |
| Warning |
naming |
LocalVariableName |
Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. |
482 |
