Checkstyle Results

The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
14 0 40 0

Files

File  I  W  E
org/opendaylight/topoprocessing/i2rs/adapter/I2RSModelAdapter.java 0 1 0
org/opendaylight/topoprocessing/i2rs/listener/I2RSUnderlayTopologyListener.java 0 1 0
org/opendaylight/topoprocessing/i2rs/listener/I2RSUnderlayTopologyListenerTest.java 0 8 0
org/opendaylight/topoprocessing/i2rs/provider/I2RSTopoProcessingProviderTest.java 0 1 0
org/opendaylight/topoprocessing/i2rs/request/I2RSTopologyRequestHandlerTest.java 0 14 0
org/opendaylight/topoprocessing/i2rs/request/I2RSTopologyRequestListener.java 0 1 0
org/opendaylight/topoprocessing/i2rs/request/I2RSTopologyRequestListenerTest.java 0 6 0
org/opendaylight/topoprocessing/i2rs/translator/I2RSOverlayItemTranslatorLinkTest.java 0 2 0
org/opendaylight/topoprocessing/i2rs/translator/I2RSOverlayItemTranslatorNodeTest.java 0 6 0

Rules

Category Rule Violations Severity
blocks RightCurly
  • tokens: "CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, LITERAL_DO, STATIC_INIT, INSTANCE_INIT"
  • option: "alone"
 1  Warning
RightCurly 1  Warning
coding VariableDeclarationUsageDistance 19  Warning
imports CustomImportOrder
  • thirdPartyPackageRegExp: ".*"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
 5  Warning
indentation Indentation
  • throwsIndent: "4"
  • arrayInitIndent: "4"
  • caseIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
  • lineWrappingIndentation: "4"
 3  Warning
javadoc JavadocStyle
  • tokens: "ANNOTATION_DEF, ANNOTATION_FIELD_DEF, CLASS_DEF, CTOR_DEF, ENUM_CONSTANT_DEF, ENUM_DEF, INTERFACE_DEF, METHOD_DEF, VARIABLE_DEF"
  • checkEmptyJavadoc: "true"
 9  Warning
naming LocalVariableName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
  • allowOneCharVarInForLoop: "true"
  • tokens: "VARIABLE_DEF"
 3  Warning

Details

org/opendaylight/topoprocessing/i2rs/adapter/I2RSModelAdapter.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 40

org/opendaylight/topoprocessing/i2rs/listener/I2RSUnderlayTopologyListener.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 19

org/opendaylight/topoprocessing/i2rs/listener/I2RSUnderlayTopologyListenerTest.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 48
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodeYiid' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 77
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodeValueWithIp' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 81
 Warning coding VariableDeclarationUsageDistance Distance between variable 'physicalNode' declaration and its first usage is 7, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 92
 Warning coding VariableDeclarationUsageDistance Distance between variable 'physicalNode' declaration and its first usage is 7, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 158
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodeName' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 194
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodeValue' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 196
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodePathArgument' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 206

org/opendaylight/topoprocessing/i2rs/provider/I2RSTopoProcessingProviderTest.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 20

org/opendaylight/topoprocessing/i2rs/request/I2RSTopologyRequestHandlerTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.collect.Maps' import. Should be before 'org.opendaylight.yangtools.yang.model.api.SchemaContext'. 84
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.util.concurrent.CheckedFuture' import. Should be before 'org.opendaylight.yangtools.yang.model.api.SchemaContext'. 85
 Warning javadoc JavadocStyle Javadoc has empty description section. 87
 Warning naming LocalVariableName Local variable name 'cBuilder' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 161
 Warning naming LocalVariableName Local variable name 'cBuilder' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 173
 Warning coding VariableDeclarationUsageDistance Distance between variable 'networkBuilder' declaration and its first usage is 9, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 253
 Warning coding VariableDeclarationUsageDistance Distance between variable 'mappings' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 256
 Warning coding VariableDeclarationUsageDistance Distance between variable 'networkBuilder' declaration and its first usage is 9, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 285
 Warning coding VariableDeclarationUsageDistance Distance between variable 'mappings' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 288
 Warning coding VariableDeclarationUsageDistance Distance between variable 'networkBuilder' declaration and its first usage is 9, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 338
 Warning coding VariableDeclarationUsageDistance Distance between variable 'mappings' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 341
 Warning coding VariableDeclarationUsageDistance Distance between variable 'networkBuilder' declaration and its first usage is 9, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 379
 Warning naming LocalVariableName Local variable name 'fBuilder' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 380
 Warning coding VariableDeclarationUsageDistance Distance between variable 'filters' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 382

org/opendaylight/topoprocessing/i2rs/request/I2RSTopologyRequestListener.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 33

org/opendaylight/topoprocessing/i2rs/request/I2RSTopologyRequestListenerTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableAugmentationNodeBuilder'. 75
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.collect.Maps' import. Should be before 'org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableAugmentationNodeBuilder'. 76
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.util.concurrent.AbstractCheckedFuture' import. Should be before 'org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableAugmentationNodeBuilder'. 77
 Warning javadoc JavadocStyle Javadoc has empty description section. 79
 Warning coding VariableDeclarationUsageDistance Distance between variable 'yiid' declaration and its first usage is 8, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 136
 Warning coding VariableDeclarationUsageDistance Distance between variable 'node' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 215

org/opendaylight/topoprocessing/i2rs/translator/I2RSOverlayItemTranslatorLinkTest.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 43
 Warning coding VariableDeclarationUsageDistance Distance between variable 'wrapperName' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 80

org/opendaylight/topoprocessing/i2rs/translator/I2RSOverlayItemTranslatorNodeTest.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 49
 Warning coding VariableDeclarationUsageDistance Distance between variable 'wrapperName' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 151
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be one of the following: 16, 20. 260
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be one of the following: 16, 20. 261
 Warning indentation Indentation 'block rcurly' have incorrect indentation level 8, expected level should be one of the following: 12, 16. 262
 Warning blocks RightCurly '}' at column 9 should be alone on a line. 262