Checkstyle Results

The following document contains the results of Checkstyle 7.6.1 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
14 0 51 0

Files

File  I  W  E
org/opendaylight/topoprocessing/nt/adapter/NTModelAdapter.java 0 1 0
org/opendaylight/topoprocessing/nt/listener/NTUnderlayTopologyListener.java 0 1 0
org/opendaylight/topoprocessing/nt/listener/NTUnderlayTopologyListenerTest.java 0 16 0
org/opendaylight/topoprocessing/nt/provider/NTTopoProcessingProviderImplTest.java 0 1 0
org/opendaylight/topoprocessing/nt/request/NTTopologyRequestHandler.java 0 1 0
org/opendaylight/topoprocessing/nt/request/NTTopologyRequestHandlerTest.java 0 13 0
org/opendaylight/topoprocessing/nt/request/NTTopologyRequestListener.java 0 1 0
org/opendaylight/topoprocessing/nt/request/NTTopologyRequestListenerTest.java 0 7 0
org/opendaylight/topoprocessing/nt/translator/NTLinkTranslator.java 0 1 0
org/opendaylight/topoprocessing/nt/translator/NTNodeTranslator.java 0 1 0
org/opendaylight/topoprocessing/nt/translator/NTOverlayItemTranslatorLinkTest.java 0 2 0
org/opendaylight/topoprocessing/nt/translator/NTOverlayItemTranslatorNodeTest.java 0 6 0

Rules

Category Rule Violations Severity
blocks RightCurly
  • tokens: "CLASS_DEF, METHOD_DEF, CTOR_DEF, LITERAL_FOR, STATIC_INIT, INSTANCE_INIT"
  • option: "alone"
 1  Warning
RightCurly 1  Warning
coding VariableDeclarationUsageDistance 26  Warning
imports CustomImportOrder
  • thirdPartyPackageRegExp: ".*"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
 5  Warning
indentation Indentation
  • throwsIndent: "4"
  • arrayInitIndent: "4"
  • caseIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
  • lineWrappingIndentation: "4"
 3  Warning
javadoc JavadocStyle
  • tokens: "ANNOTATION_DEF, ANNOTATION_FIELD_DEF, CLASS_DEF, CTOR_DEF, ENUM_CONSTANT_DEF, ENUM_DEF, INTERFACE_DEF, METHOD_DEF, VARIABLE_DEF"
  • checkEmptyJavadoc: "true"
 11  Warning
naming LocalVariableName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
  • allowOneCharVarInForLoop: "true"
  • tokens: "VARIABLE_DEF"
 3  Warning
whitespace GenericWhitespace 1  Warning
ParenPad 1  Warning

Details

org/opendaylight/topoprocessing/nt/adapter/NTModelAdapter.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 40

org/opendaylight/topoprocessing/nt/listener/NTUnderlayTopologyListener.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 19

org/opendaylight/topoprocessing/nt/listener/NTUnderlayTopologyListenerTest.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 49
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodeYiid' declaration and its first usage is 10, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 78
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodeValueWithIp' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 82
 Warning coding VariableDeclarationUsageDistance Distance between variable 'physicalNode' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 96
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodePathArgument' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 98
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodeYiid' declaration and its first usage is 8, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 153
 Warning coding VariableDeclarationUsageDistance Distance between variable 'physicalNode' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 162
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodePathArgument' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 165
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodeYiid' declaration and its first usage is 10, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 202
 Warning coding VariableDeclarationUsageDistance Distance between variable 'testNode' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 207
 Warning coding VariableDeclarationUsageDistance Distance between variable 'physicalNode' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 219
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodePathArgument' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 221
 Warning whitespace GenericWhitespace GenericWhitespace '>' is followed by whitespace. 228
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodeName' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 239
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodeValue' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 241
 Warning coding VariableDeclarationUsageDistance Distance between variable 'nodePathArgument' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 251

org/opendaylight/topoprocessing/nt/provider/NTTopoProcessingProviderImplTest.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 20

org/opendaylight/topoprocessing/nt/request/NTTopologyRequestHandler.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 27

org/opendaylight/topoprocessing/nt/request/NTTopologyRequestHandlerTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.collect.Maps' import. Should be before 'org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier'. 87
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.util.concurrent.CheckedFuture' import. Should be before 'org.opendaylight.yangtools.yang.data.api.YangInstanceIdentifier'. 88
 Warning naming LocalVariableName Local variable name 'cBuilder' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 162
 Warning naming LocalVariableName Local variable name 'cBuilder' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 174
 Warning coding VariableDeclarationUsageDistance Distance between variable 'topoBuilder' declaration and its first usage is 9, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 254
 Warning coding VariableDeclarationUsageDistance Distance between variable 'mappings' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 257
 Warning coding VariableDeclarationUsageDistance Distance between variable 'topoBuilder' declaration and its first usage is 9, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 286
 Warning coding VariableDeclarationUsageDistance Distance between variable 'mappings' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 289
 Warning coding VariableDeclarationUsageDistance Distance between variable 'topoBuilder' declaration and its first usage is 9, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 343
 Warning coding VariableDeclarationUsageDistance Distance between variable 'mappings' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 346
 Warning coding VariableDeclarationUsageDistance Distance between variable 'topoBuilder' declaration and its first usage is 9, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 384
 Warning naming LocalVariableName Local variable name 'fBuilder' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 385
 Warning coding VariableDeclarationUsageDistance Distance between variable 'filters' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 387

org/opendaylight/topoprocessing/nt/request/NTTopologyRequestListener.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 32

org/opendaylight/topoprocessing/nt/request/NTTopologyRequestListenerTest.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableAugmentationNodeBuilder'. 77
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.collect.Maps' import. Should be before 'org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableAugmentationNodeBuilder'. 78
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.util.concurrent.AbstractCheckedFuture' import. Should be before 'org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableAugmentationNodeBuilder'. 79
 Warning javadoc JavadocStyle Javadoc has empty description section. 81
 Warning whitespace ParenPad '(' is followed by whitespace. 123
 Warning coding VariableDeclarationUsageDistance Distance between variable 'yiid' declaration and its first usage is 8, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 137
 Warning coding VariableDeclarationUsageDistance Distance between variable 'node' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 214

org/opendaylight/topoprocessing/nt/translator/NTLinkTranslator.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 39

org/opendaylight/topoprocessing/nt/translator/NTNodeTranslator.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 49

org/opendaylight/topoprocessing/nt/translator/NTOverlayItemTranslatorLinkTest.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 44
 Warning coding VariableDeclarationUsageDistance Distance between variable 'wrapperName' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 81

org/opendaylight/topoprocessing/nt/translator/NTOverlayItemTranslatorNodeTest.java

Severity Category Rule Message Line
 Warning javadoc JavadocStyle Javadoc has empty description section. 44
 Warning coding VariableDeclarationUsageDistance Distance between variable 'wrapperName' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 145
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be one of the following: 16, 20. 258
 Warning indentation Indentation 'block' child have incorrect indentation level 12, expected level should be one of the following: 16, 20. 260
 Warning indentation Indentation 'block rcurly' have incorrect indentation level 8, expected level should be one of the following: 12, 16. 262
 Warning blocks RightCurly '}' at column 9 should be alone on a line. 262