Checkstyle Results

The following document contains the results of Checkstyle 7.6.1 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
4 0 32 0

Files

File  I  W  E
org/opendaylight/topology/mlmt/observer/AbstractMlmtTopologyObserver.java 0 19 0
org/opendaylight/topology/mlmt/observer/MlmtDataChangeEventListener.java 0 2 0
org/opendaylight/topology/mlmt/observer/MlmtTopologyObserver.java 0 1 0
org/opendaylight/topology/mlmt/observer/MlmtTopologyObserverTest.java 0 10 0

Rules

Category Rule Violations Severity
coding IllegalCatch 3  Warning
VariableDeclarationUsageDistance 3  Warning
imports CustomImportOrder
  • thirdPartyPackageRegExp: ".*"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
 1  Warning
modifier RedundantModifier 4  Warning
naming LocalVariableName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
  • allowOneCharVarInForLoop: "true"
  • tokens: "VARIABLE_DEF"
 18  Warning
whitespace EmptyLineSeparator
  • allowNoEmptyLineBetweenFields: "true"
  • tokens: "IMPORT, CLASS_DEF, INTERFACE_DEF, ENUM_DEF, STATIC_INIT, INSTANCE_INIT, METHOD_DEF, CTOR_DEF, VARIABLE_DEF"
 1  Warning
MethodParamPad 1  Warning
WhitespaceAround
  • allowEmptyConstructors: "true"
  • allowEmptyMethods: "true"
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
 1  Warning

Details

org/opendaylight/topology/mlmt/observer/AbstractMlmtTopologyObserver.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'final' modifier. 89
 Warning modifier RedundantModifier Redundant 'final' modifier. 89
 Warning modifier RedundantModifier Redundant 'final' modifier. 90
 Warning modifier RedundantModifier Redundant 'final' modifier. 90
 Warning whitespace EmptyLineSeparator 'METHOD_DEF' should be separated from previous statement. 103
 Warning naming LocalVariableName Local variable name 'sTopologyName' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 136
 Warning naming LocalVariableName Local variable name 'lNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 138
 Warning naming LocalVariableName Local variable name 'lLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 139
 Warning naming LocalVariableName Local variable name 'lTp' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 147
 Warning naming LocalVariableName Local variable name 'lNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 174
 Warning naming LocalVariableName Local variable name 'lLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 175
 Warning naming LocalVariableName Local variable name 'lTp' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 180
 Warning naming LocalVariableName Local variable name 'lUnderlay' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 226
 Warning naming LocalVariableName Local variable name 'r' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 231
 Warning naming LocalVariableName Local variable name 'm' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 232
 Warning whitespace MethodParamPad '(' is preceded with whitespace. 276
 Warning naming LocalVariableName Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 281
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 487
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 666

org/opendaylight/topology/mlmt/observer/MlmtDataChangeEventListener.java

Severity Category Rule Message Line
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 53
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 64

org/opendaylight/topology/mlmt/observer/MlmtTopologyObserver.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.NotificationPublishService' import. Should be before 'org.opendaylight.controller.sal.binding.api.RpcProviderRegistry'. 18

org/opendaylight/topology/mlmt/observer/MlmtTopologyObserverTest.java

Severity Category Rule Message Line
 Warning coding VariableDeclarationUsageDistance Distance between variable 'key' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 146
 Warning naming LocalVariableName Local variable name 'lUnderlayTopology' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 155
 Warning naming LocalVariableName Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 189
 Warning coding VariableDeclarationUsageDistance Distance between variable 'mlmtTopologyIid' declaration and its first usage is 38, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 212
 Warning naming LocalVariableName Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 286
 Warning coding VariableDeclarationUsageDistance Distance between variable 'exampleIid' declaration and its first usage is 37, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 399
 Warning naming LocalVariableName Local variable name 'lTp' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 415
 Warning naming LocalVariableName Local variable name 'lNode' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 419
 Warning naming LocalVariableName Local variable name 'lLink' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 462
 Warning naming LocalVariableName Local variable name 'rTx' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 477