FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is low

Effort is max

Summary

Classes Bugs Errors Missing Classes
339 48 0 0

Files

Class Bugs
org.opendaylight.yangtools.yang.data.impl.codec.AbstractIntegerStringCodec 1
org.opendaylight.yangtools.yang.data.impl.codec.BooleanStringCodec 1
org.opendaylight.yangtools.yang.data.impl.codec.SchemaTracker$SchemaNodePredicate 1
org.opendaylight.yangtools.yang.data.impl.codec.ValueWithQName 1
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathLexer 7
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParser 6
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParserListenerImpl 9
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParserListenerImpl$1 2
org.opendaylight.yangtools.yang.data.impl.leafref.QNamePredicateImpl 1
org.opendaylight.yangtools.yang.data.impl.schema.InstanceIdToNodes 1
org.opendaylight.yangtools.yang.data.impl.schema.InterningLeafSetNodeBuilder 1
org.opendaylight.yangtools.yang.data.impl.schema.ResultAlreadySetException 1
org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableLeafSetNodeBuilder$ImmutableLeafSetNode 1
org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableMapEntryNodeSchemaAwareBuilder 1
org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableMapNodeBuilder$ImmutableMapNode 1
org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableOrderedLeafSetNodeBuilder$ImmutableOrderedLeafSetNode 1
org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableOrderedMapNodeBuilder$ImmutableOrderedMapNode 1
org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableUnkeyedListNodeBuilder$EmptyImmutableUnkeyedListNode 1
org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableUnkeyedListNodeBuilder$ImmutableUnkeyedListNode 1
org.opendaylight.yangtools.yang.data.impl.schema.nodes.AbstractImmutableDataContainerNode 1
org.opendaylight.yangtools.yang.data.impl.schema.nodes.UnmodifiableChildrenMap 2
org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractDataTreeCandidateNode$1 1
org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractDataTreeCandidateNode$2 1
org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractModifiedNodeBasedCandidateNode$1 1
org.opendaylight.yangtools.yang.data.impl.schema.tree.InMemoryDataTree 1
org.opendaylight.yangtools.yang.data.impl.schema.tree.MinMaxElementsValidation 1
org.opendaylight.yangtools.yang.data.impl.schema.tree.OperationWithModification$1 1

org.opendaylight.yangtools.yang.data.impl.codec.AbstractIntegerStringCodec

Bug Category Details Line Priority
Format string should use %n rather than \n in org.opendaylight.yangtools.yang.data.impl.codec.AbstractIntegerStringCodec.provideBase(String) BAD_PRACTICE VA_FORMAT_STRING_USES_NEWLINE 182 Medium

org.opendaylight.yangtools.yang.data.impl.codec.BooleanStringCodec

Bug Category Details Line Priority
org.opendaylight.yangtools.yang.data.impl.codec.BooleanStringCodec.deserialize(String) has Boolean return type and returns explicit null BAD_PRACTICE NP_BOOLEAN_RETURN_NULL 30 Medium

org.opendaylight.yangtools.yang.data.impl.codec.SchemaTracker$SchemaNodePredicate

Bug Category Details Line Priority
input must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 314 Medium

org.opendaylight.yangtools.yang.data.impl.codec.ValueWithQName

Bug Category Details Line Priority
Confusing to have methods org.opendaylight.yangtools.yang.data.impl.codec.ValueWithQName.getQname() and org.opendaylight.yangtools.yang.data.impl.leafref.QNameWithPredicateImpl.getQName() BAD_PRACTICE NM_CONFUSING 21 Low

org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathLexer

Bug Category Details Line Priority
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathLexer.getModeNames() may expose internal representation by returning LeafRefPathLexer.modeNames MALICIOUS_CODE EI_EXPOSE_REP 89 Medium
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathLexer.getRuleNames() may expose internal representation by returning LeafRefPathLexer.ruleNames MALICIOUS_CODE EI_EXPOSE_REP 83 Medium
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathLexer.getTokenNames() may expose internal representation by returning LeafRefPathLexer.tokenNames MALICIOUS_CODE EI_EXPOSE_REP 64 Medium
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathLexer.modeNames should be both final and package protected MALICIOUS_CODE MS_FINAL_PKGPROTECT 24 Medium
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathLexer._decisionToDFA should be package protected MALICIOUS_CODE MS_PKGPROTECT 115 Medium
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathLexer.ruleNames should be package protected MALICIOUS_CODE MS_PKGPROTECT 28 Medium
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathLexer.tokenNames should be package protected MALICIOUS_CODE MS_PKGPROTECT 48 Medium

org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParser

Bug Category Details Line Priority
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParser.getRuleNames() may expose internal representation by returning LeafRefPathParser.ruleNames MALICIOUS_CODE EI_EXPOSE_REP 81 Medium
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParser.getTokenNames() may expose internal representation by returning LeafRefPathParser.tokenNames MALICIOUS_CODE EI_EXPOSE_REP 68 Medium
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParser._decisionToDFA should be package protected MALICIOUS_CODE MS_PKGPROTECT 1125 Medium
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParser.ruleNames should be package protected MALICIOUS_CODE MS_PKGPROTECT 30 Medium
org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParser.tokenNames should be package protected MALICIOUS_CODE MS_PKGPROTECT 52 Medium
Switch statement found in org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParser.node_identifier() where default case is missing STYLE SF_SWITCH_NO_DEFAULT 776 Medium

org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParserListenerImpl

Bug Category Details Line Priority
Dead store to parent in org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParserListenerImpl.enterRel_path_keyexpr(LeafRefPathParser$Rel_path_keyexprContext) STYLE DLS_DEAD_LOCAL_STORE 89 Low
Dead store to parent in org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParserListenerImpl.enterRelative_path(LeafRefPathParser$Relative_pathContext) STYLE DLS_DEAD_LOCAL_STORE 109 Low
Private method org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParserListenerImpl.getNamespaceForImportPrefix(String) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 181 Low
Unread field: org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParserListenerImpl.node PERFORMANCE URF_UNREAD_FIELD 65 Low
LeafRefPathParserListenerImpl.currentLeafRefPathQName not initialized in constructor and dereferenced in org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParserListenerImpl.exitPath_predicate(LeafRefPathParser$Path_predicateContext) STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR 78 Low
LeafRefPathParserListenerImpl.currentPredicate not initialized in constructor and dereferenced in org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParserListenerImpl.exitNode_identifier(LeafRefPathParser$Node_identifierContext) STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR 158 Low
LeafRefPathParserListenerImpl.currentPredicate not initialized in constructor and dereferenced in org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParserListenerImpl.exitPath_predicate(LeafRefPathParser$Path_predicateContext) STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR 78 Low
LeafRefPathParserListenerImpl.currentPredicate not initialized in constructor and dereferenced in org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParserListenerImpl.exitRel_path_keyexpr(LeafRefPathParser$Rel_path_keyexprContext) STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR 99 Low
LeafRefPathParserListenerImpl.predicatePathKeyQnameList not initialized in constructor and dereferenced in org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParserListenerImpl.exitNode_identifier(LeafRefPathParser$Node_identifierContext) STYLE UWF_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR 165 Low

org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParserListenerImpl$1

Bug Category Details Line Priority
builder must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 53 Low
The class org.opendaylight.yangtools.yang.data.impl.leafref.LeafRefPathParserListenerImpl$1 could be refactored into a named _static_ inner class PERFORMANCE SIC_INNER_SHOULD_BE_STATIC_ANON 50 Low

org.opendaylight.yangtools.yang.data.impl.leafref.QNamePredicateImpl

Bug Category Details Line Priority
Class org.opendaylight.yangtools.yang.data.impl.leafref.QNamePredicateImpl defines non-transient non-serializable instance field pathKeyExpression BAD_PRACTICE SE_BAD_FIELD Medium

org.opendaylight.yangtools.yang.data.impl.schema.InstanceIdToNodes

Bug Category Details Line Priority
Use of non-localized String.toUpperCase() or String.toLowerCase() in org.opendaylight.yangtools.yang.data.impl.schema.InstanceIdToNodes.modifyOperationToXmlString(ModifyAction) I18N DM_CONVERT_CASE 87 Low

org.opendaylight.yangtools.yang.data.impl.schema.InterningLeafSetNodeBuilder

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.data.api.schema.LeafSetNode to org.opendaylight.yangtools.yang.model.api.LeafListSchemaNode in org.opendaylight.yangtools.yang.data.impl.schema.InterningLeafSetNodeBuilder.getInterner(DataSchemaNode) STYLE BC_UNCONFIRMED_CAST 32 Low

org.opendaylight.yangtools.yang.data.impl.schema.ResultAlreadySetException

Bug Category Details Line Priority
Class org.opendaylight.yangtools.yang.data.impl.schema.ResultAlreadySetException defines non-transient non-serializable instance field resultData BAD_PRACTICE SE_BAD_FIELD Low

org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableLeafSetNodeBuilder$ImmutableLeafSetNode

Bug Category Details Line Priority
Class org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableLeafSetNodeBuilder$ImmutableLeafSetNode implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 114 Low

org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableMapEntryNodeSchemaAwareBuilder

Bug Category Details Line Priority
org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableMapEntryNodeSchemaAwareBuilder.constructNodeIdentifier() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 62 Medium

org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableMapNodeBuilder$ImmutableMapNode

Bug Category Details Line Priority
Class org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableMapNodeBuilder$ImmutableMapNode implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 112 Low

org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableOrderedLeafSetNodeBuilder$ImmutableOrderedLeafSetNode

Bug Category Details Line Priority
Class org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableOrderedLeafSetNodeBuilder$ImmutableOrderedLeafSetNode implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 115 Low

org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableOrderedMapNodeBuilder$ImmutableOrderedMapNode

Bug Category Details Line Priority
Class org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableOrderedMapNodeBuilder$ImmutableOrderedMapNode implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 125 Low

org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableUnkeyedListNodeBuilder$EmptyImmutableUnkeyedListNode

Bug Category Details Line Priority
Class org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableUnkeyedListNodeBuilder$EmptyImmutableUnkeyedListNode implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 118 Low

org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableUnkeyedListNodeBuilder$ImmutableUnkeyedListNode

Bug Category Details Line Priority
Class org.opendaylight.yangtools.yang.data.impl.schema.builder.impl.ImmutableUnkeyedListNodeBuilder$ImmutableUnkeyedListNode implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 149 Low

org.opendaylight.yangtools.yang.data.impl.schema.nodes.AbstractImmutableDataContainerNode

Bug Category Details Line Priority
Class org.opendaylight.yangtools.yang.data.impl.schema.nodes.AbstractImmutableDataContainerNode implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 19 Low

org.opendaylight.yangtools.yang.data.impl.schema.nodes.UnmodifiableChildrenMap

Bug Category Details Line Priority
Class org.opendaylight.yangtools.yang.data.impl.schema.nodes.UnmodifiableChildrenMap defines non-transient non-serializable instance field delegate BAD_PRACTICE SE_BAD_FIELD Medium
The field org.opendaylight.yangtools.yang.data.impl.schema.nodes.UnmodifiableChildrenMap.values is transient but isn't set by deserialization BAD_PRACTICE SE_TRANSIENT_FIELD_NOT_RESTORED Low

org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractDataTreeCandidateNode$1

Bug Category Details Line Priority
input must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 26 Medium

org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractDataTreeCandidateNode$2

Bug Category Details Line Priority
input must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 32 Medium

org.opendaylight.yangtools.yang.data.impl.schema.tree.AbstractModifiedNodeBasedCandidateNode$1

Bug Category Details Line Priority
input must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 29 Medium

org.opendaylight.yangtools.yang.data.impl.schema.tree.InMemoryDataTree

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.data.api.schema.tree.DataTreeCandidate to org.opendaylight.yangtools.yang.data.impl.schema.tree.InMemoryDataTreeCandidate in org.opendaylight.yangtools.yang.data.impl.schema.tree.InMemoryDataTree.commit(DataTreeCandidate) STYLE BC_UNCONFIRMED_CAST 102 Low

org.opendaylight.yangtools.yang.data.impl.schema.tree.MinMaxElementsValidation

Bug Category Details Line Priority
Private method org.opendaylight.yangtools.yang.data.impl.schema.tree.MinMaxElementsValidation.checkOriginalPresent(ModifiedNode) is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 104 Low

org.opendaylight.yangtools.yang.data.impl.schema.tree.OperationWithModification$1

Bug Category Details Line Priority
input must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 22 Medium