FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 210 |
23 |
0 |
0 |
org.opendaylight.yangtools.yang.model.repo.util.AbstractSchemaRepository$SchemaProviderCostComparator
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.yangtools.yang.model.repo.util.AbstractSchemaRepository$SchemaProviderCostComparator implements Comparator but not Serializable |
BAD_PRACTICE |
SE_COMPARATOR_SHOULD_BE_SERIALIZABLE |
199 |
Low |
org.opendaylight.yangtools.yang.model.repo.util.FilesystemSchemaSourceCache
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference in org.opendaylight.yangtools.yang.model.repo.util.FilesystemSchemaSourceCache.findFileWithNewestRev(SourceIdentifier, File) due to return value of called method |
STYLE |
NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE |
174 |
Medium |
org.opendaylight.yangtools.yang.model.repo.util.FilesystemSchemaSourceCache$YangTextSchemaStorageAdapter$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.yang.model.repo.util.FilesystemSchemaSourceCache$YangTextSchemaStorageAdapter$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
260 |
Low |
org.opendaylight.yangtools.yang.model.util.FilteringSchemaContextProxy$4
org.opendaylight.yangtools.yang.model.util.FilteringSchemaContextProxy$ModuleId
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.yangtools.yang.model.util.FilteringSchemaContextProxy$ModuleId.getRev() may expose internal representation by returning FilteringSchemaContextProxy$ModuleId.rev |
MALICIOUS_CODE |
EI_EXPOSE_REP |
242 |
Medium |
org.opendaylight.yangtools.yang.model.util.FilteringSchemaContextProxy$ModuleId$1
org.opendaylight.yangtools.yang.model.util.ModuleImportImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.yangtools.yang.model.util.ModuleImportImpl.getRevision() may expose internal representation by returning ModuleImportImpl.revision |
MALICIOUS_CODE |
EI_EXPOSE_REP |
32 |
Medium |
| new org.opendaylight.yangtools.yang.model.util.ModuleImportImpl(String, Date, String) may expose internal representation by storing an externally mutable object into ModuleImportImpl.revision |
MALICIOUS_CODE |
EI_EXPOSE_REP2 |
21 |
Medium |
org.opendaylight.yangtools.yang.model.util.SchemaContextUtil
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference of nodeType in org.opendaylight.yangtools.yang.model.util.SchemaContextUtil.findParentModuleOfReferencingType(SchemaContext, SchemaNode) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
682 |
Medium |
| Redundant nullcheck of qnamedPath, which is known to be non-null in org.opendaylight.yangtools.yang.model.util.SchemaContextUtil.findDataSchemaNode(SchemaContext, Module, RevisionAwareXPath) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
134 |
Low |
| Redundant nullcheck of strXPath, which is known to be non-null in org.opendaylight.yangtools.yang.model.util.SchemaContextUtil.findDataSchemaNode(SchemaContext, Module, RevisionAwareXPath) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
130 |
Low |
org.opendaylight.yangtools.yang.model.util.type.InvalidBitDefinitionException
| Bug |
Category |
Details |
Line |
Priority |
| Class org.opendaylight.yangtools.yang.model.util.type.InvalidBitDefinitionException defines non-transient non-serializable instance field offendingBit |
BAD_PRACTICE |
SE_BAD_FIELD |
|
Low |
org.opendaylight.yangtools.yang.model.util.type.InvalidEnumDefinitionException
| Bug |
Category |
Details |
Line |
Priority |
| Class org.opendaylight.yangtools.yang.model.util.type.InvalidEnumDefinitionException defines non-transient non-serializable instance field offendingEnum |
BAD_PRACTICE |
SE_BAD_FIELD |
|
Low |
org.opendaylight.yangtools.yang.model.util.type.InvalidLengthConstraintException
| Bug |
Category |
Details |
Line |
Priority |
| Class org.opendaylight.yangtools.yang.model.util.type.InvalidLengthConstraintException defines non-transient non-serializable instance field offendingConstraint |
BAD_PRACTICE |
SE_BAD_FIELD |
|
Low |
org.opendaylight.yangtools.yang.model.util.type.InvalidRangeConstraintException
| Bug |
Category |
Details |
Line |
Priority |
| Class org.opendaylight.yangtools.yang.model.util.type.InvalidRangeConstraintException defines non-transient non-serializable instance field offendingRangeConstraint |
BAD_PRACTICE |
SE_BAD_FIELD |
|
Low |
org.opendaylight.yangtools.yang.model.util.type.NumberUtil$1
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from Number to Byte in org.opendaylight.yangtools.yang.model.util.type.NumberUtil$1.compare(Number, Number) |
STYLE |
BC_UNCONFIRMED_CAST |
26 |
Low |
| Unchecked/unconfirmed cast from Number to Integer in org.opendaylight.yangtools.yang.model.util.type.NumberUtil$1.compare(Number, Number) |
STYLE |
BC_UNCONFIRMED_CAST |
30 |
Low |
| Unchecked/unconfirmed cast from Number to Long in org.opendaylight.yangtools.yang.model.util.type.NumberUtil$1.compare(Number, Number) |
STYLE |
BC_UNCONFIRMED_CAST |
32 |
Low |
| Unchecked/unconfirmed cast from Number to Short in org.opendaylight.yangtools.yang.model.util.type.NumberUtil$1.compare(Number, Number) |
STYLE |
BC_UNCONFIRMED_CAST |
28 |
Low |
| Unchecked/unconfirmed cast from Number to java.math.BigDecimal in org.opendaylight.yangtools.yang.model.util.type.NumberUtil$1.compare(Number, Number) |
STYLE |
BC_UNCONFIRMED_CAST |
34 |
Low |
| Unchecked/unconfirmed cast from Number to java.math.BigInteger in org.opendaylight.yangtools.yang.model.util.type.NumberUtil$1.compare(Number, Number) |
STYLE |
BC_UNCONFIRMED_CAST |
36 |
Low |
org.opendaylight.yangtools.yang.model.util.type.NumberUtil$2
org.opendaylight.yangtools.yang.model.util.type.NumberUtil$3
