FindBugs Bug Detector Report
The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is low
Effort is max
Summary
| Classes |
Bugs |
Errors |
Missing Classes |
| 721 |
104 |
0 |
0 |
org.opendaylight.yangtools.antlrv4.code.gen.YangLexer
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.yangtools.antlrv4.code.gen.YangLexer.getModeNames() may expose internal representation by returning YangLexer.modeNames |
MALICIOUS_CODE |
EI_EXPOSE_REP |
156 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangLexer.getRuleNames() may expose internal representation by returning YangLexer.ruleNames |
MALICIOUS_CODE |
EI_EXPOSE_REP |
150 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangLexer.getTokenNames() may expose internal representation by returning YangLexer.tokenNames |
MALICIOUS_CODE |
EI_EXPOSE_REP |
131 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangLexer.modeNames should be both final and package protected |
MALICIOUS_CODE |
MS_FINAL_PKGPROTECT |
44 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangLexer._decisionToDFA should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
487 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangLexer.ruleNames should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
48 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangLexer.tokenNames should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
115 |
Medium |
org.opendaylight.yangtools.antlrv4.code.gen.YangParser
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.yangtools.antlrv4.code.gen.YangParser.getRuleNames() may expose internal representation by returning YangParser.ruleNames |
MALICIOUS_CODE |
EI_EXPOSE_REP |
179 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangParser.getTokenNames() may expose internal representation by returning YangParser.tokenNames |
MALICIOUS_CODE |
EI_EXPOSE_REP |
166 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangParser._decisionToDFA should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
12249 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangParser.ruleNames should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
78 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangParser.tokenNames should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
150 |
Medium |
| Switch statement found in org.opendaylight.yangtools.antlrv4.code.gen.YangParser.decimal64_specification() where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
8216 |
Medium |
| Switch statement found in org.opendaylight.yangtools.antlrv4.code.gen.YangParser.deviation_stmt() where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
1557 |
Medium |
| Switch statement found in org.opendaylight.yangtools.antlrv4.code.gen.YangParser.extension_stmt() where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
9574 |
Medium |
| Switch statement found in org.opendaylight.yangtools.antlrv4.code.gen.YangParser.identifier_stmt() where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
372 |
Medium |
| Switch statement found in org.opendaylight.yangtools.antlrv4.code.gen.YangParser.refine_pom() where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
3643 |
Medium |
| Switch statement found in org.opendaylight.yangtools.antlrv4.code.gen.YangParser.revision_stmt() where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
9768 |
Medium |
| Switch statement found in org.opendaylight.yangtools.antlrv4.code.gen.YangParser.stmtsep() where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
816 |
Medium |
| Switch statement found in org.opendaylight.yangtools.antlrv4.code.gen.YangParser.type_body_stmts() where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
8560 |
Medium |
| Switch statement found in org.opendaylight.yangtools.antlrv4.code.gen.YangParser.unknown_statement() where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
640 |
Medium |
org.opendaylight.yangtools.antlrv4.code.gen.YangStatementLexer
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.yangtools.antlrv4.code.gen.YangStatementLexer.getModeNames() may expose internal representation by returning YangStatementLexer.modeNames |
MALICIOUS_CODE |
EI_EXPOSE_REP |
92 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangStatementLexer.getRuleNames() may expose internal representation by returning YangStatementLexer.ruleNames |
MALICIOUS_CODE |
EI_EXPOSE_REP |
86 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangStatementLexer.getTokenNames() may expose internal representation by returning YangStatementLexer.tokenNames |
MALICIOUS_CODE |
EI_EXPOSE_REP |
67 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangStatementLexer.modeNames should be both final and package protected |
MALICIOUS_CODE |
MS_FINAL_PKGPROTECT |
25 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangStatementLexer._decisionToDFA should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
147 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangStatementLexer.ruleNames should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
29 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangStatementLexer.tokenNames should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
51 |
Medium |
org.opendaylight.yangtools.antlrv4.code.gen.YangStatementParser
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.yangtools.antlrv4.code.gen.YangStatementParser.getRuleNames() may expose internal representation by returning YangStatementParser.ruleNames |
MALICIOUS_CODE |
EI_EXPOSE_REP |
75 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangStatementParser.getTokenNames() may expose internal representation by returning YangStatementParser.tokenNames |
MALICIOUS_CODE |
EI_EXPOSE_REP |
62 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangStatementParser._decisionToDFA should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
501 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangStatementParser.ruleNames should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
26 |
Medium |
| org.opendaylight.yangtools.antlrv4.code.gen.YangStatementParser.tokenNames should be package protected |
MALICIOUS_CODE |
MS_PKGPROTECT |
46 |
Medium |
| Switch statement found in org.opendaylight.yangtools.antlrv4.code.gen.YangStatementParser.keyword() where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
331 |
Medium |
org.opendaylight.yangtools.yang.parser.builder.impl.GroupingUtils$UsesComparator
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.yangtools.yang.parser.builder.impl.GroupingUtils$UsesComparator implements Comparator but not Serializable |
BAD_PRACTICE |
SE_COMPARATOR_SHOULD_BE_SERIALIZABLE |
144 |
Medium |
org.opendaylight.yangtools.yang.parser.builder.impl.LeafListSchemaNodeBuilder
| Bug |
Category |
Details |
Line |
Priority |
org.opendaylight.yangtools.yang.parser.builder.impl.ModuleBuilder
| Bug |
Category |
Details |
Line |
Priority |
| Class org.opendaylight.yangtools.yang.parser.builder.impl.ModuleBuilder implements same interface as superclass |
STYLE |
RI_REDUNDANT_INTERFACES |
67 |
Low |
org.opendaylight.yangtools.yang.parser.builder.util.Comparators$AugmentBuilderComparator
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.yangtools.yang.parser.builder.util.Comparators$AugmentBuilderComparator implements Comparator but not Serializable |
BAD_PRACTICE |
SE_COMPARATOR_SHOULD_BE_SERIALIZABLE |
47 |
Medium |
org.opendaylight.yangtools.yang.parser.builder.util.Comparators$AugmentComparator
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.yangtools.yang.parser.builder.util.Comparators$AugmentComparator implements Comparator but not Serializable |
BAD_PRACTICE |
SE_COMPARATOR_SHOULD_BE_SERIALIZABLE |
56 |
Medium |
org.opendaylight.yangtools.yang.parser.builder.util.Comparators$SchemaNodeComparator
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.yangtools.yang.parser.builder.util.Comparators$SchemaNodeComparator implements Comparator but not Serializable |
BAD_PRACTICE |
SE_COMPARATOR_SHOULD_BE_SERIALIZABLE |
40 |
Medium |
org.opendaylight.yangtools.yang.parser.impl.ParserListenerUtils
| Bug |
Category |
Details |
Line |
Priority |
| Exception is caught when Exception is not thrown in org.opendaylight.yangtools.yang.parser.impl.ParserListenerUtils.parseMaxElements(YangParser$Max_elements_stmtContext, String) |
STYLE |
REC_CATCH_EXCEPTION |
1723 |
Low |
| Exception is caught when Exception is not thrown in org.opendaylight.yangtools.yang.parser.impl.ParserListenerUtils.parseMinElements(YangParser$Min_elements_stmtContext, String) |
STYLE |
REC_CATCH_EXCEPTION |
1700 |
Low |
| Switch statement found in org.opendaylight.yangtools.yang.parser.impl.ParserListenerUtils.parseTypeWithBody(String, YangParser$Type_body_stmtsContext, SchemaPath, QName, Builder) where default case is missing |
STYLE |
SF_SWITCH_NO_DEFAULT |
1431 |
Medium |
| Private method org.opendaylight.yangtools.yang.parser.impl.ParserListenerUtils.getParentModule(ParseTree) is never called |
PERFORMANCE |
UPM_UNCALLED_PRIVATE_METHOD |
415 |
Low |
org.opendaylight.yangtools.yang.parser.impl.YangParserImpl$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.yang.parser.impl.YangParserImpl$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
276 |
Low |
org.opendaylight.yangtools.yang.parser.impl.YangParserImpl$2
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.yang.parser.impl.YangParserImpl$2 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
306 |
Low |
org.opendaylight.yangtools.yang.parser.impl.YangStatementParserListenerImpl
| Bug |
Category |
Details |
Line |
Priority |
| YangStatementParserListenerImpl.prefixes should be final since org.opendaylight.yangtools.yang.parser.impl.YangStatementParserListenerImpl is marked as Immutable. |
BAD_PRACTICE |
JCIP_FIELD_ISNT_FINAL_IN_IMMUTABLE_CLASS |
|
Medium |
| YangStatementParserListenerImpl.stmtDef should be final since org.opendaylight.yangtools.yang.parser.impl.YangStatementParserListenerImpl is marked as Immutable. |
BAD_PRACTICE |
JCIP_FIELD_ISNT_FINAL_IN_IMMUTABLE_CLASS |
|
Medium |
| YangStatementParserListenerImpl.writer should be final since org.opendaylight.yangtools.yang.parser.impl.YangStatementParserListenerImpl is marked as Immutable. |
BAD_PRACTICE |
JCIP_FIELD_ISNT_FINAL_IN_IMMUTABLE_CLASS |
|
Medium |
org.opendaylight.yangtools.yang.parser.impl.YinStatementParserImpl
| Bug |
Category |
Details |
Line |
Priority |
| Load of known null value in org.opendaylight.yangtools.yang.parser.impl.YinStatementParserImpl.getAttributeValue(XMLStreamReader, QName, QNameToStatementDefinition) |
STYLE |
NP_LOAD_OF_KNOWN_NULL_VALUE |
250 |
Low |
| Possible null pointer dereference of stmtDef in org.opendaylight.yangtools.yang.parser.impl.YinStatementParserImpl.isStatementWithArgument(QName, QNameToStatementDefinition) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
232 |
Medium |
| Questionable use of non-short-circuit logic in org.opendaylight.yangtools.yang.parser.impl.YinStatementParserImpl.enterStatement(XMLStreamReader) |
STYLE |
NS_NON_SHORT_CIRCUIT |
164 |
Low |
org.opendaylight.yangtools.yang.parser.repo.SharedSchemaContextFactory$1
org.opendaylight.yangtools.yang.parser.repo.SharedSchemaContextFactory$2
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.antlr.v4.runtime.ParserRuleContext to org.opendaylight.yangtools.antlrv4.code.gen.YangStatementParser$StatementContext of return value in org.opendaylight.yangtools.yang.parser.repo.SharedSchemaContextFactory$2.apply(List) |
STYLE |
BC_UNCONFIRMED_CAST_OF_RETURN_VALUE |
88 |
Low |
| The class org.opendaylight.yangtools.yang.parser.repo.SharedSchemaContextFactory$2 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
63 |
Low |
org.opendaylight.yangtools.yang.parser.repo.SharedSchemaContextFactory$3
org.opendaylight.yangtools.yang.parser.repo.SharedSchemaContextFactory$SourceIdMismatchDetector
org.opendaylight.yangtools.yang.parser.repo.URLSchemaContextResolver$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.yang.parser.repo.URLSchemaContextResolver$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
49 |
Low |
org.opendaylight.yangtools.yang.parser.repo.YangTextSchemaContextResolver$2
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.yang.parser.repo.YangTextSchemaContextResolver$2 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
163 |
Low |
org.opendaylight.yangtools.yang.parser.spi.SubstatementValidator
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of org.opendaylight.yangtools.yang.parser.spi.meta.StmtContext.getFromNamespace(Class, Object), which is known to be non-null in org.opendaylight.yangtools.yang.parser.spi.SubstatementValidator.validate(StmtContext) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
90 |
Medium |
org.opendaylight.yangtools.yang.parser.spi.meta.StmtContextUtils
| Bug |
Category |
Details |
Line |
Priority |
| Call to org.opendaylight.yangtools.yang.common.QNameModule.equals(org.opendaylight.yangtools.yang.common.QName) in org.opendaylight.yangtools.yang.parser.spi.meta.StmtContextUtils.replaceModuleQNameForKey(StmtContext, QNameModule) |
CORRECTNESS |
EC_UNRELATED_TYPES |
219 |
High |
org.opendaylight.yangtools.yang.parser.spi.meta.StmtContextUtils$1
org.opendaylight.yangtools.yang.parser.spi.meta.StmtContextUtils$2
org.opendaylight.yangtools.yang.parser.spi.source.SourceException
| Bug |
Category |
Details |
Line |
Priority |
| Class org.opendaylight.yangtools.yang.parser.spi.source.SourceException defines non-transient non-serializable instance field sourceRef |
BAD_PRACTICE |
SE_BAD_FIELD |
|
Low |
org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext
| Bug |
Category |
Details |
Line |
Priority |
| Switch statement found in org.opendaylight.yangtools.yang.parser.stmt.reactor.BuildGlobalContext.completePhaseActions() where one case falls through to the next case |
STYLE |
SF_SWITCH_FALLTHROUGH |
270 |
Medium |
org.opendaylight.yangtools.yang.parser.stmt.reactor.CrossSourceStatementReactor$BuildAction
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.yang.parser.stmt.reactor.CrossSourceStatementReactor$BuildAction could be refactored into a _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS |
83 |
Low |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AnyxmlStatementImpl$Definition
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of findNode, which is known to be non-null in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AnyxmlStatementImpl$Definition.getAnyXmlSchema(StmtContext, SchemaNodeIdentifier) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
109 |
Low |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AugmentStatementImpl$Definition
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to sourceCtxPrereq in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AugmentStatementImpl$Definition.onFullDefinitionDeclared(StmtContext$Mutable) |
STYLE |
DLS_DEAD_LOCAL_STORE |
104 |
Medium |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AugmentStatementImpl$Definition$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.yang.parser.stmt.rfc6020.AugmentStatementImpl$Definition$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
108 |
Low |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.BaseStatementImpl$Definition
| Bug |
Category |
Details |
Line |
Priority |
| Dead store to mutatesPrereq in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.BaseStatementImpl$Definition.onStatementDefinitionDeclared(StmtContext$Mutable) |
STYLE |
DLS_DEAD_LOCAL_STORE |
75 |
Medium |
| Dead store to requiresPrereq in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.BaseStatementImpl$Definition.onStatementDefinitionDeclared(StmtContext$Mutable) |
STYLE |
DLS_DEAD_LOCAL_STORE |
73 |
Medium |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.BaseStatementImpl$Definition$1
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of derivedIdentities, which is known to be non-null in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.BaseStatementImpl$Definition$1.apply() |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
83 |
Medium |
| The class org.opendaylight.yangtools.yang.parser.stmt.rfc6020.BaseStatementImpl$Definition$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
78 |
Low |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.BelongsToStatementImpl$Definition$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.yang.parser.stmt.rfc6020.BelongsToStatementImpl$Definition$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
78 |
Low |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.GroupingStatementImpl$Definition
| Bug |
Category |
Details |
Line |
Priority |
| Nullcheck of stmt at line 84 of value previously dereferenced in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.GroupingStatementImpl$Definition.onFullDefinitionDeclared(StmtContext$Mutable) |
CORRECTNESS |
RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE |
82 |
Medium |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.ImportStatementDefinition$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.yang.parser.stmt.rfc6020.ImportStatementDefinition$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
82 |
Low |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.IncludeStatementImpl$Definition$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.yang.parser.stmt.rfc6020.IncludeStatementImpl$Definition$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
78 |
Low |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.MandatoryStatementImpl$Definition
| Bug |
Category |
Details |
Line |
Priority |
| Call to org.opendaylight.yangtools.yang.parser.stmt.rfc6020.EmptyMandatoryStatement$1.equals(org.opendaylight.yangtools.yang.parser.stmt.rfc6020.MandatoryStatementImpl) in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.MandatoryStatementImpl$Definition.createDeclared(StmtContext) |
CORRECTNESS |
EC_UNRELATED_TYPES |
45 |
High |
| Call to org.opendaylight.yangtools.yang.parser.stmt.rfc6020.EmptyMandatoryStatement$2.equals(org.opendaylight.yangtools.yang.parser.stmt.rfc6020.MandatoryStatementImpl) in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.MandatoryStatementImpl$Definition.createDeclared(StmtContext) |
CORRECTNESS |
EC_UNRELATED_TYPES |
47 |
High |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.SchemaNodeIdentifierBuildNamespace
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of nextNodeCtx, which is known to be non-null in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.SchemaNodeIdentifierBuildNamespace.getFrom(NamespaceBehaviour$NamespaceStorageNode, SchemaNodeIdentifier) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
67 |
Medium |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.TypeStatementImpl$Definition$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.yang.parser.stmt.rfc6020.TypeStatementImpl$Definition$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
217 |
Low |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.TypedefStatementImpl$Definition
| Bug |
Category |
Details |
Line |
Priority |
| Nullcheck of stmt at line 72 of value previously dereferenced in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.TypedefStatementImpl$Definition.onFullDefinitionDeclared(StmtContext$Mutable) |
CORRECTNESS |
RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE |
71 |
Medium |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.UsesStatementImpl$Definition$1
| Bug |
Category |
Details |
Line |
Priority |
| The class org.opendaylight.yangtools.yang.parser.stmt.rfc6020.UsesStatementImpl$Definition$1 could be refactored into a named _static_ inner class |
PERFORMANCE |
SIC_INNER_SHOULD_BE_STATIC_ANON |
89 |
Low |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.Utils
| Bug |
Category |
Details |
Line |
Priority |
| Possible null pointer dereference of null in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.Utils.getRootModuleQName(StmtContext) |
CORRECTNESS |
NP_NULL_ON_SOME_PATH |
528 |
High |
| Redundant nullcheck of qNameModule, which is known to be non-null in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.Utils.qNameFromArgument(StmtContext, String) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
477 |
High |
| Redundant nullcheck of qNameModule, which is known to be non-null in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.Utils.getModuleQNameByPrefix(StmtContext, String) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
503 |
Medium |
| Redundant nullcheck of qNameModule, which is known to be non-null in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.Utils.qNameFromArgument(StmtContext, String) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
471 |
Medium |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.YangStatementSourceImpl
| Bug |
Category |
Details |
Line |
Priority |
| Exception is caught when Exception is not thrown in new org.opendaylight.yangtools.yang.parser.stmt.rfc6020.YangStatementSourceImpl(InputStream) |
STYLE |
REC_CATCH_EXCEPTION |
64 |
Low |
| Exception is caught when Exception is not thrown in new org.opendaylight.yangtools.yang.parser.stmt.rfc6020.YangStatementSourceImpl(String, boolean) |
STYLE |
REC_CATCH_EXCEPTION |
54 |
Low |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.YinStatementSourceImpl
| Bug |
Category |
Details |
Line |
Priority |
| Usage of GetResource in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.YinStatementSourceImpl.loadFile(String, boolean) may be unsafe if class is extended |
BAD_PRACTICE |
UI_INHERITANCE_UNSAFE_GETRESOURCE |
120 |
Low |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.AbstractEffectiveSimpleDataNodeContainer
| Bug |
Category |
Details |
Line |
Priority |
| Class org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.AbstractEffectiveSimpleDataNodeContainer implements same interface as superclass |
STYLE |
RI_REDUNDANT_INTERFACES |
45 |
Low |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.AugmentEffectiveStatementImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.AugmentEffectiveStatementImpl.getRevision() may expose internal representation by returning AugmentEffectiveStatementImpl.revision |
MALICIOUS_CODE |
EI_EXPOSE_REP |
98 |
Medium |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.EffectiveConstraintDefinitionImpl
| Bug |
Category |
Details |
Line |
Priority |
| Boxed value is unboxed and then immediately reboxed in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.EffectiveConstraintDefinitionImpl.forParent(EffectiveStatementBase) |
PERFORMANCE |
BX_UNBOXING_IMMEDIATELY_REBOXED |
39 |
Medium |
| Suspicious comparison of a Integer reference to constant in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.EffectiveConstraintDefinitionImpl.forParent(EffectiveStatementBase) |
BAD_PRACTICE |
RC_REF_COMPARISON_BAD_PRACTICE |
59 |
Medium |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.EffectiveStatementBase$1
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.EffectiveStatementBase$2
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.IdentityEffectiveStatementImpl
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of derivedIdentitiesCtxList, which is known to be non-null in new org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.IdentityEffectiveStatementImpl(StmtContext) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
36 |
Medium |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.ImportEffectiveStatementImpl
| Bug |
Category |
Details |
Line |
Priority |
| org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.ImportEffectiveStatementImpl.getRevision() may expose internal representation by returning ImportEffectiveStatementImpl.revision |
MALICIOUS_CODE |
EI_EXPOSE_REP |
49 |
Medium |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.TypeDefEffectiveStatementImpl
| Bug |
Category |
Details |
Line |
Priority |
| Possible doublecheck on org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.TypeDefEffectiveStatementImpl.typeStatement in org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.TypeDefEffectiveStatementImpl.asTypeEffectiveStatement() |
MT_CORRECTNESS |
DC_DOUBLECHECK |
72 |
Medium |
| Inconsistent synchronization of org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.TypeDefEffectiveStatementImpl.typeStatement; locked 66% of time |
MT_CORRECTNESS |
IS2_INCONSISTENT_SYNC |
71 |
Medium |
org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.UnknownEffectiveStatementBase
| Bug |
Category |
Details |
Line |
Priority |
| Redundant nullcheck of extensionInit, which is known to be non-null in new org.opendaylight.yangtools.yang.parser.stmt.rfc6020.effective.UnknownEffectiveStatementBase(StmtContext) |
STYLE |
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE |
41 |
Medium |
org.opendaylight.yangtools.yang.parser.util.ModuleDependencySort$1
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.parser.util.TopologicalSort$Node to org.opendaylight.yangtools.yang.parser.util.ModuleDependencySort$ModuleNodeImpl in org.opendaylight.yangtools.yang.parser.util.ModuleDependencySort$1.apply(TopologicalSort$Node) |
STYLE |
BC_UNCONFIRMED_CAST |
51 |
Low |
org.opendaylight.yangtools.yang.parser.util.ModuleDependencySort$2
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.parser.util.TopologicalSort$Node to org.opendaylight.yangtools.yang.parser.util.ModuleDependencySort$ModuleNodeImpl in org.opendaylight.yangtools.yang.parser.util.ModuleDependencySort$2.apply(TopologicalSort$Node) |
STYLE |
BC_UNCONFIRMED_CAST |
73 |
Low |
org.opendaylight.yangtools.yang.parser.util.ModuleDependencySort$3
| Bug |
Category |
Details |
Line |
Priority |
| Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.parser.util.TopologicalSort$Node to org.opendaylight.yangtools.yang.parser.util.ModuleDependencySort$ModuleNodeImpl in org.opendaylight.yangtools.yang.parser.util.ModuleDependencySort$3.apply(TopologicalSort$Node) |
STYLE |
BC_UNCONFIRMED_CAST |
113 |
Low |
