Checkstyle Results

The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. rss feed

Summary

Files  Info  Warnings  Errors
13 0 47 0

Files

File  I  W  E
org/opendaylight/yangtools/yang2sources/plugin/ConfigArg.java 0 4 0
org/opendaylight/yangtools/yang2sources/plugin/GenerateSourcesTest.java 0 2 0
org/opendaylight/yangtools/yang2sources/plugin/Util.java 0 13 0
org/opendaylight/yangtools/yang2sources/plugin/YangSourceFromFile.java 0 1 0
org/opendaylight/yangtools/yang2sources/plugin/YangSourceInZipFileTest.java 0 1 0
org/opendaylight/yangtools/yang2sources/plugin/YangToSourcesMojo.java 0 3 0
org/opendaylight/yangtools/yang2sources/plugin/YangToSourcesMojoTest.java 0 1 0
org/opendaylight/yangtools/yang2sources/plugin/YangToSourcesProcessor.java 0 18 0
org/opendaylight/yangtools/yang2sources/plugin/YangToSourcesProcessorTest.java 0 4 0

Rules

Category Rule Violations Severity
coding IllegalCatch 5  Warning
VariableDeclarationUsageDistance 1  Warning
imports CustomImportOrder
  • thirdPartyPackageRegExp: ".*"
  • sortImportsInGroupAlphabetically: "true"
  • customImportOrderRules: "STATIC###THIRD_PARTY_PACKAGE"
 2  Warning
indentation Indentation
  • throwsIndent: "4"
  • arrayInitIndent: "4"
  • caseIndent: "4"
  • basicOffset: "4"
  • braceAdjustment: "0"
  • lineWrappingIndentation: "4"
 2  Warning
javadoc JavadocParagraph
  • allowNewlineParagraph: "false"
 2  Warning
JavadocStyle
  • checkEmptyJavadoc: "true"
 5  Warning
NonEmptyAtclauseDescription 4  Warning
misc UpperEll 1  Warning
modifier RedundantModifier 1  Warning
naming LocalVariableName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
  • allowOneCharVarInForLoop: "true"
  • tokens: "VARIABLE_DEF"
 2  Warning
MemberName
  • format: "^[a-z][a-z0-9][a-zA-Z0-9]*$"
 1  Warning
sizes LineLength
  • max: "120"
  • ignorePattern: "^package.*|^import.*|a href|href|http://|https://|ftp://"
 11  Warning
whitespace OperatorWrap
  • tokens: "BAND, BOR, BSR, BXOR, DIV, EQUAL, GE, GT, LAND, LE, LITERAL_INSTANCEOF, LOR, LT, MINUS, MOD, NOT_EQUAL, PLUS, QUESTION, SL, SR, STAR "
  • option: "NL"
 3  Warning
WhitespaceAround
  • allowEmptyConstructors: "true"
  • allowEmptyMethods: "true"
  • allowEmptyLoops: "true"
  • allowEmptyTypes: "true"
 2  Warning

Details

org/opendaylight/yangtools/yang2sources/plugin/ConfigArg.java

Severity Category Rule Message Line
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.base.Preconditions' import. Should be before 'org.apache.maven.project.MavenProject'. 15
 Warning imports CustomImportOrder Wrong lexicographical order for 'com.google.common.collect.Maps' import. Should be before 'org.apache.maven.project.MavenProject'. 16
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 18
 Warning javadoc JavadocStyle First sentence should end with a period. 18

org/opendaylight/yangtools/yang2sources/plugin/GenerateSourcesTest.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 122). 60
 Warning sizes LineLength Line is longer than 120 characters (found 136). 88

org/opendaylight/yangtools/yang2sources/plugin/Util.java

Severity Category Rule Message Line
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 46
 Warning javadoc JavadocStyle First sentence should end with a period. 46
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 114
 Warning javadoc JavadocStyle First sentence should end with a period. 114
 Warning whitespace OperatorWrap '+' should be on a new line. 223
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 311
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 319
 Warning javadoc JavadocParagraph Empty line should be followed by <p> tag on the next line. 321
 Warning javadoc NonEmptyAtclauseDescription At-clause should have a non-empty description. 324
 Warning javadoc NonEmptyAtclauseDescription At-clause should have a non-empty description. 325
 Warning javadoc NonEmptyAtclauseDescription At-clause should have a non-empty description. 326
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 334
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 374

org/opendaylight/yangtools/yang2sources/plugin/YangSourceFromFile.java

Severity Category Rule Message Line
 Warning modifier RedundantModifier Redundant 'public' modifier. 20

org/opendaylight/yangtools/yang2sources/plugin/YangSourceInZipFileTest.java

Severity Category Rule Message Line
 Warning misc UpperEll Should use uppercase 'L'. 26

org/opendaylight/yangtools/yang2sources/plugin/YangToSourcesMojo.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 160). 45
 Warning javadoc NonEmptyAtclauseDescription Javadoc comment at column 4 has parse error. Unrecognized error from ANTLR parser: null 49
 Warning naming MemberName Member name 'yang_skip' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 91

org/opendaylight/yangtools/yang2sources/plugin/YangToSourcesMojoTest.java

Severity Category Rule Message Line
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 40

org/opendaylight/yangtools/yang2sources/plugin/YangToSourcesProcessor.java

Severity Category Rule Message Line
 Warning sizes LineLength Line is longer than 120 characters (found 128). 66
 Warning sizes LineLength Line is longer than 120 characters (found 124). 72
 Warning sizes LineLength Line is longer than 120 characters (found 138). 73
 Warning naming LocalVariableName Local variable name 'i' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 78
 Warning sizes LineLength Line is longer than 120 characters (found 136). 90
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 219
 Warning whitespace OperatorWrap '+' should be on a new line. 222
 Warning sizes LineLength Line is longer than 120 characters (found 127). 227
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 296
 Warning javadoc JavadocStyle First sentence should end with a period. 296
 Warning coding IllegalCatch Catching 'Exception' is not allowed. 309
 Warning javadoc SummaryJavadoc First sentence of Javadoc is incomplete (period is missing) or not present. 324
 Warning javadoc JavadocStyle First sentence should end with a period. 324
 Warning coding VariableDeclarationUsageDistance Distance between variable 'g' declaration and its first usage is 6, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). 332
 Warning naming LocalVariableName Local variable name 'g' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. 332
 Warning indentation Indentation 'if' child have incorrect indentation level 10, expected level should be 12. 338
 Warning indentation Indentation 'else' child have incorrect indentation level 10, expected level should be 12. 340
 Warning whitespace OperatorWrap '+' should be on a new line. 340

org/opendaylight/yangtools/yang2sources/plugin/YangToSourcesProcessorTest.java

Severity Category Rule Message Line
 Warning whitespace WhitespaceAround WhitespaceAround: '{' is not preceded with whitespace. 35
 Warning sizes LineLength Line is longer than 120 characters (found 182). 37
 Warning sizes LineLength Line is longer than 120 characters (found 159). 40
 Warning sizes LineLength Line is longer than 120 characters (found 153). 51