The following document contains the results of Checkstyle 6.16 with odl_checks.xml ruleset. 
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | LeftCurly
|
1 | |
| NeedBraces | 1 | ||
| coding | IllegalCatch | 69 | |
| MissingSwitchDefault | 1 | ||
| OverloadMethodsDeclarationOrder | 3 | ||
| VariableDeclarationUsageDistance | 6 | ||
| imports | CustomImportOrder
|
68 | |
| RedundantImport | 1 | ||
| UnusedImports | 9 | ||
| indentation | Indentation
|
47 | |
| javadoc | JavadocStyle
|
13 | |
| JavadocTagContinuationIndentation | 10 | ||
| naming | ConstantName | 1 | |
LocalVariableName
|
19 | ||
MemberName
|
3 | ||
ParameterName
|
8 | ||
| regexp | RegexpSingleline
|
21 | |
RegexpSinglelineJava
|
15 | ||
| sizes | LineLength
|
75 | |
| whitespace | GenericWhitespace | 27 | |
| MethodParamPad | 19 | ||
OperatorWrap
|
52 | ||
SeparatorWrap
|
40 | ||
SeparatorWrap
|
40 | ||
WhitespaceAround
|
47 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| sizes | LineLength | Line is longer than 120 characters (found 210). | 20 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 20 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| naming | ParameterName | Parameter name 'nVpnMgr' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 48 | |
| whitespace | WhitespaceAround | WhitespaceAround: '=' is not preceded with whitespace. | 54 | |
| whitespace | WhitespaceAround | WhitespaceAround: '=' is not followed by whitespace. | 54 | |
| coding | VariableDeclarationUsageDistance | Distance between variable 'importRouteTargets' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 88 | |
| coding | VariableDeclarationUsageDistance | Distance between variable 'exportRouteTargets' declaration and its first usage is 5, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 89 | |
| sizes | LineLength | Line is longer than 120 characters (found 122). | 129 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 131 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 219 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 220 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Import statement for 'org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.buildfloatingIpIdToPortMappingIdentifier' is in the wrong order. Should be in the 'STATIC' group, expecting not assigned imports on this line. | 37 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 120 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 124 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 127 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 164 | |
| sizes | LineLength | Line is longer than 120 characters (found 121). | 166 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 169 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 208 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 220 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 244 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 258 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 261 | |
| coding | VariableDeclarationUsageDistance | Distance between variable 'portsIdentifierBuilder' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 279 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 287 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 302 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 307 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 308 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 317 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 320 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 321 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 47 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 60 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' should followed by whitespace. | 74 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 74 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' should followed by whitespace. | 79 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 79 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' should followed by whitespace. | 84 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 84 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 91 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 94 | |
| blocks | NeedBraces | 'if' construct must use '{}'s. | 114 | |
| coding | MissingSwitchDefault | switch without "default" clause. | 129 | |
| blocks | LeftCurly | '{' at column 5 should be on the previous line. | 165 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'java.util.Objects'. | 14 | |
| naming | ParameterName | Parameter name 'nVpnMgr' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 53 | |
| naming | ParameterName | Parameter name 'nVpnNatMgr' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 54 | |
| whitespace | GenericWhitespace | GenericWhitespace '<' is preceded with whitespace. | 193 | |
| sizes | LineLength | Line is longer than 120 characters (found 135). | 197 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 198 | |
| sizes | LineLength | Line is longer than 120 characters (found 121). | 218 | |
| sizes | LineLength | Line is longer than 120 characters (found 133). | 236 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '210'. | 248 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.ElanInstances. | 43 | |
| imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.elan.instances.ElanInstance. | 45 | |
| imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.elan.instances.ElanInstanceKey. | 46 | |
| imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.PortAddedToSubnetBuilder. | 52 | |
| imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.PortRemovedFromSubnetBuilder. | 53 | |
| naming | ParameterName | Parameter name 'nVpnMgr' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 78 | |
| naming | ParameterName | Parameter name 'nVpnNatMgr' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 78 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 212 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 226 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 316 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 332 | |
| indentation | Indentation | 'method def modifier' have incorrect indentation level 20, expected level should be one of the following: 12, 16. | 455 | |
| indentation | Indentation | 'method def' child have incorrect indentation level 24, expected level should be one of the following: 16, 20. | 457 | |
| indentation | Indentation | 'method def' child have incorrect indentation level 24, expected level should be one of the following: 16, 20. | 458 | |
| coding | VariableDeclarationUsageDistance | Distance between variable 'futures' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 458 | |
| indentation | Indentation | 'method def' child have incorrect indentation level 24, expected level should be one of the following: 16, 20. | 460 | |
| indentation | Indentation | 'method def' child have incorrect indentation level 24, expected level should be one of the following: 16, 20. | 461 | |
| indentation | Indentation | 'method def' child have incorrect indentation level 24, expected level should be one of the following: 16, 20. | 462 | |
| indentation | Indentation | 'method def' child have incorrect indentation level 24, expected level should be one of the following: 16, 20. | 464 | |
| indentation | Indentation | 'if' have incorrect indentation level 24, expected level should be one of the following: 16, 20. | 466 | |
| indentation | Indentation | 'if' child have incorrect indentation level 28, expected level should be one of the following: 20, 24. | 467 | |
| indentation | Indentation | 'if' child have incorrect indentation level 28, expected level should be one of the following: 20, 24. | 469 | |
| indentation | Indentation | 'if' child have incorrect indentation level 28, expected level should be one of the following: 20, 24. | 470 | |
| indentation | Indentation | 'if' child have incorrect indentation level 28, expected level should be one of the following: 20, 24. | 472 | |
| indentation | Indentation | 'if rcurly' have incorrect indentation level 24, expected level should be one of the following: 16, 20. | 473 | |
| indentation | Indentation | 'if' have incorrect indentation level 24, expected level should be one of the following: 16, 20. | 474 | |
| indentation | Indentation | 'if' child have incorrect indentation level 28, expected level should be one of the following: 20, 24. | 475 | |
| indentation | Indentation | 'if' child have incorrect indentation level 28, expected level should be one of the following: 20, 24. | 476 | |
| indentation | Indentation | 'if rcurly' have incorrect indentation level 24, expected level should be one of the following: 16, 20. | 477 | |
| indentation | Indentation | 'if' have incorrect indentation level 24, expected level should be one of the following: 16, 20. | 478 | |
| indentation | Indentation | 'if' child have incorrect indentation level 28, expected level should be one of the following: 20, 24. | 480 | |
| indentation | Indentation | 'if' child have incorrect indentation level 28, expected level should be one of the following: 20, 24. | 481 | |
| indentation | Indentation | 'if' child have incorrect indentation level 28, expected level should be one of the following: 20, 24. | 483 | |
| indentation | Indentation | 'if' child have incorrect indentation level 28, expected level should be one of the following: 20, 24. | 484 | |
| indentation | Indentation | 'if rcurly' have incorrect indentation level 24, expected level should be one of the following: 16, 20. | 485 | |
| indentation | Indentation | 'method def' child have incorrect indentation level 24, expected level should be one of the following: 16, 20. | 486 | |
| indentation | Indentation | 'method def' child have incorrect indentation level 24, expected level should be one of the following: 16, 20. | 487 | |
| indentation | Indentation | 'method def rcurly' have incorrect indentation level 20, expected level should be one of the following: 12, 16. | 488 | |
| indentation | Indentation | 'object def rcurly' have incorrect indentation level 16, expected level should be one of the following: 8, 12. | 489 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 540 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 556 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 585 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 618 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 619 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 623 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 624 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier'. | 50 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.Futures' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier'. | 51 | |
| naming | MemberName | Member name 'nVpnMgr' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 61 | |
| naming | MemberName | Member name 'nVpnNatMgr' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 63 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 97 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 104 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 64 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 286 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| naming | ParameterName | Parameter name 'nVpnMgr' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 38 | |
| sizes | LineLength | Line is longer than 120 characters (found 121). | 39 | |
| naming | ParameterName | Parameter name 'nVpnNatMgr' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 39 | |
| sizes | LineLength | Line is longer than 120 characters (found 125). | 135 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| whitespace | SeparatorWrap | '.' should be on a new line. | 55 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 87 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 211 | |
| sizes | LineLength | Line is longer than 120 characters (found 144). | 217 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| naming | ParameterName | Parameter name 'nVpnMgr' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 36 | |
| sizes | LineLength | Line is longer than 120 characters (found 122). | 118 | |
| sizes | LineLength | Line is longer than 120 characters (found 124). | 133 | |
| sizes | LineLength | Line is longer than 120 characters (found 122). | 145 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 168 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.ThreadFactoryBuilder' import. Should be before 'org.slf4j.LoggerFactory'. | 41 | |
| coding | IllegalCatch | Catching 'Throwable' is not allowed. | 76 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '89'. | 140 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 162 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.Objects' import. Should be before 'java.util.concurrent.Callable'. | 19 | |
| imports | UnusedImports | Unused import - org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.neutron.vpn.portip.port.data.VpnPortipToPort. | 87 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.slf4j.LoggerFactory'. | 123 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.ListenableFuture' import. Should be before 'org.slf4j.LoggerFactory'. | 124 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.SettableFuture' import. Should be before 'org.slf4j.LoggerFactory'. | 125 | |
| javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 138 | |
| javadoc | JavadocStyle | Javadoc has empty description section. | 138 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 238 | |
| sizes | LineLength | Line is longer than 120 characters (found 123). | 245 | |
| sizes | LineLength | Line is longer than 120 characters (found 128). | 247 | |
| sizes | LineLength | Line is longer than 120 characters (found 125). | 255 | |
| sizes | LineLength | Line is longer than 120 characters (found 126). | 259 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 298 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 391 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 402 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 456 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 474 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 520 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 546 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 575 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 598 | |
| coding | VariableDeclarationUsageDistance | Distance between variable 'ips' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 611 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 667 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 703 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 708 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 712 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 734 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 762 | |
| javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 770 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 770 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 808 | |
| javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 812 | |
| sizes | LineLength | Line is longer than 120 characters (found 131). | 856 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 914 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 925 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 938 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 943 | |
| javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 947 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 974 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1034 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 1036 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1039 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 1044 | |
| javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 1048 | |
| indentation | Indentation | 'operator new lparen' have incorrect indentation level 32, expected level should be 24. | 1066 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 1066 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 1078 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1089 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1102 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 1196 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 1216 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 1345 | |
| sizes | LineLength | Line is longer than 120 characters (found 128). | 1361 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 1367 | |
| sizes | LineLength | Line is longer than 120 characters (found 132). | 1369 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 1369 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 1373 | |
| sizes | LineLength | Line is longer than 120 characters (found 129). | 1374 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 1381 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 1397 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 1450 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 1500 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 1528 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 1556 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 1586 | |
| whitespace | MethodParamPad | '(' is preceded with whitespace. | 1587 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 1626 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 1640 | |
| sizes | LineLength | Line is longer than 120 characters (found 122). | 1643 | |
| javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 1644 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1674 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1676 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 1678 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1682 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 1689 | |
| javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 1693 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 1713 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1728 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1731 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 1733 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1737 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 1743 | |
| sizes | LineLength | Line is longer than 120 characters (found 130). | 1745 | |
| javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 1746 | |
| sizes | LineLength | Line is longer than 120 characters (found 127). | 1749 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1768 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1772 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1774 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 1776 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1780 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 1786 | |
| javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 1790 | |
| javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 1791 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1822 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1824 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 1826 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1830 | |
| javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 1841 | |
| javadoc | JavadocTagContinuationIndentation | Line continuation have incorrect indentation level, expected level should be 4. | 1842 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 1863 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 1866 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 1867 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1884 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1887 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 1889 | |
| whitespace | GenericWhitespace | GenericWhitespace '>' is followed by whitespace. | 1893 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 1922 | |
| javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 1955 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 1955 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 1962 | |
| sizes | LineLength | Line is longer than 120 characters (found 121). | 1967 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 1989 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 1992 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 1997 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 1999 | |
| javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 2004 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 2004 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 2013 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 2014 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 2015 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 2016 | |
| naming | LocalVariableName | Local variable name 'VpnList' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 2032 | |
| naming | LocalVariableName | Local variable name 'Vpn' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 2033 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 2060 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 2061 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 2063 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 2064 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 2066 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 2067 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 2072 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 2113 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 2147 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 2173 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.external.networks.NetworksKey'. | 26 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.slf4j.LoggerFactory'. | 36 | |
| javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 46 | |
| javadoc | JavadocStyle | Javadoc has empty description section. | 46 | |
| naming | LocalVariableName | Local variable name 'ext_net_changed' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 65 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 69 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 76 | |
| whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 84 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 92 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 98 | |
| naming | LocalVariableName | Local variable name 'orig_ext_net' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 105 | |
| naming | LocalVariableName | Local variable name 'new_ext_net' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 106 | |
| naming | LocalVariableName | Local variable name 'orig_ext_gw' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 132 | |
| naming | LocalVariableName | Local variable name 'new_ext_gw' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 133 | |
| naming | LocalVariableName | Local variable name 'orig_ext_gw' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 153 | |
| naming | LocalVariableName | Local variable name 'new_ext_gw' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 154 | |
| naming | LocalVariableName | Local variable name 'orig_ext_fixed_ips' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 177 | |
| naming | LocalVariableName | Local variable name 'orig_fixed_ip_set' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 178 | |
| naming | LocalVariableName | Local variable name 'fixed_ip' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 179 | |
| naming | LocalVariableName | Local variable name 'new_ext_fixed_ips' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 182 | |
| naming | LocalVariableName | Local variable name 'upd_fixed_ip_set' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 183 | |
| naming | LocalVariableName | Local variable name 'fixed_ip' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 184 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 191 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 205 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 214 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 219 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 234 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 235 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 244 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 253 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 260 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 263 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 264 | |
| sizes | LineLength | Line is longer than 120 characters (found 126). | 277 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 284 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 294 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 313 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 314 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 326 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 333 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 346 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 347 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 356 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 367 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 378 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 379 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 388 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 410 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 411 | |
| sizes | LineLength | Line is longer than 120 characters (found 125). | 430 | |
| naming | LocalVariableName | Local variable name 'ext_fixed_ips' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 447 | |
| naming | LocalVariableName | Local variable name 'fixed_ips' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 448 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 468 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 469 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 491 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 492 | |
| naming | LocalVariableName | Local variable name 'ext_fixed_ips' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 510 | |
| naming | LocalVariableName | Local variable name 'fixed_ips' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 511 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 517 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 522 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 523 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 535 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 552 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 553 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 567 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 583 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'java.math.BigInteger' import. Should be before 'java.util.Iterator'. | 13 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'java.util.Iterator'. | 14 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.Collection' import. Should be before 'java.util.Iterator'. | 15 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.Collections' import. Should be before 'java.util.Iterator'. | 16 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.HashMap' import. Should be before 'java.util.Iterator'. | 17 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.HashSet' import. Should be before 'java.util.Iterator'. | 18 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.collect.ImmutableBiMap' import. Should be before 'org.apache.commons.lang3.tuple.ImmutablePair'. | 32 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.collect.Sets' import. Should be before 'org.apache.commons.lang3.tuple.ImmutablePair'. | 33 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.controller.md.sal.binding.api.WriteTransaction' import. Should be before 'org.opendaylight.controller.md.sal.common.api.data.LogicalDatastoreType'. | 38 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.netvirt.neutronvpn.api.utils.NeutronConstants' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 46 | |
| imports | RedundantImport | Duplicate import to line 40 - org.opendaylight.netvirt.neutronvpn.api.utils.NeutronConstants. | 46 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.huawei.params.xml.ns.yang.l3vpn.rev140815.VpnInterfaces' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 47 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.huawei.params.xml.ns.yang.l3vpn.rev140815.vpn.interfaces.VpnInterface' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 48 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.huawei.params.xml.ns.yang.l3vpn.rev140815.vpn.interfaces.VpnInterfaceKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 49 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.IpAddress' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 50 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.inet.types.rev130715.Ipv6Address' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 51 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.Interfaces' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 52 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.Interface' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 53 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.interfaces.rev140508.interfaces.InterfaceKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 54 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.Uuid' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 55 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.SegmentTypeBase' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 56 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.SegmentTypeFlat' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 57 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.SegmentTypeGre' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 58 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.SegmentTypeVlan' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 59 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.elan.rev150602.SegmentTypeVxlan' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 60 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.NeutronRouterDpns' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 61 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.LearntVpnVipToPortData' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 62 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.neutron.router.dpns.RouterDpnList' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 63 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.neutron.router.dpns.router.dpn.list.DpnVpninterfacesList' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 64 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.learnt.vpn.vip.to.port.data.LearntVpnVipToPort' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 65 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.l3vpn.rev130911.learnt.vpn.vip.to.port.data.LearntVpnVipToPortKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 66 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ExtRouters' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.natservice.rev160111.ProviderTypes'. | 67 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.AllocateIdInput' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 99 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.AllocateIdInputBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 100 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.AllocateIdOutput' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 101 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.IdManagerService' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 102 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.ReleaseIdInput' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 103 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.genius.idmanager.rev160406.ReleaseIdInputBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 104 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.NetworkMaps' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 105 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.Subnetmaps' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 106 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.VpnMaps' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 107 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.networkmaps.NetworkMap' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 108 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.networkmaps.NetworkMapKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 109 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.subnetmaps.Subnetmap' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 110 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.subnetmaps.SubnetmapKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 111 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.vpnmaps.VpnMap' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 112 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.rev150602.vpnmaps.VpnMapKey' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.neutron.subnets.rev150712.subnets.attributes.subnets.SubnetKey'. | 113 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.ietf.params.xml.ns.yang.ietf.yang.types.rev130715.MacAddress' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.inter.vpn.link.rev160311.inter.vpn.links.InterVpnLink'. | 119 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.aclservice.rev160608.IpPrefixOrAddress' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.inter.vpn.link.rev160311.inter.vpn.links.InterVpnLink'. | 120 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.aclservice.rev160608.InterfaceAclBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.inter.vpn.link.rev160311.inter.vpn.links.InterVpnLink'. | 121 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.aclservice.rev160608.interfaces._interface.AllowedAddressPairs' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.inter.vpn.link.rev160311.inter.vpn.links.InterVpnLink'. | 122 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.aclservice.rev160608.interfaces._interface.AllowedAddressPairsBuilder' import. Should be before 'org.opendaylight.yang.gen.v1.urn.opendaylight.params.xml.ns.yang.netvirt.inter.vpn.link.rev160311.inter.vpn.links.InterVpnLink'. | 123 | |
| naming | ConstantName | Name 'logger' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. | 132 | |
| sizes | LineLength | Line is longer than 120 characters (found 121). | 133 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 342 | |
| sizes | LineLength | Line is longer than 120 characters (found 149). | 456 | |
| sizes | LineLength | Line is longer than 120 characters (found 151). | 457 | |
| sizes | LineLength | Line is longer than 120 characters (found 127). | 466 | |
| sizes | LineLength | Line is longer than 120 characters (found 127). | 468 | |
| sizes | LineLength | Line is longer than 120 characters (found 139). | 470 | |
| sizes | LineLength | Line is longer than 120 characters (found 139). | 472 | |
| sizes | LineLength | Line is longer than 120 characters (found 153). | 474 | |
| coding | OverloadMethodsDeclarationOrder | Overload methods should not be split. Previous overloaded method located at line '512'. | 542 | |
| indentation | Indentation | 'portAllowedAddressPair' have incorrect indentation level 16, expected level should be 17. | 547 | |
| whitespace | OperatorWrap | '?' should be on a new line. | 591 | |
| sizes | LineLength | Line is longer than 120 characters (found 148). | 612 | |
| sizes | LineLength | Line is longer than 120 characters (found 149). | 613 | |
| whitespace | OperatorWrap | '?' should be on a new line. | 618 | |
| indentation | Indentation | 'if' child have incorrect indentation level 16, expected level should be 12. | 639 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 673 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 748 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 761 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 794 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 799 | |
| regexp | RegexpSinglelineJava | Line contains console output. | 801 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 812 | |
| whitespace | OperatorWrap | '+' should be on a new line. | 819 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 821 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 838 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 852 | |
| sizes | LineLength | Line is longer than 120 characters (found 123). | 853 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 933 | |
| whitespace | MethodParamPad | '(' should be on the previous line. | 939 | |
| whitespace | MethodParamPad | '(' is preceded with whitespace. | 1025 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 1036 | |
| indentation | Indentation | 'if' have incorrect indentation level 15, expected level should be 16. | 1051 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 1051 | |
| indentation | Indentation | 'if' child have incorrect indentation level 19, expected level should be 20. | 1052 | |
| indentation | Indentation | 'if rcurly' have incorrect indentation level 15, expected level should be 16. | 1053 | |
| indentation | Indentation | 'if' child have incorrect indentation level 19, expected level should be 20. | 1054 | |
| indentation | Indentation | 'if rcurly' have incorrect indentation level 15, expected level should be 16. | 1055 | |
| indentation | Indentation | 'if' child have incorrect indentation level 19, expected level should be 20. | 1056 | |
| indentation | Indentation | 'if rcurly' have incorrect indentation level 15, expected level should be 16. | 1057 | |
| indentation | Indentation | 'if' child have incorrect indentation level 19, expected level should be 20. | 1058 | |
| indentation | Indentation | 'if rcurly' have incorrect indentation level 15, expected level should be 16. | 1059 | |
| javadoc | SummaryJavadoc | First sentence of Javadoc is incomplete (period is missing) or not present. | 1084 | |
| javadoc | JavadocStyle | First sentence should end with a period. | 1084 | |
| sizes | LineLength | Line is longer than 120 characters (found 129). | 1125 | |
| sizes | LineLength | Line is longer than 120 characters (found 125). | 1218 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| sizes | LineLength | Line is longer than 120 characters (found 139). | 29 | |
| sizes | LineLength | Line is longer than 120 characters (found 126). | 38 | |
| sizes | LineLength | Line is longer than 120 characters (found 126). | 74 | |
| sizes | LineLength | Line is longer than 120 characters (found 133). | 80 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 86 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.ArrayList' import. Should be before 'org.slf4j.LoggerFactory'. | 31 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'java.util.List' import. Should be before 'org.slf4j.LoggerFactory'. | 32 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 59 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 156 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'catch' is not preceded with whitespace. | 177 | |
| whitespace | WhitespaceAround | WhitespaceAround: '}' is not followed by whitespace. | 177 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 177 | |
| sizes | LineLength | Line is longer than 120 characters (found 121). | 189 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'catch' is not preceded with whitespace. | 191 | |
| whitespace | WhitespaceAround | WhitespaceAround: '}' is not followed by whitespace. | 191 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 191 | |
| sizes | LineLength | Line is longer than 120 characters (found 123). | 192 | |
| whitespace | MethodParamPad | '(' is preceded with whitespace. | 206 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 218 | |
| sizes | LineLength | Line is longer than 120 characters (found 136). | 219 | |
| sizes | LineLength | Line is longer than 120 characters (found 127). | 225 | |
| sizes | LineLength | Line is longer than 120 characters (found 131). | 240 | |
| sizes | LineLength | Line is longer than 120 characters (found 129). | 255 | |
| sizes | LineLength | Line is longer than 120 characters (found 127). | 269 | |
| sizes | LineLength | Line is longer than 120 characters (found 124). | 281 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.base.Optional' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier'. | 86 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'com.google.common.util.concurrent.Futures' import. Should be before 'org.opendaylight.yangtools.yang.binding.InstanceIdentifier'. | 87 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 95 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 101 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 107 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 109 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 112 | |
| naming | MemberName | Member name 'nVpnMgr' must match pattern '^[a-z][a-z0-9][a-zA-Z0-9]*$'. | 117 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 126 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 132 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 134 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 156 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 158 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 162 | |
| indentation | Indentation | 'method call' child have incorrect indentation level 8, expected level should be 12. | 163 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 167 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 169 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 173 | |
| sizes | LineLength | Line is longer than 120 characters (found 149). | 177 | |
| sizes | LineLength | Line is longer than 120 characters (found 158). | 178 | |
| sizes | LineLength | Line is longer than 120 characters (found 128). | 179 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 183 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 184 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 185 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 186 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 187 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 188 | |
| indentation | Indentation | 'method call' child have incorrect indentation level 8, expected level should be 12. | 189 | |
| sizes | LineLength | Line is longer than 120 characters (found 159). | 192 | |
| whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 192 | |
| whitespace | WhitespaceAround | WhitespaceAround: '+' is not followed by whitespace. | 192 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 196 | |
| sizes | LineLength | Line is longer than 120 characters (found 149). | 199 | |
| sizes | LineLength | Line is longer than 120 characters (found 158). | 200 | |
| sizes | LineLength | Line is longer than 120 characters (found 128). | 201 | |
| sizes | LineLength | Line is longer than 120 characters (found 153). | 205 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 207 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 208 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 209 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 210 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 211 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 212 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 213 | |
| indentation | Indentation | 'method call' child have incorrect indentation level 8, expected level should be 12. | 214 | |
| sizes | LineLength | Line is longer than 120 characters (found 159). | 217 | |
| whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 217 | |
| whitespace | WhitespaceAround | WhitespaceAround: '+' is not followed by whitespace. | 217 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 221 | |
| sizes | LineLength | Line is longer than 120 characters (found 149). | 224 | |
| sizes | LineLength | Line is longer than 120 characters (found 158). | 225 | |
| sizes | LineLength | Line is longer than 120 characters (found 128). | 226 | |
| sizes | LineLength | Line is longer than 120 characters (found 153). | 230 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 232 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 233 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 234 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 235 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 236 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 237 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 238 | |
| indentation | Indentation | 'method call' child have incorrect indentation level 8, expected level should be 12. | 239 | |
| sizes | LineLength | Line is longer than 120 characters (found 159). | 242 | |
| whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 242 | |
| whitespace | WhitespaceAround | WhitespaceAround: '+' is not followed by whitespace. | 242 | |
| sizes | LineLength | Line is longer than 120 characters (found 149). | 249 | |
| sizes | LineLength | Line is longer than 120 characters (found 158). | 250 | |
| sizes | LineLength | Line is longer than 120 characters (found 128). | 251 | |
| sizes | LineLength | Line is longer than 120 characters (found 150). | 255 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 257 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 258 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 259 | |
| indentation | Indentation | 'method call' child have incorrect indentation level 8, expected level should be 12. | 260 | |
| sizes | LineLength | Line is longer than 120 characters (found 159). | 263 | |
| whitespace | WhitespaceAround | WhitespaceAround: '+' is not preceded with whitespace. | 263 | |
| whitespace | WhitespaceAround | WhitespaceAround: '+' is not followed by whitespace. | 263 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 266 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 269 | |
| indentation | Indentation | 'method call' child have incorrect indentation level 8, expected level should be 12. | 270 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 277 | |
| coding | VariableDeclarationUsageDistance | Distance between variable 'subnets' declaration and its first usage is 4, but allowed 3. Consider to make that variable as final if you still need to store its value in advance (before method calls that might do side effect on original value). | 297 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 300 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 304 | |
| sizes | LineLength | Line is longer than 120 characters (found 141). | 323 | |
| sizes | LineLength | Line is longer than 120 characters (found 121). | 330 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 332 | |
| indentation | Indentation | 'method call' child have incorrect indentation level 8, expected level should be 12. | 333 | |
| sizes | LineLength | Line is longer than 120 characters (found 162). | 338 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 342 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 384 | |
| regexp | RegexpSingleline | Line has trailing spaces. | 386 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 394 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 394 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 395 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 395 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 400 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 400 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 126 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'try' is not followed by whitespace. | 133 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 133 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 134 | |
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 161 | |
| indentation | Indentation | '.' have incorrect indentation level 16, expected level should be 17. | 216 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'for' is not followed by whitespace. | 285 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 285 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 340 | |
| whitespace | SeparatorWrap | '.' should be on a new line. | 341 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| coding | IllegalCatch | Catching 'Exception' is not allowed. | 85 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | UnusedImports | Unused import - org.opendaylight.controller.md.sal.binding.api.DataChangeListener. | 17 | |
| imports | UnusedImports | Unused import - org.opendaylight.controller.sal.binding.api.RpcProviderRegistry. | 22 | |
| imports | UnusedImports | Unused import - org.opendaylight.yangtools.concepts.ListenerRegistration. | 39 | |
| whitespace | WhitespaceAround | WhitespaceAround: 'if' is not followed by whitespace. | 118 | |
| whitespace | WhitespaceAround | WhitespaceAround: '{' is not preceded with whitespace. | 118 | |
| sizes | LineLength | Line is longer than 120 characters (found 145). | 151 | |
| sizes | LineLength | Line is longer than 120 characters (found 147). | 152 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.genius.utils.hwvtep.HwvtepSouthboundConstants' import. Should be before 'org.opendaylight.netvirt.neutronvpn.api.l2gw.L2GatewayDevice'. | 15 | |
| imports | CustomImportOrder | Wrong lexicographical order for 'org.opendaylight.genius.utils.hwvtep.HwvtepSouthboundUtils' import. Should be before 'org.opendaylight.netvirt.neutronvpn.api.l2gw.L2GatewayDevice'. | 16 |