FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is low

Effort is max

Summary

Classes Bugs Errors Missing Classes
52 68 0 0

Files

Class Bugs
org.opendaylight.netvirt.neutronvpn.BridgeRefEntryToTransportZoneListener 1
org.opendaylight.netvirt.neutronvpn.InterfaceStateToTransportZoneListener 1
org.opendaylight.netvirt.neutronvpn.NeutronBgpvpnChangeListener 1
org.opendaylight.netvirt.neutronvpn.NeutronFloatingToFixedIpMappingChangeListener 5
org.opendaylight.netvirt.neutronvpn.NeutronHostConfigChangeListener 4
org.opendaylight.netvirt.neutronvpn.NeutronNetworkChangeListener 1
org.opendaylight.netvirt.neutronvpn.NeutronPortChangeListener 4
org.opendaylight.netvirt.neutronvpn.NeutronPortChangeListener$4 1
org.opendaylight.netvirt.neutronvpn.NeutronQosUtils 1
org.opendaylight.netvirt.neutronvpn.NeutronRouterChangeListener 1
org.opendaylight.netvirt.neutronvpn.NeutronRouterDpnsToTransportZoneListener 1
org.opendaylight.netvirt.neutronvpn.NeutronSecurityRuleListener 1
org.opendaylight.netvirt.neutronvpn.NeutronSubnetChangeListener 3
org.opendaylight.netvirt.neutronvpn.NeutronvpnManager 20
org.opendaylight.netvirt.neutronvpn.NeutronvpnNatManager 3
org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils 14
org.opendaylight.netvirt.neutronvpn.QosInterfaceStateChangeListener 1
org.opendaylight.netvirt.neutronvpn.l2gw.L2GatewayListener 2
org.opendaylight.netvirt.neutronvpn.l2gw.L2GatewayListener$1 1
org.opendaylight.netvirt.neutronvpn.l2gw.L2GwTransportZoneListener 1
org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.config.rev160806.NeutronvpnConfigBuilder$NeutronvpnConfigImpl 1

org.opendaylight.netvirt.neutronvpn.BridgeRefEntryToTransportZoneListener

Bug Category Details Line Priority
Class org.opendaylight.netvirt.neutronvpn.BridgeRefEntryToTransportZoneListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 20 Low

org.opendaylight.netvirt.neutronvpn.InterfaceStateToTransportZoneListener

Bug Category Details Line Priority
Class org.opendaylight.netvirt.neutronvpn.InterfaceStateToTransportZoneListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 20 Low

org.opendaylight.netvirt.neutronvpn.NeutronBgpvpnChangeListener

Bug Category Details Line Priority
Class org.opendaylight.netvirt.neutronvpn.NeutronBgpvpnChangeListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 40 Low

org.opendaylight.netvirt.neutronvpn.NeutronFloatingToFixedIpMappingChangeListener

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronFloatingToFixedIpMappingChangeListener.addToFloatingIpInfo(String, Uuid, String, String, String, Uuid) STYLE REC_CATCH_EXCEPTION 169 Medium
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronFloatingToFixedIpMappingChangeListener.clearFromFloatingIpInfo(String, String, String) STYLE REC_CATCH_EXCEPTION 208 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronFloatingToFixedIpMappingChangeListener.dissociatefixedIPFromFloatingIP(String) STYLE REC_CATCH_EXCEPTION 261 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronFloatingToFixedIpMappingChangeListener.removeRouterPortsOrPortsNode(String, InstanceIdentifier$InstanceIdentifierBuilder, List, String, boolean) STYLE REC_CATCH_EXCEPTION 287 Low
Class org.opendaylight.netvirt.neutronvpn.NeutronFloatingToFixedIpMappingChangeListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 39 Low

org.opendaylight.netvirt.neutronvpn.NeutronHostConfigChangeListener

Bug Category Details Line Priority
Use of non-localized String.toUpperCase() or String.toLowerCase() in org.opendaylight.netvirt.neutronvpn.NeutronHostConfigChangeListener.extractHostConfig(Node) I18N DM_CONVERT_CASE 113 Low
Redundant nullcheck of hostType, which is known to be non-null in org.opendaylight.netvirt.neutronvpn.NeutronHostConfigChangeListener.extractHostConfig(Node) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 109 Low
Class org.opendaylight.netvirt.neutronvpn.NeutronHostConfigChangeListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 31 Low
Private method org.opendaylight.netvirt.neutronvpn.NeutronHostConfigChangeListener.createInstanceIdentifier() is never called PERFORMANCE UPM_UNCALLED_PRIVATE_METHOD 177 Medium

org.opendaylight.netvirt.neutronvpn.NeutronNetworkChangeListener

Bug Category Details Line Priority
Class org.opendaylight.netvirt.neutronvpn.NeutronNetworkChangeListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 44 Low

org.opendaylight.netvirt.neutronvpn.NeutronPortChangeListener

Bug Category Details Line Priority
Dead store to network in org.opendaylight.netvirt.neutronvpn.NeutronPortChangeListener.createInterface(Port) STYLE DLS_DEAD_LOCAL_STORE 553 Medium
Dead store to interfaceName in org.opendaylight.netvirt.neutronvpn.NeutronPortChangeListener.handlePortSecurityUpdated(Port, Port, boolean, boolean, InterfaceBuilder) STYLE DLS_DEAD_LOCAL_STORE 494 Medium
Dead store to mac in org.opendaylight.netvirt.neutronvpn.NeutronPortChangeListener.handleRouterInterfaceAdded(Port) STYLE DLS_DEAD_LOCAL_STORE 308 Medium
Class org.opendaylight.netvirt.neutronvpn.NeutronPortChangeListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 66 Low

org.opendaylight.netvirt.neutronvpn.NeutronPortChangeListener$4

Bug Category Details Line Priority
Dead store of null to vpnIdOld in org.opendaylight.netvirt.neutronvpn.NeutronPortChangeListener$4.call() STYLE DLS_DEAD_LOCAL_STORE_OF_NULL 469 Low

org.opendaylight.netvirt.neutronvpn.NeutronQosUtils

Bug Category Details Line Priority
Dead store to result in org.opendaylight.netvirt.neutronvpn.NeutronQosUtils.read(LogicalDatastoreType, InstanceIdentifier, DataBroker) STYLE DLS_DEAD_LOCAL_STORE 283 Low

org.opendaylight.netvirt.neutronvpn.NeutronRouterChangeListener

Bug Category Details Line Priority
Class org.opendaylight.netvirt.neutronvpn.NeutronRouterChangeListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 30 Low

org.opendaylight.netvirt.neutronvpn.NeutronRouterDpnsToTransportZoneListener

Bug Category Details Line Priority
Class org.opendaylight.netvirt.neutronvpn.NeutronRouterDpnsToTransportZoneListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 20 Low

org.opendaylight.netvirt.neutronvpn.NeutronSecurityRuleListener

Bug Category Details Line Priority
Dead store to sourcePortRangeBuilder in org.opendaylight.netvirt.neutronvpn.NeutronSecurityRuleListener.toAceBuilder(SecurityRule) STYLE DLS_DEAD_LOCAL_STORE 106 High

org.opendaylight.netvirt.neutronvpn.NeutronSubnetChangeListener

Bug Category Details Line Priority
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronSubnetChangeListener.createSubnetToNetworkMapping(Uuid, Uuid) STYLE REC_CATCH_EXCEPTION 136 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronSubnetChangeListener.deleteSubnetToNetworkMapping(Uuid, Uuid) STYLE REC_CATCH_EXCEPTION 168 Low
Class org.opendaylight.netvirt.neutronvpn.NeutronSubnetChangeListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 30 Low

org.opendaylight.netvirt.neutronvpn.NeutronvpnManager

Bug Category Details Line Priority
Dead store to builder in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.addToNeutronRouterInterfacesMap(Uuid, String) STYLE DLS_DEAD_LOCAL_STORE 1201 Medium
Dead store to errorResponse in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.dissociateRouter(DissociateRouterInput) STYLE DLS_DEAD_LOCAL_STORE 1882 Low
Redundant nullcheck of routerSubnets, which is known to be non-null in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.associateRouterToVpn(Uuid, Uuid) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 1519 Low
Redundant nullcheck of failStrings, which is known to be non-null in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.createL3Vpn(Uuid, String, Uuid, List, List, List, Uuid, List) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 800 Low
Redundant nullcheck of erAdjList, which is known to be non-null in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.createVpnInterface(Uuid, Uuid, Port, WriteTransaction) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 634 Low
Redundant nullcheck of routerSubnets, which is known to be non-null in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.dissociateRouterFromVpn(Uuid, Uuid) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 1545 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.updateVpnInstanceNode(String, List, List, List) STYLE REC_CATCH_EXCEPTION 456 Medium
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.clearFromVpnMaps(Uuid, Uuid, List) STYLE REC_CATCH_EXCEPTION 546 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.createSubnetmapNode(Uuid, String, Uuid, Uuid) STYLE REC_CATCH_EXCEPTION 191 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.deleteSubnetMapNode(Uuid) STYLE REC_CATCH_EXCEPTION 391 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.deleteVpnInstance(Uuid) STYLE REC_CATCH_EXCEPTION 598 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.getL3VPN(GetL3VPNInput) STYLE REC_CATCH_EXCEPTION 1036 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.removeFromSubnetNode(Uuid, Uuid, Uuid, Uuid, Uuid) STYLE REC_CATCH_EXCEPTION 339 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.showNeutronPortsCLI() STYLE REC_CATCH_EXCEPTION 1997 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.updateSubnetNode(Uuid, Uuid, Uuid) STYLE REC_CATCH_EXCEPTION 225 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.updateSubnetNodeWithFixedIp(Uuid, Uuid, Uuid, String, String) STYLE REC_CATCH_EXCEPTION 258 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.updateVpnInterface(Uuid, Uuid, Port, boolean, boolean, WriteTransaction) STYLE REC_CATCH_EXCEPTION 734 Low
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.updateVpnMaps(Uuid, String, Uuid, Uuid, List) STYLE REC_CATCH_EXCEPTION 520 Low
Useless object stored in variable interfaces of method org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.addToNeutronRouterInterfacesMap(Uuid, String) STYLE UC_USELESS_OBJECT 1202 Medium
org.opendaylight.netvirt.neutronvpn.NeutronvpnManager.getAdjacencyforExtraRoute(Uuid, List, String) makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 1345 Medium

org.opendaylight.netvirt.neutronvpn.NeutronvpnNatManager

Bug Category Details Line Priority
Redundant nullcheck of builder, which is known to be non-null in org.opendaylight.netvirt.neutronvpn.NeutronvpnNatManager.handleExternalFixedIpsForRouter(Router, DataBroker) STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 509 Low
Suspicious comparison of Boolean references in org.opendaylight.netvirt.neutronvpn.NeutronvpnNatManager.snatSettingChanged(Router, Router) BAD_PRACTICE RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN 146 Medium
Exception is caught when Exception is not thrown in org.opendaylight.netvirt.neutronvpn.NeutronvpnNatManager.addExternalRouter(Router, DataBroker) STYLE REC_CATCH_EXCEPTION 468 Low

org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils

Bug Category Details Line Priority
Dead store to prefix in org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.getIPPrefixFromPort(DataBroker, Port) STYLE DLS_DEAD_LOCAL_STORE 777 Medium
Dead store to result in org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.read(DataBroker, LogicalDatastoreType, InstanceIdentifier) STYLE DLS_DEAD_LOCAL_STORE 1033 Low
org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.getIPPrefixFromPort(DataBroker, Port) invokes inefficient new Short(short) constructor; use Short.valueOf(short) instead PERFORMANCE DM_NUMBER_CTOR 777 Medium
Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.lock(String) MT_CORRECTNESS JLM_JSR166_UTILCONCURRENT_MONITORENTER 726 Medium
Synchronization performed on java.util.concurrent.ConcurrentHashMap in org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.unlock(String) MT_CORRECTNESS JLM_JSR166_UTILCONCURRENT_MONITORENTER 766 Medium
org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.networkMap isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 141 High
org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.portMap isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 143 High
org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.qosNetworksMap isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 148 High
org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.qosPolicyMap isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 146 High
org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.qosPortsMap isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 147 High
org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.routerMap isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 142 High
org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.subnetGwIpMap isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 145 High
org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.subnetMap isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 144 High
Return value of java.util.concurrent.locks.Lock.tryLock(long, TimeUnit) ignored in org.opendaylight.netvirt.neutronvpn.NeutronvpnUtils.lock(String) CORRECTNESS RV_RETURN_VALUE_IGNORED 735 High

org.opendaylight.netvirt.neutronvpn.QosInterfaceStateChangeListener

Bug Category Details Line Priority
Class org.opendaylight.netvirt.neutronvpn.QosInterfaceStateChangeListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 29 Low

org.opendaylight.netvirt.neutronvpn.l2gw.L2GatewayListener

Bug Category Details Line Priority
Dead store to iid in org.opendaylight.netvirt.neutronvpn.l2gw.L2GatewayListener.removeL2Device(Devices, L2gateway) STYLE DLS_DEAD_LOCAL_STORE 122 Medium
Class org.opendaylight.netvirt.neutronvpn.l2gw.L2GatewayListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 44 Low

org.opendaylight.netvirt.neutronvpn.l2gw.L2GatewayListener$1

Bug Category Details Line Priority
isOwner must be non-null but is marked as nullable STYLE NP_PARAMETER_MUST_BE_NONNULL_BUT_MARKED_AS_NULLABLE 130 Low

org.opendaylight.netvirt.neutronvpn.l2gw.L2GwTransportZoneListener

Bug Category Details Line Priority
Class org.opendaylight.netvirt.neutronvpn.l2gw.L2GwTransportZoneListener implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 26 Low

org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.config.rev160806.NeutronvpnConfigBuilder$NeutronvpnConfigImpl

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.opendaylight.yangtools.yang.binding.DataObject to org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.config.rev160806.NeutronvpnConfigBuilder$NeutronvpnConfigImpl in org.opendaylight.yang.gen.v1.urn.opendaylight.netvirt.neutronvpn.config.rev160806.NeutronvpnConfigBuilder$NeutronvpnConfigImpl.equals(Object) STYLE BC_UNCONFIRMED_CAST 161 Low